From 75a020aa6ba7e06e8805f1b02b233d5a88f8da15 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Mon, 7 Aug 2023 14:06:10 -0700 Subject: [PATCH] Only query serial number and firmware versions from Sony PS5 controllers I don't know of any specific issue with this, but third party PS4 controllers have had issues with reports that are specific to Sony hardware, so this is a speculative change to prevent issues with future controllers. If it turns out that these reports are valid and useful for third party controllers, we can back this change out. --- src/joystick/hidapi/SDL_hidapi_ps5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/joystick/hidapi/SDL_hidapi_ps5.c b/src/joystick/hidapi/SDL_hidapi_ps5.c index 8c46f4200b..1f6df2a632 100644 --- a/src/joystick/hidapi/SDL_hidapi_ps5.c +++ b/src/joystick/hidapi/SDL_hidapi_ps5.c @@ -412,7 +412,7 @@ static SDL_bool HIDAPI_DriverPS5_InitDevice(SDL_HIDAPI_Device *device) /* Connected over Bluetooth, using simple reports (DirectInput enabled) */ } - if (ctx->enhanced_reports) { + if (device->vendor_id == USB_VENDOR_SONY && ctx->enhanced_reports) { /* Read the serial number (Bluetooth address in reverse byte order) This will also enable enhanced reports over Bluetooth */