From 8a5f9a38377ab8ec4eb5397ce3d97204c8d5cf29 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Tue, 30 Sep 2025 11:36:29 -0700 Subject: [PATCH] Removed validate_feature_indirect_draw_first_instance_disabled (thanks @rabbit-ecl!) It was incorrectly checking the direct draw functions instead of checking indirect draw buffers. --- src/gpu/SDL_gpu.c | 13 ------------- src/gpu/SDL_sysgpu.h | 1 - 2 files changed, 14 deletions(-) diff --git a/src/gpu/SDL_gpu.c b/src/gpu/SDL_gpu.c index 6715cd23d9..3b786d4680 100644 --- a/src/gpu/SDL_gpu.c +++ b/src/gpu/SDL_gpu.c @@ -726,9 +726,6 @@ SDL_GPUDevice *SDL_CreateGPUDeviceWithProperties(SDL_PropertiesID props) result->default_enable_depth_clip = true; result->validate_feature_depth_clamp_disabled = true; } - if (!SDL_GetBooleanProperty(props, SDL_PROP_GPU_DEVICE_CREATE_FEATURE_INDIRECT_DRAW_FIRST_INSTANCE_BOOLEAN, true)) { - result->validate_feature_indirect_draw_first_instance_disabled = true; - } if (!SDL_GetBooleanProperty(props, SDL_PROP_GPU_DEVICE_CREATE_FEATURE_ANISOTROPY_BOOLEAN, true)) { result->validate_feature_anisotropy_disabled = true; } @@ -2191,11 +2188,6 @@ void SDL_DrawGPUIndexedPrimitives( CHECK_RENDERPASS CHECK_GRAPHICS_PIPELINE_BOUND SDL_GPU_CheckGraphicsBindings(render_pass); - if (RENDERPASS_DEVICE->validate_feature_indirect_draw_first_instance_disabled && - first_instance != 0) { - SDL_assert_release(!"first_instance must be 0 (FEATURE_INDIRECT_DRAW_FIRST_INSTANCE disabled)"); - return; - } } RENDERPASS_DEVICE->DrawIndexedPrimitives( @@ -2223,11 +2215,6 @@ void SDL_DrawGPUPrimitives( CHECK_RENDERPASS CHECK_GRAPHICS_PIPELINE_BOUND SDL_GPU_CheckGraphicsBindings(render_pass); - if (RENDERPASS_DEVICE->validate_feature_indirect_draw_first_instance_disabled && - first_instance != 0) { - SDL_assert_release(!"first_instance must be 0 (FEATURE_INDIRECT_DRAW_FIRST_INSTANCE disabled)"); - return; - } } RENDERPASS_DEVICE->DrawPrimitives( diff --git a/src/gpu/SDL_sysgpu.h b/src/gpu/SDL_sysgpu.h index f967a8a24f..44ce625698 100644 --- a/src/gpu/SDL_sysgpu.h +++ b/src/gpu/SDL_sysgpu.h @@ -1098,7 +1098,6 @@ struct SDL_GPUDevice bool debug_mode; bool default_enable_depth_clip; bool validate_feature_depth_clamp_disabled; - bool validate_feature_indirect_draw_first_instance_disabled; bool validate_feature_anisotropy_disabled; };