From b16165a33fdd993d0801d9e5cef79182c3f51530 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Tue, 24 Oct 2023 14:42:02 -0400 Subject: [PATCH] rwlock: SDL_UnlockRWLock was incorrectly tagged with SDL_RELEASE_SHARED. It needs to be SDL_RELEASE_GENERIC, because it releases both exclusive (writer) and shared (reader) locks. Without this fix, clang's `-Wthread-safety` tests generate incorrect warnings. Reference Issue #8096. --- include/SDL3/SDL_mutex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/SDL3/SDL_mutex.h b/include/SDL3/SDL_mutex.h index 19c6b5557c..23fb86c302 100644 --- a/include/SDL3/SDL_mutex.h +++ b/include/SDL3/SDL_mutex.h @@ -433,7 +433,7 @@ extern DECLSPEC int SDLCALL SDL_TryLockRWLockForWriting(SDL_RWLock *rwlock) SDL_ * * \since This function is available since SDL 3.0.0. */ -extern DECLSPEC int SDLCALL SDL_UnlockRWLock(SDL_RWLock *rwlock) SDL_RELEASE_SHARED(rwlock); +extern DECLSPEC int SDLCALL SDL_UnlockRWLock(SDL_RWLock *rwlock) SDL_RELEASE_GENERIC(rwlock); /** * Destroy a read/write lock created with SDL_CreateRWLock().