From c56a1c664cb85cb53b95c60d9301e5027ede843f Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Fri, 25 Apr 2025 12:49:41 -0400 Subject: [PATCH] aaudio: We PlayDevice first and WaitDevice after; reduce semaphore count by 1. Previously, we would WaitDevice first, but that would feed a silent buffer to AAudio upfront, introducing latency. When this change was made, the semaphore count should have been adjusted, since we're waiting on one less buffer. Fixes #12882. (cherry picked from commit 2767c1a440fc65184482a3ee0a664609fb6f9ada) --- src/audio/aaudio/SDL_aaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/audio/aaudio/SDL_aaudio.c b/src/audio/aaudio/SDL_aaudio.c index 3360bec949..95124546a9 100644 --- a/src/audio/aaudio/SDL_aaudio.c +++ b/src/audio/aaudio/SDL_aaudio.c @@ -366,7 +366,7 @@ static bool BuildAAudioStream(SDL_AudioDevice *device) hidden->processed_bytes = 0; hidden->callback_bytes = 0; - hidden->semaphore = SDL_CreateSemaphore(recording ? 0 : hidden->num_buffers); + hidden->semaphore = SDL_CreateSemaphore(recording ? 0 : hidden->num_buffers - 1); if (!hidden->semaphore) { LOGI("SDL Failed SDL_CreateSemaphore %s recording:%d", SDL_GetError(), recording); return false;