mirrors/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-09-24 03:58:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

GPU: Remove pitch parameters from indirect draw calls (#10803)

Browse Source
This commit is contained in:
Caleb Cornett
2024-09-12 01:30:14 -05:00
committed by GitHub
parent 3d7e8c9bb7
commit ddd5723e2e
8 changed files with 47 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
src/gpu/d3d12/SDL_gpu_d3d12.c
View File

@@ -4722,80 +4722,42 @@ static void D3D12_DrawPrimitivesIndirect(
SDL_GPUCommandBuffer *commandBuffer,
SDL_GPUBuffer *buffer,
Uint32 offset,
Uint32 drawCount,
Uint32 pitch)
Uint32 drawCount)
{
D3D12CommandBuffer *d3d12CommandBuffer = (D3D12CommandBuffer *)commandBuffer;
D3D12Buffer *d3d12Buffer = ((D3D12BufferContainer *)buffer)->activeBuffer;
D3D12_INTERNAL_BindGraphicsResources(d3d12CommandBuffer);
if (pitch == sizeof(SDL_GPUIndirectDrawCommand)) {
// Real multi-draw!
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectDrawCommandSignature,
drawCount,
d3d12Buffer->handle,
offset,
NULL,
0);
} else {
/* Fake multi-draw...
* FIXME: we could make this real multi-draw
* if we have a lookup to get command signature per pitch value
*/
for (Uint32 i = 0; i < drawCount; i += 1) {
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectDrawCommandSignature,
1,
d3d12Buffer->handle,
offset + (pitch * i),
NULL,
0);
}
}
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectDrawCommandSignature,
drawCount,
d3d12Buffer->handle,
offset,
NULL,
0);
}
static void D3D12_DrawIndexedPrimitivesIndirect(
SDL_GPUCommandBuffer *commandBuffer,
SDL_GPUBuffer *buffer,
Uint32 offset,
Uint32 drawCount,
Uint32 pitch)
Uint32 drawCount)
{
D3D12CommandBuffer *d3d12CommandBuffer = (D3D12CommandBuffer *)commandBuffer;
D3D12Buffer *d3d12Buffer = ((D3D12BufferContainer *)buffer)->activeBuffer;
D3D12_INTERNAL_BindGraphicsResources(d3d12CommandBuffer);
if (pitch == sizeof(SDL_GPUIndexedIndirectDrawCommand)) {
// Real multi-draw!
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectIndexedDrawCommandSignature,
drawCount,
d3d12Buffer->handle,
offset,
NULL,
0);
} else {
/* Fake multi-draw...
* FIXME: we could make this real multi-draw
* if we have a lookup to get command signature per pitch value
*/
for (Uint32 i = 0; i < drawCount; i += 1) {
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectIndexedDrawCommandSignature,
1,
d3d12Buffer->handle,
offset + (pitch * i),
NULL,
0);
}
}
ID3D12GraphicsCommandList_ExecuteIndirect(
d3d12CommandBuffer->graphicsCommandList,
d3d12CommandBuffer->renderer->indirectIndexedDrawCommandSignature,
drawCount,
d3d12Buffer->handle,
offset,
NULL,
0);
}
static void D3D12_EndRenderPass(