From ad4f43d46dcab6b2df36347230771c74d01d3b90 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mauro=20Balad=C3=A9s?= <mauro.balades@tutanota.com>
Date: Fri, 13 Sep 2024 21:42:28 -0700
Subject: [PATCH 1/3] Refactor sign.ps1 script to enforce mandatory parameters
 order

---
 build/winsign/sign.ps1 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build/winsign/sign.ps1 b/build/winsign/sign.ps1
index 6cc1f4f86..6d7351f5f 100644
--- a/build/winsign/sign.ps1
+++ b/build/winsign/sign.ps1
@@ -1,6 +1,6 @@
 param(
-    [string]$RunID,
-    [string]$SignIdentity
+    [string][Parameter(Mandatory=$true)]$SignIdentity,
+    [string][Parameter(Mandatory=$true)]$RunID
 )
 
 $ErrorActionPreference = "Stop"

From 873bcbc24d67101fff24b1519ece99c9c9107ec2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mauro=20Balad=C3=A9s?= <mauro.balades@tutanota.com>
Date: Fri, 13 Sep 2024 21:55:32 -0700
Subject: [PATCH 2/3] Refactor sign.ps1 script to remove unnecessary directory
 creation

---
 build/winsign/sign.ps1 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build/winsign/sign.ps1 b/build/winsign/sign.ps1
index 6d7351f5f..92bd963d5 100644
--- a/build/winsign/sign.ps1
+++ b/build/winsign/sign.ps1
@@ -6,6 +6,7 @@ param(
 $ErrorActionPreference = "Stop"
 
 echo "Preparing environment"
+rmdir engine\obj-x86_64-pc-windows-msvc\ -Recurse -ErrorAction SilentlyContinue
 mkdir windsign-temp -ErrorAction SilentlyContinue
 mkdir engine\obj-x86_64-pc-windows-msvc\ -ErrorAction SilentlyContinue
 

From cf0d35f7c9d76a86be4dce572677725f17017684 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mauro=20Balad=C3=A9s?= <mauro.balades@tutanota.com>
Date: Fri, 13 Sep 2024 22:36:31 -0700
Subject: [PATCH 3/3] Refactor sign.ps1 script to download specific and generic
 object files from runner

---
 build/winsign/sign.ps1 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/build/winsign/sign.ps1 b/build/winsign/sign.ps1
index 92bd963d5..98dcc485e 100644
--- a/build/winsign/sign.ps1
+++ b/build/winsign/sign.ps1
@@ -13,7 +13,8 @@ mkdir engine\obj-x86_64-pc-windows-msvc\ -ErrorAction SilentlyContinue
 pnpm surfer ci --brand alpha
 
 echo "Downloading from runner with ID $RunID"
-gh run download $RunID --pattern "windows-x64-obj-*" --dir windsign-temp
+gh run download $RunID --name "windows-x64-obj-specific" --dir windsign-temp
+gh run download $RunID --name "windows-x64-obj-generic" --dir windsign-temp
 
 function SignAndPackage($name) {
     echo "Executing on $name"