From 5c8e6dd5a43e81eaa9960dfa9d44e98ea3778cee Mon Sep 17 00:00:00 2001
From: "Mr. M" <mr.m@tuta.com>
Date: Sat, 13 Sep 2025 01:46:35 +0200
Subject: [PATCH] chore: Change the use of `hidden` after the new firefox
 update, b=no-bug, c=compact-mode, split-view, workspaces

---
 src/zen/compact-mode/ZenCompactMode.mjs     |  3 ++-
 src/zen/split-view/ZenViewSplitter.mjs      | 15 +++++++++++----
 src/zen/workspaces/ZenGradientGenerator.mjs | 11 ++++++++---
 3 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/src/zen/compact-mode/ZenCompactMode.mjs b/src/zen/compact-mode/ZenCompactMode.mjs
index 1f0d70eb3..9232af336 100644
--- a/src/zen/compact-mode/ZenCompactMode.mjs
+++ b/src/zen/compact-mode/ZenCompactMode.mjs
@@ -189,10 +189,11 @@ var gZenCompactModeManager = {
   updateCompactModeContext(isSingleToolbar) {
     const menuitem = document.getElementById('zen-context-menu-compact-mode-toggle');
     const menu = document.getElementById('zen-context-menu-compact-mode');
-    menu.setAttribute('hidden', isSingleToolbar);
     if (isSingleToolbar) {
+      menu.setAttribute('hidden', 'true');
       menu.before(menuitem);
     } else {
+      menu.removeAttribute('hidden');
       menu.querySelector('menupopup').prepend(menuitem);
     }
   },
diff --git a/src/zen/split-view/ZenViewSplitter.mjs b/src/zen/split-view/ZenViewSplitter.mjs
index b50a12a93..39c8b4edc 100644
--- a/src/zen/split-view/ZenViewSplitter.mjs
+++ b/src/zen/split-view/ZenViewSplitter.mjs
@@ -513,7 +513,11 @@ class nsZenViewSplitter extends nsZenDOMOperatedFeature {
     const wrapper = this.overlay?.parentNode;
     if (!wrapper) return;
 
-    wrapper.setAttribute('hidden', !value);
+    if (!value) {
+      wrapper.setAttribute('hidden', 'true');
+    } else {
+      wrapper.removeAttribute('hidden');
+    }
   }
 
   enableTabRearrangeView(tabDrag = false) {
@@ -896,9 +900,12 @@ class nsZenViewSplitter extends nsZenDOMOperatedFeature {
         tabCount: window.gBrowser.selectedTabs.length,
       });
       document.getElementById('context_zenSplitTabs').setAttribute('data-l10n-args', tabCountInfo);
-      document
-        .getElementById('context_zenSplitTabs')
-        .setAttribute('hidden', !this.contextCanSplitTabs());
+      const splitTabs = document.getElementById('context_zenSplitTabs');
+      if (!this.contextCanSplitTabs()) {
+        splitTabs.setAttribute('hidden', 'true');
+      } else {
+        splitTabs.removeAttribute('hidden');
+      }
     });
   }
 
diff --git a/src/zen/workspaces/ZenGradientGenerator.mjs b/src/zen/workspaces/ZenGradientGenerator.mjs
index 2bc5d6bb5..1c287d894 100644
--- a/src/zen/workspaces/ZenGradientGenerator.mjs
+++ b/src/zen/workspaces/ZenGradientGenerator.mjs
@@ -1400,9 +1400,14 @@
               ? workspaceTheme.gradientColors.length >= nsZenThemePicker.MAX_DOTS
               : false);
         }
-        document
-          .getElementById('PanelUI-zen-gradient-generator-color-click-to-add')
-          .toggleAttribute('hidden', workspaceTheme.gradientColors.length > 0);
+        const clickToAdd = browser.document.getElementById(
+          'PanelUI-zen-gradient-generator-color-click-to-add'
+        );
+        if (workspaceTheme.gradientColors.length > 0) {
+          clickToAdd.setAttribute('hidden', 'true');
+        } else {
+          clickToAdd.removeAttribute('hidden');
+        }
 
         opacitySlider.value = browser.gZenThemePicker.currentOpacity;
         const textureSelectWrapper = browser.document.getElementById(