From 9bf6b6ec4a32206a20ca5110f1520267ed8f555e Mon Sep 17 00:00:00 2001 From: Pavel Zolotarevskiy Date: Fri, 3 Jan 2025 21:15:31 +0300 Subject: [PATCH] fix: don't flash compact sidebar when opening glance Flashing the sidebar when opening glance is unnecessary, as the user explicitly opens the glance tab so there are no new information presented to the user in the sidebar. On the other hand, the sidebar partially covers the glance tab, meaning that the user has to wait for a while before seeing the tab content, which breaks the flow. Closes #3351 Signed-off-by: Pavel Zolotarevskiy --- src/browser/components/tabbrowser/content/tabs-js.patch | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/browser/components/tabbrowser/content/tabs-js.patch b/src/browser/components/tabbrowser/content/tabs-js.patch index a8fc8e2b2..972d9c315 100644 --- a/src/browser/components/tabbrowser/content/tabs-js.patch +++ b/src/browser/components/tabbrowser/content/tabs-js.patch @@ -76,7 +76,8 @@ index f7c39fe804182e2bdf53045ba3b6a5ba17079fc3..93be23da305a5e2e51bff1c5b5f28743 - } + this.arrowScrollbox.ensureElementIsVisible(selectedTab, aInstant); -+ if (!aInstant && Services.prefs.getBoolPref('zen.view.compact') ++ if (!aInstant && !gZenGlanceManager.animatingOpen ++ && Services.prefs.getBoolPref('zen.view.compact') + && Services.prefs.getBoolPref('zen.view.compact.toolbar-flash-popup')) { + gZenCompactModeManager.flashSidebar(); + }