From a716c99152240cced94f998528b1b64991c0d693 Mon Sep 17 00:00:00 2001 From: jso8910 Date: Thu, 6 Feb 2025 08:42:53 +0800 Subject: [PATCH] Fixed bug where new pinned tabs can't be renamed --- src/browser/base/content/ZenUIManager.mjs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/browser/base/content/ZenUIManager.mjs b/src/browser/base/content/ZenUIManager.mjs index 9c27f7bc9..7966ddac7 100644 --- a/src/browser/base/content/ZenUIManager.mjs +++ b/src/browser/base/content/ZenUIManager.mjs @@ -632,9 +632,7 @@ var gZenVerticalTabsManager = { _insertDoubleClickListenerPinnedTabs() { const tabs = gBrowser.tabs; for (const tab of tabs) { - if (tab.pinned) { - tab.addEventListener('dblclick', this.contextRenameTabStart.bind(this)); - } + tab.addEventListener('dblclick', this.contextRenameTabStart.bind(this)); } }, @@ -661,11 +659,12 @@ var gZenVerticalTabsManager = { }, contextRenameTabStart(event) { - if (event.target.closest('.tab-label-container-editing')) { + if (this._tabEdited) return; + this._tabEdited = event.target.closest('.tabbrowser-tab'); + if (!this._tabEdited.pinned) { + this._tabEdited = null; return; } - this._tabEdited = event.target.closest('.tabbrowser-tab'); - console.log(this._tabEdited); const label = this._tabEdited.querySelector('.tab-label-container'); label.style.display = 'none'; label.className += ' tab-label-container-editing'; @@ -694,11 +693,15 @@ var gZenVerticalTabsManager = { if (event.target.closest('#tab-label-input')) { return; } + if (!this._tabEdited) { + return; + } this._tabEdited.querySelector('.tab-editor-container').remove(); const label = this._tabEdited.querySelector('.tab-label-container-editing'); label.style.display = ''; label.className = label.className.replace(' tab-label-container-editing', ''); document.removeEventListener('click', this.contextRenameTabHalt.bind(this)); + this._tabEdited = null; }, };