From bd7df3831040bf38b20cbcaa7cf0d69041aa6c27 Mon Sep 17 00:00:00 2001 From: "mr. m" Date: Tue, 14 Oct 2025 02:26:22 +0200 Subject: [PATCH] chore: Fix linter issues, b=no-bug, c=folders, glance --- src/zen/folders/ZenFolders.mjs | 2 +- src/zen/glance/ZenGlanceManager.mjs | 4 ++++ src/zen/urlbar/ZenSiteDataPanel.sys.mjs | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/zen/folders/ZenFolders.mjs b/src/zen/folders/ZenFolders.mjs index ec10042b6..3d181132b 100644 --- a/src/zen/folders/ZenFolders.mjs +++ b/src/zen/folders/ZenFolders.mjs @@ -1309,7 +1309,7 @@ animations.push( ...this.#createAnimation( itemsToHide, - { opacity: 0, height: 0 }, + { opacity: [1, 0], height: ['auto', 0] }, { duration: 0.12, ease: 'easeInOut' } ), ...this.updateFolderIcon(group), diff --git a/src/zen/glance/ZenGlanceManager.mjs b/src/zen/glance/ZenGlanceManager.mjs index 5805742fe..ce6258f52 100644 --- a/src/zen/glance/ZenGlanceManager.mjs +++ b/src/zen/glance/ZenGlanceManager.mjs @@ -315,6 +315,10 @@ * @returns {Promise} Promise that resolves to the glance tab */ #animateGlanceOpening(data, browserElement) { + // FIXME(cheffy): We *must* have the call back async (at least, + // until a better solution is found). If we do it inside the requestAnimationFrame, + // we see flashing and if we do it directly, the animation does not play at all. + // eslint-disable-next-line no-async-promise-executor return new Promise(async (resolve) => { this.#prepareGlanceAnimation(data, browserElement); if (data.width && data.height) { diff --git a/src/zen/urlbar/ZenSiteDataPanel.sys.mjs b/src/zen/urlbar/ZenSiteDataPanel.sys.mjs index 8d08cfc5e..4b04d49ee 100644 --- a/src/zen/urlbar/ZenSiteDataPanel.sys.mjs +++ b/src/zen/urlbar/ZenSiteDataPanel.sys.mjs @@ -82,7 +82,7 @@ export class nsZenSiteDataPanel { container.appendChild(fragment); const aElement = this.document.getElementById('zen-copy-url-button'); - aElement.addEventListener('click', (event) => { + aElement.addEventListener('click', () => { this.document.getElementById('cmd_zenCopyCurrentURL').doCommand(); });