chore: Clean up old prefs and fixed small details, b=no-bug, c=common, folders, workspaces

prefs/urlbar.yaml

@@ -4,9 +4,6 @@
 
 # URL bar and search-related preferences
 
-- name: browser.urlbar.unitConversion.enabled
-  value: true
-
 - name: browser.urlbar.trending.featureGate
   value: false
 
@@ -19,16 +16,12 @@
 - name: browser.urlbar.clipboard.featureGate
   value: true
 
-- name: browser.urlbar.suggest.calculator
-  value: true
-
 - name: browser.urlbar.trimHttps
   value: true
 
 - name: browser.urlbar.untrimOnUserInteraction.featureGate
   value: true
 
-# Keep in sync with browser/components/topsites/constants.mjs
 - name: browser.urlbar.maxRichResults
   value: 7
 
@@ -42,9 +35,6 @@
 - name: browser.search.separatePrivateDefault.ui.enabled
   value: true
 
-- name: browser.urlbar.update2.engineAliasRefresh
-  value: true
-
 - name: browser.urlbar.quicksuggest.enabled
   value: false
   locked: true
@@ -66,12 +56,6 @@
 - name: browser.formfill.enable
   value: false
 
-- name: security.insecure_connection_text.enabled
-  value: true
-
-- name: security.insecure_connection_text.pbmode.enabled
-  value: true
-
 - name: network.IDN_show_punycode
   value: true
 

src/browser/components/urlbar/UrlbarProvidersManager-sys-mjs.patch

@@ -0,0 +1,13 @@
+diff --git a/browser/components/urlbar/UrlbarProvidersManager.sys.mjs b/browser/components/urlbar/UrlbarProvidersManager.sys.mjs
+index 555273f6ea1efd77aa3062b9910bbfe28568775d..c8aae86e1233d256e538970d58fd0febed745893 100644
+--- a/browser/components/urlbar/UrlbarProvidersManager.sys.mjs
++++ b/browser/components/urlbar/UrlbarProvidersManager.sys.mjs
+@@ -138,7 +138,7 @@ class ProvidersManager {
+     // To improve dataflow and reduce UI work, when a result is added we may notify
+     // it to the controller after a delay, so that we can chunk results in that
+     // timeframe into a single call. See _notifyResultsFromProvider for details.
+-    this.CHUNK_RESULTS_DELAY_MS = 16;
++    this.CHUNK_RESULTS_DELAY_MS = 20;
+   }
+ 
+   /**

src/browser/components/urlbar/UrlbarView-sys-mjs.patch

@@ -1,5 +1,5 @@
 diff --git a/browser/components/urlbar/UrlbarView.sys.mjs b/browser/components/urlbar/UrlbarView.sys.mjs
-index b3608bb8b851979b893da9c83e86d08b54288047..021ce0b80015256767b88132e99c67fa8ddfd2c4 100644
+index b3608bb8b851979b893da9c83e86d08b54288047..97ffb0b855b1f1c3fe5c4081aa1ec03ceda82b05 100644
 --- a/browser/components/urlbar/UrlbarView.sys.mjs
 +++ b/browser/components/urlbar/UrlbarView.sys.mjs
 @@ -609,7 +609,7 @@ export class UrlbarView {
@@ -16,7 +16,7 @@ index b3608bb8b851979b893da9c83e86d08b54288047..021ce0b80015256767b88132e99c67fa
          });
        let canBeVisible =
 -        newSpanCount <= this.#queryContext.maxResults && !seenMisplacedResult;
-+        newSpanCount < this.#queryContext.maxResults+1 && !seenMisplacedResult;
++        newSpanCount < this.#queryContext.maxResults && !seenMisplacedResult;
        if (result.isHiddenExposure) {
          if (canBeVisible) {
            this.controller.engagementEvent.addExposure(

src/zen/common/styles/zen-urlbar.css

@@ -560,12 +560,12 @@ button.popup-notification-dropmarker {
 }
 
 .urlbarView-row[has-action]:is([type='switchtab'], [type='remotetab'], [type='clipboard']) {
-  & .urlbarView-action {
+  & .urlbarView-action:last-child {
     margin-left: auto !important;
     margin-right: 0 !important;
   }
 
-  &:is([type='switchtab'], [type='remotetab']) .urlbarView-action {
+  &:is([type='switchtab'], [type='remotetab']) .urlbarView-action:last-child {
     background: transparent !important;
     align-items: center;
     display: flex;

src/zen/folders/ZenFolder.mjs

@@ -92,7 +92,7 @@
       this.labelElement.parentElement.setAttribute('context', 'zenFolderActions');
 
       this.labelElement.onRenameFinished = (newLabel) => {
-        this.name = newLabel;
+        this.name = newLabel.trim() || 'Folder';
         const event = new CustomEvent('ZenFolderRenamed', {
           bubbles: true,
         });

src/zen/workspaces/ZenGradientGenerator.mjs

@@ -1089,7 +1089,7 @@
         return color.c;
       }
       let opacity = this.currentOpacity;
-      if (forToolbar) {
+      if (forToolbar && !this.#allowTransparencyOnSidebar) {
         color = this.blendColors(
           color.c,
           this.getToolbarModifiedBaseRaw().slice(0, 3),