chore: Stick closer to firefox default preferences, p=#11611, c=no-component

* feat(downloads): add pref to control download popup position independently

Add `zen.downloads.icon-popup-position` preference that allows users to
control the download popup/indicator position independently from the
vertical tabs position.

Valid values:
- "follow-tabs" (default): popup appears on same side as vertical tabs
- "left": popup always appears on the left
- "right": popup always appears on the right

This is useful for users who have vertical tabs on the right but prefer
the download indicator to appear on the left side of the screen.

* feat: Convert pref to integers, b=no-bug, c=no-component

---------

Co-authored-by: salmonumbrella <salmonumbrella@users.noreply.github.com>
Co-authored-by: mr. m <mr.m@tuta.com>

configs/dumps/search-config-v2.json

@@ -15,6 +15,5 @@
       "ebay",
       "ebay-*"
     ]
-  },
+  }
-  "timestamp": 1765455207275
 }

prefs/firefox/browser.yaml

@@ -8,9 +8,6 @@
 - name: browser.sessionstore.restore_pinned_tabs_on_demand
   value: true
 
-- name: browser.tabs.loadBookmarksInTabs
-  value: false
-
 - name: browser.tabs.hoverPreview.enabled
   value: false
 
@@ -23,18 +20,6 @@
 - name: browser.toolbars.bookmarks.visibility
   value: 'never'
 
-- name: browser.bookmarks.openInTabClosesMenu
-  value: false
-
-- name: browser.menu.showViewImageInfo
-  value: true
-
-- name: findbar.highlightAll
-  value: true
-
-- name: layout.word_select.eat_space_to_next_word
-  value: false
-
 - name: widget.non-native-theme.scrollbar.style
   value: 2
 
@@ -58,9 +43,6 @@
 - name: browser.download.manager.addToRecentDocs
   value: false
 
-- name: browser.download.open_pdf_attachments_inline
-  value: true
-
 - name: browser.download.alwaysOpenPanel
   value: false
 

prefs/firefox/performance.yaml

@@ -8,3 +8,12 @@
 
 - name: network.predictor.enable-hover-on-ssl
   value: true
+
+# See https://github.com/zen-browser/desktop/issues/11599, this pref seems to
+# have disabled itself on macos for some unknown reason.
+# Make sure its in sync with:
+# https://searchfox.org/firefox-main/rev/1477feb9706f4ccc5bd571c1c215832a6fbb7464/modules/libpref/init/StaticPrefList.yaml#7741-7748
+- name: gfx.webrender.compositor
+  condition: 'defined(XP_WIN) || defined(XP_DARWIN)'
+  value: '@cond'
+  mirror: once

prefs/firefox/urlbar.yaml

@@ -26,7 +26,6 @@
   value: true
   locked: true
 
-# Enable private suggestions
 - name: browser.search.suggest.enabled
   value: false
 

prefs/zen/downloads.yaml

@@ -7,3 +7,9 @@
 
 - name: zen.downloads.download-animation-duration
   value: 1000 # ms
+
+- name: zen.downloads.icon-popup-position
+  # 0: Follow tab's position
+  # 1: Left side always
+  # 2: Right side always
+  value: 0

scripts/json_with_comments.py

@@ -5,6 +5,7 @@
 import json
 from typing import Any
 
+
 class JSONWithCommentsDecoder(json.JSONDecoder):
   def __init__(self, **kw):
     super().__init__(**kw)

src/zen/common/styles/zen-single-components.css

@@ -261,6 +261,7 @@ body > #confetti {
 }
 
 #TabsToolbar {
+  gap: var(--zen-toolbox-padding);
   -moz-window-dragging: unset;
 }
 

src/zen/downloads/ZenDownloadAnimation.mjs

@@ -131,6 +131,9 @@ class nsZenDownloadAnimationElement extends HTMLElement {
   }
 
   #areTabsOnRightSide() {
+    const position = Services.prefs.getIntPref('zen.downloads.icon-popup-position', 0);
+    if (position === 1) return false;
+    if (position === 2) return true;
     return Services.prefs.getBoolPref('zen.tabs.vertical.right-side');
   }
 

src/zen/tabs/zen-tabs/vertical-tabs.css

@@ -439,7 +439,6 @@
   background: transparent;
   gap: 5px;
   align-items: center;
-  padding-top: var(--zen-element-separation);
 
   & > toolbarbutton:not(#zen-workspaces-button) {
     padding: 0 !important;

src/zen/workspaces/ZenWorkspaces.mjs

@@ -3140,7 +3140,7 @@ class nsZenWorkspaces extends nsZenMultiWindowFeature {
       return;
     }
     const maxButtonSize = 32; // IMPORTANT: This should match the CSS size of the icons
-    const minButtonSize = 15;
+    const minButtonSize = maxButtonSize / 2; // Minimum size for icons when space is limited
     const separation = 3; // Space between icons
 
     // Calculate the total width needed for all icons
@@ -3160,9 +3160,7 @@ class nsZenWorkspaces extends nsZenMultiWindowFeature {
 
     // Set the width of each icon to the maximum size they can fit on
     const widthPerButton = Math.max(
-      Math.floor(
+      (parent.clientWidth - separation * (parent.children.length - 1)) / parent.children.length,
-        (parent.clientWidth - separation * (parent.children.length - 1)) / parent.children.length
-      ),
       minButtonSize
     );
     for (const icon of parent.children) {

src/zen/workspaces/overflow-icons.inc.css

@@ -4,31 +4,40 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+&::after {
+  content: '';
+  position: absolute;
+  width: 4px;
+  border-radius: 99px;
+  height: 4px;
+  background: color-mix(
+    in srgb,
+    var(--zen-primary-color) 10%,
+    light-dark(rgba(0, 0, 0, 0.4), rgba(255, 255, 255, 0.4)) 90%
+  );
+  left: 50%;
+  top: 50%;
+  filter: saturate(140%) brightness(110%) !important;
+  transform: translate(-50%, -50%);
+  transition: opacity 150ms ease-in-out;
+  opacity: 0;
+}
+
+& .zen-workspace-icon {
+  transition: opacity 150ms ease-in-out, transform 150ms ease-in-out;
+  z-index: 2;
+  transform-origin: center;
+}
+
 &:not(:hover) {
   min-width: 10px;
 
   &::after {
-    content: '';
+    opacity: 1;
-    position: absolute;
-    width: 4px;
-    border-radius: 99px;
-    height: 4px;
-    background: color-mix(
-      in srgb,
-      var(--zen-primary-color) 10%,
-      light-dark(rgba(0, 0, 0, 0.4), rgba(255, 255, 255, 0.4)) 90%
-    );
-    left: 50%;
-    top: 50%;
-    filter: saturate(140%) brightness(110%) !important;
-    transform: translate(-50%, -50%);
   }
 
   & .zen-workspace-icon {
-    display: none;
+    opacity: 0;
+    transform: scale(0);
   }
 }
-
-&:hover {
-  width: 20px !important;
-}

src/zen/workspaces/zen-workspaces.css

@@ -94,7 +94,7 @@
 
   &[icons-overflow] {
     gap: 0 !important;
-    justify-content: space-between;
+    justify-content: center;
 
     & toolbarbutton {
       margin: 0;
@@ -108,7 +108,7 @@
     }
 
     &:has(toolbarbutton:hover) toolbarbutton[active='true']:not([dragged='true']) {
-%include overflow-icons.inc.css 
+%include overflow-icons.inc.css
     }
   }
 }

surfer.json

@@ -19,7 +19,7 @@
       "brandShortName": "Zen",
       "brandFullName": "Zen Browser",
       "release": {
-        "displayVersion": "1.17.13b",
+        "displayVersion": "1.17.14b",
         "github": {
           "repo": "zen-browser/desktop"
         },