Compare commits

..

10 Commits

155 changed files with 3558 additions and 4805 deletions

View File

@@ -1 +1 @@
1.94.1 1.95.0

View File

@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity to a ne
### Firefox Versions ### Firefox Versions
- [`Release`](https://zen-browser.app/download) - Is currently built using Firefox version `155.0.1`! - [`Release`](https://zen-browser.app/download) - Is currently built using Firefox version `156.0`!
- [`Twilight`](https://zen-browser.app/download?twilight) - Is currently built using Firefox version `RC 155.0.1`! - [`Twilight`](https://zen-browser.app/download?twilight) - Is currently built using Firefox version `RC 156.0`!
### Contributing ### Contributing

View File

@@ -1 +1 @@
b6d45eac914fd4886c9b6e5f1447f613771228ff 07c99209a6e4c794752e9a242215199ad3ea10f6

View File

@@ -147,9 +147,9 @@ function SignAndPackage($name) {
$env:ZEN_SETUP_EXE_PATH="$PWD\windsign-temp\windows-x64-obj-$name\browser\installer\windows\instgen\setup.exe" $env:ZEN_SETUP_EXE_PATH="$PWD\windsign-temp\windows-x64-obj-$name\browser\installer\windows\instgen\setup.exe"
if ($name -eq "arm64") { if ($name -eq "arm64") {
$env:WIN32_REDIST_DIR="$PWD\win-cross\vs2026\VC\Redist\MSVC\14.50.35710\arm64\Microsoft.VC145.CRT" $env:WIN32_REDIST_DIR="$PWD\win-cross\vs2026\VC\Redist\MSVC\14.51.36231\arm64\Microsoft.VC145.CRT"
} else { } else {
$env:WIN32_REDIST_DIR="$PWD\win-cross\vs2026\VC\Redist\MSVC\14.50.35710\x64\Microsoft.VC145.CRT" $env:WIN32_REDIST_DIR="$PWD\win-cross\vs2026\VC\Redist\MSVC\14.51.36231\x64\Microsoft.VC145.CRT"
} }
$env:MAR="..\\build\\windows\\mar.exe" $env:MAR="..\\build\\windows\\mar.exe"

View File

@@ -15,9 +15,9 @@ if test "$ZEN_CROSS_COMPILING"; then
CROSS_COMPILE=1 CROSS_COMPILE=1
if test "$SURFER_COMPAT" = "aarch64"; then if test "$SURFER_COMPAT" = "aarch64"; then
export WIN32_REDIST_DIR="$WINSYSROOT/VC/Redist/MSVC/14.50.35710/arm64/Microsoft.VC145.CRT" export WIN32_REDIST_DIR="$WINSYSROOT/VC/Redist/MSVC/14.51.36231/arm64/Microsoft.VC145.CRT"
else else
export WIN32_REDIST_DIR="$WINSYSROOT/VC/Redist/MSVC/14.50.35710/x64/Microsoft.VC145.CRT" export WIN32_REDIST_DIR="$WINSYSROOT/VC/Redist/MSVC/14.51.36231/x64/Microsoft.VC145.CRT"
fi fi
fi fi

View File

@@ -5,6 +5,8 @@
zen-action-toggle-compact-mode = Toggle Compact Mode zen-action-toggle-compact-mode = Toggle Compact Mode
zen-action-open-theme-picker = Open Theme Picker zen-action-open-theme-picker = Open Theme Picker
zen-action-new-split-view = New Split View zen-action-new-split-view = New Split View
zen-action-unsplit-view = Expand current view
zen-action-new-space = New Space
zen-action-new-folder = New Folder zen-action-new-folder = New Folder
zen-action-copy-current-url = Copy Current URL zen-action-copy-current-url = Copy Current URL
zen-action-settings = Settings zen-action-settings = Settings
@@ -18,6 +20,9 @@ zen-action-new-boost = New Boost
zen-action-next-space = Next Space zen-action-next-space = Next Space
zen-action-previous-space = Previous Space zen-action-previous-space = Previous Space
zen-action-close-tab = Close Tab zen-action-close-tab = Close Tab
zen-action-reopen-closed-tab = Reopen Closed Tab
zen-action-duplicate-tab = Duplicate Current Tab
zen-action-reset-pinned-tab = Reset Pinned Tab
zen-action-reload-tab = Reload Tab zen-action-reload-tab = Reload Tab
zen-action-reload-tab-without-cache = Reload Tab Without Cache zen-action-reload-tab-without-cache = Reload Tab Without Cache
zen-action-next-tab = Next Tab zen-action-next-tab = Next Tab

View File

@@ -1,5 +1,5 @@
diff --git a/browser/base/content/navigator-toolbox.inc.xhtml b/browser/base/content/navigator-toolbox.inc.xhtml diff --git a/browser/base/content/navigator-toolbox.inc.xhtml b/browser/base/content/navigator-toolbox.inc.xhtml
index dd2f391096968564086911c532f696dc7ffb8ae1..c968e5f0ebb5f0151fb124bafe10d8d5361e060f 100644 index a76bb7aae7636c07989a4acb35281777d3103505..c5eafbdad5270cd9926ed4f1d850d134440d775b 100644
--- a/browser/base/content/navigator-toolbox.inc.xhtml --- a/browser/base/content/navigator-toolbox.inc.xhtml
+++ b/browser/base/content/navigator-toolbox.inc.xhtml +++ b/browser/base/content/navigator-toolbox.inc.xhtml
@@ -2,7 +2,7 @@ @@ -2,7 +2,7 @@
@@ -26,7 +26,7 @@ index dd2f391096968564086911c532f696dc7ffb8ae1..c968e5f0ebb5f0151fb124bafe10d8d5
<toolbar id="TabsToolbar" <toolbar id="TabsToolbar"
class="browser-toolbar browser-titlebar" class="browser-toolbar browser-titlebar"
fullscreentoolbar="true" fullscreentoolbar="true"
@@ -54,6 +58,8 @@ @@ -56,6 +60,8 @@
<html:sidebar-pins-promo id="drag-to-pin-promo-card"></html:sidebar-pins-promo> <html:sidebar-pins-promo id="drag-to-pin-promo-card"></html:sidebar-pins-promo>
<arrowscrollbox id="pinned-tabs-container" orient="horizontal" clicktoscroll=""></arrowscrollbox> <arrowscrollbox id="pinned-tabs-container" orient="horizontal" clicktoscroll=""></arrowscrollbox>
<splitter orient="vertical" id="vertical-pinned-tabs-splitter" resizebefore="sibling" resizeafter="none" hidden="true"/> <splitter orient="vertical" id="vertical-pinned-tabs-splitter" resizebefore="sibling" resizeafter="none" hidden="true"/>
@@ -35,7 +35,7 @@ index dd2f391096968564086911c532f696dc7ffb8ae1..c968e5f0ebb5f0151fb124bafe10d8d5
<hbox class="tab-drop-indicator" hidden="true"/> <hbox class="tab-drop-indicator" hidden="true"/>
<arrowscrollbox id="tabbrowser-arrowscrollbox" orient="horizontal" flex="1" clicktoscroll="" scrolledtostart="" scrolledtoend=""> <arrowscrollbox id="tabbrowser-arrowscrollbox" orient="horizontal" flex="1" clicktoscroll="" scrolledtostart="" scrolledtoend="">
<tab is="tabbrowser-tab" class="tabbrowser-tab" selected="" visuallyselected="" fadein=""/> <tab is="tabbrowser-tab" class="tabbrowser-tab" selected="" visuallyselected="" fadein=""/>
@@ -73,6 +79,7 @@ @@ -75,6 +81,7 @@
tooltip="dynamic-shortcut-tooltip" tooltip="dynamic-shortcut-tooltip"
data-l10n-id="tabs-toolbar-new-tab"/> data-l10n-id="tabs-toolbar-new-tab"/>
<html:span id="tabbrowser-tab-a11y-desc" hidden="true"/> <html:span id="tabbrowser-tab-a11y-desc" hidden="true"/>
@@ -43,7 +43,7 @@ index dd2f391096968564086911c532f696dc7ffb8ae1..c968e5f0ebb5f0151fb124bafe10d8d5
</tabs> </tabs>
<toolbarbutton id="new-tab-button" <toolbarbutton id="new-tab-button"
@@ -99,9 +106,10 @@ @@ -102,9 +109,10 @@
<toolbarbutton class="content-analysis-indicator toolbarbutton-1 content-analysis-indicator-icon"/> <toolbarbutton class="content-analysis-indicator toolbarbutton-1 content-analysis-indicator-icon"/>
@@ -54,4 +54,4 @@ index dd2f391096968564086911c532f696dc7ffb8ae1..c968e5f0ebb5f0151fb124bafe10d8d5
+</hbox> +</hbox>
<toolbar id="nav-bar" <toolbar id="nav-bar"
class="browser-toolbar chromeclass-location" class="browser-toolbar"

View File

@@ -1,5 +1,5 @@
diff --git a/browser/components/customizableui/CustomizableUI.sys.mjs b/browser/components/customizableui/CustomizableUI.sys.mjs diff --git a/browser/components/customizableui/CustomizableUI.sys.mjs b/browser/components/customizableui/CustomizableUI.sys.mjs
index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa13303d3a3 100644 index 875f8b03d979353ef44a57c15ef1ae09d33ab730..3d6e092e7ed126cdee8c32229df2cfa13303d3a3 100644
--- a/browser/components/customizableui/CustomizableUI.sys.mjs --- a/browser/components/customizableui/CustomizableUI.sys.mjs
+++ b/browser/components/customizableui/CustomizableUI.sys.mjs +++ b/browser/components/customizableui/CustomizableUI.sys.mjs
@@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, {
@@ -19,7 +19,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
}, },
false false
); );
@@ -362,27 +363,23 @@ var CustomizableUIInternal = { @@ -362,20 +363,15 @@ var CustomizableUIInternal = {
"back-button", "back-button",
"forward-button", "forward-button",
"stop-reload-button", "stop-reload-button",
@@ -41,27 +41,29 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
this.registerArea( this.registerArea(
CustomizableUI.AREA_NAVBAR, CustomizableUI.AREA_NAVBAR,
{ {
type: CustomizableUI.TYPE_TOOLBAR, @@ -383,9 +379,6 @@ var CustomizableUIInternal = {
overflowable: true, overflowable: true,
defaultPlacements: navbarPlacements, defaultPlacements: navbarPlacements,
- verticalTabsDefaultPlacements: ["alltabs-button", "ai-window-toggle"], verticalTabsDefaultPlacements: [
+ verticalTabsDefaultPlacements: [ - "alltabs-button",
+ ], - "smartwindow-group-tabs-button",
- "ai-window-toggle",
],
defaultCollapsed: false, defaultCollapsed: false,
}, },
true @@ -410,11 +403,6 @@ var CustomizableUIInternal = {
@@ -406,10 +403,6 @@ var CustomizableUIInternal = {
type: CustomizableUI.TYPE_TOOLBAR, type: CustomizableUI.TYPE_TOOLBAR,
defaultPlacements: [ defaultPlacements: [
"tabbrowser-tabs", "tabbrowser-tabs",
- "new-tab-button", - "new-tab-button",
- "spring", - "spring",
- "alltabs-button", - "alltabs-button",
- "smartwindow-group-tabs-button",
- "ai-window-toggle", - "ai-window-toggle",
], ],
verticalTabsDefaultPlacements: [], verticalTabsDefaultPlacements: [],
defaultCollapsed: null, defaultCollapsed: null,
@@ -502,6 +495,7 @@ var CustomizableUIInternal = { @@ -507,6 +495,7 @@ var CustomizableUIInternal = {
CustomizableUI.AREA_NAVBAR, CustomizableUI.AREA_NAVBAR,
CustomizableUI.AREA_BOOKMARKS, CustomizableUI.AREA_BOOKMARKS,
CustomizableUI.AREA_TABSTRIP, CustomizableUI.AREA_TABSTRIP,
@@ -69,7 +71,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
]); ]);
if (AppConstants.platform != "macosx") { if (AppConstants.platform != "macosx") {
toolbars.add(CustomizableUI.AREA_MENUBAR); toolbars.add(CustomizableUI.AREA_MENUBAR);
@@ -1334,6 +1328,9 @@ var CustomizableUIInternal = { @@ -1339,6 +1328,9 @@ var CustomizableUIInternal = {
placements = gPlacements.get(area); placements = gPlacements.get(area);
} }
@@ -79,7 +81,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
// For toolbars that need it, mark as dirty. // For toolbars that need it, mark as dirty.
let defaultPlacements = areaProperties.get("defaultPlacements"); let defaultPlacements = areaProperties.get("defaultPlacements");
if ( if (
@@ -1842,7 +1839,6 @@ var CustomizableUIInternal = { @@ -1847,7 +1839,6 @@ var CustomizableUIInternal = {
lazy.log.info( lazy.log.info(
"Widget " + aWidgetId + " not found, unable to remove from " + aArea "Widget " + aWidgetId + " not found, unable to remove from " + aArea
); );
@@ -87,7 +89,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
} }
this.notifyDOMChange(widgetNode, null, container, true, () => { this.notifyDOMChange(widgetNode, null, container, true, () => {
@@ -1852,7 +1848,7 @@ var CustomizableUIInternal = { @@ -1857,7 +1848,7 @@ var CustomizableUIInternal = {
// We also need to remove the panel context menu if it's there: // We also need to remove the panel context menu if it's there:
this.ensureButtonContextMenu(widgetNode); this.ensureButtonContextMenu(widgetNode);
if (gPalette.has(aWidgetId) || this.isSpecialWidget(aWidgetId)) { if (gPalette.has(aWidgetId) || this.isSpecialWidget(aWidgetId)) {
@@ -96,7 +98,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
} else { } else {
window.gNavToolbox.palette.appendChild(widgetNode); window.gNavToolbox.palette.appendChild(widgetNode);
} }
@@ -2020,16 +2016,16 @@ var CustomizableUIInternal = { @@ -2025,16 +2016,16 @@ var CustomizableUIInternal = {
elem.setAttribute("skipintoolbarset", "true"); elem.setAttribute("skipintoolbarset", "true");
} }
} }
@@ -116,7 +118,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
// Handle initial state of vertical tabs. // Handle initial state of vertical tabs.
if (isVerticalTabs) { if (isVerticalTabs) {
// Show the vertical tabs toolbar // Show the vertical tabs toolbar
@@ -2271,6 +2267,10 @@ var CustomizableUIInternal = { @@ -2276,6 +2267,10 @@ var CustomizableUIInternal = {
* The identifier string of the area that aNode is being inserted into. * The identifier string of the area that aNode is being inserted into.
*/ */
insertWidgetBefore(aNode, aNextNode, aContainer, aAreaId) { insertWidgetBefore(aNode, aNextNode, aContainer, aAreaId) {
@@ -127,7 +129,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
this.notifyDOMChange(aNode, aNextNode, aContainer, false, () => { this.notifyDOMChange(aNode, aNextNode, aContainer, false, () => {
this.setLocationAttributes(aNode, aAreaId); this.setLocationAttributes(aNode, aAreaId);
aContainer.insertBefore(aNode, aNextNode); aContainer.insertBefore(aNode, aNextNode);
@@ -4647,7 +4647,7 @@ var CustomizableUIInternal = { @@ -4652,7 +4647,7 @@ var CustomizableUIInternal = {
* For all registered areas, builds those areas to reflect the current * For all registered areas, builds those areas to reflect the current
* placement state of all widgets. * placement state of all widgets.
*/ */
@@ -136,7 +138,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
for (let [areaId, areaNodes] of gBuildAreas) { for (let [areaId, areaNodes] of gBuildAreas) {
let placements = gPlacements.get(areaId); let placements = gPlacements.get(areaId);
let isFirstChangedToolbar = true; let isFirstChangedToolbar = true;
@@ -4658,7 +4658,7 @@ var CustomizableUIInternal = { @@ -4663,7 +4658,7 @@ var CustomizableUIInternal = {
if (area.get("type") == CustomizableUI.TYPE_TOOLBAR) { if (area.get("type") == CustomizableUI.TYPE_TOOLBAR) {
let defaultCollapsed = area.get("defaultCollapsed"); let defaultCollapsed = area.get("defaultCollapsed");
let win = areaNode.documentGlobal; let win = areaNode.documentGlobal;
@@ -145,7 +147,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
win.setToolbarVisibility( win.setToolbarVisibility(
areaNode, areaNode,
typeof defaultCollapsed == "string" typeof defaultCollapsed == "string"
@@ -5971,6 +5971,7 @@ export var CustomizableUI = { @@ -5976,6 +5971,7 @@ export var CustomizableUI = {
unregisterArea(aName, aDestroyPlacements) { unregisterArea(aName, aDestroyPlacements) {
CustomizableUIInternal.unregisterArea(aName, aDestroyPlacements); CustomizableUIInternal.unregisterArea(aName, aDestroyPlacements);
}, },
@@ -153,7 +155,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
/** /**
* Add a widget to an area. * Add a widget to an area.
* If the area to which you try to add is not known to CustomizableUI, * If the area to which you try to add is not known to CustomizableUI,
@@ -7946,7 +7947,9 @@ class OverflowableToolbar { @@ -7951,7 +7947,9 @@ class OverflowableToolbar {
); );
if (webExtList && CustomizableUI.isWebExtensionWidget(child.id)) { if (webExtList && CustomizableUI.isWebExtensionWidget(child.id)) {
@@ -163,7 +165,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
webExtList.insertBefore(child, webExtList.firstElementChild); webExtList.insertBefore(child, webExtList.firstElementChild);
} else { } else {
child.setAttribute("cui-anchorid", this.#defaultListButton.id); child.setAttribute("cui-anchorid", this.#defaultListButton.id);
@@ -7995,6 +7998,7 @@ class OverflowableToolbar { @@ -8000,6 +7998,7 @@ class OverflowableToolbar {
return aElement.getBoundingClientRect().width; return aElement.getBoundingClientRect().width;
} }
@@ -171,7 +173,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
function sumChildrenInlineSize(aParent, aExceptChild = null) { function sumChildrenInlineSize(aParent, aExceptChild = null) {
let sum = 0; let sum = 0;
for (let child of aParent.children) { for (let child of aParent.children) {
@@ -8006,7 +8010,10 @@ class OverflowableToolbar { @@ -8011,7 +8010,10 @@ class OverflowableToolbar {
) { ) {
continue; continue;
} }
@@ -183,7 +185,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
if (child != aExceptChild) { if (child != aExceptChild) {
sum += getInlineSize(child); sum += getInlineSize(child);
} }
@@ -8030,11 +8037,11 @@ class OverflowableToolbar { @@ -8035,11 +8037,11 @@ class OverflowableToolbar {
parseFloat(style.paddingLeft) - parseFloat(style.paddingLeft) -
parseFloat(style.paddingRight) - parseFloat(style.paddingRight) -
toolbarChildrenWidth; toolbarChildrenWidth;
@@ -197,7 +199,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
}); });
lazy.log.debug( lazy.log.debug(
@@ -8049,7 +8056,39 @@ class OverflowableToolbar { @@ -8054,7 +8056,39 @@ class OverflowableToolbar {
Math.max(targetWidth, targetChildrenWidth) Math.max(targetWidth, targetChildrenWidth)
); );
totalAvailWidth = Math.ceil(totalAvailWidth); totalAvailWidth = Math.ceil(totalAvailWidth);
@@ -238,7 +240,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
return { isOverflowing, targetContentWidth, totalAvailWidth }; return { isOverflowing, targetContentWidth, totalAvailWidth };
} }
@@ -8110,7 +8149,11 @@ class OverflowableToolbar { @@ -8115,7 +8149,11 @@ class OverflowableToolbar {
return; return;
} }
} }
@@ -251,7 +253,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
lazy.log.debug( lazy.log.debug(
`Need ${minSize} but width is ${totalAvailWidth} so bailing` `Need ${minSize} but width is ${totalAvailWidth} so bailing`
); );
@@ -8143,7 +8186,7 @@ class OverflowableToolbar { @@ -8148,7 +8186,7 @@ class OverflowableToolbar {
} }
} }
if (!inserted) { if (!inserted) {
@@ -260,7 +262,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
} }
child.removeAttribute("cui-anchorid"); child.removeAttribute("cui-anchorid");
child.removeAttribute("overflowedItem"); child.removeAttribute("overflowedItem");
@@ -8269,6 +8312,9 @@ class OverflowableToolbar { @@ -8274,6 +8312,9 @@ class OverflowableToolbar {
* if no such list exists. * if no such list exists.
*/ */
get #webExtList() { get #webExtList() {
@@ -270,7 +272,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
if (!this.#webExtListRef) { if (!this.#webExtListRef) {
let targetID = this.#toolbar.getAttribute("addon-webext-overflowtarget"); let targetID = this.#toolbar.getAttribute("addon-webext-overflowtarget");
if (!targetID) { if (!targetID) {
@@ -8280,6 +8326,9 @@ class OverflowableToolbar { @@ -8285,6 +8326,9 @@ class OverflowableToolbar {
let win = this.#toolbar.documentGlobal; let win = this.#toolbar.documentGlobal;
let { panel } = win.gUnifiedExtensions; let { panel } = win.gUnifiedExtensions;
this.#webExtListRef = panel.querySelector(`#${targetID}`); this.#webExtListRef = panel.querySelector(`#${targetID}`);
@@ -280,7 +282,7 @@ index 6d1885a54815d10b3a4e79f7e5acd61ab3abb159..3d6e092e7ed126cdee8c32229df2cfa1
} }
return this.#webExtListRef; return this.#webExtListRef;
} }
@@ -8488,7 +8537,7 @@ class OverflowableToolbar { @@ -8493,7 +8537,7 @@ class OverflowableToolbar {
break; break;
} }
case "mousedown": { case "mousedown": {

View File

@@ -1,16 +1,16 @@
diff --git a/browser/components/sessionstore/SessionFile.sys.mjs b/browser/components/sessionstore/SessionFile.sys.mjs diff --git a/browser/components/sessionstore/SessionFile.sys.mjs b/browser/components/sessionstore/SessionFile.sys.mjs
index 5580838acd72bf0e1189d367984859529d89f5b4..e5fa6076a9cc6ada016ccc4e129cad455010a522 100644 index 370e5c105c3d9bee05c2d9d7b63d0ee45b8331e1..1c37c19794ebe863a25f780e9a74d63526b929d7 100644
--- a/browser/components/sessionstore/SessionFile.sys.mjs --- a/browser/components/sessionstore/SessionFile.sys.mjs
+++ b/browser/components/sessionstore/SessionFile.sys.mjs +++ b/browser/components/sessionstore/SessionFile.sys.mjs
@@ -22,6 +22,7 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -25,6 +25,7 @@ const lazy = XPCOMUtils.declareLazy({
RunState: "resource:///modules/sessionstore/RunState.sys.mjs", "moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionWriter:
SessionWriter: "resource:///modules/sessionstore/SessionWriter.sys.mjs", "moz-src:///browser/components/sessionstore/SessionWriter.sys.mjs",
+ ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs", + ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs",
}); });
const PREF_UPGRADE_BACKUP = "browser.sessionstore.upgradeBackup.latestBuildID"; const PREF_UPGRADE_BACKUP = "browser.sessionstore.upgradeBackup.latestBuildID";
@@ -381,7 +382,7 @@ var SessionFileInternal = { @@ -384,7 +385,7 @@ var SessionFileInternal = {
this._readOrigin = result.origin; this._readOrigin = result.origin;
result.noFilesFound = noFilesFound; result.noFilesFound = noFilesFound;

View File

@@ -1,11 +1,11 @@
diff --git a/browser/components/sessionstore/SessionSaver.sys.mjs b/browser/components/sessionstore/SessionSaver.sys.mjs diff --git a/browser/components/sessionstore/SessionSaver.sys.mjs b/browser/components/sessionstore/SessionSaver.sys.mjs
index 9141793550f7c7ff6aa63d4c85bf571b4499e2d0..6906fd9be7ae6ca4316133e0d6552b797c54a7ec 100644 index 1f26bc5fdb83f55bdf0b9b7d01fafe1cd37f77f4..5916f741d0fa04c392dcdd10f843e595fe5e058c 100644
--- a/browser/components/sessionstore/SessionSaver.sys.mjs --- a/browser/components/sessionstore/SessionSaver.sys.mjs
+++ b/browser/components/sessionstore/SessionSaver.sys.mjs +++ b/browser/components/sessionstore/SessionSaver.sys.mjs
@@ -20,6 +20,7 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -20,6 +20,7 @@ const lazy = XPCOMUtils.declareLazy({
SessionFile: "resource:///modules/sessionstore/SessionFile.sys.mjs", "moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", sessionStoreLogger:
sessionStoreLogger: "resource:///modules/sessionstore/SessionLogger.sys.mjs", "moz-src:///browser/components/sessionstore/SessionLogger.sys.mjs",
+ ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs", + ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs",
}); });

View File

@@ -1,16 +1,16 @@
diff --git a/browser/components/sessionstore/SessionStartup.sys.mjs b/browser/components/sessionstore/SessionStartup.sys.mjs diff --git a/browser/components/sessionstore/SessionStartup.sys.mjs b/browser/components/sessionstore/SessionStartup.sys.mjs
index 86600ffb5178599ab23270a964064ca657a3283f..70d7b5c7d69d3700475d663b595052264c67d351 100644 index 919d4536c5462603346684bbe26794ae9279b517..5a8fae0708e4a9a82c5e85f8a473ebaeafebe71f 100644
--- a/browser/components/sessionstore/SessionStartup.sys.mjs --- a/browser/components/sessionstore/SessionStartup.sys.mjs
+++ b/browser/components/sessionstore/SessionStartup.sys.mjs +++ b/browser/components/sessionstore/SessionStartup.sys.mjs
@@ -40,6 +40,7 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -41,6 +41,7 @@ const lazy = XPCOMUtils.declareLazy({
StartupPerformance: "moz-src:///browser/components/sessionstore/StartupPerformance.sys.mjs",
"resource:///modules/sessionstore/StartupPerformance.sys.mjs", sessionStoreLogger:
sessionStoreLogger: "resource:///modules/sessionstore/SessionLogger.sys.mjs", "moz-src:///browser/components/sessionstore/SessionLogger.sys.mjs",
+ ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs", + ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs",
}); });
const STATE_RUNNING_STR = "running"; const STATE_RUNNING_STR = "running";
@@ -85,7 +86,7 @@ export var SessionStartup = { @@ -86,7 +87,7 @@ export var SessionStartup = {
} }
// do not need to initialize anything in auto-started private browsing sessions // do not need to initialize anything in auto-started private browsing sessions
@@ -19,7 +19,7 @@ index 86600ffb5178599ab23270a964064ca657a3283f..70d7b5c7d69d3700475d663b59505226
this._initialized = true; this._initialized = true;
gOnceInitializedDeferred.resolve(); gOnceInitializedDeferred.resolve();
return; return;
@@ -179,6 +180,8 @@ export var SessionStartup = { @@ -180,6 +181,8 @@ export var SessionStartup = {
this._initialState = parsed; this._initialState = parsed;
} }
@@ -28,7 +28,7 @@ index 86600ffb5178599ab23270a964064ca657a3283f..70d7b5c7d69d3700475d663b59505226
if (this._initialState == null) { if (this._initialState == null) {
// No valid session found. // No valid session found.
this._sessionType = this.NO_SESSION; this._sessionType = this.NO_SESSION;
@@ -276,6 +279,8 @@ export var SessionStartup = { @@ -277,6 +280,8 @@ export var SessionStartup = {
`Previous shutdown ok? ${this._previousSessionCrashed}, reason: ${previousSessionCrashedReason}` `Previous shutdown ok? ${this._previousSessionCrashed}, reason: ${previousSessionCrashedReason}`
); );
@@ -37,7 +37,7 @@ index 86600ffb5178599ab23270a964064ca657a3283f..70d7b5c7d69d3700475d663b59505226
Services.obs.addObserver(this, "sessionstore-windows-restored", true); Services.obs.addObserver(this, "sessionstore-windows-restored", true);
if (this.sessionType == this.NO_SESSION) { if (this.sessionType == this.NO_SESSION) {
@@ -336,12 +341,7 @@ export var SessionStartup = { @@ -337,12 +342,7 @@ export var SessionStartup = {
isAutomaticRestoreEnabled() { isAutomaticRestoreEnabled() {
if (this._resumeSessionEnabled === null) { if (this._resumeSessionEnabled === null) {
this._resumeSessionEnabled = this._resumeSessionEnabled =
@@ -51,7 +51,7 @@ index 86600ffb5178599ab23270a964064ca657a3283f..70d7b5c7d69d3700475d663b59505226
} }
return this._resumeSessionEnabled; return this._resumeSessionEnabled;
@@ -354,8 +354,7 @@ export var SessionStartup = { @@ -355,8 +355,7 @@ export var SessionStartup = {
*/ */
willRestore() { willRestore() {
return ( return (

View File

@@ -1,8 +1,8 @@
diff --git a/browser/components/sessionstore/SessionStore.sys.mjs b/browser/components/sessionstore/SessionStore.sys.mjs diff --git a/browser/components/sessionstore/SessionStore.sys.mjs b/browser/components/sessionstore/SessionStore.sys.mjs
index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2eaa1afed 100644 index 52fc803050cd257d6de52b1e4a92f3211cbaba88..a9841832ddce540dc0f9b14c29e5eadac7510935 100644
--- a/browser/components/sessionstore/SessionStore.sys.mjs --- a/browser/components/sessionstore/SessionStore.sys.mjs
+++ b/browser/components/sessionstore/SessionStore.sys.mjs +++ b/browser/components/sessionstore/SessionStore.sys.mjs
@@ -126,6 +126,11 @@ const TAB_EVENTS = [ @@ -111,6 +111,11 @@ const TAB_EVENTS = [
"TabSplitViewActivate", "TabSplitViewActivate",
"SplitViewRemoved", "SplitViewRemoved",
"SplitViewCreated", "SplitViewCreated",
@@ -14,16 +14,39 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
]; ];
const XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"; const XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
@@ -198,6 +203,8 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -185,6 +190,8 @@ const lazy = XPCOMUtils.declareLazy({
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateFlusher:
TabStateFlusher: "resource:///modules/sessionstore/TabStateFlusher.sys.mjs", "moz-src:///browser/components/sessionstore/TabStateFlusher.sys.mjs",
setTimeout: "resource://gre/modules/Timer.sys.mjs", setTimeout: "resource://gre/modules/Timer.sys.mjs",
+ ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs", + ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs",
+ ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs", + ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs",
}); blankURI: () => Services.io.newURI("about:blank"),
gRestoreWindowsToVirtualDesktop: {
pref: "browser.sessionstore.restore_windows_to_virtual_desktop",
@@ -348,6 +355,22 @@ class _SessionStore {
return this.#shouldRestoreLastSession;
}
ChromeUtils.defineLazyGetter(lazy, "blankURI", () => { + get _windows() {
@@ -1314,10 +1321,7 @@ var SessionStoreInternal = { + return this.#windows;
+ }
+
+ get _browserWindows() {
+ return this.#browserWindows;
+ }
+
+ set _deferredInitialState(aState) {
+ this.#deferredInitialState = aState;
+ }
+
+ initializeWindow(aWindow, aInitialState) {
+ this.#initializeWindow(aWindow, aInitialState);
+ }
+
// whether we will potentially be restoring the session
// more than once without Firefox restarting in between
#restoreWithoutRestart = false;
@@ -515,10 +538,7 @@ class _SessionStore {
*/ */
get willAutoRestore() { get willAutoRestore() {
return ( return (
@@ -33,9 +56,9 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
- BROWSER_STARTUP_RESUME_SESSION) - BROWSER_STARTUP_RESUME_SESSION)
+ true + true
); );
}, }
@@ -2005,6 +2009,11 @@ var SessionStoreInternal = { @@ -1215,6 +1235,11 @@ class _SessionStore {
case "TabPinned": case "TabPinned":
case "TabUnpinned": case "TabUnpinned":
case "SwapDocShells": case "SwapDocShells":
@@ -44,47 +67,47 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
+ case "TabMove": + case "TabMove":
+ case "TabGroupMoved": + case "TabGroupMoved":
+ case "ZenWorkspaceDataChanged": + case "ZenWorkspaceDataChanged":
this.saveStateDelayed(win); this.#saveStateDelayed(win);
break; break;
case "TabGroupCreate": case "TabGroupCreate":
@@ -2114,6 +2123,10 @@ var SessionStoreInternal = { @@ -1341,6 +1366,10 @@ class _SessionStore {
this._windows[aWindow.__SSi].isTaskbarTab = true; this.#windows[aWindow.__SSi].isTaskbarTab = true;
} }
+ if (aWindow.document.documentElement.hasAttribute("zen-unsynced-window")) { + if (aWindow.document.documentElement.hasAttribute("zen-unsynced-window")) {
+ this._windows[aWindow.__SSi].isZenUnsynced = true; + this.#windows[aWindow.__SSi].isZenUnsynced = true;
+ } + }
+ +
if (lazy.AIWindow.isAIWindowActiveAndEnabled(aWindow)) { if (lazy.AIWindow.isAIWindowActiveAndEnabled(aWindow)) {
this._windows[aWindow.__SSi].isAIWindow = true; this.#windows[aWindow.__SSi].isAIWindow = true;
} }
@@ -2150,7 +2163,7 @@ var SessionStoreInternal = { @@ -1377,7 +1406,7 @@ class _SessionStore {
let isTaskbarTab = this._windows[aWindow.__SSi].isTaskbarTab; let isTaskbarTab = this.#windows[aWindow.__SSi].isTaskbarTab;
// A regular window is not a private window, taskbar tab window, or popup window // A regular window is not a private window, taskbar tab window, or popup window
let isRegularWindow = let isRegularWindow =
- !isPrivateWindow && !isTaskbarTab && aWindow.toolbar.visible; - !isPrivateWindow && !isTaskbarTab && aWindow.toolbar.visible;
+ !isPrivateWindow && !isTaskbarTab && aWindow.toolbar.visible && !this._windows[aWindow.__SSi].isZenUnsynced; + !isPrivateWindow && !isTaskbarTab && aWindow.toolbar.visible && !this.#windows[aWindow.__SSi].isZenUnsynced;
// perform additional initialization when the first window is loading // perform additional initialization when the first window is loading
if (lazy.RunState.isStopped) { if (lazy.RunState.isStopped) {
@@ -2162,7 +2175,7 @@ var SessionStoreInternal = { @@ -1389,7 +1418,7 @@ class _SessionStore {
// to disk to NOW() to enforce a full interval before the next write. // to disk to NOW() to enforce a full interval before the next write.
lazy.SessionSaver.updateLastSaveTime(); lazy.SessionSaver.updateLastSaveTime();
- if (isPrivateWindow || isTaskbarTab) { - if (isPrivateWindow || isTaskbarTab) {
+ if (isPrivateWindow || isTaskbarTab || aWindow.document.documentElement.hasAttribute("zen-unsynced-window")) { + if (isPrivateWindow || isTaskbarTab || aWindow.document.documentElement.hasAttribute("zen-unsynced-window")) {
this._log.debug( this.#log.debug(
"initializeWindow, the window is private or a web app. Saving SessionStartup.state for possibly restoring later" "initializeWindow, the window is private or a web app. Saving SessionStartup.state for possibly restoring later"
); );
@@ -2206,6 +2219,7 @@ var SessionStoreInternal = { @@ -1433,6 +1462,7 @@ class _SessionStore {
null, null,
"sessionstore-one-or-no-tab-restored" "sessionstore-one-or-no-tab-restored"
); );
+ lazy.ZenSessionStore.onNewEmptySession(aWindow); + lazy.ZenSessionStore.onNewEmptySession(aWindow);
this._deferredAllWindowsRestored.resolve(); this.#deferredAllWindowsRestored.resolve();
} }
// this window was opened by _openWindowWithState // this window was opened by #openWindowWithState
@@ -2255,7 +2269,6 @@ var SessionStoreInternal = { @@ -1482,7 +1512,6 @@ class _SessionStore {
if (closedWindowState) { if (closedWindowState) {
let newWindowState; let newWindowState;
if ( if (
@@ -92,25 +115,25 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
!lazy.SessionStartup.willRestore() !lazy.SessionStartup.willRestore()
) { ) {
// We want to split the window up into pinned tabs and unpinned tabs. // We want to split the window up into pinned tabs and unpinned tabs.
@@ -2291,6 +2304,7 @@ var SessionStoreInternal = { @@ -1518,6 +1547,7 @@ class _SessionStore {
} }
if (newWindowState) { if (newWindowState) {
+ lazy.ZenSessionStore.onRestoringClosedWindow(newWindowState); + lazy.ZenSessionStore.onRestoringClosedWindow(newWindowState);
// Ensure that the window state isn't hidden // Ensure that the window state isn't hidden
this._restoreCount = 1; this.#restoreCount = 1;
let state = { windows: [newWindowState] }; let state = { windows: [newWindowState] };
@@ -2327,6 +2341,9 @@ var SessionStoreInternal = { @@ -1554,6 +1584,9 @@ class _SessionStore {
}); });
this._shouldRestoreLastSession = false; this.#shouldRestoreLastSession = false;
} }
+ else if (!aInitialState && isRegularWindow) { + else if (!aInitialState && isRegularWindow) {
+ lazy.ZenSessionStore.restoreNewWindow(aWindow, this); + lazy.ZenSessionStore.restoreNewWindow(aWindow, this);
+ } + }
if (this._restoreLastWindow && aWindow.toolbar.visible) { if (this.#restoreLastWindow && aWindow.toolbar.visible) {
// always reset (if not a popup window) // always reset (if not a popup window)
@@ -2477,7 +2494,7 @@ var SessionStoreInternal = { @@ -1704,7 +1737,7 @@ class _SessionStore {
var tabbrowser = aWindow.gBrowser; var tabbrowser = aWindow.gBrowser;
@@ -119,56 +142,56 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
TAB_EVENTS.forEach(function (aEvent) { TAB_EVENTS.forEach(function (aEvent) {
tabbrowser.tabContainer.removeEventListener(aEvent, this, true); tabbrowser.tabContainer.removeEventListener(aEvent, this, true);
@@ -2528,7 +2545,7 @@ var SessionStoreInternal = { @@ -1755,7 +1788,7 @@ class _SessionStore {
let isLastRegularWindow = let isLastRegularWindow =
Object.values(this._windows).filter( Object.values(this.#windows).filter(
- wData => !wData.isPrivate && !wData.isTaskbarTab - wData => !wData.isPrivate && !wData.isTaskbarTab
+ wData => !wData.isPrivate && !wData.isTaskbarTab && !wData.isZenUnsynced + wData => !wData.isPrivate && !wData.isTaskbarTab && !wData.isZenUnsynced
).length == 1; ).length == 1;
this._log.debug( this.#log.debug(
`onClose, closing window isLastRegularWindow? ${isLastRegularWindow}` `onClose, closing window isLastRegularWindow? ${isLastRegularWindow}`
@@ -2585,8 +2602,8 @@ var SessionStoreInternal = { @@ -1812,8 +1845,8 @@ class _SessionStore {
// 2) Flush the window. // 2) Flush the window.
// 3) When the flush is complete, revisit our decision to store the window // 3) When the flush is complete, revisit our decision to store the window
// in _closedWindows, and add/remove as necessary. // in #closedWindows, and add/remove as necessary.
- if (!winData.isPrivate && !winData.isTaskbarTab) { - if (!winData.isPrivate && !winData.isTaskbarTab) {
- this.maybeSaveClosedWindow(winData, isLastWindow); - this.#maybeSaveClosedWindow(winData, isLastWindow);
+ if (!winData.isPrivate && !winData.isTaskbarTab && !winData.isZenUnsynced) { + if (!winData.isPrivate && !winData.isTaskbarTab && !winData.isZenUnsynced) {
+ this.maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow); + this.#maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow);
} }
completionPromise = lazy.TabStateFlusher.flushWindow(aWindow).then(() => { completionPromise = lazy.TabStateFlusher.flushWindow(aWindow).then(() => {
@@ -2606,8 +2623,9 @@ var SessionStoreInternal = { @@ -1833,8 +1866,9 @@ class _SessionStore {
// Save non-private windows if they have at // Save non-private windows if they have at
// least one saveable tab or are the last window. // least one saveable tab or are the last window.
- if (!winData.isPrivate && !winData.isTaskbarTab) { - if (!winData.isPrivate && !winData.isTaskbarTab) {
- this.maybeSaveClosedWindow(winData, isLastWindow); - this.#maybeSaveClosedWindow(winData, isLastWindow);
+ lazy.ZenWindowSync.on_WindowCloseAndBrowserFlushed(browsers); + lazy.ZenWindowSync.on_WindowCloseAndBrowserFlushed(browsers);
+ if (!winData.isPrivate && !winData.isTaskbarTab && !winData.isZenUnsynced) { + if (!winData.isPrivate && !winData.isTaskbarTab && !winData.isZenUnsynced) {
+ this.maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow); + this.#maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow);
if (!isLastWindow && winData.closedId > -1) { if (!isLastWindow && winData.closedId > -1) {
this._addClosedAction( this.#addClosedAction(
@@ -2683,7 +2701,7 @@ var SessionStoreInternal = { @@ -1910,7 +1944,7 @@ class _SessionStore {
* to call this method again asynchronously (for example, after * to call this method again asynchronously (for example, after
* a window flush). * a window flush).
*/ */
- maybeSaveClosedWindow(winData, isLastWindow) { - #maybeSaveClosedWindow(winData, isLastWindow) {
+ maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow = false) { + #maybeSaveClosedWindow(winData, isLastWindow, isLastRegularWindow = false) {
// Make sure SessionStore is still running, and make sure that we // Make sure SessionStore is still running, and make sure that we
// haven't chosen to forget this window. // haven't chosen to forget this window.
if ( if (
@@ -2700,6 +2718,7 @@ var SessionStoreInternal = { @@ -1927,6 +1961,7 @@ class _SessionStore {
// _closedWindows from a previous call to this function. // #closedWindows from a previous call to this function.
let winIndex = this._closedWindows.indexOf(winData); let winIndex = this.#closedWindows.indexOf(winData);
let alreadyStored = winIndex != -1; let alreadyStored = winIndex != -1;
+ lazy.ZenSessionStore.maybeSaveClosedWindow(winData, isLastRegularWindow); + lazy.ZenSessionStore.maybeSaveClosedWindow(winData, isLastRegularWindow);
// If sidebar command is truthy, i.e. sidebar is open, store sidebar settings // If sidebar command is truthy, i.e. sidebar is open, store sidebar settings
let shouldStore = hasSaveableTabs || isLastWindow; let shouldStore = hasSaveableTabs || isLastWindow;
@@ -3522,7 +3541,7 @@ var SessionStoreInternal = { @@ -2744,7 +2779,7 @@ class _SessionStore {
if (!isPrivateWindow && tabState.isPrivate) { if (!isPrivateWindow && tabState.isPrivate) {
return; return;
} }
@@ -177,7 +200,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
return; return;
} }
@@ -4260,7 +4279,15 @@ var SessionStoreInternal = { @@ -3511,7 +3546,15 @@ class _SessionStore {
1, 1,
Math.min(tabState.index, tabState.entries.length) Math.min(tabState.index, tabState.entries.length)
); );
@@ -194,7 +217,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
if (inBackground === false) { if (inBackground === false) {
aWindow.gBrowser.selectedTab = newTab; aWindow.gBrowser.selectedTab = newTab;
@@ -4694,6 +4721,8 @@ var SessionStoreInternal = { @@ -4036,6 +4079,8 @@ class _SessionStore {
// Append the tab if we're opening into a different window, // Append the tab if we're opening into a different window,
tabIndex: aSource == aTargetWindow ? pos : Infinity, tabIndex: aSource == aTargetWindow ? pos : Infinity,
pinned: state.pinned, pinned: state.pinned,
@@ -203,7 +226,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
userContextId: state.userContextId, userContextId: state.userContextId,
skipLoad: true, skipLoad: true,
preferredRemoteType, preferredRemoteType,
@@ -5191,9 +5220,10 @@ var SessionStoreInternal = { @@ -4608,9 +4653,10 @@ class _SessionStore {
if (activePageData.title && activePageData.title != activePageData.url) { if (activePageData.title && activePageData.title != activePageData.url) {
win.gBrowser.setInitialTabTitle(tab, activePageData.title, { win.gBrowser.setInitialTabTitle(tab, activePageData.title, {
isContentTitle: true, isContentTitle: true,
@@ -215,7 +238,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
} }
} }
@@ -5561,7 +5591,7 @@ var SessionStoreInternal = { @@ -4982,7 +5028,7 @@ class _SessionStore {
for (let i = tabbrowser.pinnedTabCount; i < tabbrowser.tabs.length; i++) { for (let i = tabbrowser.pinnedTabCount; i < tabbrowser.tabs.length; i++) {
let tab = tabbrowser.tabs[i]; let tab = tabbrowser.tabs[i];
@@ -224,30 +247,30 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
removableTabs.push(tab); removableTabs.push(tab);
} }
} }
@@ -5674,7 +5704,7 @@ var SessionStoreInternal = { @@ -5095,7 +5141,7 @@ class _SessionStore {
// collect the data for all windows // collect the data for all windows
for (ix in this._windows) { for (ix in this.#windows) {
- if (this._windows[ix]._restoring || this._windows[ix].isTaskbarTab) { - if (this.#windows[ix]._restoring || this.#windows[ix].isTaskbarTab) {
+ if (this._windows[ix]._restoring || this._windows[ix].isTaskbarTab && !this._windows[ix].isZenUnsynced) { + if (this.#windows[ix]._restoring || this.#windows[ix].isTaskbarTab && !this.#windows[ix].isZenUnsynced) {
// window data is still in _statesToRestore // window data is still in #statesToRestore
continue; continue;
} }
@@ -5818,11 +5848,12 @@ var SessionStoreInternal = { @@ -5239,11 +5285,12 @@ class _SessionStore {
} }
let tabbrowser = aWindow.gBrowser; let tabbrowser = aWindow.gBrowser;
- let tabs = tabbrowser.tabs; - let tabs = tabbrowser.tabs;
+ let tabs = aWindow.gZenWorkspaces.allStoredTabs; + let tabs = aWindow.gZenWorkspaces.allStoredTabs;
/** @type {WindowStateData} */ /** @type {WindowStateData} */
let winData = this._windows[aWindow.__SSi]; let winData = this.#windows[aWindow.__SSi];
let tabsData = (winData.tabs = []); let tabsData = (winData.tabs = []);
+ winData.splitViewData = aWindow.gZenViewSplitter?.storeDataForSessionStore(); + winData.splitViewData = aWindow.gZenViewSplitter?.storeDataForSessionStore();
// update the internal state data for this window // update the internal state data for this window
for (let tab of tabs) { for (let tab of tabs) {
if (tab == aWindow.FirefoxViewHandler.tab) { if (tab == aWindow.FirefoxViewHandler.tab) {
@@ -5833,6 +5864,9 @@ var SessionStoreInternal = { @@ -5254,6 +5301,9 @@ class _SessionStore {
tabsData.push(tabData); tabsData.push(tabData);
} }
@@ -257,7 +280,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
// update tab group state for this window // update tab group state for this window
winData.groups = []; winData.groups = [];
for (let tabGroup of aWindow.gBrowser.tabGroups) { for (let tabGroup of aWindow.gBrowser.tabGroups) {
@@ -5849,7 +5883,7 @@ var SessionStoreInternal = { @@ -5270,7 +5320,7 @@ class _SessionStore {
// a window is closed, point to the first item in the tab strip instead (it will never be the Firefox View tab, // a window is closed, point to the first item in the tab strip instead (it will never be the Firefox View tab,
// since it's only inserted into the tab strip after it's selected). // since it's only inserted into the tab strip after it's selected).
if (aWindow.FirefoxViewHandler.tab?.selected) { if (aWindow.FirefoxViewHandler.tab?.selected) {
@@ -266,7 +289,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
winData.title = tabbrowser.tabs[0].label; winData.title = tabbrowser.tabs[0].label;
} }
winData.selected = selectedIndex; winData.selected = selectedIndex;
@@ -6051,8 +6085,8 @@ var SessionStoreInternal = { @@ -5472,8 +5522,8 @@ class _SessionStore {
// selectTab represents. // selectTab represents.
let selectTab = 0; let selectTab = 0;
if (overwriteTabs) { if (overwriteTabs) {
@@ -277,7 +300,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
selectTab = Math.min(selectTab, winData.tabs.length); selectTab = Math.min(selectTab, winData.tabs.length);
} }
@@ -6074,6 +6108,7 @@ var SessionStoreInternal = { @@ -5495,6 +5545,7 @@ class _SessionStore {
if (overwriteTabs) { if (overwriteTabs) {
for (let i = tabbrowser.browsers.length - 1; i >= 0; i--) { for (let i = tabbrowser.browsers.length - 1; i >= 0; i--) {
if (!tabbrowser.tabs[i].selected) { if (!tabbrowser.tabs[i].selected) {
@@ -285,7 +308,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
tabbrowser.removeTab(tabbrowser.tabs[i]); tabbrowser.removeTab(tabbrowser.tabs[i]);
} }
} }
@@ -6108,6 +6143,12 @@ var SessionStoreInternal = { @@ -5529,6 +5580,12 @@ class _SessionStore {
savedTabGroup => !openTabGroupIdsInWindow.has(savedTabGroup.id) savedTabGroup => !openTabGroupIdsInWindow.has(savedTabGroup.id)
); );
} }
@@ -298,7 +321,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
// Move the originally open tabs to the end. // Move the originally open tabs to the end.
if (initialTabs) { if (initialTabs) {
@@ -6674,6 +6715,25 @@ var SessionStoreInternal = { @@ -6098,6 +6155,25 @@ class _SessionStore {
// Most of tabData has been restored, now continue with restoring // Most of tabData has been restored, now continue with restoring
// attributes that may trigger external events. // attributes that may trigger external events.
@@ -324,24 +347,25 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
if (tabData.pinned) { if (tabData.pinned) {
tabbrowser.pinTab(tab); tabbrowser.pinTab(tab);
@@ -6859,6 +6919,9 @@ var SessionStoreInternal = { @@ -6272,6 +6348,9 @@ class _SessionStore {
aWindow.gURLBar.readOnly = false; aWindow.gURLBar.readOnly = false;
} }
} }
+ if (aWinData.isZenUnsynced) { + if (aWinData.isZenUnsynced) {
+ this._windows[aWindow.__SSi].isZenUnsynced = true; + this.#windows[aWindow.__SSi].isZenUnsynced = true;
+ } + }
let promiseParts = Promise.withResolvers(); let promiseParts = Promise.withResolvers();
aWindow.setTimeout(() => { const wasMinimized = aWindow.windowState == aWindow.STATE_MINIMIZED;
@@ -7356,5 +7419,6 @@ var SessionStoreInternal = { @@ -6774,6 +6853,7 @@ class _SessionStore {
*/ */
_isCmdLineEmpty: function ssi_isCmdLineEmpty(aWindow, aState) { #isCmdLineEmpty(aWindow, aState) {
var pinnedOnly = var pinnedOnly =
+ !Services.prefs.getBoolPref("zen.workspaces.continue-where-left-off") && + !Services.prefs.getBoolPref("zen.workspaces.continue-where-left-off") &&
aState.windows && aState.windows &&
aState.windows.every(win => win.tabs.every(tab => tab.pinned)); aState.windows.every(win => win.tabs.every(tab => tab.pinned));
@@ -7654,7 +7718,7 @@ var SessionStoreInternal = {
@@ -7116,7 +7196,7 @@ class _SessionStore {
let groupsToSave = new Map(); let groupsToSave = new Map();
for (let tIndex = 0; tIndex < window.tabs.length; ) { for (let tIndex = 0; tIndex < window.tabs.length; ) {
@@ -350,7 +374,7 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
// Adjust window.selected // Adjust window.selected
if (tIndex + 1 < window.selected) { if (tIndex + 1 < window.selected) {
window.selected -= 1; window.selected -= 1;
@@ -7669,7 +7733,7 @@ var SessionStoreInternal = { @@ -7131,7 +7211,7 @@ class _SessionStore {
); );
// We don't want to increment tIndex here. // We don't want to increment tIndex here.
continue; continue;
@@ -359,15 +383,15 @@ index 76a984f6e21409941ea038218d161e67f2e0c23d..52408568a33a89c0e3d0d1514152ded2
// Convert any open groups into saved groups. // Convert any open groups into saved groups.
let groupStateToSave = window.groups.find( let groupStateToSave = window.groups.find(
groupState => groupState.id == window.tabs[tIndex].groupId groupState => groupState.id == window.tabs[tIndex].groupId
@@ -8233,7 +8297,6 @@ var SessionStoreInternal = { @@ -7691,7 +7771,6 @@ class _SessionStore {
timer.initWithCallback( timer.initWithCallback(
function () { () => {
if (beats <= 0) { if (beats <= 0) {
- this._log.debug(`looseTimer of ${delay} timed out`); - this.#log.debug(`looseTimer of ${delay} timed out`);
Glean.sessionRestore.shutdownFlushAllOutcomes.timed_out.add(1); Glean.sessionRestore.shutdownFlushAllOutcomes.timed_out.add(1);
deferred.resolve(); deferred.resolve();
} }
@@ -8711,6 +8774,7 @@ var SessionStoreInternal = { @@ -8174,6 +8253,7 @@ class _SessionStore {
if ( if (
!savedTabGroupState.tabs.length || !savedTabGroupState.tabs.length ||
this.getSavedTabGroup(savedTabGroupState.id) this.getSavedTabGroup(savedTabGroupState.id)

View File

@@ -1,16 +1,16 @@
diff --git a/browser/components/sessionstore/TabState.sys.mjs b/browser/components/sessionstore/TabState.sys.mjs diff --git a/browser/components/sessionstore/TabState.sys.mjs b/browser/components/sessionstore/TabState.sys.mjs
index a33deeb5b587d6a950960a1a4781176e4e730ad7..7927471d389f2626e4cc1b0e7a6eab6446dca432 100644 index bb7bd8c7ca88f776188fce64e0c85beb5ceb27a5..bdec77ba26172fe1b41369b1d45d5a6f9d52ae25 100644
--- a/browser/components/sessionstore/TabState.sys.mjs --- a/browser/components/sessionstore/TabState.sys.mjs
+++ b/browser/components/sessionstore/TabState.sys.mjs +++ b/browser/components/sessionstore/TabState.sys.mjs
@@ -8,6 +8,7 @@ ChromeUtils.defineESModuleGetters(lazy, { @@ -10,6 +10,7 @@ const lazy = XPCOMUtils.declareLazy({
PrivacyFilter: "resource://gre/modules/sessionstore/PrivacyFilter.sys.mjs", "moz-src:///browser/components/sessionstore/TabAttributes.sys.mjs",
TabAttributes: "resource:///modules/sessionstore/TabAttributes.sys.mjs", TabStateCache:
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", "moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
+ UrlbarShared: "chrome://browser/content/urlbar/UrlbarShared.mjs", + UrlbarShared: "chrome://browser/content/urlbar/UrlbarShared.mjs",
sessionStoreLogger: "resource:///modules/sessionstore/SessionLogger.sys.mjs", sessionStoreLogger:
"moz-src:///browser/components/sessionstore/SessionLogger.sys.mjs",
}); });
@@ -106,10 +107,28 @@ class _TabState {
@@ -103,10 +104,28 @@ class _TabState {
} }
} }
@@ -39,7 +39,7 @@ index a33deeb5b587d6a950960a1a4781176e4e730ad7..7927471d389f2626e4cc1b0e7a6eab64
tabData.userContextId = tab.userContextId || 0; tabData.userContextId = tab.userContextId || 0;
@@ -132,6 +151,10 @@ class _TabState { @@ -135,6 +154,10 @@ class _TabState {
tabData.image = tabbrowser.getIcon(tab); tabData.image = tabbrowser.getIcon(tab);
} }

File diff suppressed because it is too large Load Diff

View File

@@ -1,8 +1,8 @@
diff --git a/browser/components/tabbrowser/content/drag-and-drop.js b/browser/components/tabbrowser/content/drag-and-drop.js diff --git a/browser/components/tabbrowser/content/drag-and-drop.js b/browser/components/tabbrowser/content/drag-and-drop.js
index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8edf9bcf4 100644 index f9623f82499e516050d523068e70ebaa4fe9a66a..95bcc078a86b4ec4b35f5916b7e4a5e305afba9e 100644
--- a/browser/components/tabbrowser/content/drag-and-drop.js --- a/browser/components/tabbrowser/content/drag-and-drop.js
+++ b/browser/components/tabbrowser/content/drag-and-drop.js +++ b/browser/components/tabbrowser/content/drag-and-drop.js
@@ -35,6 +35,9 @@ @@ -42,6 +42,9 @@
* @returns {MozTabbrowserTab|vbox} * @returns {MozTabbrowserTab|vbox}
*/ */
const elementToMove = element => { const elementToMove = element => {
@@ -12,7 +12,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if (isTab(element) || isSplitViewWrapper(element)) { if (isTab(element) || isSplitViewWrapper(element)) {
return element; return element;
} }
@@ -128,6 +131,9 @@ @@ -140,6 +143,9 @@
} }
let draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0); let draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0);
@@ -22,15 +22,15 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if ( if (
(dropEffect == "move" || dropEffect == "copy") && (dropEffect == "move" || dropEffect == "copy") &&
document == draggedTab.ownerDocument && document == draggedTab.ownerDocument &&
@@ -148,6 +154,7 @@ @@ -161,6 +167,7 @@
!draggedTab.group.collapsed
) { ) {
draggedTab.group.collapsedByDrag = true;
draggedTab.group.collapsed = true; draggedTab.group.collapsed = true;
+ gZenFolders.animateGroupMove(draggedTab.group); + gZenFolders.animateGroupMove(draggedTab.group);
} }
if (dropEffect == "move") { if (dropEffect == "move") {
@@ -155,10 +162,6 @@ @@ -168,10 +175,6 @@
// Pinned tabs in expanded vertical mode are on a grid format and require // Pinned tabs in expanded vertical mode are on a grid format and require
// different logic to drag and drop. // different logic to drag and drop.
@@ -41,7 +41,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
this._animateTabMove(event); this._animateTabMove(event);
return; return;
} }
@@ -297,6 +300,10 @@ @@ -310,6 +313,10 @@
this._tabDropIndicator.hidden = true; this._tabDropIndicator.hidden = true;
event.stopPropagation(); event.stopPropagation();
@@ -52,7 +52,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if (draggedTab && dropEffect == "copy") { if (draggedTab && dropEffect == "copy") {
let duplicatedDraggedTab; let duplicatedDraggedTab;
let duplicatedTabs = []; let duplicatedTabs = [];
@@ -324,12 +331,16 @@ @@ -337,12 +344,16 @@
let translateOffsetY = oldTranslateY % tabHeight; let translateOffsetY = oldTranslateY % tabHeight;
let newTranslateX = oldTranslateX - translateOffsetX; let newTranslateX = oldTranslateX - translateOffsetX;
let newTranslateY = oldTranslateY - translateOffsetY; let newTranslateY = oldTranslateY - translateOffsetY;
@@ -73,7 +73,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if (this._tabbrowserTabs.isContainerVerticalPinnedGrid(draggedTab)) { if (this._tabbrowserTabs.isContainerVerticalPinnedGrid(draggedTab)) {
// Update both translate axis for pinned vertical expanded tabs // Update both translate axis for pinned vertical expanded tabs
@@ -404,11 +415,13 @@ @@ -417,11 +428,13 @@
this._dragToPinPromoCard, this._dragToPinPromoCard,
]; ];
let shouldPin = let shouldPin =
@@ -87,7 +87,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
isTab(draggedTab) && isTab(draggedTab) &&
draggedTab.pinned && draggedTab.pinned &&
this._tabbrowserTabs.arrowScrollbox.contains(event.target); this._tabbrowserTabs.arrowScrollbox.contains(event.target);
@@ -484,6 +497,7 @@ @@ -492,6 +505,7 @@
} }
} }
@@ -95,7 +95,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if (shouldTranslate) { if (shouldTranslate) {
this.#dropAnimationEndTime = Date.now() + DROP_ANIMATION_GRACE_MS; this.#dropAnimationEndTime = Date.now() + DROP_ANIMATION_GRACE_MS;
let translationPromises = []; let translationPromises = [];
@@ -496,7 +510,7 @@ @@ -504,7 +518,7 @@
item.removeAttribute("tabdrop-samewindow"); item.removeAttribute("tabdrop-samewindow");
resolve(); resolve();
}; };
@@ -104,7 +104,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
postTransitionCleanup(); postTransitionCleanup();
} else { } else {
let onTransitionEnd = transitionendEvent => { let onTransitionEnd = transitionendEvent => {
@@ -580,7 +594,7 @@ @@ -595,7 +609,7 @@
if (tab.selected) { if (tab.selected) {
selectedTab = tab; selectedTab = tab;
indexForSelectedTab = newIndex; indexForSelectedTab = newIndex;
@@ -113,7 +113,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
const droppedIntoPinnedArea = dropIndex < gBrowser.pinnedTabCount; const droppedIntoPinnedArea = dropIndex < gBrowser.pinnedTabCount;
const newSplitView = gBrowser.adoptSplitView(tab, { const newSplitView = gBrowser.adoptSplitView(tab, {
elementIndex: droppedIntoPinnedArea elementIndex: droppedIntoPinnedArea
@@ -605,7 +619,7 @@ @@ -620,7 +634,7 @@
} }
} }
} }
@@ -122,7 +122,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
const newTab = gBrowser.adoptTab(selectedTab, { const newTab = gBrowser.adoptTab(selectedTab, {
elementIndex: indexForSelectedTab, elementIndex: indexForSelectedTab,
selectTab: selectedTab == draggedTab, selectTab: selectedTab == draggedTab,
@@ -639,10 +653,6 @@ @@ -654,10 +668,6 @@
this._tabbrowserTabs.dragAndDropElements[ this._tabbrowserTabs.dragAndDropElements[
gBrowser.pinnedTabCount + unpinnedSplitViews.length - 1 gBrowser.pinnedTabCount + unpinnedSplitViews.length - 1
]; ];
@@ -133,7 +133,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
} }
} }
} else { } else {
@@ -703,6 +713,7 @@ @@ -717,6 +727,7 @@
let nextItem = this._tabbrowserTabs.dragAndDropElements[newIndex]; let nextItem = this._tabbrowserTabs.dragAndDropElements[newIndex];
let tabGroup = isTab(nextItem) && nextItem.group; let tabGroup = isTab(nextItem) && nextItem.group;
@@ -141,7 +141,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
gBrowser.loadTabs(urls, { gBrowser.loadTabs(urls, {
inBackground, inBackground,
replace, replace,
@@ -744,6 +755,22 @@ @@ -758,6 +769,22 @@
this._expandGroupOnDrop(draggedTab); this._expandGroupOnDrop(draggedTab);
} }
this._resetTabsAfterDrop(draggedTab); this._resetTabsAfterDrop(draggedTab);
@@ -164,7 +164,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
if ( if (
dt.mozUserCancelled || dt.mozUserCancelled ||
@@ -1074,11 +1101,10 @@ @@ -1088,11 +1115,10 @@
return this.#getHorizontalScrollboxDragTarget(event, ignoreSides); return this.#getHorizontalScrollboxDragTarget(event, ignoreSides);
} }
while (target) { while (target) {
@@ -180,7 +180,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
break; break;
} }
target = target.parentNode; target = target.parentNode;
@@ -1108,6 +1134,9 @@ @@ -1122,6 +1148,9 @@
return null; return null;
} }
} }
@@ -190,36 +190,43 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
return target; return target;
} }
@@ -1170,14 +1199,20 @@ @@ -1188,17 +1217,24 @@
let releaseReservedSpace = () => let periphery = draggedTab.ownerDocument.getElementById(
this.#releaseSpaceInScrolledContent(periphery); "tabbrowser-arrowscrollbox-periphery"
if (group.collapsed) { );
- // The group's tabs animate back to their full size, so hold on to the - // The group's tabs animate back to their full size, so hold on to the
- // space reserved for them until they get there. - // space reserved for them until they get there.
- group.addEventListener( - group.addEventListener(
- "TabGroupAnimationComplete", - "TabGroupAnimationComplete",
- releaseReservedSpace, - () => {
- { once: true } - group.collapsedByDrag = false;
- ); - this.#releaseSpaceInScrolledContent(periphery);
- group.collapsed = false; - },
+ const expand = !group.hasAttribute("has-active"); - { once: true }
+ if (expand) { - );
+ // The group's tabs animate back to their full size, so hold on to the - group.collapsed = false;
+ // space reserved for them until they get there. + const expand = !group.hasAttribute("has-active");
+ group.addEventListener( + if (expand) {
+ "TabGroupAnimationComplete", + // The group's tabs animate back to their full size, so hold on to the
+ releaseReservedSpace, + // space reserved for them until they get there.
+ { once: true } + group.addEventListener(
+ ); + "TabGroupAnimationComplete",
+ } else { + () => {
+ releaseReservedSpace(); + group.collapsedByDrag = false;
+ } + this.#releaseSpaceInScrolledContent(periphery);
+ group.collapsed = !expand; + },
+ gZenFolders.animateGroupMove(group, true); + { once: true }
} else { + );
releaseReservedSpace(); + } else {
} + group.collapsedByDrag = false;
@@ -1362,7 +1397,6 @@ + this.#releaseSpaceInScrolledContent(periphery);
+ }
+ group.collapsed = !expand;
+ gZenFolders.animateGroupMove(group, true);
}
/**
@@ -1380,7 +1416,6 @@
// using updateDragImage. On Linux, we can use a panel. // using updateDragImage. On Linux, we can use a panel.
if (platform == "win" || platform == "macosx") { if (platform == "win" || platform == "macosx") {
captureListener = function () { captureListener = function () {
@@ -227,7 +234,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
}; };
} else { } else {
// Create a panel to use it in setDragImage // Create a panel to use it in setDragImage
@@ -1400,7 +1434,6 @@ @@ -1418,7 +1453,6 @@
); );
dragImageOffset = dragImageOffset * scale; dragImageOffset = dragImageOffset * scale;
} }
@@ -235,7 +242,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
// _dragData.offsetX/Y give the coordinates that the mouse should be // _dragData.offsetX/Y give the coordinates that the mouse should be
// positioned relative to the corner of the new window created upon // positioned relative to the corner of the new window created upon
@@ -1419,7 +1452,7 @@ @@ -1437,7 +1471,7 @@
let dropEffect = this.getDropEffectForTabDrag(event); let dropEffect = this.getDropEffectForTabDrag(event);
let isMovingInTabStrip = !fromTabList && dropEffect == "move"; let isMovingInTabStrip = !fromTabList && dropEffect == "move";
let collapseTabGroupDuringDrag = let collapseTabGroupDuringDrag =
@@ -244,7 +251,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
tab._dragData = { tab._dragData = {
offsetX: this._tabbrowserTabs.verticalMode offsetX: this._tabbrowserTabs.verticalMode
@@ -1429,7 +1462,7 @@ @@ -1447,7 +1481,7 @@
? event.screenY - window.screenY - tabOffset ? event.screenY - window.screenY - tabOffset
: event.screenY - window.screenY, : event.screenY - window.screenY,
scrollPos: scrollPos:
@@ -253,7 +260,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
? this._tabbrowserTabs.pinnedTabsContainer.scrollPosition ? this._tabbrowserTabs.pinnedTabsContainer.scrollPosition
: this._tabbrowserTabs.arrowScrollbox.scrollPosition, : this._tabbrowserTabs.arrowScrollbox.scrollPosition,
screenX: event.screenX, screenX: event.screenX,
@@ -1522,6 +1555,7 @@ @@ -1540,6 +1574,7 @@
if (tabStripItemElement.hasAttribute("dragtarget")) { if (tabStripItemElement.hasAttribute("dragtarget")) {
return; return;
} }
@@ -261,7 +268,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
let isPinned = tab.pinned; let isPinned = tab.pinned;
let dragAndDropElements = this._tabbrowserTabs.dragAndDropElements; let dragAndDropElements = this._tabbrowserTabs.dragAndDropElements;
let isGrid = this._tabbrowserTabs.isContainerVerticalPinnedGrid(tab); let isGrid = this._tabbrowserTabs.isContainerVerticalPinnedGrid(tab);
@@ -1895,23 +1929,6 @@ @@ -1913,23 +1948,6 @@
// Slide the relevant tabs to their new position. // Slide the relevant tabs to their new position.
// non-moving tabs adjust for RTL // non-moving tabs adjust for RTL
@@ -285,7 +292,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
// moving tabs don't adjust for RTL // moving tabs don't adjust for RTL
for (let item of selectedElements) { for (let item of selectedElements) {
if ( if (
@@ -1960,7 +1977,6 @@ @@ -1978,7 +1996,6 @@
for (let item of this._tabbrowserTabs.dragAndDropElements) { for (let item of this._tabbrowserTabs.dragAndDropElements) {
delete item._moveTogetherSelectedTabsData; delete item._moveTogetherSelectedTabsData;
item = elementToMove(item); item = elementToMove(item);
@@ -293,7 +300,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
item.removeAttribute("multiselected-move-together"); item.removeAttribute("multiselected-move-together");
} }
} }
@@ -2812,7 +2828,6 @@ @@ -2830,7 +2847,6 @@
tab.style.top = ""; tab.style.top = "";
tab.style.maxWidth = ""; tab.style.maxWidth = "";
tab.style.pointerEvents = ""; tab.style.pointerEvents = "";
@@ -301,7 +308,7 @@ index 70b37f93c4e8ff4ad9a2452681e468d23914c1b5..dbf2d9c83dafbe0e0b4e6caf3835edc8
tab.removeAttribute("small-stack"); tab.removeAttribute("small-stack");
tab.removeAttribute("big-stack"); tab.removeAttribute("big-stack");
} }
@@ -2821,11 +2836,9 @@ @@ -2839,11 +2855,9 @@
)) { )) {
label.style.width = ""; label.style.width = "";
label.style.maxWidth = ""; label.style.maxWidth = "";

File diff suppressed because it is too large Load Diff

View File

@@ -1,15 +1,15 @@
diff --git a/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs b/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs diff --git a/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs b/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs
index cfc232f038cd491db32e0c0ca35622360dd9dec5..4806a725ddefa9d0709020d537eae5464249a294 100644 index e32b02941a6019703212cede4660a24b88845120..5cb363ed20d49c1ae8abedecc3b08540406b7a1b 100644
--- a/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs --- a/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs
+++ b/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs +++ b/browser/components/urlbar/UrlbarProviderHeuristicFallback.sys.mjs
@@ -77,22 +77,26 @@ export class UrlbarProviderHeuristicFallback extends UrlbarProvider { @@ -76,22 +76,26 @@ export class UrlbarProviderHeuristicFallback extends UrlbarProvider {
// Since we can't tell if this is a real URL and whether the user wants // Since we can't tell if this is a real URL and whether the user wants
// to visit or search for it, we provide an alternative searchengine // to visit or search for it, we provide an alternative searchengine
// match if the string looks like an alphanumeric origin or an e-mail. // match if the string looks like an alphanumeric origin or an e-mail.
- let str = queryContext.searchString; - let str = queryContext.searchString;
- if (!URL.canParse(str)) { - if (!URL.canParse(str)) {
- if ( - if (
- lazy.UrlbarPrefs.get("keyword.enabled") && - queryContext.keywordEnabled &&
- (lazy.UrlUtils.looksLikeOrigin(str, { - (lazy.UrlUtils.looksLikeOrigin(str, {
- noIp: true, - noIp: true,
- noPort: true, - noPort: true,
@@ -24,7 +24,7 @@ index cfc232f038cd491db32e0c0ca35622360dd9dec5..4806a725ddefa9d0709020d537eae546
+ } + }
+ ); + );
+ if ( + if (
+ lazy.UrlbarPrefs.get("keyword.enabled") && + queryContext.keywordEnabled &&
+ (lazy.UrlUtils.looksLikeUrl(searchCandidate) || + (lazy.UrlUtils.looksLikeUrl(searchCandidate) ||
+ lazy.UrlUtils.looksLikeOrigin(searchCandidate, { + lazy.UrlUtils.looksLikeOrigin(searchCandidate, {
+ allowPartialNumericalTLDs: true, + allowPartialNumericalTLDs: true,

View File

@@ -1,16 +0,0 @@
diff --git a/browser/components/urlbar/UrlbarUtils.sys.mjs b/browser/components/urlbar/UrlbarUtils.sys.mjs
index 178cd5e84fda74a28b2de59b671b3399cc28fac4..b03c6e06de4ee9a95dcb4d33d7ac9f0b053be4e1 100644
--- a/browser/components/urlbar/UrlbarUtils.sys.mjs
+++ b/browser/components/urlbar/UrlbarUtils.sys.mjs
@@ -214,6 +214,11 @@ export var UrlbarUtils = {
return UrlbarShared.RESULT_GROUP.HEURISTIC_FALLBACK;
case "UrlbarProviderHistoryUrlHeuristic":
return UrlbarShared.RESULT_GROUP.HEURISTIC_HISTORY_URL;
+ case "ZenUrlbarProviderGlobalActions":
+ if (result.source == UrlbarShared.RESULT_SOURCE.WORKSPACES) {
+ return UrlbarShared.RESULT_GROUP.ZEN_WORKSPACE;
+ }
+ return UrlbarShared.RESULT_GROUP.ZEN_ACTION;
case "UrlbarProviderOmnibox":
return UrlbarShared.RESULT_GROUP.HEURISTIC_OMNIBOX;
case "UrlbarProviderRestrictKeywordsAutofill":

View File

@@ -1,16 +1,16 @@
diff --git a/browser/components/urlbar/content/UrlbarChildController.mjs b/browser/components/urlbar/content/UrlbarChildController.mjs diff --git a/browser/components/urlbar/content/UrlbarChildController.mjs b/browser/components/urlbar/content/UrlbarChildController.mjs
index a17a4de079b69d2818388b33a2c1746cc6148c73..4fee63a22919972af08716db2d2de1c7549ff100 100644 index 52ed36deac35d3de9f7f537313159fb4debe98a6..3bbc612a2e10eedafdabdaa8e17cf36831a6a27c 100644
--- a/browser/components/urlbar/content/UrlbarChildController.mjs --- a/browser/components/urlbar/content/UrlbarChildController.mjs
+++ b/browser/components/urlbar/content/UrlbarChildController.mjs +++ b/browser/components/urlbar/content/UrlbarChildController.mjs
@@ -438,7 +438,6 @@ export class UrlbarChildController { @@ -446,7 +446,6 @@ export class UrlbarChildController {
const isMac = AppConstants.platform == "macosx"; const isMac = UrlbarContentUtils.getPlatform() == "macosx";
// Handle readline/emacs-style navigation bindings on Mac. // Handle readline/emacs-style navigation bindings on Mac.
if ( if (
- isMac && - isMac &&
this.view.isOpen && this.view.isOpen &&
event.ctrlKey && event.ctrlKey &&
(event.key == "n" || event.key == "p") (event.key == "n" || event.key == "p")
@@ -630,6 +629,8 @@ export class UrlbarChildController { @@ -644,6 +643,8 @@ export class UrlbarChildController {
}); });
} }
event.preventDefault(); event.preventDefault();
@@ -19,7 +19,7 @@ index a17a4de079b69d2818388b33a2c1746cc6148c73..4fee63a22919972af08716db2d2de1c7
} }
break; break;
} }
@@ -934,6 +935,10 @@ export class UrlbarChildController { @@ -905,6 +906,10 @@ export class UrlbarChildController {
} }
reuseEmpty = true; reuseEmpty = true;
} }
@@ -30,7 +30,7 @@ index a17a4de079b69d2818388b33a2c1746cc6148c73..4fee63a22919972af08716db2d2de1c7
// The browser window exists only in chrome; a content-process input has no // The browser window exists only in chrome; a content-process input has no
// tab to reuse, so `gBrowser` is absent and the reuse is skipped. // tab to reuse, so `gBrowser` is absent and the reuse is skipped.
if ( if (
@@ -943,6 +948,10 @@ export class UrlbarChildController { @@ -914,6 +919,10 @@ export class UrlbarChildController {
) { ) {
where = "current"; where = "current";
} }

View File

@@ -1,22 +1,21 @@
diff --git a/browser/components/urlbar/content/UrlbarInput.mjs b/browser/components/urlbar/content/UrlbarInput.mjs diff --git a/browser/components/urlbar/content/UrlbarInputBase.mjs b/browser/components/urlbar/content/UrlbarInputBase.mjs
index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36d7d74e8e 100644 index 8be35b58c5369e123ca69426e852e3849bf75513..170cffbdd12a72dab15976cdab9207dc4292d4e6 100644
--- a/browser/components/urlbar/content/UrlbarInput.mjs --- a/browser/components/urlbar/content/UrlbarInputBase.mjs
+++ b/browser/components/urlbar/content/UrlbarInput.mjs +++ b/browser/components/urlbar/content/UrlbarInputBase.mjs
@@ -88,6 +88,13 @@ const lazy = XPCOMUtils.declareLazy({ @@ -83,6 +83,12 @@ if (lazy) {
logger: () => UrlbarShared.getLogger({ prefix: "Input" }), Ci.nsIURLQueryStringStripper,
}); ],
});
+ XPCOMUtils.defineLazyPreferenceGetter(
+ lazy,
+ "ZEN_URLBAR_BEHAVIOR",
+ "zen.urlbar.behavior",
+ 'default'
+ );
}
+XPCOMUtils.defineLazyPreferenceGetter( const logger = () => UrlbarShared.getLogger({ prefix: "Input" });
+ lazy, @@ -917,7 +923,16 @@ ${
+ "ZEN_URLBAR_BEHAVIOR",
+ "zen.urlbar.behavior",
+ 'default'
+);
+
const UNLIMITED_MAX_RESULTS = 99;
let getBoundsWithoutFlushing = element =>
@@ -771,7 +778,16 @@ ${
// See _on_select(). HTMLInputElement.select() dispatches a "select" // See _on_select(). HTMLInputElement.select() dispatches a "select"
// event but does not set the primary selection. // event but does not set the primary selection.
this._suppressPrimaryAdjustment = true; this._suppressPrimaryAdjustment = true;
@@ -33,7 +32,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
this._suppressPrimaryAdjustment = false; this._suppressPrimaryAdjustment = false;
} }
@@ -846,6 +862,10 @@ ${ @@ -992,6 +1007,10 @@ ${
hideSearchTerms = false, hideSearchTerms = false,
isSameDocument = false, isSameDocument = false,
} = {}) { } = {}) {
@@ -44,7 +43,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
if (!this.#isAddressbar) { if (!this.#isAddressbar) {
throw new Error( throw new Error(
"Cannot set URI for UrlbarInput that is not an address bar" "Cannot set URI for UrlbarInput that is not an address bar"
@@ -1143,7 +1163,16 @@ ${ @@ -1289,7 +1308,16 @@ ${
this.searchModeSwitcher?.updateSearchIcon(); this.searchModeSwitcher?.updateSearchIcon();
} }
@@ -61,7 +60,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
} }
/** /**
@@ -1255,6 +1284,9 @@ ${ @@ -1401,6 +1429,9 @@ ${
where, where,
query: searchString, query: searchString,
}); });
@@ -71,7 +70,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
this.controller.openSERP( this.controller.openSERP(
engine.id, engine.id,
searchString, searchString,
@@ -1726,7 +1758,11 @@ ${ @@ -1884,7 +1915,11 @@ ${
openParams.avoidBrowserFocus = keepViewOpen; openParams.avoidBrowserFocus = keepViewOpen;
if (!this.#providesSearchMode(result) && !keepViewOpen) { if (!this.#providesSearchMode(result) && !keepViewOpen) {
@@ -84,12 +83,12 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
} }
if (isCanonized) { if (isCanonized) {
@@ -3016,6 +3052,42 @@ ${ @@ -3181,6 +3216,42 @@ ${
await this.#updateLayoutBreakoutDimensions(); await this.#updateLayoutBreakoutDimensions();
} }
+ zenFormatURLValue() { + zenFormatURLValue() {
+ return this.#lazy.valueFormatter._formatURL(); + return this.#getValueFormatter().update();
+ } + }
+ +
+ get zenUrlbarBehavior() { + get zenUrlbarBehavior() {
@@ -127,7 +126,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
startLayoutExtend() { startLayoutExtend() {
if (!this.#allowBreakout || this.hasAttribute("breakout-extend")) { if (!this.#allowBreakout || this.hasAttribute("breakout-extend")) {
// Do not expand if the Urlbar does not support being expanded or it is // Do not expand if the Urlbar does not support being expanded or it is
@@ -3030,6 +3102,13 @@ ${ @@ -3195,6 +3266,13 @@ ${
this.toggleAttribute("breakout-extend", true); this.toggleAttribute("breakout-extend", true);
this.#updateTextboxPosition(); this.#updateTextboxPosition();
@@ -141,7 +140,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
// Enable the animation only after the first extend call to ensure it // Enable the animation only after the first extend call to ensure it
// doesn't run when opening a new window. // doesn't run when opening a new window.
if (!this.hasAttribute("breakout-extend-animate")) { if (!this.hasAttribute("breakout-extend-animate")) {
@@ -3053,6 +3132,29 @@ ${ @@ -3218,6 +3296,29 @@ ${
return; return;
} }
@@ -171,7 +170,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
this.toggleAttribute("breakout-extend", false); this.toggleAttribute("breakout-extend", false);
this.#updateTextboxPosition(); this.#updateTextboxPosition();
} }
@@ -3091,7 +3193,7 @@ ${ @@ -3256,7 +3357,7 @@ ${
forceUnifiedSearchButtonAvailable = false forceUnifiedSearchButtonAvailable = false
) { ) {
let prevState = this.getAttribute("pageproxystate"); let prevState = this.getAttribute("pageproxystate");
@@ -180,20 +179,20 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
this.setAttribute("pageproxystate", state); this.setAttribute("pageproxystate", state);
this._inputContainer.setAttribute("pageproxystate", state); this._inputContainer.setAttribute("pageproxystate", state);
this._identityBox?.setAttribute("pageproxystate", state); this._identityBox?.setAttribute("pageproxystate", state);
@@ -3355,10 +3457,12 @@ ${ @@ -3533,7 +3634,11 @@ ${
return;
} }
this.style.top = px( - this.style.top = px(getUntransformedTop(this.parentNode));
+ this.style.top = px(
+ this.window.gZenVerticalTabsManager._hasSetSingleToolbar ? + this.window.gZenVerticalTabsManager._hasSetSingleToolbar ?
this.parentNode.getBoxQuads({ + getUntransformedTop(this.parentNode)
ignoreTransforms: true, + : (UrlbarContentUtils.getPlatform() == "macosx" ? -2 : -5)
flush: false, + );
})[0].p1.y
+ : (AppConstants.platform == "macosx" ? -2 : -5)
);
} }
@@ -3417,9 +3521,10 @@ ${ #updateTextboxPositionNextFrame() {
@@ -3591,9 +3696,10 @@ ${
return; return;
} }
@@ -205,7 +204,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
); );
if (this.#breakoutBlockerCount) { if (this.#breakoutBlockerCount) {
@@ -3929,6 +4034,7 @@ ${ @@ -4108,6 +4214,7 @@ ${
} }
_toggleActionOverride(event) { _toggleActionOverride(event) {
@@ -213,7 +212,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
if ( if (
event.keyCode == KeyEvent.DOM_VK_SHIFT || event.keyCode == KeyEvent.DOM_VK_SHIFT ||
event.keyCode == KeyEvent.DOM_VK_ALT || event.keyCode == KeyEvent.DOM_VK_ALT ||
@@ -4027,9 +4133,10 @@ ${ @@ -4206,9 +4313,10 @@ ${
if (!this.#isAddressbar) { if (!this.#isAddressbar) {
return val; return val;
} }
@@ -226,36 +225,36 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
+ : val; + : val;
// Only trim value if the directionality doesn't change to RTL and we're not // Only trim value if the directionality doesn't change to RTL and we're not
// showing a strikeout https protocol. // showing a strikeout https protocol.
return this.controller.isTextDirectionRTL(trimmedValue) || return UrlbarContentUtils.isTextDirectionRTL(trimmedValue, window) ||
@@ -4235,6 +4342,11 @@ ${ @@ -4410,6 +4518,11 @@ ${
keepViewOpen = false, keepViewOpen = false,
browserId = null, browserId = null,
}) { }) {
+ where = this.window.gZenUIManager.getOpenUILinkWhere( + where = this.window.gZenUIManager.getOpenUILinkWhere(
+ url, + loadRequest.urlLoad?.url ?? "",
+ this.window.gBrowser.selectedBrowser, + this.window.gBrowser.selectedBrowser,
+ where + where
+ ); + );
let userTypedValue; let keyDownEnterDeferred;
if (this.#isAddressbar && where == "current") { if (
// Make sure URL is formatted properly (don't show punycode). this._keyDownEnterDeferred &&
@@ -4576,6 +4688,7 @@ ${ @@ -4731,6 +4844,7 @@ ${
this.setResultForCurrentValue(null); this.setResultForCurrentValue(null);
this.handleCommand(); this.handleCommand();
this.controller.clearLastQueryContextCache(); this.controller.clearLastQueryContextCache();
+ this.view.close(); + this.view.close();
this._suppressStartQuery = false; this._suppressStartQuery = false;
}); });
@@ -4583,7 +4696,6 @@ ${ @@ -4742,7 +4856,6 @@ ${
contextMenu.addEventListener("popupshowing", () => { // Close the results pane, because paste and go doesn't want a result
// Close the results pane when the input field contextual menu is open, // selection. This has to happen before the menu opens: ending
// because paste and go doesn't want a result selection. // breakout-extend once it's open keeps it from showing (bug 2037468).
- this.view.close(); - this.view.close();
let controller = let controller =
this.document.commandDispatcher.getControllerForCommand("cmd_paste"); this.document.commandDispatcher.getControllerForCommand("cmd_paste");
@@ -4850,7 +4962,11 @@ ${ @@ -5025,7 +5138,11 @@ ${
if (!engineName && !source && !this.hasAttribute("searchmode")) { if (!engineName && !source && !this.hasAttribute("searchmode")) {
return; return;
} }
@@ -268,7 +267,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
if (this._searchModeIndicatorTitle) { if (this._searchModeIndicatorTitle) {
this._searchModeIndicatorTitle.textContent = ""; this._searchModeIndicatorTitle.textContent = "";
this._searchModeIndicatorTitle.removeAttribute("data-l10n-id"); this._searchModeIndicatorTitle.removeAttribute("data-l10n-id");
@@ -5149,6 +5265,7 @@ ${ @@ -5335,6 +5452,7 @@ ${
this.document.l10n.setAttributes( this.document.l10n.setAttributes(
this.inputField, this.inputField,
@@ -276,10 +275,10 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
l10nId, l10nId,
l10nId == "urlbar-placeholder-with-name" l10nId == "urlbar-placeholder-with-name"
? { name: engineName } ? { name: engineName }
@@ -5199,6 +5316,12 @@ ${ @@ -5385,6 +5503,12 @@ ${
} }
lazy.logger.debug("Blur Event"); logger().debug("Blur Event");
+ if ( + if (
+ this.document.commandDispatcher.focusedElement == this.inputField && + this.document.commandDispatcher.focusedElement == this.inputField &&
+ !UrlbarPrefs.get("closeOnWindowBlur") + !UrlbarPrefs.get("closeOnWindowBlur")
@@ -289,7 +288,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
// We cannot count every blur events after a missed engagement as abandoment // We cannot count every blur events after a missed engagement as abandoment
// because the user may have clicked on some view element that executes // because the user may have clicked on some view element that executes
// a command causing a focus change. For example opening preferences from // a command causing a focus change. For example opening preferences from
@@ -5276,6 +5399,11 @@ ${ @@ -5464,6 +5588,11 @@ ${
} }
_on_click(event) { _on_click(event) {
@@ -301,7 +300,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
switch (event.target) { switch (event.target) {
case this.inputField: case this.inputField:
case this._inputContainer: case this._inputContainer:
@@ -5371,10 +5499,11 @@ ${ @@ -5558,10 +5687,11 @@ ${
} }
if (untrim) { if (untrim) {
this.setValue(this._untrimmedValue); this.setValue(this._untrimmedValue);
@@ -314,7 +313,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
this.view.autoOpen({ event }); this.view.autoOpen({ event });
} else { } else {
if (this._untrimOnFocusAfterKeydown) { if (this._untrimOnFocusAfterKeydown) {
@@ -5414,9 +5543,16 @@ ${ @@ -5605,9 +5735,16 @@ ${
} }
_on_mousedown(event) { _on_mousedown(event) {
@@ -332,7 +331,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
if ( if (
event.composedTarget != this.inputField && event.composedTarget != this.inputField &&
event.composedTarget != this._inputContainer event.composedTarget != this._inputContainer
@@ -5426,6 +5562,10 @@ ${ @@ -5617,6 +5754,10 @@ ${
this.focusedViaMousedown = !this.focused; this.focusedViaMousedown = !this.focused;
this.#preventClickSelectsAll = this.focused; this.#preventClickSelectsAll = this.focused;
@@ -343,7 +342,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
// Keep the focus status, since the attribute may be changed // Keep the focus status, since the attribute may be changed
// upon calling this.focus(). // upon calling this.focus().
@@ -5463,7 +5603,7 @@ ${ @@ -5654,7 +5795,7 @@ ${
// view open on tab switch, and the TabSelect event arrived earlier. // view open on tab switch, and the TabSelect event arrived earlier.
// Also ignore mousedown on the urlbarView context menu: opening/closing the // Also ignore mousedown on the urlbarView context menu: opening/closing the
// view is already handled by the result opening flow. // view is already handled by the result opening flow.
@@ -352,7 +351,7 @@ index 319fb6870ec18d87b9f1263bd960edaa39b0447c..1746a052c304e7988447fdb869ad2e36
break; break;
} }
@@ -5754,7 +5894,7 @@ ${ @@ -5948,7 +6089,7 @@ ${
// When we are in actions search mode we can show more results so // When we are in actions search mode we can show more results so
// increase the limit. // increase the limit.
let maxResults = let maxResults =

View File

@@ -1,8 +1,8 @@
diff --git a/browser/components/urlbar/content/UrlbarShared.mjs b/browser/components/urlbar/content/UrlbarShared.mjs diff --git a/browser/components/urlbar/content/UrlbarShared.mjs b/browser/components/urlbar/content/UrlbarShared.mjs
index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36119ae73e 100644 index 0ac5330223c84fbb98880a5c2d83ae58a8f3079e..f9d3d27333f5552404bd8a1138fb1e5d6150a3d8 100644
--- a/browser/components/urlbar/content/UrlbarShared.mjs --- a/browser/components/urlbar/content/UrlbarShared.mjs
+++ b/browser/components/urlbar/content/UrlbarShared.mjs +++ b/browser/components/urlbar/content/UrlbarShared.mjs
@@ -100,6 +100,7 @@ export const UrlbarShared = { @@ -158,6 +158,7 @@ export const UrlbarShared = {
// `looksLikeOrigin()` returned `LOOKS_LIKE_ORIGIN.OTHER` for this token. // `looksLikeOrigin()` returned `LOOKS_LIKE_ORIGIN.OTHER` for this token.
// It may or may not be an origin. // It may or may not be an origin.
POSSIBLE_ORIGIN_BUT_SEARCH_ALLOWED: 12, POSSIBLE_ORIGIN_BUT_SEARCH_ALLOWED: 12,
@@ -10,7 +10,7 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
}), }),
/** /**
@@ -120,6 +121,7 @@ export const UrlbarShared = { @@ -178,6 +179,7 @@ export const UrlbarShared = {
TITLE: "#", TITLE: "#",
URL: "$", URL: "$",
ACTION: ">", ACTION: ">",
@@ -18,7 +18,7 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
}), }),
// Defines UrlbarResult types. // Defines UrlbarResult types.
@@ -165,6 +167,8 @@ export const UrlbarShared = { @@ -223,6 +225,8 @@ export const UrlbarShared = {
OTHER_NETWORK: 6, OTHER_NETWORK: 6,
ADDON: 7, ADDON: 7,
ACTIONS: 8, ACTIONS: 8,
@@ -27,7 +27,7 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
}), }),
// Results are categorized into groups to help the muxer compose them. See // Results are categorized into groups to help the muxer compose them. See
@@ -200,6 +204,8 @@ export const UrlbarShared = { @@ -258,6 +262,8 @@ export const UrlbarShared = {
SEMANTIC_HISTORY: "semanticHistory", SEMANTIC_HISTORY: "semanticHistory",
SUGGESTED_INDEX: "suggestedIndex", SUGGESTED_INDEX: "suggestedIndex",
TAIL_SUGGESTION: "tailSuggestion", TAIL_SUGGESTION: "tailSuggestion",
@@ -36,7 +36,7 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
}), }),
// Defines provider types. // Defines provider types.
@@ -385,6 +391,14 @@ export const UrlbarShared = { @@ -443,6 +449,14 @@ export const UrlbarShared = {
telemetryLabel: "actions", telemetryLabel: "actions",
uiLabel: "urlbar-searchmode-actions3", uiLabel: "urlbar-searchmode-actions3",
}, },
@@ -51,7 +51,7 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
]); ]);
}, },
@@ -402,6 +416,7 @@ export const UrlbarShared = { @@ -460,6 +474,7 @@ export const UrlbarShared = {
if (UrlbarPrefs.get("scotchBonnet.enableOverride")) { if (UrlbarPrefs.get("scotchBonnet.enableOverride")) {
keys.push(this.RESTRICT_TOKENS.ACTION); keys.push(this.RESTRICT_TOKENS.ACTION);
} }
@@ -59,3 +59,15 @@ index 4e67dad66ae006842abc6eed547e4a244320d57a..393b61b4d2543c73e60afd334a353f36
return new Set(keys); return new Set(keys);
}, },
@@ -1032,6 +1047,11 @@ export const UrlbarShared = {
return UrlbarShared.RESULT_GROUP.HEURISTIC_FALLBACK;
case "UrlbarProviderHistoryUrlHeuristic":
return UrlbarShared.RESULT_GROUP.HEURISTIC_HISTORY_URL;
+ case "ZenUrlbarProviderGlobalActions":
+ if (result.source == UrlbarShared.RESULT_SOURCE.WORKSPACES) {
+ return UrlbarShared.RESULT_GROUP.ZEN_WORKSPACE;
+ }
+ return UrlbarShared.RESULT_GROUP.ZEN_ACTION;
case "UrlbarProviderOmnibox":
return UrlbarShared.RESULT_GROUP.HEURISTIC_OMNIBOX;
case "UrlbarProviderRestrictKeywordsAutofill":

View File

@@ -1,10 +1,10 @@
diff --git a/browser/modules/ExtensionsUI.sys.mjs b/browser/modules/ExtensionsUI.sys.mjs diff --git a/browser/modules/ExtensionsUI.sys.mjs b/browser/modules/ExtensionsUI.sys.mjs
index 95a4b6e40bd568c3ea5003b648b0acbf96bbb725..6ab8a658721aa6470d482dc958e4b3ac78f49f44 100644 index 73ef024602cb4554a024de4ddef83f492adc33ef..959c3403a48a3e4294ad5d2f72bad0e5d4fbfd75 100644
--- a/browser/modules/ExtensionsUI.sys.mjs --- a/browser/modules/ExtensionsUI.sys.mjs
+++ b/browser/modules/ExtensionsUI.sys.mjs +++ b/browser/modules/ExtensionsUI.sys.mjs
@@ -502,7 +502,7 @@ export var ExtensionsUI = { @@ -507,7 +507,7 @@ export var ExtensionsUI = {
eventCallback, // right after the panel opens can't accidentally grant permissions).
removeOnDismissal: true, autofocus: true,
popupOptions: { popupOptions: {
- position: "bottomright topright", - position: "bottomright topright",
+ position: window.gZenUIManager.panelUIPosition(), + position: window.gZenUIManager.panelUIPosition(),

View File

@@ -1,8 +1,8 @@
diff --git a/browser/themes/shared/tabbrowser/content-area.css b/browser/themes/shared/tabbrowser/content-area.css diff --git a/browser/themes/shared/tabbrowser/content-area.css b/browser/themes/shared/tabbrowser/content-area.css
index 2374ed38bd9361d6c7e1886117099c6761e403b8..72f1f52a13096f19ca4009037ad0cdc880775ff7 100644 index 86400b643c8b2af4207d226fbd6d91e5e74548b9..3044e4ab87b7ebcfaa2ac624680da1cc5653c861 100644
--- a/browser/themes/shared/tabbrowser/content-area.css --- a/browser/themes/shared/tabbrowser/content-area.css
+++ b/browser/themes/shared/tabbrowser/content-area.css +++ b/browser/themes/shared/tabbrowser/content-area.css
@@ -239,7 +239,6 @@ @@ -166,7 +166,6 @@
min-width: 0; min-width: 0;
/* We want to be able to show the frame color behind the clipped radiused corner */ /* We want to be able to show the frame color behind the clipped radiused corner */
@@ -10,7 +10,7 @@ index 2374ed38bd9361d6c7e1886117099c6761e403b8..72f1f52a13096f19ca4009037ad0cdc8
display: grid; display: grid;
/** /**
@@ -425,7 +424,6 @@ @@ -355,7 +354,6 @@
} }
browser:is([blank], [pendingpaint]) { browser:is([blank], [pendingpaint]) {
@@ -18,21 +18,21 @@ index 2374ed38bd9361d6c7e1886117099c6761e403b8..72f1f52a13096f19ca4009037ad0cdc8
} }
/* Exclude browsers with smartwindow-content attribute which inherit /* Exclude browsers with smartwindow-content attribute which inherit
@@ -865,7 +863,7 @@ split-view-footer { @@ -735,7 +733,7 @@ split-view-footer {
.dialogStack { .dialogStack {
z-index: var(--browser-stack-z-index-dialog-stack); z-index: var(--browser-stack-z-index-dialog-stack);
- position: absolute; - position: absolute;
+ position: fixed; + position: fixed;
inset: 0;
/* --browser-with-dialog set on browser[tabDialogShowing], we want to position the overlay /* --browser-with-dialog set on browser[tabDialogShowing], we want to position the overlay
only on the top of the <browser> element so it doesn't overlap the DevTools toolbox */ only on the top of the <browser> element so it doesn't overlap the DevTools toolbox */
@@ -1034,7 +1032,7 @@ split-view-footer { @@ -909,7 +907,7 @@ split-view-footer {
.dialogOverlay[topmost="true"], .dialogOverlay[topmost="true"],
#window-modal-dialog::backdrop { #window-modal-dialog::backdrop {
- background-color: var(--background-color-overlay); - background-color: var(--background-color-overlay);
+ background-color: light-dark(rgba(255, 255, 255, .3), rgba(0, 0, 0, .3)); + background-color: light-dark(rgba(255, 255, 255, .3), rgba(0, 0, 0, .3));
border-radius: var(--chrome-block-radius); }
.browserSidebarContainer.responsive-mode & { .dialogOverlay[hideContent="true"][topmost="true"] {

View File

@@ -1,5 +1,5 @@
diff --git a/browser/themes/shared/toolbarbuttons.css b/browser/themes/shared/toolbarbuttons.css diff --git a/browser/themes/shared/toolbarbuttons.css b/browser/themes/shared/toolbarbuttons.css
index 94b1a2a841d8fd47a491616d52e5bf544f0c0bf9..9e98266b98c6b66fed26fec12fa3391fc5fcc79b 100644 index bbf906c7bf1d6f0d71744953aeeb750c5181639a..dd116e22c38dc376c9c6b34dfa569bf4661a8971 100644
--- a/browser/themes/shared/toolbarbuttons.css --- a/browser/themes/shared/toolbarbuttons.css
+++ b/browser/themes/shared/toolbarbuttons.css +++ b/browser/themes/shared/toolbarbuttons.css
@@ -13,20 +13,6 @@ @@ -13,20 +13,6 @@
@@ -23,7 +23,7 @@ index 94b1a2a841d8fd47a491616d52e5bf544f0c0bf9..9e98266b98c6b66fed26fec12fa3391f
&:where([uidensity="compact"]) { &:where([uidensity="compact"]) {
--toolbarbutton-padding-inner: var(--toolbarbutton-padding-inner-compact); --toolbarbutton-padding-inner: var(--toolbarbutton-padding-inner-compact);
--bookmark-block-padding: 1px; --bookmark-block-padding: 1px;
@@ -123,9 +109,7 @@ @@ -119,9 +105,7 @@
#TabsToolbar { #TabsToolbar {
/* Override the inner padding to ensure the dimensions match the tabs, but also making sure /* Override the inner padding to ensure the dimensions match the tabs, but also making sure
different types of buttons (combined-buttons-dropmarker or text) still look correct. */ different types of buttons (combined-buttons-dropmarker or text) still look correct. */
@@ -33,18 +33,16 @@ index 94b1a2a841d8fd47a491616d52e5bf544f0c0bf9..9e98266b98c6b66fed26fec12fa3391f
} }
/* Primary toolbar buttons */ /* Primary toolbar buttons */
@@ -205,8 +189,8 @@ toolbar .toolbarbutton-1 { @@ -174,7 +158,7 @@
> .toolbarbutton-icon { toolbar .toolbarbutton-1 {
/* horizontal padding + actual icon width */ /* horizontal padding + actual icon width */
- width: calc(2 * var(--toolbarbutton-padding-inner) + 16px); - --toolbarbutton-icon-size: calc(2 * var(--toolbarbutton-padding-inner) + 16px);
- height: calc(2 * var(--toolbarbutton-padding-inner) + 16px); + --toolbarbutton-icon-size: calc(2 * var(--toolbarbutton-padding-inner) + var(--zen-toolbar-button-size, 16px));
+ width: calc(2 * var(--toolbarbutton-padding-inner) + var(--zen-toolbar-button-size, 16px));
+ height: calc(2 * var(--toolbarbutton-padding-inner) + var(--zen-toolbar-button-size, 16px));
}
> .toolbarbutton-text { appearance: none;
@@ -216,7 +200,7 @@ toolbar .toolbarbutton-1 { margin: 0;
@@ -214,7 +198,7 @@ toolbar .toolbarbutton-1 {
* height as the button icons and the same vertical padding, but as a minimum, * height as the button icons and the same vertical padding, but as a minimum,
* because otherwise an increase in text sizes would break things. * because otherwise an increase in text sizes would break things.
*/ */
@@ -62,7 +60,7 @@ index 94b1a2a841d8fd47a491616d52e5bf544f0c0bf9..9e98266b98c6b66fed26fec12fa3391f
display: none; display: none;
} }
@@ -536,7 +520,7 @@ toolbarbutton.bookmark-item:not(.subviewbutton) { @@ -427,7 +411,7 @@ toolbarbutton.bookmark-item:not(.subviewbutton) {
*/ */
align-items: stretch; align-items: stretch;
> .toolbarbutton-icon { > .toolbarbutton-icon {

View File

@@ -1,8 +1,8 @@
diff --git a/browser/themes/shared/urlbar-searchbar.css b/browser/themes/shared/urlbar-searchbar.css diff --git a/browser/themes/shared/urlbar.css b/browser/themes/shared/urlbar.css
index 149f123e26cd79e89432dfeb504ca7218ee04810..7e0e6d981d6c2aa53bc2a76d82d2078419659065 100644 index 06183c82e2869290a5fb476c47fb7db92bbef57f..c64cde1eef50d3457fb1c540d95fe3b8aa087294 100644
--- a/browser/themes/shared/urlbar-searchbar.css --- a/browser/themes/shared/urlbar.css
+++ b/browser/themes/shared/urlbar-searchbar.css +++ b/browser/themes/shared/urlbar.css
@@ -19,8 +19,8 @@ @@ -24,8 +24,8 @@
@media not -moz-pref("browser.nova.enabled") { @media not -moz-pref("browser.nova.enabled") {
--urlbar-basic-component-size: calc(var(--urlbar-height) - 2 * (var(--urlbar-input-container-border-width) + var(--urlbar-input-container-padding))); --urlbar-basic-component-size: calc(var(--urlbar-height) - 2 * (var(--urlbar-input-container-border-width) + var(--urlbar-input-container-padding)));
@@ -13,7 +13,7 @@ index 149f123e26cd79e89432dfeb504ca7218ee04810..7e0e6d981d6c2aa53bc2a76d82d20784
} }
@media (max-width: 770px) { @media (max-width: 770px) {
--urlbar-container-min-width: 240px; --urlbar-container-min-width: 240px;
@@ -127,7 +127,7 @@ toolbar[inactive="true"] .urlbar, @@ -143,7 +143,7 @@ toolbar[inactive="true"] .urlbar,
.urlbar:not([usertyping]) > .urlbar-input-container > .urlbar-go-button, .urlbar:not([usertyping]) > .urlbar-input-container > .urlbar-go-button,
.urlbar:not(#searchbar-new, [focused]) > .urlbar-input-container > .urlbar-go-button, .urlbar:not(#searchbar-new, [focused]) > .urlbar-input-container > .urlbar-go-button,
#urlbar-revert-button-container { #urlbar-revert-button-container {
@@ -22,7 +22,7 @@ index 149f123e26cd79e89432dfeb504ca7218ee04810..7e0e6d981d6c2aa53bc2a76d82d20784
} }
/* Document Picture-in-Picture API window */ /* Document Picture-in-Picture API window */
@@ -405,6 +405,10 @@ toolbar[inactive="true"] .urlbar, @@ -434,6 +434,10 @@ toolbar[inactive="true"] .urlbar,
.urlbar:not([focused])[textoverflow="left"][domaindir="rtl"] > .urlbar-input-container > .urlbar-input-box > & { .urlbar:not([focused])[textoverflow="left"][domaindir="rtl"] > .urlbar-input-container > .urlbar-input-box > & {
mask-image: linear-gradient(to right, transparent var(--urlbar-scheme-size), black calc(var(--urlbar-scheme-size) + 3ch)); mask-image: linear-gradient(to right, transparent var(--urlbar-scheme-size), black calc(var(--urlbar-scheme-size) + 3ch));
} }
@@ -33,7 +33,7 @@ index 149f123e26cd79e89432dfeb504ca7218ee04810..7e0e6d981d6c2aa53bc2a76d82d20784
} }
#urlbar-scheme { #urlbar-scheme {
@@ -476,10 +480,15 @@ toolbar[inactive="true"] .urlbar, @@ -505,10 +509,15 @@ toolbar[inactive="true"] .urlbar,
} }
.urlbar[breakout][breakout-extend] { .urlbar[breakout][breakout-extend] {

View File

@@ -1,5 +1,5 @@
diff --git a/build/moz.configure/lto-pgo.configure b/build/moz.configure/lto-pgo.configure diff --git a/build/moz.configure/lto-pgo.configure b/build/moz.configure/lto-pgo.configure
index df2b0bf0081edfdc2c7bccaefc780d2b0c6555ff..53a3b55de7650799e3730372e72ad7b4bb2eea03 100644 index c72af5ed5f88fc80c810ef626e57a8b991dee514..53a3b55de7650799e3730372e72ad7b4bb2eea03 100644
--- a/build/moz.configure/lto-pgo.configure --- a/build/moz.configure/lto-pgo.configure
+++ b/build/moz.configure/lto-pgo.configure +++ b/build/moz.configure/lto-pgo.configure
@@ -234,6 +234,7 @@ def moz_pgo_rust(pgo, profile_use, profile_generate, c_compiler): @@ -234,6 +234,7 @@ def moz_pgo_rust(pgo, profile_use, profile_generate, c_compiler):
@@ -14,7 +14,7 @@ index df2b0bf0081edfdc2c7bccaefc780d2b0c6555ff..53a3b55de7650799e3730372e72ad7b4
help="Indicate that ld64 is free of symbol aliasing bugs", help="Indicate that ld64 is free of symbol aliasing bugs",
) )
-imply_option("MOZ_LD64_KNOWN_GOOD", moz_automation) -imply_option("MOZ_LD64_KNOWN_GOOD", True, when=moz_automation)
use_fat_lto = cxx_compiler.try_link( use_fat_lto = cxx_compiler.try_link(
ldflags=depends(stlport_libs)( ldflags=depends(stlport_libs)(

View File

@@ -1,168 +0,0 @@
diff --git a/browser/components/sessionstore/test/browser.toml b/browser/components/sessionstore/test/browser.toml
--- a/browser/components/sessionstore/test/browser.toml
+++ b/browser/components/sessionstore/test/browser.toml
@@ -14,10 +14,12 @@
"browser_frame_history_c.html",
"browser_frame_history_c1.html",
"browser_frame_history_c2.html",
"browser_formdata_format_sample.html",
"browser_sessionHistory_slow.sjs",
+ "browser_policy_container_sample.html",
+ "browser_policy_container_sample_frame.html",
"browser_scrollPositions_sample.html",
"browser_scrollPositions_sample2.html",
"browser_scrollPositions_sample_frameset.html",
"browser_scrollPositions_readerModeArticle.html",
"browser_sessionStorage.html",
@@ -226,10 +228,12 @@
["browser_pinned_tabs.js"]
skip-if = [
"ccov", # Bug 1625525
]
+["browser_policy_container_not_stored.js"]
+
["browser_privatetabs.js"]
["browser_purge_domaindata.js"]
["browser_purge_shistory.js"]
diff --git a/browser/components/sessionstore/test/browser_policy_container_not_stored.js b/browser/components/sessionstore/test/browser_policy_container_not_stored.js
new file mode 100644
--- /dev/null
+++ b/browser/components/sessionstore/test/browser_policy_container_not_stored.js
@@ -0,0 +1,51 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+"use strict";
+
+/**
+ * A session history entry only needs to retain the policy container for loads
+ * that inherit their policies (about:blank, about:srcdoc, blob:, data:, ...).
+ * Anything fetched over the network gets its policies from the response again,
+ * so storing them would only bloat the session store (bug 2011236).
+ */
+
+const TEST_ROOT = getRootDirectory(gTestPath).replace(
+ "chrome://mochitests/content",
+ "https://example.com"
+);
+const PARENT_URL = TEST_ROOT + "browser_policy_container_sample.html";
+const FRAME_URL = TEST_ROOT + "browser_policy_container_sample_frame.html";
+
+add_task(async function test_policy_container_only_for_inheriting_loads() {
+ const tab = BrowserTestUtils.addTab(gBrowser, PARENT_URL);
+ gBrowser.selectedTab = tab;
+ await promiseBrowserLoaded(tab.linkedBrowser, true, PARENT_URL);
+ await TabStateFlusher.flush(tab.linkedBrowser);
+
+ const state = JSON.parse(ss.getTabState(tab));
+ const topEntry = state.entries.at(-1);
+ is(topEntry.url, PARENT_URL, "collected the parent entry");
+
+ const children = topEntry.children ?? [];
+ const networkFrame = children.find(child => child.url === FRAME_URL);
+ const blankFrame = children.find(child => child.url === "about:blank");
+
+ ok(networkFrame, "collected the network-scheme subframe entry");
+ ok(blankFrame, "collected the about:blank subframe entry");
+
+ // The parent has a CSP, so both subframes inherit a policy container onto
+ // their load state. Only the one that cannot recover it from a response
+ // should keep it in session history.
+ ok(
+ !("policyContainer" in networkFrame),
+ "https subframe entry does not store a policyContainer"
+ );
+ ok(
+ "policyContainer" in blankFrame,
+ "about:blank subframe entry still stores its inherited policyContainer"
+ );
+
+ await BrowserTestUtils.removeTab(tab);
+});
diff --git a/browser/components/sessionstore/test/browser_policy_container_sample.html b/browser/components/sessionstore/test/browser_policy_container_sample.html
new file mode 100644
--- /dev/null
+++ b/browser/components/sessionstore/test/browser_policy_container_sample.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <meta charset="utf-8">
+ <meta http-equiv="Content-Security-Policy" content="default-src * data: blob: 'unsafe-inline'">
+ <title>policyContainer session store sample</title>
+</head>
+<body>
+ <iframe id="network" src="browser_policy_container_sample_frame.html"></iframe>
+ <iframe id="blank" src="about:blank"></iframe>
+</body>
+</html>
diff --git a/browser/components/sessionstore/test/browser_policy_container_sample_frame.html b/browser/components/sessionstore/test/browser_policy_container_sample_frame.html
new file mode 100644
--- /dev/null
+++ b/browser/components/sessionstore/test/browser_policy_container_sample_frame.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <meta charset="utf-8">
+ <title>policyContainer session store sample frame</title>
+</head>
+<body>
+ frame
+</body>
+</html>
diff --git a/docshell/shistory/SessionHistoryEntry.cpp b/docshell/shistory/SessionHistoryEntry.cpp
--- a/docshell/shistory/SessionHistoryEntry.cpp
+++ b/docshell/shistory/SessionHistoryEntry.cpp
@@ -41,10 +41,18 @@
extern mozilla::LazyLogModule gSHLog;
namespace mozilla {
namespace dom {
+// Only store policy container for loads that can't carry it themselves
+// (about:blank, about:srcdoc, blob:, data:, ...)
+// bug 1867137, bug 2011236
+static nsIPolicyContainer* PolicyContainerToStore(
+ nsIURI* aURI, nsIPolicyContainer* aPolicyContainer) {
+ return CSP_ShouldURIInheritCSP(aURI) ? aPolicyContainer : nullptr;
+}
+
SessionHistoryInfo::SessionHistoryInfo(nsDocShellLoadState* aLoadState,
nsIChannel* aChannel)
: mURI(aLoadState->URI()),
mOriginalURI(aLoadState->OriginalURI()),
mResultPrincipalURI(aLoadState->ResultPrincipalURI()),
@@ -59,11 +67,12 @@
mLoadReplace(aLoadState->LoadReplace()),
mHasUserActivation(aLoadState->HasValidUserGestureActivation()),
mSharedState(SharedState::Create(
aLoadState->TriggeringPrincipal(), aLoadState->PrincipalToInherit(),
aLoadState->PartitionedPrincipalToInherit(),
- aLoadState->PolicyContainer(),
+ PolicyContainerToStore(aLoadState->URI(),
+ aLoadState->PolicyContainer()),
/* FIXME Is this correct? */
aLoadState->TypeHint())) {
MOZ_DIAGNOSTIC_ASSERT(!mURI->SchemeIs("javascript"));
// Pull the upload stream off of the channel instead of the load state, as
@@ -124,11 +133,12 @@
loadInfo->GetPrincipalToInherit(
getter_AddRefs(mSharedState.Get()->mPrincipalToInherit));
mSharedState.Get()->mPartitionedPrincipalToInherit =
aPartitionedPrincipalToInherit;
- mSharedState.Get()->mPolicyContainer = aPolicyContainer;
+ mSharedState.Get()->mPolicyContainer =
+ PolicyContainerToStore(mURI, aPolicyContainer);
aChannel->GetContentType(mSharedState.Get()->mContentType);
aChannel->GetOriginalURI(getter_AddRefs(mOriginalURI));
uint32_t loadFlags;
aChannel->GetLoadFlags(&loadFlags);

View File

@@ -1,558 +0,0 @@
diff --git a/gfx/wr/webrender/res/ps_quad_mask.glsl b/gfx/wr/webrender/res/ps_quad_mask.glsl
--- a/gfx/wr/webrender/res/ps_quad_mask.glsl
+++ b/gfx/wr/webrender/res/ps_quad_mask.glsl
@@ -19,12 +19,14 @@
// We pack 4 vec3 clip planes into 3 vec4 to save a varying slot.
flat varying highp vec4 vClipPlane_A;
flat varying highp vec4 vClipPlane_B;
flat varying highp vec4 vClipPlane_C;
+#ifdef WR_FEATURE_SUPERELLIPSE
flat varying highp vec4 vClipShape;
flat varying highp vec4 vClipClampedInset;
+#endif
#endif
flat varying highp vec2 vClipMode;
#ifdef WR_VERTEX_SHADER
@@ -40,12 +42,14 @@
vec4 radii;
#else
vec4 radii_top;
vec4 radii_bottom;
+#ifdef WR_FEATURE_SUPERELLIPSE
vec4 shape;
vec4 inset;
+#endif
#endif
float mode;
int space;
};
@@ -58,22 +62,29 @@
vec4 texels[3] = fetch_from_gpu_buffer_3f(index);
clip.rect = RectWithEndpoint(texels[0].xy, texels[0].zw);
clip.radii = texels[1];
clip.mode = texels[2].x;
#else
+#ifdef WR_FEATURE_SUPERELLIPSE
vec4 texels[6] = fetch_from_gpu_buffer_6f(index);
+#else
+ vec4 texels[4] = fetch_from_gpu_buffer_4f(index);
+#endif
clip.rect = RectWithEndpoint(texels[0].xy, texels[0].zw);
clip.radii_top = texels[1];
clip.radii_bottom = texels[2];
clip.mode = texels[3].x;
+#ifdef WR_FEATURE_SUPERELLIPSE
clip.shape = texels[4];
clip.inset = texels[5];
+#endif
#endif
return clip;
}
+#ifdef WR_FEATURE_SUPERELLIPSE
vec4 precalc_corner(vec2 center, vec2 radii, vec2 inset, vec2 clip_sign, float k) {
if (k == 1.0) {
// round/ellipse corner, precalc the ellipse parameters
return vec4(center, inverse_radii_squared(radii));
} else {
@@ -85,10 +96,11 @@
radii = offset_radii.zw;
}
return vec4(center, inverse_radii(radii));
}
}
+#endif
void pattern_vertex(PrimitiveInfo prim_info) {
Clip clip = fetch_clip(aClipData.y);
Transform clip_transform = fetch_transform(aClipData.x);
@@ -121,10 +133,11 @@
vec2 r_tl = clip.radii_top.xy;
vec2 r_tr = clip.radii_top.zw;
vec2 r_br = clip.radii_bottom.zw;
vec2 r_bl = clip.radii_bottom.xy;
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipCenter_Radius_TL = precalc_corner(clip.rect.p0 + r_tl,
r_tl,
clip.inset.wx,
vec2(-1.0, -1.0),
clip.shape.x);
@@ -146,10 +159,25 @@
clip.rect.p1.y - r_bl.y),
r_bl,
clip.inset.wz,
vec2(-1.0, 1.0),
clip.shape.w);
+#else
+ vClipCenter_Radius_TL = vec4(clip.rect.p0 + r_tl,
+ inverse_radii_squared(r_tl));
+
+ vClipCenter_Radius_TR = vec4(clip.rect.p1.x - r_tr.x,
+ clip.rect.p0.y + r_tr.y,
+ inverse_radii_squared(r_tr));
+
+ vClipCenter_Radius_BR = vec4(clip.rect.p1 - r_br,
+ inverse_radii_squared(r_br));
+
+ vClipCenter_Radius_BL = vec4(clip.rect.p0.x + r_bl.x,
+ clip.rect.p1.y - r_bl.y,
+ inverse_radii_squared(r_bl));
+#endif
// We need to know the half-spaces of the corners separate from the center
// and radius. We compute a point that falls on the diagonal (which is just
// an inner vertex pushed out along one axis, but not on both) to get the
// plane offset of the half-space. We also compute the direction vector of
@@ -170,13 +198,15 @@
vClipPlane_A = vec4(tl.x, tl.y, tl.z, tr.x);
vClipPlane_B = vec4(tr.y, tr.z, br.x, br.y);
vClipPlane_C = vec4(br.z, bl.x, bl.y, bl.z);
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipShape = clip.shape;
vClipClampedInset = min(clip.inset, 0.0);
#endif
+#endif
}
#endif
#ifdef WR_FRAGMENT_SHADER
@@ -205,11 +235,13 @@
vec3 plane_tr = vec3(vClipPlane_A.w, vClipPlane_B.x, vClipPlane_B.y);
vec3 plane_br = vec3(vClipPlane_B.z, vClipPlane_B.w, vClipPlane_C.x);
vec3 plane_bl = vec3(vClipPlane_C.y, vClipPlane_C.z, vClipPlane_C.w);
float dist;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (vClipShape == vec4(1.0)) {
+#endif
dist = distance_to_rounded_rect(
clip_local_pos,
plane_tl,
vClipCenter_Radius_TL,
plane_tr,
@@ -218,10 +250,11 @@
vClipCenter_Radius_BR,
plane_bl,
vClipCenter_Radius_BL,
vTransformBounds
);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
dist = distance_to_shaped_rect(
clip_local_pos,
vClipCenter_Radius_TL,
vClipCenter_Radius_TR,
@@ -230,10 +263,11 @@
vTransformBounds,
vClipShape,
vClipClampedInset
);
}
+#endif
#endif
// Compute AA for the given dist and range.
float alpha = distance_aa(aa_range, dist);
@@ -340,13 +374,13 @@
#define AA_RECT(local_pos) \
sd_round_box(local_pos, v_clip_size, v_clip_radii)
#else
// The span fast path only handles elliptical corners. For superellipse
// shapes, bail out and let SWGL fall back to the fragment shader.
- if (vClipShape != vec4(1.0)) {
+ #ifdef WR_FEATURE_SUPERELLIPSE
return;
- }
+ #endif
// Unpack the corner half-spaces packed into vClipPlane_A/B/C.
vec3 plane_tl = vec3(vClipPlane_A.x, vClipPlane_A.y, vClipPlane_A.z);
vec3 plane_tr = vec3(vClipPlane_A.w, vClipPlane_B.x, vClipPlane_B.y);
vec3 plane_br = vec3(vClipPlane_B.z, vClipPlane_B.w, vClipPlane_C.x);
diff --git a/gfx/wr/webrender/src/batch.rs b/gfx/wr/webrender/src/batch.rs
--- a/gfx/wr/webrender/src/batch.rs
+++ b/gfx/wr/webrender/src/batch.rs
@@ -1224,25 +1224,29 @@
/// A list of clip instances to be drawn into a target.
#[cfg_attr(feature = "capture", derive(Serialize))]
#[cfg_attr(feature = "replay", derive(Deserialize))]
pub struct ClipMaskInstanceList {
pub mask_instances_fast: FrameVec<MaskInstance>,
+ pub mask_instances_superellipse: FrameVec<MaskInstance>,
pub mask_instances_slow: FrameVec<MaskInstance>,
pub mask_instances_fast_with_scissor: FastHashMap<DeviceIntRect, FrameVec<MaskInstance>>,
+ pub mask_instances_superellipse_with_scissor: FastHashMap<DeviceIntRect, FrameVec<MaskInstance>>,
pub mask_instances_slow_with_scissor: FastHashMap<DeviceIntRect, FrameVec<MaskInstance>>,
pub image_mask_instances: FastHashMap<TextureSource, FrameVec<PrimitiveInstanceData>>,
pub image_mask_instances_with_scissor: FastHashMap<(DeviceIntRect, TextureSource), FrameVec<PrimitiveInstanceData>>,
}
impl ClipMaskInstanceList {
pub fn new(memory: &FrameMemory) -> Self {
ClipMaskInstanceList {
mask_instances_fast: memory.new_vec(),
+ mask_instances_superellipse: memory.new_vec(),
mask_instances_slow: memory.new_vec(),
mask_instances_fast_with_scissor: FastHashMap::default(),
+ mask_instances_superellipse_with_scissor: FastHashMap::default(),
mask_instances_slow_with_scissor: FastHashMap::default(),
image_mask_instances: FastHashMap::default(),
image_mask_instances_with_scissor: FastHashMap::default(),
}
}
@@ -1250,20 +1254,24 @@
pub fn is_empty(&self) -> bool {
// Destructure self to make sure we don't forget to update this method if
// a new member is added.
let ClipMaskInstanceList {
mask_instances_fast,
+ mask_instances_superellipse,
mask_instances_slow,
mask_instances_fast_with_scissor,
+ mask_instances_superellipse_with_scissor,
mask_instances_slow_with_scissor,
image_mask_instances,
image_mask_instances_with_scissor,
} = self;
mask_instances_fast.is_empty()
+ && mask_instances_superellipse.is_empty()
&& mask_instances_slow.is_empty()
&& mask_instances_fast_with_scissor.is_empty()
+ && mask_instances_superellipse_with_scissor.is_empty()
&& mask_instances_slow_with_scissor.is_empty()
&& image_mask_instances.is_empty()
&& image_mask_instances_with_scissor.is_empty()
}
}
diff --git a/gfx/wr/webrender/src/quad.rs b/gfx/wr/webrender/src/quad.rs
--- a/gfx/wr/webrender/src/quad.rs
+++ b/gfx/wr/webrender/src/quad.rs
@@ -1807,11 +1807,11 @@
gpu_buffer: &mut GpuBufferBuilderF,
clip_rect: LayoutRect,
radius: &BorderRadius,
inset: LayoutSideOffsets,
mode: ClipMode,
-) -> (GpuBufferAddress, bool) {
+) -> (GpuBufferAddress, bool, bool) {
let radius = clamped_radius(radius, clip_rect.size());
if radius.can_use_fast_path_in(&clip_rect) {
let mut writer = gpu_buffer.write_blocks(3);
writer.push_one(clip_rect);
@@ -1821,13 +1821,15 @@
radius.bottom_left.width,
radius.top_left.width,
]);
writer.push_one([mode as i32 as f32, 0.0, 0.0, 0.0]);
- (writer.finish(), true)
+ (writer.finish(), true, false)
} else {
- let mut writer = gpu_buffer.write_blocks(6);
+ let superellipse = !radius.shapes_all_round();
+ let block_count = if superellipse { 6 } else { 4 };
+ let mut writer = gpu_buffer.write_blocks(block_count);
writer.push_one(clip_rect);
writer.push_one([
radius.top_left.width,
radius.top_left.height,
radius.top_right.width,
@@ -1838,19 +1840,21 @@
radius.bottom_left.height,
radius.bottom_right.width,
radius.bottom_right.height,
]);
writer.push_one([mode as i32 as f32, 0.0, 0.0, 0.0]);
- writer.push_one([
- radius.shape_top_left,
- radius.shape_top_right,
- radius.shape_bottom_right,
- radius.shape_bottom_left,
- ]);
- writer.push_one(inset);
+ if superellipse {
+ writer.push_one([
+ radius.shape_top_left,
+ radius.shape_top_right,
+ radius.shape_bottom_right,
+ radius.shape_bottom_left,
+ ]);
+ writer.push_one(inset);
+ }
- (writer.finish(), false)
+ (writer.finish(), false, superellipse)
}
}
pub fn prepare_clip_task(
clip_instance: &ClipNodeInstance,
@@ -1865,11 +1869,11 @@
gpu_buffer: &mut GpuBufferBuilderF,
transforms: &mut TransformPalette,
rg_builder: &mut RenderTaskGraphBuilder,
sub_tasks: &mut SubTaskRange,
) {
- let (clip_address, fast_path) = match clip_item.kind {
+ let (clip_address, fast_path, superellipse) = match clip_item.kind {
ClipItemKind::RoundedRectangle { radius, inset, mode } => {
write_rounded_rect_clip_blocks(
gpu_buffer,
clip_instance.clip_rect,
&radius,
@@ -1882,11 +1886,11 @@
writer.push_one(clip_instance.clip_rect);
writer.push_one([0.0, 0.0, 0.0, 0.0]);
writer.push_one([mode as i32 as f32, 0.0, 0.0, 0.0]);
let clip_address = writer.finish();
- (clip_address, true)
+ (clip_address, true, false)
}
ClipItemKind::Image { .. } => {
let transform_id = transforms.gpu.get_id_with_post_scale(
clip_instance.spatial_node_index,
raster_spatial_node_index,
@@ -2033,10 +2037,11 @@
clip_transform_id,
quad_flags,
clip_space,
needs_scissor_rect,
rounded_rect_fast_path: fast_path,
+ rounded_rect_superellipse: superellipse,
}),
);
}
fn create_quad_primitive(
diff --git a/gfx/wr/webrender/src/render_target.rs b/gfx/wr/webrender/src/render_target.rs
--- a/gfx/wr/webrender/src/render_target.rs
+++ b/gfx/wr/webrender/src/render_target.rs
@@ -441,11 +441,11 @@
// so the target must be initialized to one.
self.clears.push((target_rect, ColorF::WHITE));
let device_rect = DeviceRect::from_size(target_rect.size().to_f32());
- let (clip_address, fast_path) = quad::write_rounded_rect_clip_blocks(
+ let (clip_address, fast_path, superellipse) = quad::write_rounded_rect_clip_blocks(
&mut gpu_buffer_builder.f32,
region_task.clip_rect,
&region_task.radius,
region_task.inset,
region_task.mode,
@@ -495,10 +495,12 @@
unused: 0,
};
if fast_path {
self.clip_masks.mask_instances_fast.push(instance);
+ } else if superellipse {
+ self.clip_masks.mask_instances_superellipse.push(instance);
} else {
self.clip_masks.mask_instances_slow.push(instance);
}
},
);
@@ -925,19 +927,26 @@
if task.rounded_rect_fast_path {
results.mask_instances_fast_with_scissor
.entry(*target_rect)
.or_insert_with(|| memory.new_vec())
.push(instance);
+ } else if task.rounded_rect_superellipse {
+ results.mask_instances_superellipse_with_scissor
+ .entry(*target_rect)
+ .or_insert_with(|| memory.new_vec())
+ .push(instance);
} else {
results.mask_instances_slow_with_scissor
.entry(*target_rect)
.or_insert_with(|| memory.new_vec())
.push(instance);
}
} else {
if task.rounded_rect_fast_path {
results.mask_instances_fast.push(instance);
+ } else if task.rounded_rect_superellipse {
+ results.mask_instances_superellipse.push(instance);
} else {
results.mask_instances_slow.push(instance);
}
}
}
diff --git a/gfx/wr/webrender/src/render_task.rs b/gfx/wr/webrender/src/render_task.rs
--- a/gfx/wr/webrender/src/render_task.rs
+++ b/gfx/wr/webrender/src/render_task.rs
@@ -2240,10 +2240,11 @@
/// Transform from the quad primitive's space to the clip's local space.
pub clip_transform_id: GpuTransformId,
pub quad_flags: QuadFlags,
pub needs_scissor_rect: bool,
pub rounded_rect_fast_path: bool,
+ pub rounded_rect_superellipse: bool,
}
/// An clip applied to a render task using the multiply blend mode on top of
/// the content being clipped.
#[derive(Debug)]
diff --git a/gfx/wr/webrender/src/renderer/mod.rs b/gfx/wr/webrender/src/renderer/mod.rs
--- a/gfx/wr/webrender/src/renderer/mod.rs
+++ b/gfx/wr/webrender/src/renderer/mod.rs
@@ -2450,10 +2450,54 @@
}
self.device.disable_scissor();
}
+ if !masks.mask_instances_superellipse.is_empty() {
+ self.shaders.borrow_mut().ps_mask_superellipse().bind(
+ &mut self.device,
+ projection,
+ None,
+ &mut self.renderer_errors,
+ &mut self.profile,
+ &mut self.command_log,
+ );
+
+ self.draw_instanced_batch(
+ &masks.mask_instances_superellipse,
+ VertexArrayKind::Mask,
+ &BatchTextures::empty(),
+ stats,
+ );
+ }
+
+ if !masks.mask_instances_superellipse_with_scissor.is_empty() {
+ self.shaders.borrow_mut().ps_mask_superellipse().bind(
+ &mut self.device,
+ projection,
+ None,
+ &mut self.renderer_errors,
+ &mut self.profile,
+ &mut self.command_log,
+ );
+
+ self.device.enable_scissor();
+
+ for (scissor_rect, instances) in &masks.mask_instances_superellipse_with_scissor {
+ self.device.set_scissor_rect(draw_target.to_framebuffer_rect(*scissor_rect));
+
+ self.draw_instanced_batch(
+ instances,
+ VertexArrayKind::Mask,
+ &BatchTextures::empty(),
+ stats,
+ );
+ }
+
+ self.device.disable_scissor();
+ }
+
if !masks.image_mask_instances.is_empty() {
self.shaders.borrow_mut().ps_quad_textured().bind(
&mut self.device,
projection,
None,
diff --git a/gfx/wr/webrender/src/renderer/shade.rs b/gfx/wr/webrender/src/renderer/shade.rs
--- a/gfx/wr/webrender/src/renderer/shade.rs
+++ b/gfx/wr/webrender/src/renderer/shade.rs
@@ -65,10 +65,11 @@
];
const DITHERING_FEATURE: &str = "DITHERING";
const DUAL_SOURCE_FEATURE: &str = "DUAL_SOURCE_BLENDING";
const FAST_PATH_FEATURE: &str = "FAST_PATH";
+const SUPERELLIPSE_FEATURE: &str = "SUPERELLIPSE";
pub(crate) enum ShaderKind {
Primitive,
Cache(VertexArrayKind),
Text,
@@ -449,10 +450,11 @@
ps_quad_backdrop: ShaderHandle,
ps_quad_blend: ShaderHandle,
ps_quad_mix_blend: ShaderHandle,
ps_mask: ShaderHandle,
ps_mask_fast: ShaderHandle,
+ ps_mask_superellipse: ShaderHandle,
ps_clear: ShaderHandle,
ps_copy: ShaderHandle,
composite: CompositorShaders,
}
@@ -514,10 +516,17 @@
"ps_quad_mask",
&[FAST_PATH_FEATURE],
&shader_list,
)?;
+ let ps_mask_superellipse = loader.create_shader(
+ ShaderKind::Cache(VertexArrayKind::Mask),
+ "ps_quad_mask",
+ &[SUPERELLIPSE_FEATURE],
+ &shader_list,
+ )?;
+
let mut cs_scale = Vec::new();
let scale_shader_num = IMAGE_BUFFER_KINDS.len();
// PrimitiveShader is not clonable. Use push() to initialize the vec.
for _ in 0 .. scale_shader_num {
cs_scale.push(None);
@@ -786,10 +795,11 @@
ps_quad_backdrop,
ps_quad_blend,
ps_quad_mix_blend,
ps_mask,
ps_mask_fast,
+ ps_mask_superellipse,
ps_split_composite,
ps_clear,
ps_copy,
composite,
})
@@ -963,10 +973,11 @@
pub fn ps_quad_textured(&mut self) -> &mut LazilyCompiledShader {
self.loader.get(self.ps_quad_textured)
}
pub fn ps_mask(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.ps_mask) }
pub fn ps_mask_fast(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.ps_mask_fast) }
+ pub fn ps_mask_superellipse(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.ps_mask_superellipse) }
pub fn ps_clear(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.ps_clear) }
pub fn ps_copy(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.ps_copy) }
pub fn deinit(self, device: &mut Device) {
self.loader.deinit(device);
diff --git a/gfx/wr/webrender_build/src/shader_features.rs b/gfx/wr/webrender_build/src/shader_features.rs
--- a/gfx/wr/webrender_build/src/shader_features.rs
+++ b/gfx/wr/webrender_build/src/shader_features.rs
@@ -65,11 +65,11 @@
let mut shaders = ShaderFeatures::new();
// Cache shaders
shaders.insert("cs_blur", vec!["ALPHA_TARGET".to_string(), "COLOR_TARGET".to_string()]);
- shaders.insert("ps_quad_mask", vec![String::new(), "FAST_PATH".to_string()]);
+ shaders.insert("ps_quad_mask", vec![String::new(), "FAST_PATH".to_string(), "SUPERELLIPSE".to_string()]);
for name in &[
"cs_line_decoration",
"cs_border_segment",
"cs_border_solid",

View File

@@ -1,307 +0,0 @@
diff --git a/gfx/wr/webrender/res/ps_quad_box_shadow.glsl b/gfx/wr/webrender/res/ps_quad_box_shadow.glsl
--- a/gfx/wr/webrender/res/ps_quad_box_shadow.glsl
+++ b/gfx/wr/webrender/res/ps_quad_box_shadow.glsl
@@ -49,22 +49,26 @@
flat varying highp vec4 vElemCenter_Radius_TL;
flat varying highp vec4 vElemCenter_Radius_TR;
flat varying highp vec4 vElemCenter_Radius_BR;
flat varying highp vec4 vElemCenter_Radius_BL;
+#ifdef WR_FEATURE_SUPERELLIPSE
flat varying highp vec4 vElemShape;
+#endif
#ifdef WR_VERTEX_SHADER
void pattern_vertex(PrimitiveInfo info) {
vec4 data0 = fetch_from_gpu_buffer_1f(info.pattern_input.x);
vec4 data1 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 1);
vec4 data2 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 2);
vec4 data3 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 3);
vec4 data4 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 4);
vec4 data5 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 5);
+#ifdef WR_FEATURE_SUPERELLIPSE
vec4 data6 = fetch_from_gpu_buffer_1f(info.pattern_input.x + 6);
+#endif
vec2 alloc_size = data0.xy;
vec2 dest_rect_size = data0.zw;
vec2 dest_rect_off = data1.xy;
v_uv_scale_inset = vec4(vec2(1.0) / alloc_size, data1.z, 0.0);
@@ -84,11 +88,11 @@
// Map nine-patch UV=1.0 to the true content edge (uv_p0 + content_device_size)
// rather than the rounded atlas entry edge (info.segment.uv_rect.p1). The atlas
// allocation is rounded up from content_device_size, so this edge always lies
// inside the entry; using it keeps the mapping stable to sub-texel precision as
// the blur animates (bug 2002194).
- vec2 content_device_size = data6.xy;
+ vec2 content_device_size = data5.xy;
vec2 texture_size = vec2(TEX_SIZE(sColor0));
vec2 uv_p0 = info.segment.uv_rect.p0;
vec2 uv_p1 = uv_p0 + content_device_size;
v_uv_rect = vec4(uv_p0, uv_p1) / texture_size.xyxy;
v_uv_bounds = vec4(
@@ -110,11 +114,13 @@
vElemCenter_Radius_TL = vec4(elem_p0 + r_tl, r_tl);
vElemCenter_Radius_TR = vec4(elem_p1.x - r_tr.x, elem_p0.y + r_tr.y, r_tr);
vElemCenter_Radius_BR = vec4(elem_p1 - r_br, r_br);
vElemCenter_Radius_BL = vec4(elem_p0.x + r_bl.x, elem_p1.y - r_bl.y, r_bl);
- vElemShape = data5;
+#ifdef WR_FEATURE_SUPERELLIPSE
+ vElemShape = data6;
+#endif
}
#endif
#ifdef WR_FRAGMENT_SHADER
@@ -170,22 +176,24 @@
vec3 elem_plane_bl = vec3(n_bl, dot(n_bl, vec2(c_bl.x, c_bl.y + r_bl.y)));
// Reconstruct the element rect bounds from the TL and BR corner data.
vec4 elem_bounds = vec4(c_tl - r_tl, c_br + r_br);
- vec4 elem_shape = vElemShape;
-
float elem_dist;
+#ifdef WR_FEATURE_SUPERELLIPSE
+ vec4 elem_shape = vElemShape;
if (elem_shape == vec4(1.0)) {
+#endif
elem_dist = distance_to_rounded_rect(
local_pos,
elem_plane_tl, vec4(c_tl, inverse_radii_squared(r_tl)),
elem_plane_tr, vec4(c_tr, inverse_radii_squared(r_tr)),
elem_plane_br, vec4(c_br, inverse_radii_squared(r_br)),
elem_plane_bl, vec4(c_bl, inverse_radii_squared(r_bl)),
elem_bounds
);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
elem_dist = distance_to_shaped_rect(
local_pos,
vec4(c_tl, elem_shape.x == 1.0 ? inverse_radii_squared(r_tl) : inverse_radii(r_tl)),
vec4(c_tr, elem_shape.y == 1.0 ? inverse_radii_squared(r_tr) : inverse_radii(r_tr)),
@@ -194,10 +202,11 @@
elem_bounds,
elem_shape,
vec4(0.0)
);
}
+#endif
// Outset (inset=0): dist < 0 = inside element → should be clipped out → use -elem_dist.
// Inset (inset=1): dist < 0 = inside element → should be kept → use elem_dist.
float element_clip = distance_aa(aa_range, mix(-elem_dist, elem_dist, inset));
diff --git a/gfx/wr/webrender/src/pattern/box_shadow.rs b/gfx/wr/webrender/src/pattern/box_shadow.rs
--- a/gfx/wr/webrender/src/pattern/box_shadow.rs
+++ b/gfx/wr/webrender/src/pattern/box_shadow.rs
@@ -41,11 +41,14 @@
_sub_rect: Option<DeviceRect>,
_offset: LayoutVector2D,
_ctx: &PatternBuilderContext,
state: &mut PatternBuilderState,
) -> Pattern {
- let mut writer = state.frame_gpu_data.f32.write_blocks(7);
+ let superellipse = !self.element_radius.shapes_all_round();
+
+ let block_count = if superellipse { 7 } else { 6 };
+ let mut writer = state.frame_gpu_data.f32.write_blocks(block_count);
writer.push_one([
self.shadow_rect_alloc_size.width,
self.shadow_rect_alloc_size.height,
self.dest_rect_size.width,
self.dest_rect_size.height,
@@ -72,26 +75,28 @@
self.element_radius.bottom_right.width,
self.element_radius.bottom_right.height,
self.element_radius.bottom_left.width,
self.element_radius.bottom_left.height,
]);
- writer.push_one([
- self.element_radius.shape_top_left,
- self.element_radius.shape_top_right,
- self.element_radius.shape_bottom_right,
- self.element_radius.shape_bottom_left,
- ]);
writer.push_one([
self.content_device_size.width,
self.content_device_size.height,
0.0,
0.0,
]);
+ if superellipse {
+ writer.push_one([
+ self.element_radius.shape_top_left,
+ self.element_radius.shape_top_right,
+ self.element_radius.shape_bottom_right,
+ self.element_radius.shape_bottom_left,
+ ]);
+ }
let addr = writer.finish();
Pattern {
- kind: PatternKind::BoxShadow,
+ kind: if superellipse { PatternKind::BoxShadowSuperellipse } else { PatternKind::BoxShadow },
shader_input: PatternShaderInput(addr.as_int(), 0),
texture_input: PatternTextureInput::new(self.render_task),
base_color: self.color,
is_opaque: false,
blend_mode: BlendMode::PremultipliedAlpha,
diff --git a/gfx/wr/webrender/src/pattern/mod.rs b/gfx/wr/webrender/src/pattern/mod.rs
--- a/gfx/wr/webrender/src/pattern/mod.rs
+++ b/gfx/wr/webrender/src/pattern/mod.rs
@@ -29,36 +29,37 @@
Gradient = 1,
Repeat = 2,
Mask = 3,
BoxShadow = 4,
+ BoxShadowSuperellipse = 5,
// Variants of ColorOrTexture that use a non-default sampler type
// (samplerExternalOES / __samplerExternal2DY2YEXT / sampler2DRect). The
// quad shader is compiled in matching per-kind variants; see
// ps_quad_textured.glsl.
- TextureExternal = 5,
- TextureExternalBT709 = 6,
- TextureRect = 7,
+ TextureExternal = 6,
+ TextureExternalBT709 = 7,
+ TextureRect = 8,
// Samples up to three planes (sColor0/1/2) and converts from YUV to RGB.
// Like ColorOrTexture, the YUV pattern comes in sampler-type-specific
// variants so that the planes are sampled with the matching sColor
// declaration; see ps_quad_yuv.glsl. `Yuv` is the default (TEXTURE_2D).
- Yuv = 8,
- YuvTextureExternal = 9,
- YuvTextureExternalBT709 = 10,
- YuvTextureRect = 11,
+ Yuv = 9,
+ YuvTextureExternal = 10,
+ YuvTextureExternalBT709 = 11,
+ YuvTextureRect = 12,
// Samples a captured backdrop texture using a (bilerp) 4-corner uv quad.
- Backdrop = 12,
+ Backdrop = 13,
// Applies a filter to a sampled source texture; see ps_quad_blend.glsl.
- Blend = 13,
+ Blend = 14,
// Composites a picture over its backdrop with a software mix-blend-mode;
// samples two textures (backdrop + source). See ps_quad_mix_blend.glsl.
- MixBlend = 14,
+ MixBlend = 15,
// When adding patterns, don't forget to update the NUM_PATTERNS constant.
}
-pub const NUM_PATTERNS: u32 = 15;
+pub const NUM_PATTERNS: u32 = 16;
impl PatternKind {
pub fn from_u32(val: u32) -> Self {
assert!(val < NUM_PATTERNS);
unsafe { std::mem::transmute(val) }
diff --git a/gfx/wr/webrender/src/renderer/mod.rs b/gfx/wr/webrender/src/renderer/mod.rs
--- a/gfx/wr/webrender/src/renderer/mod.rs
+++ b/gfx/wr/webrender/src/renderer/mod.rs
@@ -251,10 +251,11 @@
BatchKind::Quad(PatternKind::TextureExternalBT709) => GPU_TAG_PRIMITIVE,
BatchKind::Quad(PatternKind::TextureRect) => GPU_TAG_PRIMITIVE,
BatchKind::Quad(PatternKind::Gradient) => GPU_TAG_GRADIENT,
BatchKind::Quad(PatternKind::Repeat) => GPU_TAG_REPEAT,
BatchKind::Quad(PatternKind::BoxShadow) => GPU_TAG_PRIMITIVE,
+ BatchKind::Quad(PatternKind::BoxShadowSuperellipse) => GPU_TAG_PRIMITIVE,
BatchKind::Quad(PatternKind::Yuv) => GPU_TAG_BRUSH_YUV_IMAGE,
BatchKind::Quad(PatternKind::YuvTextureExternal) => GPU_TAG_BRUSH_YUV_IMAGE,
BatchKind::Quad(PatternKind::YuvTextureExternalBT709) => GPU_TAG_BRUSH_YUV_IMAGE,
BatchKind::Quad(PatternKind::YuvTextureRect) => GPU_TAG_BRUSH_YUV_IMAGE,
BatchKind::Quad(PatternKind::Backdrop) => GPU_TAG_PRIMITIVE,
diff --git a/gfx/wr/webrender/src/renderer/shade.rs b/gfx/wr/webrender/src/renderer/shade.rs
--- a/gfx/wr/webrender/src/renderer/shade.rs
+++ b/gfx/wr/webrender/src/renderer/shade.rs
@@ -438,10 +438,11 @@
ps_quad_textured_external_bt709: Option<ShaderHandle>,
ps_quad_textured_rect: Option<ShaderHandle>,
ps_quad_repeat: ShaderHandle,
ps_quad_gradient: ShaderHandle,
ps_quad_box_shadow: ShaderHandle,
+ ps_quad_box_shadow_superellipse: ShaderHandle,
// ps_quad_yuv, like ps_quad_textured, comes in sampler-type-specific
// variants so the YUV planes are sampled with the matching sColor
// declaration. The variant is selected via PatternKind.
ps_quad_yuv: ShaderHandle,
ps_quad_yuv_external: Option<ShaderHandle>,
@@ -651,10 +652,17 @@
"ps_quad_box_shadow",
&[],
&shader_list,
)?;
+ let ps_quad_box_shadow_superellipse = loader.create_shader(
+ ShaderKind::Primitive,
+ "ps_quad_box_shadow",
+ &[SUPERELLIPSE_FEATURE],
+ &shader_list,
+ )?;
+
let ps_quad_yuv = loader.create_shader(
ShaderKind::Primitive,
"ps_quad_yuv",
&["TEXTURE_2D"],
&shader_list,
@@ -786,10 +794,11 @@
ps_quad_textured_external_bt709,
ps_quad_textured_rect,
ps_quad_repeat,
ps_quad_gradient,
ps_quad_box_shadow,
+ ps_quad_box_shadow_superellipse,
ps_quad_yuv,
ps_quad_yuv_external,
ps_quad_yuv_external_bt709,
ps_quad_yuv_rect,
ps_quad_backdrop,
@@ -867,10 +876,11 @@
PatternKind::TextureRect => self.ps_quad_textured_rect
.expect("bug: ps_quad_textured TEXTURE_RECT variant not loaded"),
PatternKind::Gradient => self.ps_quad_gradient,
PatternKind::Repeat => self.ps_quad_repeat,
PatternKind::BoxShadow => self.ps_quad_box_shadow,
+ PatternKind::BoxShadowSuperellipse => self.ps_quad_box_shadow_superellipse,
PatternKind::Yuv => self.ps_quad_yuv,
PatternKind::YuvTextureExternal => self.ps_quad_yuv_external
.expect("bug: ps_quad_yuv TEXTURE_EXTERNAL variant not loaded"),
PatternKind::YuvTextureExternalBT709 => self.ps_quad_yuv_external_bt709
.expect("bug: ps_quad_yuv TEXTURE_EXTERNAL_BT709 variant not loaded"),
@@ -923,10 +933,13 @@
self.ps_quad_repeat
}
BatchKind::Quad(PatternKind::BoxShadow) => {
self.ps_quad_box_shadow
}
+ BatchKind::Quad(PatternKind::BoxShadowSuperellipse) => {
+ self.ps_quad_box_shadow_superellipse
+ }
BatchKind::Quad(PatternKind::Yuv) => {
self.ps_quad_yuv
}
BatchKind::Quad(PatternKind::YuvTextureExternal) => {
self.ps_quad_yuv_external
diff --git a/gfx/wr/webrender_build/src/shader_features.rs b/gfx/wr/webrender_build/src/shader_features.rs
--- a/gfx/wr/webrender_build/src/shader_features.rs
+++ b/gfx/wr/webrender_build/src/shader_features.rs
@@ -166,11 +166,11 @@
}
shaders.insert("ps_quad_textured", ps_quad_textured_features);
shaders.insert("ps_quad_repeat", vec![base_prim_features.finish()]);
- shaders.insert("ps_quad_box_shadow", vec![base_prim_features.finish()]);
+ shaders.insert("ps_quad_box_shadow", vec![base_prim_features.finish(), "SUPERELLIPSE".to_string()]);
// Like ps_quad_textured, ps_quad_yuv needs per-texture-kind variants so that
// the YUV planes are sampled with the correct sampler type.
let mut ps_quad_yuv_features: Vec<String> = vec!["TEXTURE_2D".to_string()];
if flags.contains(ShaderFeatureFlags::GL) {

View File

@@ -1,560 +0,0 @@
diff --git a/gfx/wr/webrender/res/border_shared.glsl b/gfx/wr/webrender/res/border_shared.glsl
--- a/gfx/wr/webrender/res/border_shared.glsl
+++ b/gfx/wr/webrender/res/border_shared.glsl
@@ -27,25 +27,33 @@
vec4 rect;
vec4 color0;
vec4 color1;
vec2 widths;
vec2 radii;
+#ifdef WR_FEATURE_SUPERELLIPSE
float shape;
vec2 shape_offset;
vec2 inset;
+#endif
};
BorderInstanceGpuData fetch_gpu_data(int index) {
BorderInstanceGpuData data;
+#ifdef WR_FEATURE_SUPERELLIPSE
vec4 texels[6] = fetch_from_gpu_buffer_6f(index);
+#else
+ vec4 texels[4] = fetch_from_gpu_buffer_4f(index);
+#endif
data.rect = texels[0];
data.color0 = texels[1];
data.color1 = texels[2];
data.widths = texels[3].xy;
data.radii = texels[3].zw;
+#ifdef WR_FEATURE_SUPERELLIPSE
data.shape = texels[4].x;
data.shape_offset = texels[4].yz;
data.inset = texels[5].xy;
+#endif
return data;
}
diff --git a/gfx/wr/webrender/res/cs_border_segment.glsl b/gfx/wr/webrender/res/cs_border_segment.glsl
--- a/gfx/wr/webrender/res/cs_border_segment.glsl
+++ b/gfx/wr/webrender/res/cs_border_segment.glsl
@@ -30,11 +30,13 @@
flat varying highp vec4 vClipCenter_Sign;
// An outer and inner elliptical radii for border
// corner clipping.
flat varying highp vec4 vClipRadii;
+#ifdef WR_FEATURE_SUPERELLIPSE
flat varying highp vec4 vClipOffsets;
+#endif
// Reference point for determine edge clip lines.
flat varying highp vec4 vEdgeReference;
// Stores widths/2 and widths/3 to save doing this in FS.
@@ -192,26 +194,34 @@
vColor00 = color0[0];
vColor01 = color0[1];
vec4[2] color1 = get_colors_for_side(data.color1, style1);
vColor10 = color1[0];
vColor11 = color1[1];
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipCenter_Sign = vec4(outer + clip_sign * (data.radii + data.shape_offset), clip_sign);
+#else
+ vClipCenter_Sign = vec4(outer + clip_sign * data.radii, clip_sign);
+#endif
vClipRadii = vec4(data.radii, max(data.radii - data.widths, 0.0));
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipOffsets = vec4(0.0);
+#endif
vColorLine = vec4(outer, data.widths.y * -clip_sign.y, data.widths.x * clip_sign.x);
vEdgeReference = vec4(edge_reference, edge_reference + data.widths);
vClipParams1 = aClipParams1;
vClipParams2 = aClipParams2;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape != 1.0)
{
vec2 reference_radii = (data.radii == vec2(0.0)) ? vec2(0.0) : data.radii + data.inset;
vec4 contour1 = compute_contoured_superellipse(reference_radii, data.shape, data.inset);
vec4 contour2 = compute_contoured_superellipse(reference_radii, data.shape, data.inset + data.widths);
vClipOffsets = vec4(contour1.xy, contour2.xy);
vClipRadii = vec4(contour1.zw, contour2.zw);
}
+#endif
// For the case of dot and dash clips, optimize the number of pixels that
// are hit to just include the dot itself.
if (clip_mode == CLIP_DOT) {
float radius = aClipParams1.z;
@@ -258,19 +268,22 @@
// also 0.67 of the radii. Use these to form a
// SDF subtraction which will clip out the inside
// third of the rounded edge.
float d_radii_a;
float d_radii_b;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape == 1.0) {
+#endif
d_radii_a = distance_to_ellipse(
clip_relative_pos,
clip_radii.xy - vPartialWidths.xy
);
d_radii_b = distance_to_ellipse(
clip_relative_pos,
clip_radii.xy - 2.0 * vPartialWidths.xy
);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
d_radii_a = distance_to_superellipse(
clip_relative_pos - mix(vClipOffsets.xy, vClipOffsets.zw, 1.0 / 3.0),
mix(clip_radii.xy, clip_radii.zw, 1.0 / 3.0),
data.shape
@@ -286,24 +299,28 @@
d_radii_a = max(d_radii_a, -min(included_region_a.x, included_region_a.y));
vec2 included_region_b = data.radii - 2.0 * vPartialWidths.xy - clip_relative_pos;
d_radii_b = max(d_radii_b, -min(included_region_b.x, included_region_b.y));
}
+#endif
float d = min(-d_radii_a, d_radii_b);
color0 *= distance_aa(aa_range, d);
break;
}
case BORDER_STYLE_GROOVE:
case BORDER_STYLE_RIDGE: {
float d;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape == 1.0) {
+#endif
d = distance_to_ellipse(
clip_relative_pos,
clip_radii.xy - vPartialWidths.zw
);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
d = distance_to_superellipse(
clip_relative_pos - mix(vClipOffsets.xy, vClipOffsets.zw, 0.5),
mix(clip_radii.xy, clip_radii.zw, 0.5),
data.shape
@@ -311,10 +328,11 @@
// Clamp to the middle of the adjacent borders
vec2 included_region = data.radii - vPartialWidths.zw - clip_relative_pos;
d = max(d, -min(included_region.x, included_region.y));
}
+#endif
float alpha = distance_aa(aa_range, d);
float swizzled_factor;
switch (segment) {
case SEGMENT_TOP_LEFT: swizzled_factor = 0.0; break;
case SEGMENT_TOP_RIGHT: swizzled_factor = mix_factor; break;
@@ -435,22 +453,26 @@
if (in_clip_region) {
float d_radii_a;
float d_radii_b;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape == 1.0) {
+#endif
d_radii_a = distance_to_ellipse(clip_relative_pos, vClipRadii.xy);
d_radii_b = distance_to_ellipse(clip_relative_pos, vClipRadii.zw);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
clip_relative_pos = abs(clip_relative_pos) - data.shape_offset;
d_radii_a = distance_to_superellipse(clip_relative_pos - vClipOffsets.xy, vClipRadii.xy, data.shape);
d_radii_b = distance_to_superellipse(clip_relative_pos - vClipOffsets.zw, vClipRadii.zw, data.shape);
// exclude the straight border part from the subtracted region
vec2 included_region = data.radii - data.widths - clip_relative_pos;
d_radii_b = max(d_radii_b, -min(included_region.x, included_region.y));
}
+#endif
float d_radii = max(d_radii_a, -d_radii_b);
d = max(d, d_radii);
color0 = evaluate_color_for_style_in_corner(
diff --git a/gfx/wr/webrender/res/cs_border_solid.glsl b/gfx/wr/webrender/res/cs_border_solid.glsl
--- a/gfx/wr/webrender/res/cs_border_solid.glsl
+++ b/gfx/wr/webrender/res/cs_border_solid.glsl
@@ -31,11 +31,13 @@
flat varying highp vec4 vClipCenter_Sign;
// An outer and inner elliptical radii for border
// corner clipping.
flat varying highp vec4 vClipRadii;
+#ifdef WR_FEATURE_SUPERELLIPSE
flat varying highp vec4 vClipOffsets;
+#endif
// Position, scale, and radii of horizontally and vertically adjacent corner clips.
flat varying highp vec4 vHorizontalClipCenter_Sign;
flat varying highp vec2 vHorizontalClipRadii;
flat varying highp vec4 vVerticalClipCenter_Sign;
@@ -74,11 +76,11 @@
void main(void) {
BorderInstanceGpuData data = fetch_gpu_data(aGpuDataAddress);
vGpuDataAddress.x = aGpuDataAddress;
int segment = aFlags & 0xff;
- bool do_aa = ((aFlags >> 24) & 0xf0) != 0;
+ bool do_aa = ((aFlags >> 28) & 0x1) != 0;
vec2 outer_scale = get_outer_corner_scale(segment);
vec2 size = data.rect.zw - data.rect.xy;
vec2 outer = outer_scale * size;
vec2 clip_sign = 1.0 - 2.0 * outer_scale;
@@ -100,23 +102,31 @@
vMixColors.x = mix_colors;
vPos = size * aPosition.xy;
vColor0 = data.color0;
vColor1 = data.color1;
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipCenter_Sign = vec4(outer + clip_sign * (data.radii + data.shape_offset), clip_sign);
+#else
+ vClipCenter_Sign = vec4(outer + clip_sign * data.radii, clip_sign);
+#endif
vClipRadii = vec4(data.radii, max(data.radii - data.widths, 0.0));
+#ifdef WR_FEATURE_SUPERELLIPSE
vClipOffsets = vec4(0.0);
+#endif
vColorLine = vec4(outer, data.widths.y * -clip_sign.y, data.widths.x * clip_sign.x);
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape != 1.0)
{
vec2 reference_radii = (data.radii == vec2(0.0)) ? vec2(0.0) : data.radii + data.inset;
vec4 contour1 = compute_contoured_superellipse(reference_radii, data.shape, data.inset);
vec4 contour2 = compute_contoured_superellipse(reference_radii, data.shape, data.inset + data.widths);
vClipOffsets = vec4(contour1.xy, contour2.xy);
vClipRadii = vec4(contour1.zw, contour2.zw);
}
+#endif
vec2 horizontal_clip_sign = vec2(-clip_sign.x, clip_sign.y);
vHorizontalClipCenter_Sign = vec4(aClipParams1.xy +
horizontal_clip_sign * aClipParams1.zw,
horizontal_clip_sign);
@@ -156,22 +166,26 @@
float d = -1.0;
if (in_clip_region) {
float d_radii_a;
float d_radii_b;
+#ifdef WR_FEATURE_SUPERELLIPSE
if (data.shape == 1.0) {
+#endif
d_radii_a = distance_to_ellipse(clip_relative_pos, vClipRadii.xy);
d_radii_b = distance_to_ellipse(clip_relative_pos, vClipRadii.zw);
+#ifdef WR_FEATURE_SUPERELLIPSE
} else {
clip_relative_pos = abs(clip_relative_pos) - data.shape_offset;
d_radii_a = distance_to_superellipse(clip_relative_pos - vClipOffsets.xy, vClipRadii.xy, data.shape);
d_radii_b = distance_to_superellipse(clip_relative_pos - vClipOffsets.zw, vClipRadii.zw, data.shape);
// exclude the straight border part from the subtracted region
vec2 included_region = data.radii - data.widths - clip_relative_pos;
d_radii_b = max(d_radii_b, -min(included_region.x, included_region.y));
}
+#endif
d = max(d_radii_a, -d_radii_b);
}
// And again for horizontally-adjacent corner
diff --git a/gfx/wr/webrender/src/border.rs b/gfx/wr/webrender/src/border.rs
--- a/gfx/wr/webrender/src/border.rs
+++ b/gfx/wr/webrender/src/border.rs
@@ -855,14 +855,17 @@
h_adjacent_corner_radius: DeviceSize,
v_adjacent_corner_outer: DevicePoint,
v_adjacent_corner_radius: DeviceSize,
gpu_buffer_builder: &mut GpuBufferBuilderF,
) {
+ let superellipse = shape != 1.0;
+
let base_flags = (segment as i32) |
((style0 as i32) << 8) |
((style1 as i32) << 16) |
- ((do_aa as i32) << 28);
+ ((do_aa as i32) << 28) |
+ ((superellipse as i32) << 29);
let instance_gpu_data = BorderInstanceGpuData {
local_rect: task_rect,
color0: color0.premultiplied(),
color1: color1.premultiplied(),
@@ -875,11 +878,11 @@
let base_instance = BorderInstance {
task_origin: DevicePoint::zero(),
flags: base_flags,
clip_params: [0.0; 8],
- gpu_data_address: instance_gpu_data.write(gpu_buffer_builder)
+ gpu_data_address: instance_gpu_data.write(superellipse, gpu_buffer_builder)
};
match segment {
BorderSegment::TopLeft |
BorderSegment::TopRight |
diff --git a/gfx/wr/webrender/src/gpu_types.rs b/gfx/wr/webrender/src/gpu_types.rs
--- a/gfx/wr/webrender/src/gpu_types.rs
+++ b/gfx/wr/webrender/src/gpu_types.rs
@@ -192,18 +192,21 @@
pub shape_offset: DeviceSize,
pub inset: DeviceSize,
}
impl BorderInstanceGpuData {
- pub fn write(&self, gpu_buffer_builder: &mut GpuBufferBuilderF) -> GpuBufferAddress {
- let mut writer = gpu_buffer_builder.write_blocks(6);
+ pub fn write(&self, superellipse: bool, gpu_buffer_builder: &mut GpuBufferBuilderF) -> GpuBufferAddress {
+ let block_count = if superellipse { 6 } else { 4 };
+ let mut writer = gpu_buffer_builder.write_blocks(block_count);
writer.push_one(self.local_rect);
writer.push_one(self.color0);
writer.push_one(self.color1);
writer.push_one([self.widths.width, self.widths.height, self.radius.width, self.radius.height]);
- writer.push_one([self.shape, self.shape_offset.width, self.shape_offset.height, 0.0]);
- writer.push_one([self.inset.width, self.inset.height, 0.0, 0.0]);
+ if superellipse {
+ writer.push_one([self.shape, self.shape_offset.width, self.shape_offset.height, 0.0]);
+ writer.push_one([self.inset.width, self.inset.height, 0.0, 0.0]);
+ }
writer.finish()
}
}
diff --git a/gfx/wr/webrender/src/render_target.rs b/gfx/wr/webrender/src/render_target.rs
--- a/gfx/wr/webrender/src/render_target.rs
+++ b/gfx/wr/webrender/src/render_target.rs
@@ -33,10 +33,11 @@
use crate::spatial_tree::SpatialNodeIndex;
const STYLE_SOLID: i32 = ((BorderStyle::Solid as i32) << 8) | ((BorderStyle::Solid as i32) << 16);
const STYLE_MASK: i32 = 0x00FF_FF00;
+const SUPERELLIPSE_MASK: i32 = 1 << 29;
/// A tag used to identify the output format of a `RenderTarget`.
#[derive(Debug, Copy, Clone, Eq, PartialEq, Hash)]
#[cfg_attr(feature = "capture", derive(Serialize))]
#[cfg_attr(feature = "replay", derive(Deserialize))]
@@ -163,10 +164,12 @@
pub clip_masks: ClipMaskInstanceList,
pub border_segments_complex: FrameVec<BorderInstance>,
pub border_segments_solid: FrameVec<BorderInstance>,
+ pub border_segments_complex_superellipse: FrameVec<BorderInstance>,
+ pub border_segments_solid_superellipse: FrameVec<BorderInstance>,
pub line_decorations: FrameVec<LineDecorationJob>,
// Clearing render targets has a fair amount of special cases.
// The general rules are:
// - Depth (for at least the used potion of the target) is always cleared if it
@@ -223,10 +226,12 @@
prim_instances: std::array::from_fn(|_| FastHashMap::default()),
prim_instances_with_scissor: FastHashMap::default(),
clip_masks: ClipMaskInstanceList::new(memory),
border_segments_complex: memory.new_vec(),
border_segments_solid: memory.new_vec(),
+ border_segments_complex_superellipse: memory.new_vec(),
+ border_segments_solid_superellipse: memory.new_vec(),
clears: memory.new_vec(),
line_decorations: memory.new_vec(),
}
}
@@ -547,14 +552,23 @@
let instances = task_info.instances.clone();
for mut instance in instances {
// TODO(gw): It may be better to store the task origin in
// the render task data instead of per instance.
instance.task_origin = task_origin;
+ let superellipse = (instance.flags & SUPERELLIPSE_MASK) != 0;
if instance.flags & STYLE_MASK == STYLE_SOLID {
- self.border_segments_solid.push(instance);
+ if superellipse {
+ self.border_segments_solid_superellipse.push(instance);
+ } else {
+ self.border_segments_solid.push(instance);
+ }
} else {
- self.border_segments_complex.push(instance);
+ if superellipse {
+ self.border_segments_complex_superellipse.push(instance);
+ } else {
+ self.border_segments_complex.push(instance);
+ }
}
}
}
RenderTaskKind::Image(..) |
RenderTaskKind::Cached(..) |
diff --git a/gfx/wr/webrender/src/renderer/mod.rs b/gfx/wr/webrender/src/renderer/mod.rs
--- a/gfx/wr/webrender/src/renderer/mod.rs
+++ b/gfx/wr/webrender/src/renderer/mod.rs
@@ -3394,11 +3394,13 @@
draw_target,
);
// Draw any borders for this target.
if !target.border_segments_solid.is_empty() ||
- !target.border_segments_complex.is_empty()
+ !target.border_segments_complex.is_empty() ||
+ !target.border_segments_solid_superellipse.is_empty() ||
+ !target.border_segments_complex_superellipse.is_empty()
{
let _timer = self.gpu_profiler.start_timer(GPU_TAG_CACHE_BORDER);
self.set_blend(true, FramebufferKind::Other);
self.set_blend_mode_premultiplied_alpha(FramebufferKind::Other);
@@ -3437,10 +3439,46 @@
&BatchTextures::empty(),
stats,
);
}
+ if !target.border_segments_solid_superellipse.is_empty() {
+ self.shaders.borrow_mut().cs_border_solid_superellipse().bind(
+ &mut self.device,
+ &projection,
+ None,
+ &mut self.renderer_errors,
+ &mut self.profile,
+ &mut self.command_log,
+ );
+
+ self.draw_instanced_batch(
+ &target.border_segments_solid_superellipse,
+ VertexArrayKind::Border,
+ &BatchTextures::empty(),
+ stats,
+ );
+ }
+
+ if !target.border_segments_complex_superellipse.is_empty() {
+ self.shaders.borrow_mut().cs_border_segment_superellipse().bind(
+ &mut self.device,
+ &projection,
+ None,
+ &mut self.renderer_errors,
+ &mut self.profile,
+ &mut self.command_log,
+ );
+
+ self.draw_instanced_batch(
+ &target.border_segments_complex_superellipse,
+ VertexArrayKind::Border,
+ &BatchTextures::empty(),
+ stats,
+ );
+ }
+
self.set_blend(false, FramebufferKind::Other);
}
// Draw any line decorations for this target.
if !target.line_decorations.is_empty() {
diff --git a/gfx/wr/webrender/src/renderer/shade.rs b/gfx/wr/webrender/src/renderer/shade.rs
--- a/gfx/wr/webrender/src/renderer/shade.rs
+++ b/gfx/wr/webrender/src/renderer/shade.rs
@@ -413,10 +413,12 @@
// draw intermediate results to cache targets. The results
// of these shaders are then used by the primitive shaders.
cs_blur_rgba8: ShaderHandle,
cs_border_segment: ShaderHandle,
cs_border_solid: ShaderHandle,
+ cs_border_segment_superellipse: ShaderHandle,
+ cs_border_solid_superellipse: ShaderHandle,
cs_scale: Vec<Option<ShaderHandle>>,
cs_line_decoration: ShaderHandle,
cs_svg_filter_node: ShaderHandle,
// The are "primitive shaders". These shaders draw and blend
@@ -774,19 +776,35 @@
"cs_border_solid",
&[],
&shader_list,
)?;
+ let cs_border_segment_superellipse = loader.create_shader(
+ ShaderKind::Cache(VertexArrayKind::Border),
+ "cs_border_segment",
+ &[SUPERELLIPSE_FEATURE],
+ &shader_list,
+ )?;
+
+ let cs_border_solid_superellipse = loader.create_shader(
+ ShaderKind::Cache(VertexArrayKind::Border),
+ "cs_border_solid",
+ &[SUPERELLIPSE_FEATURE],
+ &shader_list,
+ )?;
+
let composite = CompositorShaders::new(device, gl_type, &mut loader)?;
Ok(Shaders {
loader,
cs_blur_rgba8,
cs_border_segment,
- cs_line_decoration,
cs_border_solid,
+ cs_border_segment_superellipse,
+ cs_border_solid_superellipse,
+ cs_line_decoration,
cs_scale,
cs_svg_filter_node,
ps_text_run,
ps_text_run_dual_source,
ps_quad_textured,
@@ -979,10 +997,12 @@
}
pub fn cs_blur_rgba8(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_blur_rgba8) }
pub fn cs_border_segment(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_border_segment) }
pub fn cs_border_solid(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_border_solid) }
+ pub fn cs_border_segment_superellipse(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_border_segment_superellipse) }
+ pub fn cs_border_solid_superellipse(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_border_solid_superellipse) }
pub fn cs_line_decoration(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_line_decoration) }
pub fn cs_svg_filter_node(&mut self) -> &mut LazilyCompiledShader { self.loader.get(self.cs_svg_filter_node) }
pub fn ps_quad_textured(&mut self) -> &mut LazilyCompiledShader {
self.loader.get(self.ps_quad_textured)
}
diff --git a/gfx/wr/webrender_build/src/shader_features.rs b/gfx/wr/webrender_build/src/shader_features.rs
--- a/gfx/wr/webrender_build/src/shader_features.rs
+++ b/gfx/wr/webrender_build/src/shader_features.rs
@@ -69,17 +69,22 @@
shaders.insert("ps_quad_mask", vec![String::new(), "FAST_PATH".to_string(), "SUPERELLIPSE".to_string()]);
for name in &[
"cs_line_decoration",
- "cs_border_segment",
- "cs_border_solid",
"cs_svg_filter_node",
] {
shaders.insert(name, vec![String::new()]);
}
+ for name in &[
+ "cs_border_segment",
+ "cs_border_solid",
+ ] {
+ shaders.insert(name, vec![String::new(), "SUPERELLIPSE".to_string()]);
+ }
+
let mut base_prim_features = FeatureList::new();
let mut texture_types = vec!["TEXTURE_2D"];
if flags.contains(ShaderFeatureFlags::GL) {
texture_types.push("TEXTURE_RECT");

View File

@@ -1,15 +0,0 @@
diff --git a/devtools/client/responsive/test/browser/browser.toml b/devtools/client/responsive/test/browser/browser.toml
--- a/devtools/client/responsive/test/browser/browser.toml
+++ b/devtools/client/responsive/test/browser/browser.toml
@@ -275,7 +275,10 @@
skip-if = [
"os == 'win' && os_version == '11.26100' && arch == 'x86_64' && asan", # Bug 2016837
]
["browser_window_sizing.js"]
+skip-if = [
+ "os == 'win' && opt && standalone", # Bug 2063169
+]
["browser_zoom.js"]

View File

@@ -1,34 +0,0 @@
diff --git a/layout/painting/nsDisplayList.cpp b/layout/painting/nsDisplayList.cpp
--- a/layout/painting/nsDisplayList.cpp
+++ b/layout/painting/nsDisplayList.cpp
@@ -4606,12 +4606,12 @@
wr::LayoutRect deviceClipRect = wr::ToLayoutRect(clipRect);
nscoord spread = shadow.spread.ToAppUnits();
float spreadRadius = float(spread) / float(appUnitsPerDevPixel);
- wr::BorderRadius borderRadius{};
- wr::BorderRadius shadowRadius{};
+ wr::BorderRadius borderRadius = wr::EmptyBorderRadius();
+ wr::BorderRadius shadowRadius = wr::EmptyBorderRadius();
if (hasBorderRadius) {
borderRadius = wr::ToBorderRadius(borderRadii);
if (spreadRadius) {
auto shadowRadii = borderRadii;
shadowRadii.AdjustOutwards(
@@ -4727,12 +4727,12 @@
float(shadow.base.blur.ToAppUnits()) / float(appUnitsPerDevPixel);
nscoord spread = shadow.spread.ToAppUnits();
float spreadRadius = spread / float(appUnitsPerDevPixel);
- wr::BorderRadius borderRadius{};
- wr::BorderRadius shadowRadius{};
+ wr::BorderRadius borderRadius = wr::EmptyBorderRadius();
+ wr::BorderRadius shadowRadius = wr::EmptyBorderRadius();
if (hasBorderRadius) {
borderRadius = wr::ToBorderRadius(innerRadii);
if (spreadRadius) {
RectCornerRadii shadowRadii = innerRadii;
shadowRadii.AdjustInwards(

View File

@@ -1,53 +0,0 @@
diff --git a/gfx/wr/webrender/res/ps_quad_mask.glsl b/gfx/wr/webrender/res/ps_quad_mask.glsl
--- a/gfx/wr/webrender/res/ps_quad_mask.glsl
+++ b/gfx/wr/webrender/res/ps_quad_mask.glsl
@@ -318,12 +318,30 @@
#endif
vec4 clip_dist =
mix(clip_rect, clip_rect.zwxy, lessThan(local_step, vec2(0.0)).xyxy)
- local_pos0.xyxy;
+
+ // Half-width, in local units, of the band around an edge over which
+ // distance_aa() produces partial coverage.
+ float aa_band = 0.5 * recip(aa_range);
+ // An axis the span does not step along has the same distance to its two
+ // edges for every pixel of the span, so the inside/outside test below
+ // cannot resolve an edge that runs parallel to the span and coverage ends
+ // up quantized to whole spans. Grow the rect by the AA band so that a span
+ // landing inside the band counts as inside, which leaves the corner
+ // selection below unchanged, and remember that the span is only partially
+ // covered so the opaque run can be dropped further down.
+ // `inset` is the distance from the span to the nearer of an axis' two
+ // edges, positive when the span is between them.
+ vec2 inset = min(-clip_dist.xy, clip_dist.zw);
+ bvec2 flat_axis = equal(local_step, vec2(0.0));
+ bvec2 partial = lessThan(inset, vec2(aa_band));
+ bool aa_span = (flat_axis.x && partial.x) || (flat_axis.y && partial.y);
+
clip_dist =
- mix(1.0e6 * step(0.0, clip_dist),
+ mix(1.0e6 * step(0.0, clip_dist - vec4(aa_band, aa_band, -aa_band, -aa_band)),
clip_dist * recip(local_step).xyxy,
notEqual(local_step, vec2(0.0)).xyxy);
float opaque_start = max(clip_dist.x, clip_dist.y);
float opaque_end = min(clip_dist.z, clip_dist.w);
@@ -404,10 +422,16 @@
aa_margin = max(aa_margin - max(aa_start - aa_end, 0.0), 0.0);
aa_start -= aa_margin;
aa_end += aa_margin;
+ if (aa_span) {
+ // No pixel of the span is fully covered, so collapse the opaque run and
+ // let the anti-aliased runs on either side of it cover the whole span.
+ opaque_end = min(opaque_end, opaque_start);
+ }
+
ivec4 steps = ivec4(clamp(
swgl_SpanLength -
swgl_StepSize *
vec4(floor(aa_start), ceil(opaque_start), floor(opaque_end), ceil(aa_end)),
0.0, swgl_SpanLength));

View File

@@ -1,13 +1,7 @@
diff --git a/toolkit/modules/subprocess/subprocess_shared_unix.js b/toolkit/modules/subprocess/subprocess_shared_unix.js diff --git a/toolkit/modules/subprocess/subprocess_shared_unix.js b/toolkit/modules/subprocess/subprocess_shared_unix.js
--- a/toolkit/modules/subprocess/subprocess_shared_unix.js --- a/toolkit/modules/subprocess/subprocess_shared_unix.js
+++ b/toolkit/modules/subprocess/subprocess_shared_unix.js +++ b/toolkit/modules/subprocess/subprocess_shared_unix.js
@@ -52,16 +52,17 @@ @@ -57,11 +57,11 @@
close: [ctypes.default_abi, ctypes.int, ctypes.int /* fildes */],
dup: [ctypes.default_abi, ctypes.int, ctypes.int],
+ // Variadic arguments use a different calling convention on Apple silicon.
fcntl: [ fcntl: [
ctypes.default_abi, ctypes.default_abi,
ctypes.int, ctypes.int,
@@ -64,79 +58,62 @@ diff --git a/toolkit/modules/subprocess/test/xpcshell/test_subprocess_pipe_flags
new file mode 100644 new file mode 100644
--- /dev/null --- /dev/null
+++ b/toolkit/modules/subprocess/test/xpcshell/test_subprocess_pipe_flags.js +++ b/toolkit/modules/subprocess/test/xpcshell/test_subprocess_pipe_flags.js
@@ -0,0 +1,73 @@ @@ -0,0 +1,56 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public +/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this + * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+ +
+"use strict"; +"use strict";
+ +
+// fcntl commands for reading the flags set by the subprocess modules. The
+// values are the same on Linux and macOS but are not exposed by
+// ChromeUtils.getLibcConstants().
+const F_GETFD = 1;
+const F_GETFL = 3;
+
+add_task(async function test_subprocess_pipe_flags() { +add_task(async function test_subprocess_pipe_flags() {
+ const { Subprocess, getSubprocessImplForTest } = ChromeUtils.importESModule( + const { getSubprocessImplForTest } = ChromeUtils.importESModule(
+ "resource://gre/modules/Subprocess.sys.mjs" + "resource://gre/modules/Subprocess.sys.mjs"
+ ); + );
+ const { ctypes } = ChromeUtils.importESModule( + const { libc } = ChromeUtils.importESModule(
+ "resource://gre/modules/ctypes.sys.mjs" + "resource://gre/modules/subprocess/subprocess_unix.sys.mjs"
+ ); + );
+ const constants = ChromeUtils.getLibcConstants(); + const { FD_CLOEXEC, O_NONBLOCK } = ChromeUtils.getLibcConstants();
+ const library = ctypes.open("a.out"); +
+ const fcntl = library.declare( + const worker = getSubprocessImplForTest().Process.getWorker();
+ "fcntl", + equal(
+ ctypes.default_abi, + libc.fcntl(worker.signalFd, F_GETFD),
+ ctypes.int, + FD_CLOEXEC,
+ ctypes.int, + "The main-thread signal pipe has exactly FD_CLOEXEC set"
+ ctypes.int,
+ "..."
+ ); + );
+ // Darwin's fcntl commands for reading descriptor and file status flags.
+ const F_GETFD = 1;
+ const F_GETFL = 3;
+ let process;
+ +
+ try { + const proc = await Subprocess.call({
+ const worker = getSubprocessImplForTest().Process.getWorker(); + command: await Subprocess.pathSearch("cat"),
+ Assert.equal( + stderr: "pipe",
+ fcntl(worker.signalFd, F_GETFD), + });
+ constants.FD_CLOEXEC, + const fds = await worker.call("getFds", [proc.id]);
+ "The main-thread signal pipe has exactly FD_CLOEXEC set" + ok(
+ fds.every(Number.isInteger),
+ "The worker owns the stdin, stdout and stderr pipes"
+ );
+ for (const fd of fds) {
+ equal(
+ libc.fcntl(fd, F_GETFD),
+ FD_CLOEXEC,
+ "Worker pipes have exactly FD_CLOEXEC set"
+ ); + );
+ + equal(
+ process = await Subprocess.call({ + libc.fcntl(fd, F_GETFL) & O_NONBLOCK,
+ command: "/bin/cat", + O_NONBLOCK,
+ stderr: "pipe", + "Worker pipes are nonblocking"
+ disclaim: true,
+ });
+ const fds = await worker.call("getFds", [process.id]);
+ // Only inspect the descriptors while the worker owns them and cat is alive.
+ // Exact flags also rule out an unintended FD_CLOFORK on macOS.
+ for (const fd of fds) {
+ Assert.equal(
+ fcntl(fd, F_GETFD),
+ constants.FD_CLOEXEC,
+ "Worker pipes have exactly FD_CLOEXEC set"
+ );
+ Assert.equal(
+ fcntl(fd, F_GETFL) & constants.O_NONBLOCK,
+ constants.O_NONBLOCK,
+ "Worker pipes are nonblocking"
+ );
+ }
+
+ const output = process.stdout.readString(5);
+ await process.stdin.write("hello");
+ Assert.equal(await output, "hello", "The subprocess pipes transfer data");
+ await process.stdin.close();
+ Assert.equal(
+ (await process.wait()).exitCode,
+ 0,
+ "The subprocess exits cleanly"
+ ); + );
+ } finally {
+ if (process && process.exitCode === null) {
+ await process.kill();
+ }
+ library.close();
+ } + }
+
+ const output = proc.stdout.readString(5);
+ await proc.stdin.write("hello");
+ equal(await output, "hello", "The subprocess pipes transfer data");
+ await proc.stdin.close();
+ equal((await proc.wait()).exitCode, 0, "The subprocess exits cleanly");
+}); +});
diff --git a/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml b/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml diff --git a/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml b/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml
--- a/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml --- a/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml
@@ -148,7 +125,7 @@ diff --git a/toolkit/modules/subprocess/test/xpcshell/xpcshell.toml b/toolkit/mo
requesttimeoutfactor = 2 # Slow on Windows requesttimeoutfactor = 2 # Slow on Windows
+["test_subprocess_pipe_flags.js"] +["test_subprocess_pipe_flags.js"]
+run-if = ["os == 'mac'"] +skip-if = ["os == 'win'"]
+ +
["test_subprocess_polling.js"] ["test_subprocess_polling.js"]

View File

@@ -1,9 +1,8 @@
diff --git a/toolkit/themes/shared/global-shared.css b/toolkit/themes/shared/global-shared.css diff --git a/toolkit/themes/shared/global-shared.css b/toolkit/themes/shared/global-shared.css
--- a/toolkit/themes/shared/global-shared.css --- a/toolkit/themes/shared/global-shared.css
+++ b/toolkit/themes/shared/global-shared.css +++ b/toolkit/themes/shared/global-shared.css
@@ -80,11 +80,10 @@ @@ -80,10 +80,9 @@
background-color: transparent; background-color: transparent;
--panel-background: transparent;
--panel-box-shadow: none; --panel-box-shadow: none;
--panel-border-color: transparent; --panel-border-color: transparent;
--panel-box-shadow-margin: 0px; --panel-box-shadow-margin: 0px;

View File

@@ -46,27 +46,11 @@
" jsonLengthHint,": " lengthHint: jsonLengthHint," " jsonLengthHint,": " lengthHint: jsonLengthHint,"
} }
}, },
{
"type": "phabricator",
"id": "D320897",
"name": "Bug 2011236"
},
{ {
"type": "phabricator", "type": "phabricator",
"id": "D321446", "id": "D321446",
"name": "Issue 14710" "name": "Issue 14710"
}, },
{
"type": "local",
// Sorts before bug_2063169/ on purpose: D319869 builds on the border
// shader hunks in here, and surfer applies patches in path order.
"path": "firefox/bug_2047627_corner_shape_borders.patch"
},
{
"type": "phabricator",
"ids": ["D319577", "D319796", "D319869", "D320211", "D320568", "D321282"],
"name": "Bug 2063169"
},
{ {
"type": "local", "type": "local",
"path": "firefox/override_cert_checks_temp.patch" "path": "firefox/override_cert_checks_temp.patch"

View File

@@ -1,8 +1,8 @@
diff --git a/layout/painting/nsImageRenderer.cpp b/layout/painting/nsImageRenderer.cpp diff --git a/layout/painting/nsImageRenderer.cpp b/layout/painting/nsImageRenderer.cpp
index 6e464b48c90174b8954aad8a79bae30a7a30cbc9..9ea9a4963ceae679f092e014ac24a0d24fb106ce 100644 index 7ddc4f7e259272e7b905f44aff7316c1ba540c22..277a92e5d10e6a04b12373854ffe6791d562215e 100644
--- a/layout/painting/nsImageRenderer.cpp --- a/layout/painting/nsImageRenderer.cpp
+++ b/layout/painting/nsImageRenderer.cpp +++ b/layout/painting/nsImageRenderer.cpp
@@ -90,7 +90,7 @@ static already_AddRefed<imgIContainer> GetSymbolicIconImage(nsAtom* aName, @@ -95,7 +95,7 @@ static already_AddRefed<imgIContainer> GetSymbolicIconImage(nsAtom* aName,
if (NS_WARN_IF(!XRE_IsParentProcess())) { if (NS_WARN_IF(!XRE_IsParentProcess())) {
return nullptr; return nullptr;
} }
@@ -11,7 +11,7 @@ index 6e464b48c90174b8954aad8a79bae30a7a30cbc9..9ea9a4963ceae679f092e014ac24a0d2
auto key = std::make_tuple(aName, aScale, fg); auto key = std::make_tuple(aName, aScale, fg);
auto* cache = aFrame->GetOrCreateDeletableProperty(SymbolicImageCacheProp()); auto* cache = aFrame->GetOrCreateDeletableProperty(SymbolicImageCacheProp());
auto lookup = cache->Lookup(key); auto lookup = cache->Lookup(key);
@@ -575,7 +575,7 @@ ImgDrawResult nsImageRenderer::Draw(nsPresContext* aPresContext, @@ -580,7 +580,7 @@ ImgDrawResult nsImageRenderer::Draw(nsPresContext* aPresContext,
} }
case StyleImage::Tag::Gradient: { case StyleImage::Tag::Gradient: {
nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create( nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create(
@@ -20,7 +20,7 @@ index 6e464b48c90174b8954aad8a79bae30a7a30cbc9..9ea9a4963ceae679f092e014ac24a0d2
renderer.Paint(*ctx, aDest, aFill, aRepeatSize, aSrc, aDirtyRect, renderer.Paint(*ctx, aDest, aFill, aRepeatSize, aSrc, aDirtyRect,
aOpacity); aOpacity);
@@ -652,7 +652,7 @@ ImgDrawResult nsImageRenderer::BuildWebRenderDisplayItems( @@ -657,7 +657,7 @@ ImgDrawResult nsImageRenderer::BuildWebRenderDisplayItems(
switch (mType) { switch (mType) {
case StyleImage::Tag::Gradient: { case StyleImage::Tag::Gradient: {
nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create( nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create(
@@ -29,16 +29,16 @@ index 6e464b48c90174b8954aad8a79bae30a7a30cbc9..9ea9a4963ceae679f092e014ac24a0d2
renderer.BuildWebRenderDisplayItems(aBuilder, aSc, aDest, aFill, renderer.BuildWebRenderDisplayItems(aBuilder, aSc, aDest, aFill,
aRepeatSize, aSrc, aRepeatSize, aSrc,
@@ -678,6 +678,8 @@ ImgDrawResult nsImageRenderer::BuildWebRenderDisplayItems( @@ -679,6 +679,8 @@ ImgDrawResult nsImageRenderer::BuildWebRenderDisplayItems(
nsPresContext::AppUnitsToIntCSSPixels(aDest.height)}; }
SVGImageContext svgContext(Some(destCSSSize)); SVGImageContext svgContext(Some(CSSSize::FromAppUnits(aDest.Size())));
+ SVGImageContext::MaybeStoreZenBoosts(svgContext, + SVGImageContext::MaybeStoreZenBoosts(svgContext,
+ *mForFrame->PresContext()); + *mForFrame->PresContext());
Maybe<ImageIntRegion> region; Maybe<ImageIntRegion> region;
const int32_t appUnitsPerDevPixel = aPresContext->AppUnitsPerDevPixel(); const int32_t appUnitsPerDevPixel = aPresContext->AppUnitsPerDevPixel();
@@ -1092,7 +1094,7 @@ ImgDrawResult nsImageRenderer::DrawShapeImage(nsPresContext* aPresContext, @@ -1098,7 +1100,7 @@ ImgDrawResult nsImageRenderer::DrawShapeImage(nsPresContext* aPresContext,
if (mImage->IsGradient()) { if (mImage->IsGradient()) {
nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create( nsCSSGradientRenderer renderer = nsCSSGradientRenderer::Create(

View File

@@ -1,8 +1,8 @@
diff --git a/layout/svg/SVGGradientFrame.cpp b/layout/svg/SVGGradientFrame.cpp diff --git a/layout/svg/SVGGradientFrame.cpp b/layout/svg/SVGGradientFrame.cpp
index b0d38b0fab01797328af0b1f1f48af8fb5eebe4d..953feffdc96143dc2d8f8e57f8bb4a6aeb33f0c5 100644 index eebcced86ec1e9010b761d5df4a92684dde44009..4dc018a73a979f50ac7842e4a3f3fcf9d0071b56 100644
--- a/layout/svg/SVGGradientFrame.cpp --- a/layout/svg/SVGGradientFrame.cpp
+++ b/layout/svg/SVGGradientFrame.cpp +++ b/layout/svg/SVGGradientFrame.cpp
@@ -229,8 +229,9 @@ class MOZ_STACK_CLASS SVGColorStopInterpolator @@ -228,8 +228,9 @@ class MOZ_STACK_CLASS SVGColorStopInterpolator
SVGColorStopInterpolator( SVGColorStopInterpolator(
gfxPattern* aGradient, const nsTArray<ColorStop>& aStops, gfxPattern* aGradient, const nsTArray<ColorStop>& aStops,
const StyleColorInterpolationMethod& aStyleColorInterpolationMethod, const StyleColorInterpolationMethod& aStyleColorInterpolationMethod,
@@ -14,8 +14,8 @@ index b0d38b0fab01797328af0b1f1f48af8fb5eebe4d..953feffdc96143dc2d8f8e57f8bb4a6a
mGradient(aGradient) {} mGradient(aGradient) {}
void CreateStop(float aPosition, DeviceColor aColor) { void CreateStop(float aPosition, DeviceColor aColor) {
@@ -270,7 +271,8 @@ already_AddRefed<gfxPattern> SVGGradientFrame::GetPaintServerPattern( @@ -269,7 +270,8 @@ already_AddRefed<gfxPattern> SVGGradientFrame::GetPaintServerPattern(
if (nStops == 1 || GradientVectorLengthIsZero()) { if (nStops == 1 || GradientVectorLengthIsZero(gradientUnits)) {
// The gradient paints a single colour, using the stop-color of the last // The gradient paints a single colour, using the stop-color of the last
// gradient step if there are more than one. // gradient step if there are more than one.
- return MakeAndAddRef<gfxPattern>(ToDeviceColor(stops.LastElement().mColor)); - return MakeAndAddRef<gfxPattern>(ToDeviceColor(stops.LastElement().mColor));

View File

@@ -1,5 +1,5 @@
diff --git a/layout/svg/SVGImageContext.h b/layout/svg/SVGImageContext.h diff --git a/layout/svg/SVGImageContext.h b/layout/svg/SVGImageContext.h
index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd6178f9e3 100644 index 63f3c4926cfdb8b12e9e4a38016fc66f50cf3129..5ba3f2c07f521905a086ee6eea87975d5a3441ec 100644
--- a/layout/svg/SVGImageContext.h --- a/layout/svg/SVGImageContext.h
+++ b/layout/svg/SVGImageContext.h +++ b/layout/svg/SVGImageContext.h
@@ -6,6 +6,7 @@ @@ -6,6 +6,7 @@
@@ -7,10 +7,10 @@ index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd
#include "Units.h" #include "Units.h"
+#include "nsColor.h" +#include "nsColor.h"
#include "mozilla/Casting.h"
#include "mozilla/Maybe.h" #include "mozilla/Maybe.h"
#include "mozilla/SVGContextPaint.h" #include "mozilla/SVGContextPaint.h"
#include "mozilla/SVGPreserveAspectRatio.h" @@ -64,6 +65,11 @@ class SVGImageContext {
@@ -63,6 +64,11 @@ class SVGImageContext {
nsISVGPaintContext* aPaintContext, nsISVGPaintContext* aPaintContext,
imgIContainer* aImgContainer); imgIContainer* aImgContainer);
@@ -19,10 +19,10 @@ index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd
+ static void MaybeStoreZenBoosts(SVGImageContext& aContext, + static void MaybeStoreZenBoosts(SVGImageContext& aContext,
+ const nsPresContext& aPresContext); + const nsPresContext& aPresContext);
+ +
const Maybe<CSSIntSize>& GetViewportSize() const { return mViewportSize; } const Maybe<CSSSize>& GetViewportSize() const { return mViewportSize; }
void SetViewportSize(const Maybe<CSSIntSize>& aSize) { void SetViewportSize(const Maybe<CSSSize>& aSize) { mViewportSize = aSize; }
@@ -75,6 +81,21 @@ class SVGImageContext { @@ -74,6 +80,21 @@ class SVGImageContext {
mColorScheme = aScheme; mColorScheme = aScheme;
} }
@@ -44,7 +44,7 @@ index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd
const Maybe<SVGPreserveAspectRatio>& GetPreserveAspectRatio() const { const Maybe<SVGPreserveAspectRatio>& GetPreserveAspectRatio() const {
return mPreserveAspectRatio; return mPreserveAspectRatio;
} }
@@ -110,7 +131,11 @@ class SVGImageContext { @@ -109,7 +130,11 @@ class SVGImageContext {
return contextPaintIsEqual && mViewportSize == aOther.mViewportSize && return contextPaintIsEqual && mViewportSize == aOther.mViewportSize &&
mPreserveAspectRatio == aOther.mPreserveAspectRatio && mPreserveAspectRatio == aOther.mPreserveAspectRatio &&
mColorScheme == aOther.mColorScheme && mColorScheme == aOther.mColorScheme &&
@@ -56,8 +56,8 @@ index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd
+ mZenBoostsInverted == aOther.mZenBoostsInverted; + mZenBoostsInverted == aOther.mZenBoostsInverted;
} }
bool operator!=(const SVGImageContext&) const = default; PLDHashNumber Hash() const {
@@ -123,7 +148,8 @@ class SVGImageContext { @@ -120,7 +145,8 @@ class SVGImageContext {
return AddToHash(hash, mViewportSize.map(HashSize).valueOr(0), return AddToHash(hash, mViewportSize.map(HashSize).valueOr(0),
mPreserveAspectRatio.map(HashPAR).valueOr(0), mPreserveAspectRatio.map(HashPAR).valueOr(0),
mColorScheme.map(HashColorScheme).valueOr(0), mColorScheme.map(HashColorScheme).valueOr(0),
@@ -67,7 +67,7 @@ index ad833c7c2ee6a4c4984efdb0d59e3576c2d1bc19..36864a34badc0cbfe44d6295798622fd
} }
private: private:
@@ -156,6 +182,9 @@ class SVGImageContext { @@ -154,6 +180,9 @@ class SVGImageContext {
Maybe<SVGPreserveAspectRatio> mPreserveAspectRatio; Maybe<SVGPreserveAspectRatio> mPreserveAspectRatio;
Maybe<ColorScheme> mColorScheme; Maybe<ColorScheme> mColorScheme;
StyleLinkParameters mLinkParameters; StyleLinkParameters mLinkParameters;

View File

@@ -1,29 +0,0 @@
diff --git a/toolkit/content/widgets/panel-list/panel-list.mjs b/toolkit/content/widgets/panel-list/panel-list.mjs
index 68ad2fafc8b31dfff541cf8381d9b9533e376d1c..fa62fec6bfb33338091fc06d3736fb76fd5c47c4 100644
--- a/toolkit/content/widgets/panel-list/panel-list.mjs
+++ b/toolkit/content/widgets/panel-list/panel-list.mjs
@@ -223,7 +223,12 @@ export class PanelList extends HTMLElement {
this.setAttribute("showing", "true");
// Tell the host element to hide any overflow in case the panel extends off
// the page before the alignment is set.
- hostElement.style.overflow = "hidden";
+ const hostHidesOverflow = !getComputedStyle(hostElement)
+ .overflow.split(" ")
+ .includes("visible");
+ if (!hostHidesOverflow) {
+ hostElement.style.overflow = "hidden";
+ }
// Wait for a layout flush, then find the bounds.
let {
@@ -344,7 +349,9 @@ export class PanelList extends HTMLElement {
// Set the alignments and show the panel.
this.setAttribute("align", align);
this.setAttribute("valign", valign);
- hostElement.style.overflow = "";
+ if (!hostHidesOverflow) {
+ hostElement.style.overflow = "";
+ }
// Decide positioning based on where this panel will be rendered
const offsetParentIsBody =
this.supportsPopover() ||

View File

@@ -1,5 +1,5 @@
diff --git a/toolkit/themes/shared/design-system/dist/tokens-shared.css b/toolkit/themes/shared/design-system/dist/tokens-shared.css diff --git a/toolkit/themes/shared/design-system/dist/tokens-shared.css b/toolkit/themes/shared/design-system/dist/tokens-shared.css
index 63c641f560d4c0ce06b40a652ca99d1c48cd6941..39c81e773a442870763396e68fb57bd336e3625a 100644 index b0f8fa146de335c53e73d46853f45dda9b15cc73..1b7592c0e9ca12fd9d1f8a555633fd39c2efb537 100644
--- a/toolkit/themes/shared/design-system/dist/tokens-shared.css --- a/toolkit/themes/shared/design-system/dist/tokens-shared.css
+++ b/toolkit/themes/shared/design-system/dist/tokens-shared.css +++ b/toolkit/themes/shared/design-system/dist/tokens-shared.css
@@ -7,6 +7,8 @@ @@ -7,6 +7,8 @@
@@ -8,9 +8,9 @@ index 63c641f560d4c0ce06b40a652ca99d1c48cd6941..39c81e773a442870763396e68fb57bd3
+@import url("chrome://browser/content/zen-styles/zen-theme.css"); +@import url("chrome://browser/content/zen-styles/zen-theme.css");
+ +
@layer tokens-foundation { :root,
:root, :host(.anonymous-content-host) {
:host(.anonymous-content-host) { @layer tokens-foundation {
@@ -28,10 +30,10 @@ @@ -28,10 +30,10 @@
--border-color-selected: var(--color-accent-primary); --border-color-selected: var(--color-accent-primary);
--border-color-transparent: transparent; --border-color-transparent: transparent;

View File

@@ -1,16 +1,17 @@
diff --git a/widget/cocoa/nsCocoaWindow.mm b/widget/cocoa/nsCocoaWindow.mm diff --git a/widget/cocoa/nsCocoaWindow.mm b/widget/cocoa/nsCocoaWindow.mm
index 2efd02e4a92433fd29bbfdb707aa81cfec45031e..3b763c3927f07e529c826f8e4f62bc80a324b247 100644 index 887e4c052d5dd2b73d4c2059463529fb4b09dcab..36da18e19018b1b216576c299f938e75093546d3 100644
--- a/widget/cocoa/nsCocoaWindow.mm --- a/widget/cocoa/nsCocoaWindow.mm
+++ b/widget/cocoa/nsCocoaWindow.mm +++ b/widget/cocoa/nsCocoaWindow.mm
@@ -86,6 +86,7 @@ @@ -86,6 +86,8 @@
#include "mozilla/StaticPrefs_gfx.h" #include "mozilla/StaticPrefs_gfx.h"
#include "mozilla/StaticPrefs_ui.h" #include "mozilla/StaticPrefs_ui.h"
#include "mozilla/StaticPrefs_widget.h" #include "mozilla/StaticPrefs_widget.h"
+#include "mozilla/StaticPrefs_zen.h" +#include "mozilla/StaticPrefs_zen.h"
+#include "mozilla/nsZenDragAndDrop.h"
#include "mozilla/WritingModes.h" #include "mozilla/WritingModes.h"
#include "mozilla/dom/Document.h" #include "mozilla/dom/Document.h"
#include "mozilla/layers/CompositorBridgeChild.h" #include "mozilla/layers/CompositorBridgeChild.h"
@@ -1332,6 +1333,110 @@ - (NSRect)_opaqueRectForWindowMoveWhenInTitlebar { @@ -1332,6 +1334,110 @@ - (NSRect)_opaqueRectForWindowMoveWhenInTitlebar {
} }
@end @end
@@ -121,7 +122,28 @@ index 2efd02e4a92433fd29bbfdb707aa81cfec45031e..3b763c3927f07e529c826f8e4f62bc80
void nsCocoaWindow::UpdateWindowDraggingRegion( void nsCocoaWindow::UpdateWindowDraggingRegion(
const LayoutDeviceIntRegion& aRegion) { const LayoutDeviceIntRegion& aRegion) {
// mChildView returns YES from mouseDownCanMoveWindow, so we need to put // mChildView returns YES from mouseDownCanMoveWindow, so we need to put
@@ -4919,6 +5024,10 @@ - (BOOL)wantsBestResolutionOpenGLSurface { @@ -3858,7 +3964,9 @@ - (NSDragOperation)draggingEntered:(id<NSDraggingInfo>)sender {
// NSDraggingDestination
- (NSDragOperation)draggingUpdated:(id<NSDraggingInfo>)sender {
MOZ_LOG(sCocoaLog, LogLevel::Info, ("ChildView draggingUpdated: entered\n"));
- return [self doDragAction:eDragOver sender:sender];
+ NSDragOperation operation = [self doDragAction:eDragOver sender:sender];
+ zen::PrepareDropLanding(sender);
+ return operation;
}
// NSDraggingDestination
@@ -3874,6 +3982,9 @@ - (void)draggingExited:(id<NSDraggingInfo>)sender {
- (BOOL)performDragOperation:(id<NSDraggingInfo>)sender {
nsAutoRetainCocoaObject kungFuDeathGrip(self);
BOOL handled = [self doDragAction:eDrop sender:sender] != NSDragOperationNone;
+ if (handled) {
+ zen::LandDrop(sender);
+ }
NS_IF_RELEASE(mDragService);
return handled;
}
@@ -4919,6 +5030,10 @@ - (BOOL)wantsBestResolutionOpenGLSurface {
nsCocoaWindow::~nsCocoaWindow() { nsCocoaWindow::~nsCocoaWindow() {
NS_OBJC_BEGIN_TRY_IGNORE_BLOCK; NS_OBJC_BEGIN_TRY_IGNORE_BLOCK;

View File

@@ -1,5 +1,5 @@
diff --git a/widget/cocoa/nsDragService.mm b/widget/cocoa/nsDragService.mm diff --git a/widget/cocoa/nsDragService.mm b/widget/cocoa/nsDragService.mm
index 340a9ad81c5cb23bb7e5f927d11d5cffdde7ce70..32fc707ccfa56fa8c307860868d092c4a9050419 100644 index 340a9ad81c5cb23bb7e5f927d11d5cffdde7ce70..ba597ba4373ba3ace7455ce0859f2339349ffc06 100644
--- a/widget/cocoa/nsDragService.mm --- a/widget/cocoa/nsDragService.mm
+++ b/widget/cocoa/nsDragService.mm +++ b/widget/cocoa/nsDragService.mm
@@ -10,6 +10,7 @@ @@ -10,6 +10,7 @@
@@ -45,3 +45,112 @@ index 340a9ad81c5cb23bb7e5f927d11d5cffdde7ce70..32fc707ccfa56fa8c307860868d092c4
#endif #endif
src += 4; src += 4;
dest += 4; dest += 4;
@@ -249,12 +254,44 @@
[[[NSDraggingItem alloc] initWithPasteboardWriter:pbItem] autorelease];
[dragItem setDraggingFrame:localDragRect contents:image];
+ NSMutableArray* dragItems = [NSMutableArray arrayWithObject:dragItem];
+ auto zenDragAndDrop = zen::nsZenDragAndDrop::GetZenDragAndDropInstance();
+ const nsTArray<nsCOMPtr<nsINode>> noExtraImages;
+ @try {
+ for (const auto& extraImageNode :
+ zenDragAndDrop ? zenDragAndDrop->DragImages() : noExtraImages) {
+ nsCOMPtr<nsINode> mainImage = std::move(mImage);
+ mImage = extraImageNode;
+ NSPoint extraPoint;
+ NSImage* extraImage = ConstructDragImage(mSourceNode, aRegion, &extraPoint);
+ mImage = std::move(mainImage);
+ if (!extraImage) {
+ continue;
+ }
+ NSRect extraRect = extraImage.alignmentRect;
+ extraRect.origin.x = extraPoint.x;
+ extraRect.origin.y = extraPoint.y - extraRect.size.height;
+ NSPasteboardItem* extraPbItem = [[NSPasteboardItem new] autorelease];
+ [extraPbItem setData:[NSData data]
+ forType:[UTIHelper stringFromPboardType:kMozWildcardPboardType]];
+ NSDraggingItem* extraItem = [[[NSDraggingItem alloc]
+ initWithPasteboardWriter:extraPbItem] autorelease];
+ [extraItem setDraggingFrame:extraRect contents:extraImage];
+ [dragItems addObject:extraItem];
+ }
+ } @catch (NSException* e) {
+ dragItems = [NSMutableArray arrayWithObject:dragItem];
+ }
+
OpenDragPopup();
mNSDraggingSession = [mNativeDragView
- beginDraggingSessionWithItems:[NSArray arrayWithObject:dragItem]
+ beginDraggingSessionWithItems:dragItems
event:mNativeDragEvent
source:mNativeDragView];
+ if (dragItems.count > 1) {
+ mNSDraggingSession.draggingFormation = NSDraggingFormationStack;
+ }
mNSDraggingSession.animatesToStartingPositionsOnCancelOrFail =
!mDataTransfer || mDataTransfer->MozShowFailAnimation();
@@ -455,29 +492,44 @@
}
if (pc) {
+ nsPoint pt = LayoutDevicePixel::ToAppUnits(
+ devPoint, pc->DeviceContext()->AppUnitsPerDevPixel());
+ CSSIntPoint screenPoint =
+ CSSIntPoint(nsPresContext::AppUnitsToIntCSSPixels(pt.x),
+ nsPresContext::AppUnitsToIntCSSPixels(pt.y));
+
+ NSMutableArray* images = [NSMutableArray array];
+ NSMutableArray* rects = [NSMutableArray array];
+ auto render = [&]() {
+ LayoutDeviceIntRect newRect;
+ NSImage* image =
+ ConstructDragImage(mSourceNode, Nothing(), screenPoint, &newRect);
+ [images addObject:image ? (id)image : (id)[NSNull null]];
+ [rects addObject:[NSValue valueWithRect:
+ image ? nsCocoaUtils::GeckoRectToCocoaRectDevPix(
+ newRect, scaleFactor)
+ : NSZeroRect]];
+ };
+ render();
+ if (auto zenDragAndDrop = zen::nsZenDragAndDrop::GetZenDragAndDropInstance()) {
+ for (const auto& extraImageNode : zenDragAndDrop->DragImages()) {
+ nsCOMPtr<nsINode> mainImage = std::move(mImage);
+ mImage = extraImageNode;
+ render();
+ mImage = std::move(mainImage);
+ }
+ }
+
void (^changeImageBlock)(NSDraggingItem*, NSInteger, BOOL*) = ^(
NSDraggingItem* draggingItem, NSInteger idx, BOOL* stop) {
- // We never add more than one item right now, but check just in case.
- if (idx > 0) {
+ if ((NSUInteger)idx >= images.count || images[idx] == [NSNull null]) {
return;
}
-
- nsPoint pt = LayoutDevicePixel::ToAppUnits(
- devPoint, pc->DeviceContext()->AppUnitsPerDevPixel());
- CSSIntPoint screenPoint =
- CSSIntPoint(nsPresContext::AppUnitsToIntCSSPixels(pt.x),
- nsPresContext::AppUnitsToIntCSSPixels(pt.y));
-
- // Create a new image; if one isn't returned don't change the current
- // one.
- LayoutDeviceIntRect newRect;
- NSImage* image =
- ConstructDragImage(mSourceNode, Nothing(), screenPoint, &newRect);
- if (image) {
- NSRect draggingRect =
- nsCocoaUtils::GeckoRectToCocoaRectDevPix(newRect, scaleFactor);
- [draggingItem setDraggingFrame:draggingRect contents:image];
+ NSRect frame = [rects[idx] rectValue];
+ if (idx > 0) {
+ frame.origin = draggingItem.draggingFrame.origin;
}
+ [draggingItem setDraggingFrame:frame contents:images[idx]];
};
[mNSDraggingSession

View File

@@ -990,14 +990,7 @@ window.gZenVerticalTabsManager = {
}); });
ChromeUtils.defineLazyGetter(this, "hidesTabsToolbar", () => { ChromeUtils.defineLazyGetter(this, "hidesTabsToolbar", () => {
return ( return document.documentElement.hasAttribute("popup-window");
document.documentElement
.getAttribute("chromehidden")
?.includes("toolbar") ||
document.documentElement
.getAttribute("chromehidden")
?.includes("menubar")
);
}); });
XPCOMUtils.defineLazyPreferenceGetter( XPCOMUtils.defineLazyPreferenceGetter(
@@ -1587,9 +1580,7 @@ window.gZenVerticalTabsManager = {
return; return;
} }
gURLBar._initCopyCutController(); gURLBar._initCopyCutController();
gURLBar._initPasteAndGo(); gURLBar.updatePlaceholder();
gURLBar._initStripOnShare();
gURLBar._updatePlaceholderFromDefaultEngine();
}, },
rebuildAreas() { rebuildAreas() {

View File

@@ -25,9 +25,12 @@
[fxastatus='signedin'] #fxa-avatar-image, [fxastatus='signedin'] #fxa-avatar-image,
#profile-icon-image, #profile-icon-image,
.appMenu-update-banner-pulse-ring, .appMenu-update-banner-pulse-ring,
.urlbarView-favicon,
:is(#appMenu-zoomReduce-button2, #appMenu-zoomEnlarge-button2) > .toolbarbutton-icon, :is(#appMenu-zoomReduce-button2, #appMenu-zoomEnlarge-button2) > .toolbarbutton-icon,
.color-swatches .userContext-icon, .color-swatches .userContext-icon,
.reusable-relay-masks > button, .reusable-relay-masks > button,
.radio-check { .radio-check,
#zen-loading-progress-bar,
#statuspanel-label {
corner-shape: round; corner-shape: round;
} }

View File

@@ -3,7 +3,7 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this * License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. * file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/ */
:root:not([inDOMFullscreen="true"]):not([chromehidden~="location"]):not([chromehidden~="toolbar"]) { :root:not([inDOMFullscreen="true"]):not([popup-window]) {
& #tabbrowser-tabbox #tabbrowser-tabpanels .browserSidebarContainer { & #tabbrowser-tabbox #tabbrowser-tabpanels .browserSidebarContainer {
--zen-transparent-browser-background: light-dark(rgba(255, 255, 255, 0.6), rgba(255, 255, 255, 0.1)); --zen-transparent-browser-background: light-dark(rgba(255, 255, 255, 0.6), rgba(255, 255, 255, 0.1));
overflow: clip; overflow: clip;

View File

@@ -20,7 +20,7 @@ body,
position: inherit; position: inherit;
} }
:root:is([inDOMFullscreen="true"], [chromehidden~="location"], [chromehidden~="toolbar"]) { :root:is([inDOMFullscreen="true"], [popup-window]) {
#navigator-toolbox, #navigator-toolbox,
#zen-sidebar-splitter { #zen-sidebar-splitter {
visibility: collapse; visibility: collapse;
@@ -61,7 +61,7 @@ body,
background: var(--zen-main-browser-background); background: var(--zen-main-browser-background);
opacity: var(--zen-background-opacity); opacity: var(--zen-background-opacity);
transition: 0s; transition: 0s;
background-blend-mode: screen; background-blend-mode: lighten;
} }
&:is(.zen-toolbar-background) { &:is(.zen-toolbar-background) {
@@ -74,7 +74,7 @@ body,
background: var(--zen-main-browser-background-old); background: var(--zen-main-browser-background-old);
opacity: calc(1 - var(--zen-background-opacity)); opacity: calc(1 - var(--zen-background-opacity));
transition: 0s; transition: 0s;
background-blend-mode: screen; background-blend-mode: lighten;
} }
&:is(.zen-toolbar-background) { &:is(.zen-toolbar-background) {
@@ -170,7 +170,7 @@ body,
min-width: 1px; min-width: 1px;
} }
:root:not([inDOMFullscreen="true"]):not([chromehidden~="location"]):not([chromehidden~="toolbar"]) { :root:not([inDOMFullscreen="true"]):not([popup-window]) {
& #zen-tabbox-wrapper { & #zen-tabbox-wrapper {
margin: var(--zen-element-separation); margin: var(--zen-element-separation);
margin-top: 0; margin-top: 0;

View File

@@ -17,7 +17,7 @@
} }
.urlbar { .urlbar {
--urlbarview-separator-color: light-dark(hsl(0, 0%, 80%), hsl(0, 0%, 20%)); --urlbarview-separator-color: light-dark(hsl(0, 0%, 85%), hsl(0, 0%, 15%));
--urlbarview-background-color-hover: var(--toolbarbutton-background-color-hover); --urlbarview-background-color-hover: var(--toolbarbutton-background-color-hover);
border-radius: calc(var(--toolbarbutton-border-radius) - 2px); border-radius: calc(var(--toolbarbutton-border-radius) - 2px);
--urlbarView-results-padding: 10px !important; --urlbarView-results-padding: 10px !important;
@@ -284,7 +284,7 @@
background-color: var(--zen-urlbar-background-transparent, var(--zen-urlbar-background-base)) !important; background-color: var(--zen-urlbar-background-transparent, var(--zen-urlbar-background-base)) !important;
box-shadow: 0 30px 140px -15px light-dark(rgba(0, 0, 0, 0.8), rgba(0, 0, 0, 0.6)) !important; box-shadow: 0 30px 140px -15px light-dark(rgba(0, 0, 0, 0.8), rgba(0, 0, 0, 0.6)) !important;
backdrop-filter: none !important; backdrop-filter: none !important;
outline: 0.5px solid light-dark(rgba(0, 0, 0, 0.2), rgba(255, 255, 255, 0.2)) !important; outline: 0.5px solid light-dark(rgba(0, 0, 0, 0.2), rgba(255, 255, 255, 0.1)) !important;
outline-offset: var(--zen-urlbar-outline-offset) !important; outline-offset: var(--zen-urlbar-outline-offset) !important;
/* stylelint-disable-next-line media-query-no-invalid */ /* stylelint-disable-next-line media-query-no-invalid */
@@ -295,7 +295,7 @@
&, &,
.urlbar-background { .urlbar-background {
border-radius: 12px !important; border-radius: 14px !important;
} }
&[breakout-extend][animate-searchmode="true"]::before { &[breakout-extend][animate-searchmode="true"]::before {

View File

@@ -32,6 +32,7 @@ panel[type="arrow"]:not(#feature-callout) {
@media (-moz-platform: linux) or ((-moz-platform: windows) and (not (-moz-windows-mica-popups))) { @media (-moz-platform: linux) or ((-moz-platform: windows) and (not (-moz-windows-mica-popups))) {
&::part(content) { &::part(content) {
/* stylelint-disable-next-line property-no-unknown */
corner-shape: round; corner-shape: round;
border-radius: calc(var(--panel-border-radius) / var(--zen-squircle-value)); border-radius: calc(var(--panel-border-radius) / var(--zen-squircle-value));
} }

View File

@@ -303,7 +303,7 @@
} }
} }
#main-window[windowtype="navigator:browser"]:not([chromehidden~='toolbar']) { #main-window[windowtype="navigator:browser"]:not([popup-window]) {
min-height: 495px !important; min-height: 495px !important;
@media (-moz-windows-mica) or (-moz-platform: macos) or ((-moz-platform: linux) and @media (-moz-windows-mica) or (-moz-platform: macos) or ((-moz-platform: linux) and

View File

@@ -7,7 +7,8 @@ import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs";
const lazy = {}; const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionStore:
"moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
}); });
class nsZenUIMigration { class nsZenUIMigration {

View File

@@ -160,7 +160,7 @@ document.addEventListener(
} }
case "cmd_zenDuplicateTab": { case "cmd_zenDuplicateTab": {
const selectedTabs = gBrowser.selectedTabs; const selectedTabs = gBrowser.selectedTabs;
let insertAt = selectedTabs.at(-1)._tPos + 1; let insertAt = selectedTabs.at(-1).index + 1;
for (const tab of selectedTabs) { for (const tab of selectedTabs) {
gBrowser.duplicateTab(tab, true, { tabIndex: insertAt++ }); gBrowser.duplicateTab(tab, true, { tabIndex: insertAt++ });
} }

View File

@@ -109,7 +109,7 @@
if (AppConstants.platform == "macosx") { if (AppConstants.platform == "macosx") {
const targetRadius = window.matchMedia("(-moz-mac-tahoe-theme)") const targetRadius = window.matchMedia("(-moz-mac-tahoe-theme)")
.matches .matches
? 12 ? 11
: 10; : 10;
document.documentElement.style.setProperty( document.documentElement.style.setProperty(
"--zen-border-radius", "--zen-border-radius",

View File

@@ -165,9 +165,7 @@ window.gZenCompactModeManager = {
}, },
get shouldBeCompact() { get shouldBeCompact() {
return !document.documentElement return !document.documentElement.hasAttribute("popup-window");
.getAttribute("chromehidden")
?.includes("toolbar");
}, },
set preference(value) { set preference(value) {
@@ -543,7 +541,7 @@ window.gZenCompactModeManager = {
ease: "easeIn", ease: "easeIn",
type: "spring", type: "spring",
bounce: 0, bounce: 0,
duration: 0.12, duration: 0.1,
} }
) )
.then(() => { .then(() => {
@@ -599,7 +597,7 @@ window.gZenCompactModeManager = {
ease: "easeOut", ease: "easeOut",
type: "spring", type: "spring",
bounce: 0, bounce: 0,
duration: 0.12, duration: 0.1,
} }
) )
.then(() => { .then(() => {
@@ -864,7 +862,6 @@ window.gZenCompactModeManager = {
"supress-primary-adjustment" "supress-primary-adjustment"
) === "true" && ) === "true" &&
gZenVerticalTabsManager._hasSetSingleToolbar) || gZenVerticalTabsManager._hasSetSingleToolbar) ||
this._hasHoveredUrlbar ||
this._ignoreNextHover || this._ignoreNextHover ||
(event.type === "dragleave" && (event.type === "dragleave" &&
event.explicitOriginalTarget !== target && event.explicitOriginalTarget !== target &&
@@ -877,7 +874,10 @@ window.gZenCompactModeManager = {
return; return;
} }
if (this.hoverableElements[i].keepHoverDuration) { if (
this.hoverableElements[i].keepHoverDuration &&
!this._hasHoveredUrlbar
) {
this.flashElement( this.flashElement(
target, target,
this.hoverableElements[i].keepHoverDuration, this.hoverableElements[i].keepHoverDuration,

View File

@@ -27,7 +27,7 @@
* - <tab-group> label element wrapper (.tab-group-label-container) * - <tab-group> label element wrapper (.tab-group-label-container)
* *
* When working with tab strip items, if you need logical information, you * When working with tab strip items, if you need logical information, you
* can get it directly, e.g. `element.elementIndex` or `element._tPos`. If * can get it directly, e.g. `element.elementIndex` or `element._index`. If
* you need spatial information like position or dimensions, then you should * you need spatial information like position or dimensions, then you should
* call this function. For example, `elementToMove(element).getBoundingClientRect()` * call this function. For example, `elementToMove(element).getBoundingClientRect()`
* or `elementToMove(element).style.top`. * or `elementToMove(element).style.top`.
@@ -69,6 +69,7 @@
#changeSpaceTimer = null; #changeSpaceTimer = null;
#isAnimatingTabMove = false; #isAnimatingTabMove = false;
#firstHapticFeedbackPlayed = false; #firstHapticFeedbackPlayed = false;
#dragImageEssential = false;
#dragOverSplit = {}; #dragOverSplit = {};
@@ -152,10 +153,14 @@
); );
const dragImage = this.#createDragImageForTabs(draggingTabs); const dragImage = this.#createDragImageForTabs(draggingTabs);
this.originalDragImageArgs = [dragImage, offsetX, offsetY]; this.originalDragImageArgs = [dragImage, offsetX, offsetY];
this.#dragImageEssential = tab.hasAttribute("zen-essential");
dt.setDragImage(...this.originalDragImageArgs); dt.setDragImage(...this.originalDragImageArgs);
if (tab.hasAttribute("zen-essential")) { if (tab.hasAttribute("zen-essential")) {
tab.style.visibility = "hidden"; tab.style.visibility = "hidden";
} }
this._dropLandingArmed =
!args[0]?.fromTabList && this.getDropEffectForTabDrag(event) == "move";
this.ZenDragAndDropService.armDropLanding(this._dropLandingArmed);
} }
#createDragImageForTabs(movingTabs) { #createDragImageForTabs(movingTabs) {
@@ -165,62 +170,79 @@
const tabRect = window.windowUtils.getBoundsWithoutFlushing( const tabRect = window.windowUtils.getBoundsWithoutFlushing(
movingTabs[0] movingTabs[0]
); );
const native = AppConstants.platform == "macosx";
const stacked = native ? 1 : Math.min(movingTabs.length, 3);
const wrapper = this.#createDragImageWrapper(periphery, tabRect, stacked);
for (let i = 0; i < stacked; i++) {
this.#appendDragImageClone(wrapper, movingTabs[i], tabRect, i);
}
this._dragImageTabs = native ? [...movingTabs] : [movingTabs[0]];
this._extraDragImages = [];
if (native) {
for (const tab of movingTabs.slice(1)) {
const extra = this.#createDragImageWrapper(periphery, tabRect, 1);
this.#appendDragImageClone(extra, tab, tabRect, 0);
this.ZenDragAndDropService.addDragImage(extra);
this._extraDragImages.push(extra);
}
} else {
this.#maybeCreateDragImageDot(movingTabs, wrapper);
}
this._tempDragImageParent = wrapper;
return wrapper;
}
#createDragImageWrapper(periphery, tabRect, count) {
const wrapper = document.createElement("div"); const wrapper = document.createElement("div");
let movingTabsCount = Math.min(movingTabs.length, 3);
wrapper.style.width = tabRect.width + "px"; wrapper.style.width = tabRect.width + "px";
wrapper.style.height = tabRect.height * movingTabsCount + "px"; wrapper.style.height = tabRect.height * count + "px";
wrapper.style.position = "fixed"; wrapper.style.position = "fixed";
wrapper.style.top = "-9999px"; wrapper.style.top = "-9999px";
periphery.appendChild(wrapper); periphery.appendChild(wrapper);
for (let i = 0; i < movingTabsCount; i++) { return wrapper;
const tab = movingTabs[i]; }
const tabClone = tab.cloneNode(true);
if (tab.hasAttribute("zen-essential")) { #appendDragImageClone(wrapper, tab, tabRect, i) {
const rect = tab.getBoundingClientRect(); const tabClone = tab.cloneNode(true);
tabClone.style.minWidth = tabClone.style.maxWidth = `${rect.width}px`; if (tab.hasAttribute("zen-essential")) {
tabClone.style.minHeight = const rect = tab.getBoundingClientRect();
tabClone.style.maxHeight = `${rect.height}px`; tabClone.style.minWidth = tabClone.style.maxWidth = `${rect.width}px`;
if (tabClone.hasAttribute("visuallyselected")) { tabClone.style.minHeight =
tabClone.style.transform = "translate(-50%, -50%)"; tabClone.style.maxHeight = `${rect.height}px`;
} if (tabClone.hasAttribute("visuallyselected")) {
} else if (AppConstants.platform == "win" && !tab.isZenFolder) { tabClone.style.transform = "translate(-50%, -50%)";
// On windows, the shell applies its own translucency to the drag
// image which we can't control, so force some extra contrast for
// the tab to be more visible. This is a hacky workaround.
tabClone.style.colorScheme = "light";
tabClone.style.setProperty("--tab-selected-textcolor", "black");
} }
if (i > 0) { } else if (AppConstants.platform == "win" && !tab.isZenFolder) {
tabClone.style.transform = `translate(${i * 4}px, -${i * (tabRect.height - 4)}px)`; // On windows, the shell applies its own translucency to the drag
tabClone.style.opacity = "0.2"; // image which we can't control, so force some extra contrast for
tabClone.style.zIndex = `${-i}`; // the tab to be more visible. This is a hacky workaround.
} tabClone.style.colorScheme = "light";
tabClone.setAttribute("drag-image", "true"); tabClone.style.setProperty("--tab-selected-textcolor", "black");
wrapper.appendChild(tabClone); }
if (isTab(tabClone)) { if (i > 0) {
// We need to limit the label content so the drag image doesn't grow too big. tabClone.style.transform = `translate(${i * 4}px, -${i * (tabRect.height - 4)}px)`;
const label = tabClone.textLabel; tabClone.style.opacity = "0.2";
const tabLabelParentWidth = tabClone.style.zIndex = `${-i}`;
label.parentElement.getBoundingClientRect().width; }
label.textContent = label.textContent.slice( tabClone.setAttribute("drag-image", "true");
0, wrapper.appendChild(tabClone);
Math.floor(tabLabelParentWidth / 6) if (isTab(tabClone)) {
); // We need to limit the label content so the drag image doesn't grow too big.
} else if ( const label = tabClone.textLabel;
gBrowser.isTabGroup(tabClone) && const tabLabelParentWidth =
tabClone.hasAttribute("split-view-group") label.parentElement.getBoundingClientRect().width;
) { label.textContent = label.textContent.slice(
let tabs = tab.tabs; 0,
for (let j = 0; j < tabs.length; j++) { Math.floor(tabLabelParentWidth / 6)
const tabInGroup = tabs[j]; );
const tabInGroupClone = tabInGroup.cloneNode(true); } else if (
tabClone.appendChild(tabInGroupClone); gBrowser.isTabGroup(tabClone) &&
} tabClone.hasAttribute("split-view-group")
) {
for (const tabInGroup of tab.tabs) {
tabClone.appendChild(tabInGroup.cloneNode(true));
} }
} }
this.#maybeCreateDragImageDot(movingTabs, wrapper);
this._tempDragImageParent = wrapper;
return wrapper;
} }
#maybeCreateDragImageDot(movingTabs, wrapper) { #maybeCreateDragImageDot(movingTabs, wrapper) {
@@ -255,7 +277,10 @@
return; return;
} }
return this.#animateVerticalPinnedGridDragOver(event); return this.#animateVerticalPinnedGridDragOver(event);
} else if (this._fakeEssentialTab) { } else if (
this.#dragImageEssential &&
!event.target.closest("zen-essentials-promo")
) {
this.#makeDragImageNonEssential(event); this.#makeDragImageNonEssential(event);
} }
let dragData = draggedTab._dragData; let dragData = draggedTab._dragData;
@@ -557,7 +582,7 @@
dropElementSize dropElementSize
); );
moveOverThreshold = gBrowser._tabGroupsEnabled moveOverThreshold = gBrowser.tabGroupsEnabled
? Services.prefs.getIntPref( ? Services.prefs.getIntPref(
"browser.tabs.dragDrop.moveOverThresholdPercent" "browser.tabs.dragDrop.moveOverThresholdPercent"
) / 100 ) / 100
@@ -882,6 +907,8 @@
this.#dragOverSplit.fakeTab = element; this.#dragOverSplit.fakeTab = element;
this.#dragOverSplit.canDrop = true; this.#dragOverSplit.canDrop = true;
// A drop into the split takes the drag image away at once.
this.ZenDragAndDropService.armDropLanding(false);
} }
_clearDragOverSplit() { _clearDragOverSplit() {
@@ -889,6 +916,9 @@
clearTimeout(this.#dragOverSplit.timer); clearTimeout(this.#dragOverSplit.timer);
} }
this.#dragOverSplit.fakeTab?.remove(); this.#dragOverSplit.fakeTab?.remove();
if (this.#dragOverSplit.canDrop && this._dropLandingArmed) {
this.ZenDragAndDropService.armDropLanding(true);
}
this.#dragOverSplit.timer = null; this.#dragOverSplit.timer = null;
this.#dragOverSplit.fakeTab = null; this.#dragOverSplit.fakeTab = null;
@@ -902,9 +932,54 @@
} }
this.#isOutOfWindow = false; this.#isOutOfWindow = false;
const dt = event.dataTransfer; const dt = event.dataTransfer;
for (const extra of this._extraDragImages ?? []) {
this.#restoreExtraDragImage(extra);
}
dt.updateDragImage(...this.originalDragImageArgs); dt.updateDragImage(...this.originalDragImageArgs);
} }
/**
* Out of the window, every dragged tab becomes the window. Each further
* drag item gets a copy of the preview the drag image shows.
*
* @param {Element} extra - The image of a further tab
* @param {HTMLCanvasElement} canvas - The window preview
*/
#previewExtraDragImage(extra, canvas) {
if (extra._tabContents) {
return;
}
extra._tabContents = {
nodes: [...extra.childNodes],
width: extra.style.width,
height: extra.style.height,
};
const copy = document.createElementNS(
"http://www.w3.org/1999/xhtml",
"canvas"
);
copy.width = canvas.width;
copy.height = canvas.height;
copy.getContext("2d").drawImage(canvas, 0, 0);
copy.style.width = copy.style.height = "100%";
copy.style.borderRadius = canvas.style.borderRadius;
copy.style.border = canvas.style.border;
extra.style.width = this._browserDragImageWrapper.style.width;
extra.style.height = this._browserDragImageWrapper.style.height;
extra.replaceChildren(copy);
}
#restoreExtraDragImage(extra) {
const contents = extra._tabContents;
if (!contents) {
return;
}
delete extra._tabContents;
extra.style.width = contents.width;
extra.style.height = contents.height;
extra.replaceChildren(...contents.nodes);
}
handle_windowDragLeave(event) { handle_windowDragLeave(event) {
// If relatedTarget exists, then we are still in the window // If relatedTarget exists, then we are still in the window
if ( if (
@@ -930,8 +1005,6 @@
this.clearDragOverVisuals(); this.clearDragOverVisuals();
this.clearSpaceSwitchTimer(); this.clearSpaceSwitchTimer();
const dt = event.dataTransfer; const dt = event.dataTransfer;
let dragData = draggedTab._dragData;
let movingTabs = dragData.movingTabs;
if (!this._browserDragImageWrapper) { if (!this._browserDragImageWrapper) {
const wrappingDiv = document.createXULElement("vbox"); const wrappingDiv = document.createXULElement("vbox");
canvas.style.borderRadius = "8px"; canvas.style.borderRadius = "8px";
@@ -939,11 +1012,13 @@
wrappingDiv.style.width = 200 + "px"; wrappingDiv.style.width = 200 + "px";
wrappingDiv.style.height = 130 + "px"; wrappingDiv.style.height = 130 + "px";
wrappingDiv.style.position = "relative"; wrappingDiv.style.position = "relative";
this.#maybeCreateDragImageDot(movingTabs, wrappingDiv);
wrappingDiv.appendChild(canvas); wrappingDiv.appendChild(canvas);
this._browserDragImageWrapper = wrappingDiv; this._browserDragImageWrapper = wrappingDiv;
document.documentElement.appendChild(wrappingDiv); document.documentElement.appendChild(wrappingDiv);
} }
for (const extra of this._extraDragImages ?? []) {
this.#previewExtraDragImage(extra, canvas);
}
dt.updateDragImage( dt.updateDragImage(
this._browserDragImageWrapper, this._browserDragImageWrapper,
this.originalDragImageArgs[1], this.originalDragImageArgs[1],
@@ -970,11 +1045,70 @@
} }
this.clearSpaceSwitchTimer(); this.clearSpaceSwitchTimer();
gZenFolders.highlightGroupOnDragOver(null); gZenFolders.highlightGroupOnDragOver(null);
const toSplit = !!this.#dragOverSplit.canDrop;
const placesBefore = new Map(
this.#draggedElements(event).map(element => [
element,
this.#placeOf(element),
])
);
super.handle_drop(event); super.handle_drop(event);
this.#maybeClearVerticalPinnedGridDragOver(); this.#maybeClearVerticalPinnedGridDragOver();
this.#handle_dropSwitchSpace(event); this.#handle_dropSwitchSpace(event);
this.#handle_dropCreateSplit(event); this.#handle_dropCreateSplit(event);
this._clearDragOverSplit(); this._clearDragOverSplit();
if (!toSplit) {
this.#landDragImage(event, placesBefore);
}
}
/**
* @param {DragEvent} event
* @returns {Element[]} The elements of the dragged tabs, in the order of
* their drag images, when they are this window's
*/
#draggedElements(event) {
const draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0);
if (draggedTab?.documentGlobal !== window) {
return [];
}
return (this._dragImageTabs ?? [draggedTab]).map(elementToMove);
}
#placeOf(element) {
return `${element.screenX},${element.screenY}`;
}
/**
* Has the drag image land on the dropped tab rather than vanish. The OS
* slides it onto the tab's new place and ends the drag once it is there,
* which is when the tab shows again. Only macOS does so.
*
* @param {DragEvent} event - The drop
* @param {Map<Element, string>} placesBefore - Where each dragged element
* was before the drop.
*/
#landDragImage(event, placesBefore) {
// The drop is done, so its indicator goes before the image lands.
this.clearDragOverVisuals();
if (gReduceMotion) {
return;
}
const landing = [];
for (const element of this.#draggedElements(event)) {
const { width, height } = element.getBoundingClientRect();
this.ZenDragAndDropService.addDropLandingRect(
Math.round(element.screenX),
Math.round(element.screenY),
Math.round(width),
Math.round(height)
);
if (placesBefore.get(element) !== this.#placeOf(element)) {
element.style.visibility = "hidden";
landing.push(element);
}
}
this._landingElements = landing;
} }
#handle_dropSwitchSpace(event) { #handle_dropSwitchSpace(event) {
@@ -1031,6 +1165,7 @@
); );
} }
// eslint-disable-next-line complexity
handle_drop_transition(dropElement, draggedTab, movingTabs, dropBefore) { handle_drop_transition(dropElement, draggedTab, movingTabs, dropBefore) {
if ( if (
dropElement?.hasAttribute("zen-empty-tab") && dropElement?.hasAttribute("zen-empty-tab") &&
@@ -1056,6 +1191,7 @@
try { try {
if ( if (
this.#isAnimatingTabMove || this.#isAnimatingTabMove ||
this.#dragOverSplit.canDrop ||
!gZenStartup.isReady || !gZenStartup.isReady ||
gReduceMotion || gReduceMotion ||
!dropElement || !dropElement ||
@@ -1175,6 +1311,10 @@
let ownerGlobal = draggedTab?.documentGlobal; let ownerGlobal = draggedTab?.documentGlobal;
draggedTab.style.visibility = ""; draggedTab.style.visibility = "";
let thisFromGlobal = ownerGlobal?.gBrowser.tabContainer.tabDragAndDrop; let thisFromGlobal = ownerGlobal?.gBrowser.tabContainer.tabDragAndDrop;
for (const element of thisFromGlobal._landingElements ?? []) {
element.style.visibility = "";
}
delete thisFromGlobal._landingElements;
let currentEssenialContainer = let currentEssenialContainer =
ownerGlobal.gZenWorkspaces.getCurrentEssentialsContainer(); ownerGlobal.gZenWorkspaces.getCurrentEssentialsContainer();
if (currentEssenialContainer?.essentialsPromo) { if (currentEssenialContainer?.essentialsPromo) {
@@ -1194,6 +1334,7 @@
thisFromGlobal._clearDragOverSplit(); thisFromGlobal._clearDragOverSplit();
this.#maybeClearVerticalPinnedGridDragOver(); this.#maybeClearVerticalPinnedGridDragOver();
thisFromGlobal.originalDragImageArgs = []; thisFromGlobal.originalDragImageArgs = [];
thisFromGlobal._dropLandingArmed = false;
this.#firstHapticFeedbackPlayed = false; this.#firstHapticFeedbackPlayed = false;
window.removeEventListener( window.removeEventListener(
"dragenter", "dragenter",
@@ -1211,6 +1352,11 @@
thisFromGlobal._tempDragImageParent.remove(); thisFromGlobal._tempDragImageParent.remove();
delete thisFromGlobal._tempDragImageParent; delete thisFromGlobal._tempDragImageParent;
} }
for (const extra of thisFromGlobal._extraDragImages ?? []) {
extra.remove();
}
delete thisFromGlobal._extraDragImages;
delete thisFromGlobal._dragImageTabs;
delete ownerGlobal.gZenCompactModeManager._isTabBeingDragged; delete ownerGlobal.gZenCompactModeManager._isTabBeingDragged;
if (dt.dropEffect !== "move") { if (dt.dropEffect !== "move") {
ownerGlobal.gZenCompactModeManager._clearAllHoverStates(); ownerGlobal.gZenCompactModeManager._clearAllHoverStates();
@@ -1494,6 +1640,7 @@
switch (essentialsPromoStatus) { switch (essentialsPromoStatus) {
case "shown": case "shown":
case "created": case "created":
this.#makeDragImageEssential(event);
return; return;
} }
@@ -1781,53 +1928,131 @@
#makeDragImageEssential(event) { #makeDragImageEssential(event) {
const dt = event.dataTransfer; const dt = event.dataTransfer;
const draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0); const draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0);
if (draggedTab.hasAttribute("zen-essential")) { if (this.#dragImageEssential) {
return; return;
} }
this.#dragImageEssential = true;
const dragData = draggedTab._dragData; const dragData = draggedTab._dragData;
const [wrapper] = this.originalDragImageArgs; const wasEssential = draggedTab.hasAttribute("zen-essential");
const tab = wrapper.firstElementChild; const draggedTabRect = this.#essentialTileRect(event, draggedTab);
tab.setAttribute("zen-essential", "true"); for (const { wrapper, tab } of this.#dragImageClones(draggedTab)) {
tab.setAttribute("pinned", "true"); tab.setAttribute("zen-essential", "true");
tab.setAttribute("selected", "true"); tab.setAttribute("pinned", "true");
const draggedTabRect = window.windowUtils.getBoundsWithoutFlushing( tab.setAttribute("selected", "true");
this._fakeEssentialTab tab.style.minWidth =
tab.style.maxWidth =
wrapper.style.width =
draggedTabRect.width + "px";
tab.style.minHeight =
tab.style.maxHeight =
wrapper.style.height =
draggedTabRect.height + "px";
if (wasEssential) {
// Back to how the drag began.
tab.style.transform = "";
continue;
}
const offsetY = dragData.offsetY;
const offsetX = dragData.offsetX;
// Apply a transform translate to the tab in order to center it within the drag image
tab.style.transform = `translate(${(54 - offsetX) / 2}px, ${(50 - offsetY) / 2}px)`;
gZenPinnedTabManager.setEssentialTabIcon(tab);
}
if (wasEssential) {
dt.updateDragImage(...this.originalDragImageArgs);
} else {
dt.updateDragImage(this.originalDragImageArgs[0], -16, -16);
}
}
/**
* Every drag image with the tab it shows. The drag image itself and,
* on macOS, one for each further dragged tab.
*
* @param {Element} draggedTab
* @returns {{wrapper: Element, tab: Element, source: Element}[]} Each
* image's wrapper, the clone in it, and the tab it was cloned from
*/
#dragImageClones(draggedTab) {
const wrappers = [
this.originalDragImageArgs[0],
...(this._extraDragImages ?? []),
];
const sources = this._dragImageTabs ?? [draggedTab];
return wrappers.map((wrapper, i) => ({
wrapper,
tab: wrapper.firstElementChild,
source: sources[i] ?? draggedTab,
}));
}
/**
* The size the dragged tab takes as an essential. Its own when it is
* one, the tile made for it in the grid, or, with only the promo shown,
* a tile as the grid would lay it out.
*
* @param {DragEvent} event
* @param {Element} draggedTab
* @returns {{width: number, height: number}}
*/
#essentialTileRect(event, draggedTab) {
const bounds = element =>
window.windowUtils.getBoundsWithoutFlushing(element);
if (draggedTab.hasAttribute("zen-essential")) {
return bounds(draggedTab);
}
if (this._fakeEssentialTab?.isConnected) {
return bounds(this._fakeEssentialTab);
}
const container =
event.target.closest(".zen-essentials-container") ??
gZenWorkspaces.getCurrentEssentialsContainer();
const height = parseFloat(
getComputedStyle(container).getPropertyValue("--tab-min-height")
); );
tab.style.minWidth = return {
tab.style.maxWidth = width: Math.max(bounds(container).width * 0.237, height + 4),
wrapper.style.width = height,
draggedTabRect.width + "px"; };
tab.style.minHeight =
tab.style.maxHeight =
wrapper.style.height =
draggedTabRect.height + "px";
const offsetY = dragData.offsetY;
const offsetX = dragData.offsetX;
// Apply a transform translate to the tab in order to center it within the drag image
tab.style.transform = `translate(${(54 - offsetX) / 2}px, ${(50 - offsetY) / 2}px)`;
gZenPinnedTabManager.setEssentialTabIcon(tab);
dt.updateDragImage(wrapper, -16, -16);
} }
#makeDragImageNonEssential(event) { #makeDragImageNonEssential(event) {
const dt = event.dataTransfer; const dt = event.dataTransfer;
const draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0); const draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0);
if (draggedTab.hasAttribute("zen-essential")) { if (!this.#dragImageEssential) {
return; return;
} }
const wrapper = this.originalDragImageArgs[0]; this.#dragImageEssential = false;
const tab = wrapper.firstElementChild; // An essential takes the size of a row in the strip, as any tab there.
tab.style.setProperty("transition", "none", "important"); let model = draggedTab;
tab.removeAttribute("zen-essential"); if (draggedTab.hasAttribute("zen-essential")) {
tab.removeAttribute("pinned"); model =
tab.style.minWidth = tab.style.maxWidth = ""; this._tabbrowserTabs.ariaFocusableItems.find(
tab.style.minHeight = tab.style.maxHeight = ""; item => isTab(item) && !item.hasAttribute("zen-essential")
tab.style.transform = ""; ) ?? draggedTab;
const rect = window.windowUtils.getBoundsWithoutFlushing(draggedTab); }
wrapper.style.width = rect.width + "px"; const rect = window.windowUtils.getBoundsWithoutFlushing(model);
wrapper.style.height = rect.height + "px"; const clones = this.#dragImageClones(draggedTab);
for (const { wrapper, tab, source } of clones) {
tab.style.setProperty("transition", "none", "important");
tab.removeAttribute("zen-essential");
tab.removeAttribute("pinned");
tab.style.minWidth = tab.style.maxWidth = "";
tab.style.minHeight = tab.style.maxHeight = "";
tab.style.transform = "";
wrapper.style.width = rect.width + "px";
wrapper.style.height = rect.height + "px";
if (source.hasAttribute("zen-essential") && tab.textLabel) {
tab.textLabel.textContent = source.label.slice(
0,
Math.floor(rect.width / 6)
);
}
}
setTimeout(() => { setTimeout(() => {
tab.style.transition = ""; for (const { tab } of clones) {
tab.style.transition = "";
}
dt.updateDragImage(...this.originalDragImageArgs); dt.updateDragImage(...this.originalDragImageArgs);
}, 50); }, 50);
} }

View File

@@ -16,7 +16,10 @@ SOURCES += [
] ]
if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa": if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
SOURCES += ["nsZenNativeWindowMove.mm"] SOURCES += [
"nsZenDropLandingCocoa.mm",
"nsZenNativeWindowMove.mm",
]
elif CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk": elif CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"] CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]

View File

@@ -5,6 +5,7 @@
#include "nsISupports.idl" #include "nsISupports.idl"
interface mozIDOMWindowProxy; interface mozIDOMWindowProxy;
webidl Node;
/** /**
* @brief Interface for Zen's drag and drop functionality. * @brief Interface for Zen's drag and drop functionality.
@@ -33,4 +34,24 @@ interface nsIZenDragAndDrop : nsISupports {
* @param window The chrome window to move. * @param window The chrome window to move.
*/ */
void beginNativeWindowMove(in mozIDOMWindowProxy window); void beginNativeWindowMove(in mozIDOMWindowProxy window);
/**
* @brief Slide the drag image onto the drop instead of removing it.
* macOS only, the drag ends once it lands.
* @param arm Whether this drag's drops land the image.
*/
void armDropLanding(in boolean arm);
/**
* @brief Drag an extra image along as its own item, one per further tab.
* macOS stacks and counts them. Add before the drag starts.
* @param image The element to render.
*/
void addDragImage(in Node image);
/**
* @brief Where a drag item lands, in screen CSS pixels. One call per
* item in order, from within the drop event.
*/
void addDropLandingRect(in long x, in long y, in long width, in long height);
}; };

View File

@@ -91,9 +91,37 @@ nsZenDragAndDrop::OnDragStart(float opacity) {
NS_IMETHODIMP NS_IMETHODIMP
nsZenDragAndDrop::OnDragEnd() { nsZenDragAndDrop::OnDragEnd() {
mDragImageOpacity = kZenDefaultDragImageOpacity; mDragImageOpacity = kZenDefaultDragImageOpacity;
mDropLandingArmed = false;
mDragImages.Clear();
mDropLandingRects.Clear();
return NS_OK; return NS_OK;
} }
NS_IMETHODIMP
nsZenDragAndDrop::ArmDropLanding(bool aArm) {
mDropLandingArmed = aArm;
return NS_OK;
}
NS_IMETHODIMP
nsZenDragAndDrop::AddDragImage(nsINode* aImage) {
NS_ENSURE_ARG_POINTER(aImage);
mDragImages.AppendElement(aImage);
return NS_OK;
}
NS_IMETHODIMP
nsZenDragAndDrop::AddDropLandingRect(int32_t aX, int32_t aY, int32_t aWidth,
int32_t aHeight) {
mDropLandingRects.AppendElement(
mozilla::DesktopIntRect(aX, aY, aWidth, aHeight));
return NS_OK;
}
nsTArray<mozilla::DesktopIntRect> nsZenDragAndDrop::TakeDropLandingRects() {
return std::move(mDropLandingRects);
}
NS_IMETHODIMP NS_IMETHODIMP
nsZenDragAndDrop::BeginNativeWindowMove(mozIDOMWindowProxy* aWindow) { nsZenDragAndDrop::BeginNativeWindowMove(mozIDOMWindowProxy* aWindow) {
NS_ENSURE_ARG_POINTER(aWindow); NS_ENSURE_ARG_POINTER(aWindow);

View File

@@ -7,6 +7,13 @@
#include "nsIZenDragAndDrop.h" #include "nsIZenDragAndDrop.h"
#include "nsCOMPtr.h" #include "nsCOMPtr.h"
#include "Units.h"
#include "nsINode.h"
#include "nsTArray.h"
#if defined(XP_MACOSX) && defined(__OBJC__)
@protocol NSDraggingInfo;
#endif
#define ZEN_DND_MANAGER_CONTRACTID "@mozilla.org/zen/drag-and-drop;1" #define ZEN_DND_MANAGER_CONTRACTID "@mozilla.org/zen/drag-and-drop;1"
@@ -26,6 +33,15 @@ class nsZenDragAndDrop final : public nsIZenDragAndDrop {
public: public:
explicit nsZenDragAndDrop(); explicit nsZenDragAndDrop();
auto GetDragImageOpacity() const { return mDragImageOpacity; } auto GetDragImageOpacity() const { return mDragImageOpacity; }
auto DropLandingArmed() const { return mDropLandingArmed; }
const auto& DragImages() const { return mDragImages; }
/**
* @brief Take the rects the drag items are to land on after the drop
* being handled, as the drop added them, in screen CSS pixels and item
* order. Empty when the drop added none.
*/
nsTArray<mozilla::DesktopIntRect> TakeDropLandingRects();
/** /**
* @brief Get the singleton instance of nsZenDragAndDrop. There may be * @brief Get the singleton instance of nsZenDragAndDrop. There may be
@@ -39,8 +55,25 @@ class nsZenDragAndDrop final : public nsIZenDragAndDrop {
private: private:
~nsZenDragAndDrop() = default; ~nsZenDragAndDrop() = default;
float mDragImageOpacity{}; float mDragImageOpacity{};
bool mDropLandingArmed{};
nsTArray<nsCOMPtr<nsINode>> mDragImages;
nsTArray<mozilla::DesktopIntRect> mDropLandingRects;
}; };
#if defined(XP_MACOSX) && defined(__OBJC__)
/**
* @brief From the drag destination view, once a dragover is handled, ask
* the OS to land the drag image on the drop, if the drag wants that.
*/
void PrepareDropLanding(id<NSDraggingInfo> aInfo);
/**
* @brief From the drag destination view, once a drop is handled, send the
* drag image to the rect the drop set, if it set one.
*/
void LandDrop(id<NSDraggingInfo> aInfo);
#endif
} // namespace zen } // namespace zen
#endif #endif

View File

@@ -0,0 +1,54 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#import <Cocoa/Cocoa.h>
#include "nsCocoaUtils.h"
#include "nsObjCExceptions.h"
#include "nsZenDragAndDrop.h"
namespace zen {
void PrepareDropLanding(id<NSDraggingInfo> aInfo) {
NS_OBJC_BEGIN_TRY_IGNORE_BLOCK;
auto zen = nsZenDragAndDrop::GetZenDragAndDropInstance();
aInfo.animatesToDestination = zen && zen->DropLandingArmed();
NS_OBJC_END_TRY_IGNORE_BLOCK;
}
void LandDrop(id<NSDraggingInfo> aInfo) {
NS_OBJC_BEGIN_TRY_IGNORE_BLOCK;
auto zen = nsZenDragAndDrop::GetZenDragAndDropInstance();
if (!zen) {
return;
}
NSMutableArray* targets = [NSMutableArray array];
for (const auto& landing : zen->TakeDropLandingRects()) {
[targets
addObject:[NSValue valueWithRect:nsCocoaUtils::GeckoRectToCocoaRect(
landing)]];
}
if (!targets.count) {
return;
}
[aInfo enumerateDraggingItemsWithOptions:NSDraggingItemEnumerationConcurrent
forView:nil
classes:@[ [NSPasteboardItem class] ]
searchOptions:@{}
usingBlock:^(NSDraggingItem* item, NSInteger idx, BOOL* stop) {
NSRect target =
[targets[MIN((NSUInteger)idx, targets.count - 1)] rectValue];
NSRect frame = item.draggingFrame;
frame.origin.x = target.origin.x;
frame.origin.y = NSMaxY(target) - frame.size.height;
item.draggingFrame = frame;
}];
NS_OBJC_END_TRY_IGNORE_BLOCK;
}
} // namespace zen

View File

@@ -327,7 +327,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
if (isActiveFolder) { if (isActiveFolder) {
for (const folder of group.activeGroups) { for (const folder of group.activeGroups) {
folder.activeTabs = [...new Set([...folder.activeTabs, tab])].sort( folder.activeTabs = [...new Set([...folder.activeTabs, tab])].sort(
(a, b) => a._tPos > b._tPos (a, b) => a.index - b.index
); );
this.setFolderIndentation([tab], folder, /* for collapse = */ true); this.setFolderIndentation([tab], folder, /* for collapse = */ true);
} }
@@ -378,7 +378,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
if (isActiveFolder && isSplitView) { if (isActiveFolder && isSplitView) {
parentFolder.activeTabs = [ parentFolder.activeTabs = [
...new Set([...parentFolder.activeTabs, ...folder.tabs]), ...new Set([...parentFolder.activeTabs, ...folder.tabs]),
].sort((a, b) => a._tPos > b._tPos); ].sort((a, b) => a.index - b.index);
} }
parentFolder.collapsed = isActiveFolder; parentFolder.collapsed = isActiveFolder;
} }
@@ -1505,10 +1505,78 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
#createAnimation(items, targetState, opts, callback = () => {}) { #createAnimation(items, targetState, opts, callback = () => {}) {
items = Array.isArray(items) ? items : [items]; items = Array.isArray(items) ? items : [items];
return items.map(item => return items.map(item =>
gZenUIManager.motion.animate(item, targetState, opts).then(callback) this.#animateItem(item, targetState, opts).then(callback)
); );
} }
/**
* Animates an element to the given target state. An array value is a
* [from, to] pair, "auto" endpoints are resolved by measuring and an
* empty string animates back to the element's natural value. The final
* values are left applied as inline styles.
*
* @param {Element} item - The element to animate.
* @param {object} targetState - Property to value (or [from, to]) map.
* @param {object} opts - The animation options.
* @param {number} opts.duration - The duration in seconds.
* @param {string} opts.ease - The easing name.
* @returns {Promise} Resolves when the animation has finished.
*/
async #animateItem(item, targetState, { duration = 0.18, ease } = {}) {
const computed = window.getComputedStyle(item);
const toCssValue = (prop, value) =>
typeof value === "number" && prop !== "opacity"
? `${value}px`
: String(value);
const measure = prop => {
const value = computed[prop];
if (value === "auto") {
return `${item.getBoundingClientRect()[prop] ?? 0}px`;
}
return value;
};
const from = {};
const to = {};
const finalStyles = new Map();
for (const [prop, value] of Object.entries(targetState)) {
let [start, end] = Array.isArray(value) ? value : [undefined, value];
const cssProp = prop.replace(/[A-Z]/g, c => `-${c.toLowerCase()}`);
if (start === undefined || start === "auto") {
start = measure(prop);
} else {
start = toCssValue(prop, start);
}
if (end === "" || end === "auto") {
// Resolve the natural value by clearing any inline override.
item.style.removeProperty(cssProp);
end = measure(prop);
finalStyles.set(cssProp, null);
} else {
end = toCssValue(prop, end);
finalStyles.set(cssProp, end);
}
from[prop] = start;
to[prop] = end;
}
const animation = item.animate([from, to], {
duration: duration * 1000,
easing: ease === "easeInOut" ? "ease-in-out" : "ease",
});
try {
await animation.finished;
} catch (e) {
// The animation was cancelled, leave the element as-is.
return;
}
for (const [cssProp, value] of finalStyles) {
if (value === null) {
item.style.removeProperty(cssProp);
} else {
item.style.setProperty(cssProp, value);
}
}
}
#calculateHeightShift(tabsContainer, selectedTabs) { #calculateHeightShift(tabsContainer, selectedTabs) {
let heightShift = 0; let heightShift = 0;
if (selectedTabs.length) { if (selectedTabs.length) {
@@ -1526,7 +1594,11 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
} }
get #folderAnimationDuration() { get #folderAnimationDuration() {
return this._dontAnimateFolder ? 0 : 0.12; return this._dontAnimateFolder ? 0 : 0.18;
}
get #folderRevealDuration() {
return this._dontAnimateFolder ? 0 : 0.22;
} }
async animateCollapse(group) { async animateCollapse(group) {
@@ -1546,6 +1618,9 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
splitViewIds, splitViewIds,
activeFoldersIds, activeFoldersIds,
}); });
if (selectedTabs.length) {
tabsContainer.removeAttribute("hidden");
}
const collapsedHeight = this.#calculateHeightShift( const collapsedHeight = this.#calculateHeightShift(
tabsContainer, tabsContainer,
selectedTabs selectedTabs
@@ -1764,6 +1839,9 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
// Set correct margin-top after animation // Set correct margin-top after animation
const afterAnimate = () => { const afterAnimate = () => {
if (folder.hasAttribute("has-active")) {
return;
}
groupStart.style.removeProperty("margin-top"); groupStart.style.removeProperty("margin-top");
this.styleCleanup(groupItems); this.styleCleanup(groupItems);
// Trigger the recalculation so that zen returns // Trigger the recalculation so that zen returns
@@ -1785,7 +1863,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
{ {
marginTop: -(collapsedHeight + 4), marginTop: -(collapsedHeight + 4),
}, },
{ duration: 0.12, ease: "easeInOut" }, { duration: this.#folderAnimationDuration, ease: "easeInOut" },
afterAnimate afterAnimate
) )
); );
@@ -1821,6 +1899,9 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
// Set correct margin-top after animation // Set correct margin-top after animation
const afterAnimate = () => { const afterAnimate = () => {
if (folder.hasAttribute("has-active")) {
return;
}
groupStart.style.removeProperty("margin-top"); groupStart.style.removeProperty("margin-top");
this.styleCleanup(groupItems); this.styleCleanup(groupItems);
// Trigger the recalculation so that zen returns // Trigger the recalculation so that zen returns
@@ -1845,7 +1926,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
{ {
marginTop: -(collapsedHeight + 4), marginTop: -(collapsedHeight + 4),
}, },
{ duration: 0.12, ease: "easeInOut" }, { duration: this.#folderAnimationDuration, ease: "easeInOut" },
afterAnimate afterAnimate
), ),
]; ];
@@ -1870,7 +1951,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
height: 0, height: 0,
}, },
{ {
duration: 0.12, duration: this.#folderAnimationDuration,
ease: "easeInOut", ease: "easeInOut",
} }
); );
@@ -1899,12 +1980,31 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
const selectedTabs = []; const selectedTabs = [];
const splitViewIds = new Set(); const splitViewIds = new Set();
const itemsToHide = []; const itemsToHide = [];
const newlyActive = new Set();
const groupItems = this.#collectGroupItems(group, { const groupItems = this.#collectGroupItems(group, {
selectedTabs, selectedTabs,
splitViewIds, splitViewIds,
}); });
if (group.collapsed && selectedTabs.length) {
const active = new Set([...(group.activeTabs ?? []), ...selectedTabs]);
const tabs = group.tabs.filter(tab => !tab.hasAttribute("zen-empty-tab"));
if (
tabs.length &&
tabs.every(
tab =>
active.has(tab) ||
tab.selected ||
tab.multiselected ||
tab.hasAttribute("folder-active")
)
) {
group.collapsed = false;
return;
}
}
for (const tab of selectedTabs) { for (const tab of selectedTabs) {
let currentGroup = tab?.group?.hasAttribute("split-view-group") let currentGroup = tab?.group?.hasAttribute("split-view-group")
? tab.group.group ? tab.group.group
@@ -1916,10 +2016,15 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
if (activeTabs.length) { if (activeTabs.length) {
if (currentGroup.collapsed) { if (currentGroup.collapsed) {
if (currentGroup.hasAttribute("has-active")) { if (currentGroup.hasAttribute("has-active")) {
for (const activeTab of activeTabs) {
if (!currentGroup.activeTabs.includes(activeTab)) {
newlyActive.add(activeTab);
}
}
// It is important to keep the sequence of elements as in the DOM // It is important to keep the sequence of elements as in the DOM
currentGroup.activeTabs = [ currentGroup.activeTabs = [
...new Set([...currentGroup.activeTabs, ...activeTabs]), ...new Set([...currentGroup.activeTabs, ...activeTabs]),
].sort((a, b) => a._tPos > b._tPos); ].sort((a, b) => a.index - b.index);
} else { } else {
currentGroup.setAttribute("has-active", "true"); currentGroup.setAttribute("has-active", "true");
currentGroup.activeTabs = activeTabs; currentGroup.activeTabs = activeTabs;
@@ -1944,7 +2049,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
{ {
marginTop: 0, marginTop: 0,
}, },
{ duration: 0.12, ease: "easeInOut" }, { duration: this.#folderAnimationDuration, ease: "easeInOut" },
afterMarginTop afterMarginTop
) )
); );
@@ -1963,13 +2068,14 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
} }
const itemsToShow = []; const itemsToShow = [];
const itemsToReveal = [];
if (selectedTabs.length) { if (selectedTabs.length) {
for (let i = 0; i < groupItems.length; i++) { for (let i = 0; i < groupItems.length; i++) {
const { item, splitViewId } = groupItems[i]; const { item, splitViewId } = groupItems[i];
let itemVisible = item.visible; let itemVisible = item.visible;
if (itemVisible) { if (itemVisible) {
itemsToShow.push(item); (newlyActive.has(item) ? itemsToReveal : itemsToShow).push(item);
} }
// Skip selected items // Skip selected items
@@ -2003,18 +2109,48 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
height: "", height: "",
}, },
{ {
duration: 0.12, duration: this.#folderAnimationDuration,
ease: "easeInOut", ease: "easeInOut",
} }
), ),
...itemsToReveal.flatMap(item => {
const state = {
opacity: [0, ""],
height: [0, ""],
minHeight: [0, ""],
};
const folder = item.group?.hasAttribute("split-view-group")
? item.group.group
: item.group;
const slidesFromFolder = !(folder?.activeTabs ?? []).some(
active =>
!newlyActive.has(active) &&
active.compareDocumentPosition(item) &
Node.DOCUMENT_POSITION_FOLLOWING
);
if (slidesFromFolder) {
const height =
item.getBoundingClientRect().height ||
(folder?.activeTabs ?? []).reduce(
(found, active) => found || active.getBoundingClientRect().height,
0
);
state.transform = [`translateY(-${height}px)`, ""];
}
return this.#createAnimation(item, state, {
duration: this.#folderRevealDuration,
ease: "easeInOut",
});
}),
...this.#createAnimation( ...this.#createAnimation(
itemsToHide, itemsToHide,
{ {
opacity: 0, opacity: 0,
height: 0, height: 0,
minHeight: 0,
}, },
{ {
duration: 0.12, duration: this.#folderAnimationDuration,
ease: "easeInOut", ease: "easeInOut",
} }
) )
@@ -2047,7 +2183,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
{ {
marginTop: expand ? 0 : -(heightContainer + 4), marginTop: expand ? 0 : -(heightContainer + 4),
}, },
{ duration: 0.12, ease: "easeInOut" } { duration: this.#folderAnimationDuration, ease: "easeInOut" }
); );
} }
@@ -2055,6 +2191,7 @@ class nsZenFolders extends nsZenDOMOperatedFeature {
items.forEach(item => { items.forEach(item => {
item.style.removeProperty("opacity"); item.style.removeProperty("opacity");
item.style.removeProperty("height"); item.style.removeProperty("height");
item.style.removeProperty("min-height");
}); });
} }
} }

View File

@@ -193,15 +193,8 @@ zen-folder {
} }
} }
:root[zen-sidebar-expanded] &[has-active] > .tab-group-label-container { :root[zen-sidebar-expanded] &[has-active] > .tab-group-label-container:hover .tab-reset-button {
& .tab-reset-button { display: flex;
display: flex;
opacity: 0;
}
&:hover .tab-reset-button {
opacity: 1;
}
} }
} }

View File

@@ -6,7 +6,8 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
JSONFile: "resource://gre/modules/JSONFile.sys.mjs", JSONFile: "resource://gre/modules/JSONFile.sys.mjs",
setTimeout: "resource://gre/modules/Timer.sys.mjs", setTimeout: "resource://gre/modules/Timer.sys.mjs",
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs", ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs",
FeatureCallout: "resource:///modules/asrouter/FeatureCallout.sys.mjs", FeatureCallout: "resource:///modules/asrouter/FeatureCallout.sys.mjs",
}); });
@@ -497,41 +498,51 @@ class nsZenLiveFoldersManager {
); );
}) })
.map(item => { .map(item => {
const tab = this.window.gBrowser.addTrustedTab(item.url, { try {
createLazyBrowser: true, const tab = this.window.gBrowser.addTrustedTab(item.url, {
inBackground: true, createLazyBrowser: true,
skipAnimation: true, inBackground: true,
noInitialLabel: true, skipAnimation: true,
lazyTabTitle: item.title, noInitialLabel: true,
userContextId, lazyTabTitle: item.title,
}); userContextId,
// createLazyBrowser can't be pinned by default });
this.window.gBrowser.pinTab(tab); // createLazyBrowser can't be pinned by default
if (userContextId) { this.window.gBrowser.pinTab(tab);
tab.setAttribute("zenDefaultUserContextId", "true"); if (userContextId) {
} tab.setAttribute("zenDefaultUserContextId", "true");
if (item.icon) { }
this.window.gBrowser.setIcon(tab, item.icon); if (item.icon) {
if (tab.linkedBrowser) { this.window.gBrowser.setIcon(tab, item.icon);
lazy.TabStateCache.update(tab.linkedBrowser.permanentKey, { if (tab.linkedBrowser) {
image: null, lazy.TabStateCache.update(tab.linkedBrowser.permanentKey, {
image: null,
});
}
}
tab.setAttribute(
"zen-live-folder-item-id",
this.#makeCompositeId(liveFolder.id, item.id)
);
if (item.subtitle) {
tab.setAttribute("zen-show-sublabel", item.subtitle);
const tabLabel = tab.querySelector(".zen-tab-sublabel");
this.window.document.l10n.setArgs(tabLabel, {
tabSubtitle: item.subtitle,
}); });
} }
}
tab.setAttribute(
"zen-live-folder-item-id",
this.#makeCompositeId(liveFolder.id, item.id)
);
if (item.subtitle) {
tab.setAttribute("zen-show-sublabel", item.subtitle);
const tabLabel = tab.querySelector(".zen-tab-sublabel");
this.window.document.l10n.setArgs(tabLabel, {
tabSubtitle: item.subtitle,
});
}
return tab; return tab;
}); } catch (e) {
console.error(
"ZenLiveFoldersManager: Failed to add tab for item",
item.url,
e
);
return null;
}
})
.filter(tab => tab);
// Wait for tabs to (hopefully) be initialized on all windows // Wait for tabs to (hopefully) be initialized on all windows
lazy.setTimeout(() => { lazy.setTimeout(() => {

View File

@@ -242,6 +242,7 @@ export class nsGithubLiveFolderProvider extends nsZenLiveFolderProvider {
const baseQuery = [ const baseQuery = [
this.state.type === "pull-requests" ? "is:pr" : "is:issue", this.state.type === "pull-requests" ? "is:pr" : "is:issue",
"is:open", "is:open",
"archived:false",
"sort:updated-desc", "sort:updated-desc",
]; ];

View File

@@ -182,15 +182,21 @@ class nsZenMods extends nsZenPreloadedFeature {
({ enabled, preferences, name }) => ({ ({ enabled, preferences, name }) => ({
enabled, enabled,
sanitizedName: this.sanitizeModName(name), sanitizedName: this.sanitizeModName(name),
prefs: preferences.map(({ property, type }) => ({ prefs: preferences.map(({ property, type }) => {
property, const isEnabled = enabled === undefined || enabled;
type, const getPref =
sanitizedProperty: property?.replaceAll(DOT_RE, "-"), type === "checkbox"
value: ? Services.prefs.getBoolPref
enabled === undefined || enabled : Services.prefs.getStringPref;
? Services.prefs.getStringPref(property, "") const fallback = type === "checkbox" ? false : "";
: "",
})), return {
property,
type,
sanitizedProperty: property?.replaceAll(DOT_RE, "-"),
value: isEnabled ? getPref(property, fallback) : fallback,
};
}),
}) })
); );

View File

@@ -11,9 +11,12 @@ ChromeUtils.defineESModuleGetters(lazy, {
ZenLiveFoldersManager: ZenLiveFoldersManager:
"resource:///modules/zen/ZenLiveFoldersManager.sys.mjs", "resource:///modules/zen/ZenLiveFoldersManager.sys.mjs",
PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs",
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionStore:
SessionStartup: "resource:///modules/sessionstore/SessionStartup.sys.mjs", "moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
TabStateFlusher: "resource:///modules/sessionstore/TabStateFlusher.sys.mjs", SessionStartup:
"moz-src:///browser/components/sessionstore/SessionStartup.sys.mjs",
TabStateFlusher:
"moz-src:///browser/components/sessionstore/TabStateFlusher.sys.mjs",
gWindowSyncEnabled: "resource:///modules/zen/ZenWindowSync.sys.mjs", gWindowSyncEnabled: "resource:///modules/zen/ZenWindowSync.sys.mjs",
gSyncOnlyPinnedTabs: "resource:///modules/zen/ZenWindowSync.sys.mjs", gSyncOnlyPinnedTabs: "resource:///modules/zen/ZenWindowSync.sys.mjs",
DeferredTask: "resource://gre/modules/DeferredTask.sys.mjs", DeferredTask: "resource://gre/modules/DeferredTask.sys.mjs",

View File

@@ -10,13 +10,15 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
BrowserWindowTracker: "resource:///modules/BrowserWindowTracker.sys.mjs", BrowserWindowTracker: "resource:///modules/BrowserWindowTracker.sys.mjs",
TabStateFlusher: "resource:///modules/sessionstore/TabStateFlusher.sys.mjs", TabStateFlusher:
"moz-src:///browser/components/sessionstore/TabStateFlusher.sys.mjs",
// eslint-disable-next-line mozilla/valid-lazy // eslint-disable-next-line mozilla/valid-lazy
ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs", ZenSessionStore: "resource:///modules/zen/ZenSessionManager.sys.mjs",
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
setTimeout: "resource://gre/modules/Timer.sys.mjs", setTimeout: "resource://gre/modules/Timer.sys.mjs",
PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs",
RunState: "resource:///modules/sessionstore/RunState.sys.mjs", RunState: "moz-src:///browser/components/sessionstore/RunState.sys.mjs",
}); });
XPCOMUtils.defineLazyPreferenceGetter( XPCOMUtils.defineLazyPreferenceGetter(
@@ -328,7 +330,7 @@ class nsZenWindowSync {
// browser/components/extensions/parent/ext-browser.js. // browser/components/extensions/parent/ext-browser.js.
// See: Bug 1960104 - Improve tab group ID generation in addTabGroup // See: Bug 1960104 - Improve tab group ID generation in addTabGroup
// This is implemented from gBrowser.addTabGroup. // This is implemented from gBrowser.addTabGroup.
return `${Date.now()}-${Math.round(Math.random() * 100)}`; return `${Date.now()}-${Services.uuid.generateUUID().toString().slice(1, -1)}`;
} }
/** /**

View File

@@ -8,7 +8,8 @@ import { nsZenThemePicker } from "resource:///modules/zen/ZenGradientGenerator.m
const lazy = {}; const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
ZenShareClient: "resource:///modules/zen/share/ZenShareClient.sys.mjs", ZenShareClient: "resource:///modules/zen/share/ZenShareClient.sys.mjs",
ZenShareError: "resource:///modules/zen/share/ZenShareClient.sys.mjs", ZenShareError: "resource:///modules/zen/share/ZenShareClient.sys.mjs",
}); });
@@ -440,8 +441,8 @@ class nsZenShareManager extends nsZenDOMOperatedFeature {
gZenUIManager.motion gZenUIManager.motion
.animate( .animate(
group, group,
{ x: [-28, 0] }, { x: [-32, 0] },
{ type: "spring", bounce: 0.9, duration: 1.4 } { type: "spring", bounce: 0.5, duration: 1.5 }
) )
.then(() => { .then(() => {
group.style.removeProperty("transform"); group.style.removeProperty("transform");

View File

@@ -143,6 +143,14 @@ class nsZenSpaceRoutingManager {
this.#routeToWorkspace(targetRoute, newTab, options.inBackground, win); this.#routeToWorkspace(targetRoute, newTab, options.inBackground, win);
} }
shouldDeferTabSelection(beforeResult, win) {
return (
beforeResult.isRouteFound &&
beforeResult.targetRoute !== win.gZenWorkspaces.activeWorkspace &&
this.#isMostRecentBrowserWindow(win)
);
}
/** /**
* Decides whether an in-place top-level navigation should be pulled out of * Decides whether an in-place top-level navigation should be pulled out of
* the current tab and re-opened in a new tab, so that addTab()'s routing can * the current tab and re-opened in a new tab, so that addTab()'s routing can
@@ -245,10 +253,7 @@ class nsZenSpaceRoutingManager {
if (targetWorkspace) { if (targetWorkspace) {
workspaces.moveTabToWorkspace(newTab, targetWorkspace.uuid); workspaces.moveTabToWorkspace(newTab, targetWorkspace.uuid);
const mostRecentWindow = if (this.#isMostRecentBrowserWindow(win)) {
Services.wm.getMostRecentWindow("navigator:browser");
const isOriginatingWindow = win === mostRecentWindow;
if (isOriginatingWindow) {
win.gZenWorkspaces.lastSelectedWorkspaceTabs[ win.gZenWorkspaces.lastSelectedWorkspaceTabs[
targetWorkspace.uuid targetWorkspace.uuid
] = newTab; ] = newTab;
@@ -265,6 +270,10 @@ class nsZenSpaceRoutingManager {
} }
} }
#isMostRecentBrowserWindow(win) {
return win === Services.wm.getMostRecentWindow("navigator:browser");
}
/** /**
* This will give the id of the workspace this uri will * This will give the id of the workspace this uri will
* route to, or "most-recent-space" * route to, or "most-recent-space"

View File

@@ -1337,7 +1337,7 @@ export class nsZenThemePicker extends nsZenMultiWindowFeature {
this.useAlgo = themedColors[0]?.algorithm ?? ""; this.useAlgo = themedColors[0]?.algorithm ?? "";
this.#currentLightness = themedColors[0]?.lightness ?? 50; this.#currentLightness = themedColors[0]?.lightness ?? 50;
const rotation = -45; // TODO: Detect rotation based on the accent color const rotation = -30; // TODO: Detect rotation based on the accent color
if (themedColors.length === 0) { if (themedColors.length === 0) {
const getBrowserBg = () => { const getBrowserBg = () => {
if (this.canBeTransparent) { if (this.canBeTransparent) {
@@ -1367,8 +1367,8 @@ export class nsZenThemePicker extends nsZenMultiWindowFeature {
if (themedColors.length === 2) { if (themedColors.length === 2) {
if (!forToolbar) { if (!forToolbar) {
return [ return [
`linear-gradient(${rotation}deg, ${this.#getSingleRGBColor(themedColors[1], forToolbar)} 0%, transparent 100%)`, `linear-gradient(${rotation}deg, ${this.#getSingleRGBColor(themedColors[1], forToolbar)} 20%, transparent 100%)`,
`linear-gradient(${rotation + 180}deg, ${this.#getSingleRGBColor(themedColors[0], forToolbar)} 0%, transparent 100%)`, `linear-gradient(${rotation + 180}deg, ${this.#getSingleRGBColor(themedColors[0], forToolbar)} 20%, transparent 100%)`,
] ]
.reverse() .reverse()
.join(", "); .join(", ");

View File

@@ -1773,10 +1773,10 @@ class nsZenWorkspaces {
if (this.tabContainer) { if (this.tabContainer) {
this.tabContainer._invalidateCachedTabs(); this.tabContainer._invalidateCachedTabs();
} }
// Fix tabs _tPos values relative to the actual order // Fix tabs _index values relative to the actual order
const tabs = gBrowser.tabs; const tabs = gBrowser.tabs;
const usedGroups = new Set(); const usedGroups = new Set();
let tPos = 0; // _tPos is used for the session store, not needed for folders let tPos = 0; // _index is used for the session store, not needed for folders
let pPos = 0; // _pPos is used for the pinned tabs manager let pPos = 0; // _pPos is used for the pinned tabs manager
const recurseFolder = tab => { const recurseFolder = tab => {
if (tab.group) { if (tab.group) {
@@ -1789,7 +1789,7 @@ class nsZenWorkspaces {
}; };
for (const tab of tabs) { for (const tab of tabs) {
recurseFolder(tab); recurseFolder(tab);
tab._tPos = tPos++; tab._index = tPos++;
if (!tab.hasAttribute("zen-empty-tab")) { if (!tab.hasAttribute("zen-empty-tab")) {
tab._pPos = pPos++; tab._pPos = pPos++;
} }
@@ -3026,7 +3026,6 @@ class nsZenWorkspaces {
getTabsToExclude(aTab) { getTabsToExclude(aTab) {
const tabWorkspaceId = aTab.getAttribute("zen-workspace-id"); const tabWorkspaceId = aTab.getAttribute("zen-workspace-id");
const containerId = aTab.getAttribute("usercontextid") ?? "0"; const containerId = aTab.getAttribute("usercontextid") ?? "0";
// Return all tabs that are not on the same workspace
return gBrowser.tabs.filter( return gBrowser.tabs.filter(
tab => tab =>
!this._shouldShowTab( !this._shouldShowTab(

View File

@@ -352,6 +352,8 @@ zen-workspace {
scrollbar-width: auto; scrollbar-width: auto;
scrollbar-color: color-mix(in srgb, currentColor 35%, transparent 65%) transparent; /* Custom scrollbar */ scrollbar-color: color-mix(in srgb, currentColor 35%, transparent 65%) transparent; /* Custom scrollbar */
overflow-y: auto; overflow-y: auto;
padding-block-end: 120px;
overscroll-behavior: auto;
} }
:root[swipe-gesture] &::part(scrollbox) { :root[swipe-gesture] &::part(scrollbox) {

View File

@@ -1601,7 +1601,7 @@ class nsZenViewSplitter extends nsZenDOMOperatedFeature {
tab.hasAttribute("pending") tab.hasAttribute("pending")
); );
if (pendingTabs.length) { if (pendingTabs.length) {
pendingTabs.forEach(tab => gBrowser._insertBrowser(tab)); pendingTabs.forEach(tab => gBrowser.insertBrowser(tab));
// SessionStore listens for this on the tab container and restores each // SessionStore listens for this on the tab container and restores each
// tab's saved history, scroll position and form data. Kept non-bubbling // tab's saved history, scroll position and form data. Kept non-bubbling
// so it doesn't reach tabbrowser, which tracks Firefox's own split view. // so it doesn't reach tabbrowser, which tracks Firefox's own split view.

View File

@@ -23,10 +23,13 @@ XPCOMUtils.defineLazyPreferenceGetter(
); );
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
SessionSaver: "resource:///modules/sessionstore/SessionSaver.sys.mjs", SessionSaver:
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", "moz-src:///browser/components/sessionstore/SessionSaver.sys.mjs",
SessionStore:
"moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs",
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs", ZenWindowSync: "resource:///modules/zen/ZenWindowSync.sys.mjs",
ZenLiveFoldersManager: ZenLiveFoldersManager:
"resource:///modules/zen/ZenLiveFoldersManager.sys.mjs", "resource:///modules/zen/ZenLiveFoldersManager.sys.mjs",
@@ -877,7 +880,7 @@ class nsZenSpacesSyncApplier {
prev && prev &&
prev.parentNode && prev.parentNode &&
prev.parentNode === el.parentNode && prev.parentNode === el.parentNode &&
prev.nextElementSibling !== el prev.compareDocumentPosition(el) & win.Node.DOCUMENT_POSITION_PRECEDING
) { ) {
win.gBrowser.zenHandleTabMove(el, () => prev.after(el)); win.gBrowser.zenHandleTabMove(el, () => prev.after(el));
} }

View File

@@ -34,7 +34,8 @@ class ZenPinnedTabsObserver {
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
// eslint-disable-next-line mozilla/valid-lazy // eslint-disable-next-line mozilla/valid-lazy
E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs",
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
}); });
this.#listenPinnedTabEvents(); this.#listenPinnedTabEvents();
} }
@@ -373,6 +374,14 @@ class nsZenPinnedTabManager extends nsZenDOMOperatedFeature {
case "reset-switch": case "reset-switch":
case "switch": case "switch":
if (behavior.includes("unload")) { if (behavior.includes("unload")) {
if (pinnedTabs.some(tab => tab.selected)) {
const selectedTabs = pinnedTabs.filter(tab => tab.selected);
const tabToBlurTo = gBrowser._findTabToBlurTo(
selectedTabs[0],
pinnedTabs
);
gBrowser.selectedTab = tabToBlurTo;
}
for (const tab of pinnedTabs) { for (const tab of pinnedTabs) {
if (tab.hasAttribute("glance-id")) { if (tab.hasAttribute("glance-id")) {
// We have a glance tab inside the tab we are trying to unload, // We have a glance tab inside the tab we are trying to unload,

View File

@@ -329,6 +329,10 @@
display: none; display: none;
} }
&[drag-image] .tab-background {
border-radius: calc(var(--border-radius-medium) / var(--zen-squircle-value)) !important;
}
/* stylelint-disable-next-line stylelint-plugin-mozilla/no-has-selector */ /* stylelint-disable-next-line stylelint-plugin-mozilla/no-has-selector */
:root:not([zen-renaming-tab="true"]) :root:not([zen-renaming-tab="true"])
#tabbrowser-tabs:not([movingtab]) #tabbrowser-tabs:not([movingtab])
@@ -625,6 +629,8 @@
--tab-icon-end-margin: 8.5px; --tab-icon-end-margin: 8.5px;
& .tabbrowser-tab { & .tabbrowser-tab {
overflow: visible;
& .tab-label-container { & .tab-label-container {
opacity: 1; opacity: 1;
display: flex; display: flex;
@@ -1268,10 +1274,6 @@
left: calc(var(--indicator-left) + 2 * var(--zen-drag-indicator-height) + 4px); left: calc(var(--indicator-left) + 2 * var(--zen-drag-indicator-height) + 4px);
width: calc(var(--indicator-width) - 2 * var(--zen-drag-indicator-height) - 4px); width: calc(var(--indicator-width) - 2 * var(--zen-drag-indicator-height) - 4px);
height: var(--zen-drag-indicator-height); height: var(--zen-drag-indicator-height);
transition:
top 0.05s ease-out,
left 0.05s ease-out,
width 0.05s ease-out;
&::before { &::before {
left: calc(-2 * var(--zen-drag-indicator-height)); left: calc(-2 * var(--zen-drag-indicator-height));
@@ -1284,10 +1286,6 @@
top: calc(var(--indicator-top) + 2 * var(--zen-drag-indicator-height) + 4px); top: calc(var(--indicator-top) + 2 * var(--zen-drag-indicator-height) + 4px);
height: calc(var(--indicator-height) - 2 * var(--zen-drag-indicator-height) - 4px); height: calc(var(--indicator-height) - 2 * var(--zen-drag-indicator-height) - 4px);
width: var(--zen-drag-indicator-height); width: var(--zen-drag-indicator-height);
transition:
top 0.1s ease-out,
left 0.1s ease-out,
height 0.1s ease-out;
&::before { &::before {
top: calc(-2 * var(--zen-drag-indicator-height)); top: calc(-2 * var(--zen-drag-indicator-height));

View File

@@ -16,4 +16,6 @@ support-files = [
["browser_normal_tabs_apply.js"] ["browser_normal_tabs_apply.js"]
["browser_normal_tabs_order.js"]
["browser_normal_tabs_projection.js"] ["browser_normal_tabs_projection.js"]

View File

@@ -0,0 +1,101 @@
/* Any copyright is dedicated to the Public Domain.
https://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
add_task(async function test_RapidTabsGetUniqueSyncIds() {
await gZenWorkspaces.promiseInitialized;
const tabs = [];
for (let i = 0; i < 60; i++) {
tabs.push(
gBrowser.addTrustedTab(`https://example.com/?rapid-${i}`, {
inBackground: true,
skipAnimation: true,
})
);
}
await TestUtils.waitForCondition(
() => tabs.every(tab => tab.id),
"every rapidly-opened tab is assigned a sync id"
);
const ids = tabs.map(tab => tab.id);
Assert.equal(
new Set(ids).size,
ids.length,
"every rapidly-opened tab has a unique sync id"
);
for (const tab of tabs) {
BrowserTestUtils.removeTab(tab);
}
});
add_task(async function test_IncomingOrderKeepsUnlistedTabInPlace() {
await gZenWorkspaces.promiseInitialized;
await SpecialPowers.pushPrefEnv({ set: [[NORMAL_TABS_PREF, true]] });
const uuid = gZenWorkspaces.activeWorkspace;
const opened = [
await openSyncableTab("https://example.com/?order-a"),
await openSyncableTab("https://example.com/?order-b"),
await openSyncableTab("https://example.com/?order-c"),
];
const container = opened[0].parentNode;
Assert.ok(
opened.every(tab => tab.parentNode === container),
"the three tabs share a container"
);
const domOrder = () =>
[...container.children].filter(node => opened.includes(node));
const [first, middle, last] = domOrder();
const spaceData = (await collectProjections()).get(uuid)?.data;
Assert.ok(spaceData, "the active space projects");
const record = {
id: uuid,
deleted: false,
cleartext: {
kind: "space",
data: { ...spaceData, children: [first.id, last.id] },
},
};
const failed = await ZenSpacesSyncApplier.applyBatch([record]);
Assert.deepEqual(failed, [], "the space order applies cleanly");
Assert.deepEqual(
domOrder(),
[first, middle, last],
"the unlisted tab stays between its neighbours, not pushed to the bottom"
);
ZenSpacesSyncModel.noteApplied(uuid, null);
for (const tab of opened) {
BrowserTestUtils.removeTab(tab);
}
await SpecialPowers.popPrefEnv();
});
add_task(async function test_AppliedNormalTabReprojectsFaithfully() {
await gZenWorkspaces.promiseInitialized;
await SpecialPowers.pushPrefEnv({ set: [[NORMAL_TABS_PREF, true]] });
const id = "test-sync-normal-faithful";
const failed = await ZenSpacesSyncApplier.applyBatch([
tabRecord(id, { pinned: false, url: "https://example.com/?faithful" }),
]);
Assert.deepEqual(failed, [], "the normal-tab record applies cleanly");
const tab = document.getElementById(id);
Assert.ok(gBrowser.isTab(tab), "the tab materializes");
const projections = await collectProjections();
const changes = ZenSpacesSyncModel.computeChangedIDs();
Assert.ok(
projections.get(id),
"the applied normal tab re-projects (is not dropped from the sidebar)"
);
Assert.ok(!(id in changes) || projections.get(id), "and is not tombstoned");
ZenSpacesSyncModel.noteApplied(id, null);
BrowserTestUtils.removeTab(tab);
await SpecialPowers.popPrefEnv();
});

View File

@@ -11,10 +11,10 @@ const { ZenSpacesSyncApplier } = ChromeUtils.importESModule(
"resource:///modules/zen/ZenSpacesSyncApplier.sys.mjs" "resource:///modules/zen/ZenSpacesSyncApplier.sys.mjs"
); );
const { SessionSaver } = ChromeUtils.importESModule( const { SessionSaver } = ChromeUtils.importESModule(
"resource:///modules/sessionstore/SessionSaver.sys.mjs" "moz-src:///browser/components/sessionstore/SessionSaver.sys.mjs"
); );
const { TabStateFlusher } = ChromeUtils.importESModule( const { TabStateFlusher } = ChromeUtils.importESModule(
"resource:///modules/sessionstore/TabStateFlusher.sys.mjs" "moz-src:///browser/components/sessionstore/TabStateFlusher.sys.mjs"
); );
const { TestUtils } = ChromeUtils.importESModule( const { TestUtils } = ChromeUtils.importESModule(
"resource://testing-common/TestUtils.sys.mjs" "resource://testing-common/TestUtils.sys.mjs"

View File

@@ -44,8 +44,16 @@ add_task(async function test_Issue_9981() {
const tab2ResetButton = tab2.querySelector(".tab-reset-button"); const tab2ResetButton = tab2.querySelector(".tab-reset-button");
tab2ResetButton.style.display = "flex"; tab2ResetButton.style.display = "flex";
await TestUtils.waitForCondition(
() => tab2ResetButton.getBoundingClientRect().width != 0
);
EventUtils.synthesizeMouseAtCenter(tab2ResetButton, {}); EventUtils.synthesizeMouseAtCenter(tab2ResetButton, {});
await TestUtils.waitForCondition(
() => !tab2.hasAttribute("folder-active"),
"Tab 2 should be unloaded out of the active folder"
);
ok( ok(
tab1.hasAttribute("folder-active"), tab1.hasAttribute("folder-active"),
"Tab 1 should be in the active folder" "Tab 1 should be in the active folder"

View File

@@ -17,8 +17,8 @@ add_task(async function test_Glance_Basic_Open() {
"There should be no zen-glance-tab attribute on any tab" "There should be no zen-glance-tab attribute on any tab"
); );
Assert.greater( Assert.greater(
glanceTab._tPos, glanceTab.index,
selectedTab._tPos, selectedTab.index,
"The glance tab should be on the right of the selected tab" "The glance tab should be on the right of the selected tab"
); );
BrowserTestUtils.removeTab(glanceTab); BrowserTestUtils.removeTab(glanceTab);
@@ -42,8 +42,8 @@ add_task(async function test_Glance_Open_Sibling() {
await openGlanceOnTab(async glanceTab => { await openGlanceOnTab(async glanceTab => {
await gZenGlanceManager.fullyOpenGlance(); await gZenGlanceManager.fullyOpenGlance();
Assert.equal( Assert.equal(
glanceTab._tPos, glanceTab._index,
selectedTab._tPos + 1, selectedTab._index + 1,
"The glance tab should be on the right of the selected tab" "The glance tab should be on the right of the selected tab"
); );
BrowserTestUtils.removeTab(glanceTab); BrowserTestUtils.removeTab(glanceTab);

View File

@@ -19,7 +19,7 @@ add_task(async function test_Glance_Select_Parent() {
); );
const tabToRemove = gBrowser.selectedTab; const tabToRemove = gBrowser.selectedTab;
gBrowser.selectedTab = gZenGlanceManager.getTabOrGlanceParent(glanceTab); gBrowser.selectedTab = gZenGlanceManager.getTabOrGlanceParent(glanceTab);
await BrowserTestUtils.waitForCondition(() => { await TestUtils.waitForCondition(() => {
return glanceTab.selected; return glanceTab.selected;
}); });
ok(true, "The glance tab should be selected"); ok(true, "The glance tab should be selected");

View File

@@ -70,6 +70,7 @@ add_task(async function test_fetch_items_url_construction() {
const query = searchParams.get("q"); const query = searchParams.get("q");
Assert.ok(query.includes("is:open"), "Should include state:open"); Assert.ok(query.includes("is:open"), "Should include state:open");
Assert.ok(query.includes("is:pr"), "Should include is:PR"); Assert.ok(query.includes("is:pr"), "Should include is:PR");
Assert.ok(query.includes("archived:false"), "Should include archived:false");
Assert.ok(query.includes("author:@me"), "Should include author:@me"); Assert.ok(query.includes("author:@me"), "Should include author:@me");
Assert.ok(!query.includes("assignee:@me"), "Should NOT include assignee:@me"); Assert.ok(!query.includes("assignee:@me"), "Should NOT include assignee:@me");
Assert.ok( Assert.ok(

View File

@@ -146,6 +146,12 @@ xpcshell = true
source = "browser/components/tabbrowser/test/browser/tabMediaIndicator" source = "browser/components/tabbrowser/test/browser/tabMediaIndicator"
is_direct_path = true is_direct_path = true
[tabMediaIndicator.replace-manifest]
"[DEFAULT]" = """[DEFAULT]
prefs = [
"zen.window-sync.enabled=false",
]"""
[tooltiptext] [tooltiptext]
source = "toolkit/components/tooltiptext" source = "toolkit/components/tooltiptext"
disable = [ disable = [

View File

@@ -21,7 +21,7 @@ add_task(async function test_media_bar_shows_metadata_from_page() {
const titleEl = card.querySelector(".zen-media-title"); const titleEl = card.querySelector(".zen-media-title");
const artistEl = card.querySelector(".zen-media-artist"); const artistEl = card.querySelector(".zen-media-artist");
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => titleEl.textContent === "Sandstorm", () => titleEl.textContent === "Sandstorm",
"title label reflects the page's mediaSession metadata" "title label reflects the page's mediaSession metadata"
); );
@@ -36,7 +36,7 @@ add_task(async function test_media_bar_shows_metadata_from_page() {
title: "Levels", title: "Levels",
artist: "Avicii", artist: "Avicii",
}); });
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => titleEl.textContent === "Levels", () => titleEl.textContent === "Levels",
"title updates live when the page changes its mediaSession metadata" "title updates live when the page changes its mediaSession metadata"
); );

View File

@@ -24,7 +24,7 @@ add_task(async function test_mute_from_media_bar() {
); );
clickMediaButton("zen-media-mute-button"); clickMediaButton("zen-media-mute-button");
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => mediaTab.linkedBrowser.audioMuted, () => mediaTab.linkedBrowser.audioMuted,
"tab becomes muted after clicking the media bar mute button" "tab becomes muted after clicking the media bar mute button"
); );
@@ -34,7 +34,7 @@ add_task(async function test_mute_from_media_bar() {
); );
clickMediaButton("zen-media-mute-button"); clickMediaButton("zen-media-mute-button");
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => !mediaTab.linkedBrowser.audioMuted, () => !mediaTab.linkedBrowser.audioMuted,
"clicking again unmutes the tab" "clicking again unmutes the tab"
); );

View File

@@ -21,7 +21,7 @@ add_task(async function test_next_track_relays_to_page() {
// supportedkeyschange propagates asynchronously; wait for the bar's // supportedkeyschange propagates asynchronously; wait for the bar's
// next-track button to become enabled before clicking. // next-track button to become enabled before clicking.
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => !nextButton.disabled, () => !nextButton.disabled,
"next-track button becomes enabled once the page registers a handler" "next-track button becomes enabled once the page registers a handler"
); );

View File

@@ -5,7 +5,7 @@
add_task(async function test_media_bar_shows_when_switching_off_playing_tab() { add_task(async function test_media_bar_shows_when_switching_off_playing_tab() {
gZenMediaController.closeAllCards(); gZenMediaController.closeAllCards();
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => !isMediaBarVisible(), () => !isMediaBarVisible(),
"media bar hides again once the playing tab regains focus" "media bar hides again once the playing tab regains focus"
); );
@@ -31,7 +31,7 @@ add_task(async function test_media_bar_shows_when_switching_off_playing_tab() {
// timer; wait for the visibility flip rather than racing it. // timer; wait for the visibility flip rather than racing it.
await BrowserTestUtils.switchTab(gBrowser, originalTab); await BrowserTestUtils.switchTab(gBrowser, originalTab);
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
isMediaBarVisible, isMediaBarVisible,
"media bar becomes visible after switching off the playing tab" "media bar becomes visible after switching off the playing tab"
); );
@@ -44,7 +44,7 @@ add_task(async function test_media_bar_shows_when_switching_off_playing_tab() {
await BrowserTestUtils.switchTab(gBrowser, mediaTab); await BrowserTestUtils.switchTab(gBrowser, mediaTab);
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => !isMediaBarVisible(), () => !isMediaBarVisible(),
"media bar hides again once the playing tab regains focus" "media bar hides again once the playing tab regains focus"
); );

View File

@@ -21,7 +21,7 @@ add_task(async function test_media_stack_shows_multiple_cards() {
await waitForMediaBarVisible(); await waitForMediaBarVisible();
// Cards reappear on the 500ms tab-switch debounce; wait for both. // Cards reappear on the 500ms tab-switch debounce; wait for both.
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => visibleMediaCards().length === 2, () => visibleMediaCards().length === 2,
"both playing tabs get their own card in the stack" "both playing tabs get their own card in the stack"
); );
@@ -32,7 +32,7 @@ add_task(async function test_media_stack_shows_multiple_cards() {
"front card belongs to the most recently started media" "front card belongs to the most recently started media"
); );
await BrowserTestUtils.waitForCondition(() => { await TestUtils.waitForCondition(() => {
const titles = visibleMediaCards().map( const titles = visibleMediaCards().map(
card => card.querySelector(".zen-media-title").textContent card => card.querySelector(".zen-media-title").textContent
); );
@@ -41,7 +41,7 @@ add_task(async function test_media_stack_shows_multiple_cards() {
// Closing the front card only removes that session. // Closing the front card only removes that session.
clickMediaButton("zen-media-close-button"); clickMediaButton("zen-media-close-button");
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => visibleMediaCards().length === 1, () => visibleMediaCards().length === 1,
"closing the front card only removes that card" "closing the front card only removes that card"
); );

View File

@@ -31,7 +31,7 @@ async function playVideoIn(tab) {
); );
// Wait for the browser to actually consider the tab "playing" — this is // Wait for the browser to actually consider the tab "playing" — this is
// what drives the soundplaying TabAttrModified into the media controller. // what drives the soundplaying TabAttrModified into the media controller.
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
() => tab.soundPlaying, () => tab.soundPlaying,
"tab reports soundplaying" "tab reports soundplaying"
); );
@@ -57,7 +57,7 @@ function isMediaBarVisible() {
} }
async function waitForMediaBarVisible() { async function waitForMediaBarVisible() {
await BrowserTestUtils.waitForCondition( await TestUtils.waitForCondition(
isMediaBarVisible, isMediaBarVisible,
"media bar becomes visible" "media bar becomes visible"
); );

View File

@@ -1,8 +1,10 @@
const lazy = {}; const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
BrowserTestUtils: "resource://testing-common/BrowserTestUtils.sys.mjs", BrowserTestUtils: "resource://testing-common/BrowserTestUtils.sys.mjs",
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionStore:
TabStateFlusher: "resource:///modules/sessionstore/TabStateFlusher.sys.mjs", "moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
TabStateFlusher:
"moz-src:///browser/components/sessionstore/TabStateFlusher.sys.mjs",
TestUtils: "resource://testing-common/TestUtils.sys.mjs", TestUtils: "resource://testing-common/TestUtils.sys.mjs",
}); });
@@ -89,7 +91,7 @@ export var SessionStoreTestUtils = {
"browser.sessionstore.restore_hidden_tabs" "browser.sessionstore.restore_hidden_tabs"
); );
// This should match the |restoreTabsLazily| value that // This should match the |restoreTabsLazily| value that
// SessionStore.restoreWindow() uses. // SessionStore's #restoreWindow() uses.
let restoreTabsLazily = let restoreTabsLazily =
Services.prefs.getBoolPref("browser.sessionstore.restore_on_demand") && Services.prefs.getBoolPref("browser.sessionstore.restore_on_demand") &&
Services.prefs.getBoolPref("browser.sessionstore.restore_tabs_lazily"); Services.prefs.getBoolPref("browser.sessionstore.restore_tabs_lazily");

View File

@@ -293,6 +293,8 @@ disabled="Disabled by import_external_tests.py"
["browser_restore_redirect.js"] ["browser_restore_redirect.js"]
https_first_disabled = true https_first_disabled = true
["browser_restore_respects_pending_minimize.js"]
["browser_restore_reversed_z_order.js"] ["browser_restore_reversed_z_order.js"]
skip-if = [ skip-if = [
"true", # Bug 1455602 "true", # Bug 1455602
@@ -355,7 +357,7 @@ skip-if = [
["browser_sizemodeBeforeMinimized.js"] ["browser_sizemodeBeforeMinimized.js"]
skip-if = [ skip-if = [
"os == 'linux' && os_version == '22.04' && arch == 'x86_64' && opt && nova", # Bug 2057856 "os == 'linux' && os_version == '22.04' && arch == 'x86_64'", # Bug 2057856
"os == 'win' && os_version == '11.26200' && asan", # Bug 2019745 "os == 'win' && os_version == '11.26200' && asan", # Bug 2019745
] ]

View File

@@ -3,7 +3,12 @@
add_task(async function test() { add_task(async function test() {
await SpecialPowers.pushPrefEnv({ await SpecialPowers.pushPrefEnv({
set: [["dom.require_user_interaction_for_beforeunload", false]], set: [
["dom.require_user_interaction_for_beforeunload", false],
// Keep the tab closing animation, which this test relies on to observe
// a tab in its closing state.
["ui.prefersReducedMotion", 0],
],
}); });
let url = "about:robots"; let url = "about:robots";
@@ -37,12 +42,15 @@ add_task(async function test() {
ok(tab0.linkedPanel, "active tab is not able to be suspended"); ok(tab0.linkedPanel, "active tab is not able to be suspended");
// Test that tab that is closing is not able to be suspended. // Test that tab that is closing is not able to be suspended.
gBrowser._beginRemoveTab(tab1); gBrowser.removeTab(tab1, { animate: true });
gBrowser.discardBrowser(tab1); gBrowser.discardBrowser(tab1);
ok(tab1.linkedPanel, "cannot suspend a tab that is closing"); ok(tab1.linkedPanel, "cannot suspend a tab that is closing");
gBrowser._endRemoveTab(tab1); await TestUtils.waitForCondition(
() => !tab1.isConnected,
"tab1 finished closing"
);
// Open tab containing a page which has a beforeunload handler which shows a prompt. // Open tab containing a page which has a beforeunload handler which shows a prompt.
url = url =

View File

@@ -17,7 +17,7 @@ add_task(async function test_urlbarFocus() {
newWin = openDialog( newWin = openDialog(
location, location,
"_blank", "_blank",
"chrome,extrachrome,menubar,resizable,scrollbars,status,toolbar=no,location,personal,directories,dialog=no" "chrome,resizable,toolbar=no,dialog=no"
); );
await promiseWindowLoaded(newWin); await promiseWindowLoaded(newWin);
let state2 = ss.getWindowState(newWin); let state2 = ss.getWindowState(newWin);

View File

@@ -64,6 +64,6 @@ function test_duplicateTab() {
window.addEventListener("SSWindowStateReady", onSSWindowStateReady); window.addEventListener("SSWindowStateReady", onSSWindowStateReady);
gBrowser.tabContainer.addEventListener("SSTabRestoring", onSSTabRestoring); gBrowser.tabContainer.addEventListener("SSTabRestoring", onSSTabRestoring);
gBrowser._insertBrowser(tab); gBrowser.insertBrowser(tab);
newTab = ss.duplicateTab(window, tab); newTab = ss.duplicateTab(window, tab);
} }

View File

@@ -56,6 +56,6 @@ function test_setTabState() {
window.addEventListener("SSWindowStateReady", onSSWindowStateReady); window.addEventListener("SSWindowStateReady", onSSWindowStateReady);
tab.addEventListener("SSTabRestoring", onSSTabRestoring, { once: true }); tab.addEventListener("SSTabRestoring", onSSTabRestoring, { once: true });
// Browser must be inserted in order to restore. // Browser must be inserted in order to restore.
gBrowser._insertBrowser(tab); gBrowser.insertBrowser(tab);
ss.setTabState(tab, newTabState); ss.setTabState(tab, newTabState);
} }

View File

@@ -100,7 +100,7 @@ add_task(async function test() {
!gBrowser.browsers[1].isConnected, !gBrowser.browsers[1].isConnected,
"The browser that we're attempting to insert is indeed lazy" "The browser that we're attempting to insert is indeed lazy"
); );
gBrowser._insertBrowser(gBrowser.tabs[1]); gBrowser.insertBrowser(gBrowser.tabs[1]);
is(countNonLazyTabs(), 2, "Window now has 2 non-lazy tabs"); is(countNonLazyTabs(), 2, "Window now has 2 non-lazy tabs");
// Check if any lazy tabs got inserted when window closes. // Check if any lazy tabs got inserted when window closes.
@@ -122,7 +122,7 @@ add_task(async function test() {
!newWindow.gBrowser.browsers[1].isConnected, !newWindow.gBrowser.browsers[1].isConnected,
"The browser that we're attempting to insert is indeed lazy" "The browser that we're attempting to insert is indeed lazy"
); );
newWindow.gBrowser._insertBrowser(newWindow.gBrowser.tabs[1]); newWindow.gBrowser.insertBrowser(newWindow.gBrowser.tabs[1]);
is( is(
countNonLazyTabs(newWindow), countNonLazyTabs(newWindow),
1, 1,

View File

@@ -1,6 +1,8 @@
ChromeUtils.defineESModuleGetters(this, { ChromeUtils.defineESModuleGetters(this, {
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionStore:
TabStateCache: "resource:///modules/sessionstore/TabStateCache.sys.mjs", "moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
TabStateCache:
"moz-src:///browser/components/sessionstore/TabStateCache.sys.mjs",
}); });
add_task(async function () { add_task(async function () {

View File

@@ -1,5 +1,6 @@
ChromeUtils.defineESModuleGetters(this, { ChromeUtils.defineESModuleGetters(this, {
SessionStore: "resource:///modules/sessionstore/SessionStore.sys.mjs", SessionStore:
"moz-src:///browser/components/sessionstore/SessionStore.sys.mjs",
}); });
add_task(async function () { add_task(async function () {

Some files were not shown because too many files have changed in this diff Show More