diff --git a/browser/components/tabbrowser/content/tabs.js b/browser/components/tabbrowser/content/tabs.js index 84d633471c89230b981d8a07babef4e0c76c0338..1a9c56846ff27d68c16b939fb759ea9596403cef 100644 --- a/browser/components/tabbrowser/content/tabs.js +++ b/browser/components/tabbrowser/content/tabs.js @@ -83,7 +83,7 @@ }; this.arrowScrollbox._canScrollToElement = element => { if (isTab(element)) { - return !element.pinned || !this.hasAttribute("positionpinnedtabs"); + return !element.hasAttribute("zen-essential") || !this.hasAttribute("positionpinnedtabs"); } return true; }; @@ -293,6 +293,7 @@ on_TabGroupCollapse(event) { this._invalidateCachedVisibleTabs(); this._unlockTabSizing(); + return; // If the user's selected tab is in the collapsing group, kick them off // the tab. If no tabs exist outside the group, create a new one and @@ -349,7 +350,7 @@ // and we're not hitting the scroll buttons. if ( event.button != 0 || - event.target != this.arrowScrollbox || + !event.target.classList.contains("zen-workspace-normal-tabs-section") || event.composedTarget.localName == "toolbarbutton" ) { return; @@ -699,7 +700,7 @@ if (this.#isContainerVerticalPinnedGrid(tab)) { // In expanded vertical mode, the max number of pinned tabs per row is dynamic // Set this before adjusting dragged tab's position - let pinnedTabs = this.visibleTabs.slice(0, gBrowser.pinnedTabCount); + let pinnedTabs = this.ariaFocusableItems.slice(0, gBrowser._numZenEssentials); let tabsPerRow = 0; let position = 0; for (let pinnedTab of pinnedTabs) { @@ -772,7 +773,7 @@ } else if (isTabGroupLabel(tab) && !tab.group.collapsed) { this._lockTabSizing(); this.#keepTabSizeLocked = true; - tab.group.collapsed = true; + tab.group.collapsed = !tab.group.hasAttribute("split-view-group"); expandGroupOnDrop = true; } } @@ -921,6 +922,10 @@ } let draggedTab = event.dataTransfer.mozGetDataAt(TAB_DROP_TYPE, 0); + if (draggedTab && effects === "move") { + gZenPinnedTabManager.applyDragoverClass(event, draggedTab); + gZenViewSplitter.onBrowserDragEndToSplit(event); + } if ( (effects == "move" || effects == "copy") && document == draggedTab.ownerDocument && @@ -1077,6 +1082,18 @@ this._tabDropIndicator.hidden = true; event.stopPropagation(); + if (draggedTab?.hasAttribute("zen-has-splitted")) { + draggedTab.removeAttribute("zen-has-splitted"); + draggedTab._visuallySelected = false; + } + if (draggedTab && dropEffect == "move") { + let moved = gZenPinnedTabManager.moveToAnotherTabContainerIfNecessary(event, movingTabs); + + if (moved) { + this.finishMoveTogetherSelectedTabs(draggedTab); + return; + } + } if (draggedTab && dropEffect == "copy") { let duplicatedDraggedTab; let duplicatedTabs = []; @@ -1116,10 +1133,11 @@ } } else { let isPinned = draggedTab.pinned; - let numPinned = gBrowser.pinnedTabCount; + let numPinned = gBrowser._numVisiblePinTabsWithoutCollapsed; + let essential = draggedTab.hasAttribute("zen-essential"); let tabs = this.ariaFocusableItems.slice( - isPinned ? 0 : numPinned, - isPinned ? numPinned : undefined + isPinned ? (essential ? 0 : gBrowser._numZenEssentials) : numPinned, + isPinned ? (essential ? gBrowser._numZenEssentials : numPinned) : undefined ); let size = this.verticalMode ? "height" : "width"; let screenAxis = this.verticalMode ? "screenY" : "screenX"; @@ -1211,7 +1229,7 @@ item.removeAttribute("tabdrop-samewindow"); resolve(); }; - if (gReduceMotion) { + if (true || gReduceMotion) { postTransitionCleanup(); } else { let onTransitionEnd = transitionendEvent => { @@ -1337,6 +1355,7 @@ let nextItem = this.ariaFocusableItems[newIndex]; let tabGroup = isTab(nextItem) && nextItem.group; + if (gZenViewSplitter.handleTabDrop(event, urls, replace, inBackground)) return; gBrowser.loadTabs(urls, { inBackground, replace, @@ -1369,6 +1388,17 @@ this.finishMoveTogetherSelectedTabs(draggedTab); this.finishAnimateTabMove(); + + if (!dt.mozUserCancelled && dt.dropEffect == "none" && !this._isCustomizing) { + const moved = gZenViewSplitter.moveTabToSplitView(event, draggedTab); + if (moved) { + delete draggedTab._dragData; + return; + } + } else if (dt.mozUserCancelled) { + if (gZenViewSplitter._lastOpenedTab) gZenViewSplitter._lastOpenedTab._visuallySelected = false; + } + this.#expandGroupOnDrop(draggedTab); if ( @@ -1597,7 +1627,7 @@ } get newTabButton() { - return this.querySelector("#tabs-newtab-button"); + return gZenWorkspaces.activeWorkspaceStrip.querySelector("#tabs-newtab-button"); } get verticalMode() { @@ -1621,29 +1651,54 @@ if (this.#allTabs) { return this.#allTabs; } - let children = Array.from(this.arrowScrollbox.children); + let children = gZenWorkspaces.tabboxChildren; // remove arrowScrollbox periphery element children.pop(); // explode tab groups // Iterate backwards over the array to preserve indices while we modify // things in place - for (let i = children.length - 1; i >= 0; i--) { - if (children[i].tagName == "tab-group") { - children.splice(i, 1, ...children[i].tabs); + const pinnedTabs = [...gZenWorkspaces.getCurrentEssentialsContainer().children, ...this.verticalPinnedTabsContainer.children]; + const expandTabs = (tabs) => { + for (let i = tabs.length - 1; i >= 0; i--) { + const tab = tabs[i]; + if (isTabGroup(tab)) { + // remove the group from the list + tabs.splice(i, 1); + // add the tabs in the group to the list + tabs.splice(i, 0, ...tab.tabs); + } } } - - this.#allTabs = [ - ...this.verticalPinnedTabsContainer.children, + expandTabs(pinnedTabs); + expandTabs(children); + const allTabs = [ + ...pinnedTabs, ...children, ]; + const lastPinnedTabIdx = pinnedTabs.length - 1; + let i = 0; + for (const tab of [...allTabs]) { + // add glance tabs (tabs inside tabs) to the list + const glanceTab = tab.glanceTab; + if (glanceTab) { + // insert right after the parent tab. note: it must be inserted before + // the last pinned tab so it can be inserted in the correct order + allTabs.splice(Math.max(i++, lastPinnedTabIdx), 0, glanceTab); + } else if (tab.classList.contains("vertical-pinned-tabs-container-separator")) { + // remove the separator from the list + allTabs.splice(i, 1); + i--; + } + i++; + } + this.#allTabs = allTabs; return this.#allTabs; } get allGroups() { let children = Array.from(this.arrowScrollbox.children); - return children.filter(node => node.tagName == "tab-group"); + return gZenWorkspaces.allTabGroups; } /** @@ -1698,23 +1753,18 @@ } let elementIndex = 0; - let verticalPinnedTabsContainer = document.getElementById( - "vertical-pinned-tabs-container" - ); - for (let i = 0; i < verticalPinnedTabsContainer.childElementCount; i++) { - verticalPinnedTabsContainer.children[i].elementIndex = elementIndex++; - } - let children = Array.from(this.arrowScrollbox.children); + let verticalPinnedTabsContainer = this.verticalPinnedTabsContainer + let children = gZenWorkspaces.tabboxChildrenWithoutEmpty; let focusableItems = []; - for (let child of children) { + for (let child of [...gZenWorkspaces.getCurrentEssentialsContainer().children, ...verticalPinnedTabsContainer.children, ...children]) { if (isTab(child) && child.visible) { child.elementIndex = elementIndex++; focusableItems.push(child); } else if (isTabGroup(child)) { child.labelElement.elementIndex = elementIndex++; focusableItems.push(child.labelElement); - if (!child.collapsed) { + if (!child.collapsed && !child.hasAttribute("split-view-group")) { let visibleTabsInGroup = child.tabs.filter(tab => tab.visible); visibleTabsInGroup.forEach(tab => { tab.elementIndex = elementIndex++; @@ -1724,10 +1774,7 @@ } } - this.#focusableItems = [ - ...verticalPinnedTabsContainer.children, - ...focusableItems, - ]; + this.#focusableItems = focusableItems; return this.#focusableItems; } @@ -1735,6 +1782,7 @@ _invalidateCachedTabs() { this.#allTabs = null; this._invalidateCachedVisibleTabs(); + gZenWorkspaces._allStoredTabs = null; } _invalidateCachedVisibleTabs() { @@ -1749,8 +1797,8 @@ #isContainerVerticalPinnedGrid(tab) { return ( this.verticalMode && - tab.hasAttribute("pinned") && - this.hasAttribute("expanded") && + (tab.hasAttribute("zen-essential")) && + (this.hasAttribute("expanded") || document.documentElement.hasAttribute("zen-sidebar-expanded")) && !this.expandOnHover ); } @@ -1766,7 +1814,7 @@ if (node == null) { // We have a container for non-tab elements at the end of the scrollbox. - node = this.arrowScrollbox.lastChild; + node = gZenWorkspaces.activeWorkspaceStrip.lastChild; } node.before(tab); @@ -1861,7 +1909,7 @@ // There are separate "new tab" buttons for horizontal tabs toolbar, vertical tabs and // for when the tab strip is overflowed (which is shared by vertical and horizontal tabs); // Attach the long click popup to all of them. - const newTab = document.getElementById("new-tab-button"); + const newTab = gZenWorkspaces.activeWorkspaceStrip.querySelector("#tabs-newtab-button"); const newTab2 = this.newTabButton; const newTabVertical = document.getElementById( "vertical-tabs-newtab-button" @@ -1956,10 +2004,12 @@ _handleTabSelect(aInstant) { let selectedTab = this.selectedItem; + if (!selectedTab) return; if (this.overflowing) { this.arrowScrollbox.ensureElementIsVisible(selectedTab, aInstant); } + gZenCompactModeManager.flashSidebarIfNecessary(aInstant); selectedTab._notselectedsinceload = false; } @@ -2132,6 +2182,7 @@ } _positionPinnedTabs() { + if (true) return; let tabs = this.visibleTabs; let numPinned = gBrowser.pinnedTabCount; let absPositionHorizontalTabs = @@ -2206,7 +2257,7 @@ return; } - let tabs = this.visibleTabs.slice(0, gBrowser.pinnedTabCount); + let tabs = this.ariaFocusableItems.slice(0, gBrowser._numZenEssentials); let directionX = screenX > dragData.animLastScreenX; let directionY = screenY > dragData.animLastScreenY; @@ -2214,7 +2265,7 @@ dragData.animLastScreenX = screenX; let { width: tabWidth, height: tabHeight } = - draggedTab.getBoundingClientRect(); + (draggedTab.group?.hasAttribute("split-view-group") ? draggedTab.group : draggedTab).getBoundingClientRect(); let shiftSizeX = tabWidth * movingTabs.length; let shiftSizeY = tabHeight; dragData.tabWidth = tabWidth; @@ -2389,12 +2440,16 @@ this.#clearDragOverCreateGroupTimer(); - let isPinned = draggedTab.pinned; - let numPinned = gBrowser.pinnedTabCount; + let isPinned = draggedTab?.group ? draggedTab.group.pinned : draggedTab.pinned; + let numPinned = gBrowser._numVisiblePinTabsWithoutCollapsed; + let essential = draggedTab.hasAttribute("zen-essential"); let tabs = this.ariaFocusableItems.slice( - isPinned ? 0 : numPinned, - isPinned ? numPinned : undefined + isPinned ? (essential ? 0 : gBrowser._numZenEssentials) : numPinned, + isPinned ? (essential ? gBrowser._numZenEssentials : numPinned) : undefined ); + if (draggedTab.group?.hasAttribute("split-view-group")) { + draggedTab = draggedTab.group.labelElement; + } if (this.#rtlMode) { tabs.reverse(); @@ -2408,7 +2463,7 @@ let size = this.verticalMode ? "height" : "width"; let translateAxis = this.verticalMode ? "translateY" : "translateX"; let scrollDirection = this.verticalMode ? "scrollTop" : "scrollLeft"; - let { width: tabWidth, height: tabHeight } = bounds(draggedTab); + let { width: tabWidth, height: tabHeight } = bounds(draggedTab.group?.hasAttribute("split-view-group") ? draggedTab.group : draggedTab); let translateX = event.screenX - dragData.screenX; let translateY = event.screenY - dragData.screenY; @@ -2422,12 +2477,21 @@ let lastTab = tabs.at(-1); let lastMovingTab = movingTabs.at(-1); let firstMovingTab = movingTabs[0]; + if (lastMovingTab.group?.hasAttribute("split-view-group")) { + lastMovingTab = lastMovingTab.group; + } + if (firstMovingTab.group?.hasAttribute("split-view-group")) { + firstMovingTab = firstMovingTab.group; + } let endEdge = ele => ele[screenAxis] + bounds(ele)[size]; let lastMovingTabScreen = endEdge(lastMovingTab); let firstMovingTabScreen = firstMovingTab[screenAxis]; let shiftSize = lastMovingTabScreen - firstMovingTabScreen; + if (firstMovingTab.hasAttribute("split-view-group")) { + shiftSize += 5; // A hack to allow more space for the group + } let translate = screen - dragData[screenAxis]; - if (!isPinned) { + if (true) { translate += this.arrowScrollbox.scrollbox[scrollDirection] - dragData.scrollPos; } else if (isPinned && this.verticalMode) { @@ -2446,6 +2510,9 @@ // Shift the `.tab-group-label-container` to shift the label element. item = item.parentElement; } + if (item.parentElement?.hasAttribute("split-view-group")) { + item = item.parentElement; + } item.style.transform = `${translateAxis}(${translate}px)`; } @@ -2583,6 +2650,9 @@ break; } let element = tabs[mid]; + if (element?.group?.hasAttribute("split-view-group")) { + element = element.group.labelElement; + } let elementForSize = isTabGroupLabel(element) ? element.parentElement : element; @@ -2605,6 +2675,10 @@ if (!dropElement) { dropElement = this.ariaFocusableItems[oldDropElementIndex]; } + if (dropElement?.group?.hasAttribute("split-view-group")) { + // We focus the group label element, not the group itself. + dropElement = dropElement.group.labelElement; + } let newDropElementIndex = dropElement ? dropElement.elementIndex : oldDropElementIndex; @@ -2613,7 +2687,7 @@ let shouldCreateGroupOnDrop; let dropBefore; if (dropElement) { - let dropElementForOverlap = isTabGroupLabel(dropElement) + let dropElementForOverlap = isTabGroupLabel(dropElement) && !dropElement.closest("tab-group")?.hasAttribute("split-view-group") ? dropElement.parentElement : dropElement; @@ -2675,12 +2749,12 @@ } } - if (gBrowser._tabGroupsEnabled && isTab(draggedTab) && !isPinned) { + if (true) { let dragOverGroupingThreshold = 1 - moveOverThreshold; // When dragging tab(s) over an ungrouped tab, signal to the user // that dropping the tab(s) will create a new tab group. - shouldCreateGroupOnDrop = + shouldCreateGroupOnDrop = false && dropElement != draggedTab && isTab(dropElement) && !dropElement?.group && @@ -2750,7 +2824,7 @@ // Shift background tabs to leave a gap where the dragged tab // would currently be dropped. for (let item of tabs) { - if (item == draggedTab) { + if (item == draggedTab || (item.group?.hasAttribute("split-view-group") && item.group == draggedTab.group)) { continue; } @@ -2759,6 +2833,9 @@ if (isTabGroupLabel(item)) { // Shift the `.tab-group-label-container` to shift the label element. item = item.parentElement; + if (item.parentElement?.hasAttribute("split-view-group")) { + item = item.parentElement; + } } item.style.transform = transform; } @@ -2811,8 +2888,9 @@ ); } - finishAnimateTabMove() { - if (!this.#isMovingTab()) { + finishAnimateTabMove(always = false) { + gZenPinnedTabManager.removeTabContainersDragoverClass(); + if (!this.#isMovingTab() && !always) { return; } @@ -2824,6 +2902,12 @@ item = item.parentElement; } item.style.transform = ""; + if (item.closest("tab-group")?.hasAttribute("split-view-group")) item.closest("tab-group").style.transform = ""; + if (item.closest("tab-group")?.hasAttribute("split-view-group")) { + for (let tab of item.closest("tab-group").tabs) { + tab.style.transform = ""; + } + } item.removeAttribute("dragover-createGroup"); } this.removeAttribute("movingtab-createGroup"); @@ -2870,7 +2954,7 @@ let postTransitionCleanup = () => { movingTab._moveTogetherSelectedTabsData.animate = false; }; - if (gReduceMotion) { + if (true || gReduceMotion) { postTransitionCleanup(); } else { let onTransitionEnd = transitionendEvent => { @@ -3043,7 +3127,7 @@ } _notifyBackgroundTab(aTab) { - if (aTab.pinned || !aTab.visible || !this.overflowing) { + if (aTab.hasAttribute("zen-essential") || !aTab.visible || !this.overflowing) { return; } @@ -3169,6 +3253,9 @@ return null; } } + if (target?.group?.hasAttribute("split-view-group")) { + target = target.group.labelElement; + } return target; }