Files
desktop/src/browser/components/tabbrowser/content/tabgroup-js.patch
mr. m b66b05dcf6 feat: Allow pinned tabs to be collapsible, p=#11753, c=tabs, folders, workspaces
* fix: Fixed restoring the previous pinned state clearing up the custom icon, b=no-bug, c=tabs

* feat: Allow pinned tabs to be collapsible, b=no-bug, c=tabs, folders, workspaces

* fix: Fixed new folder context menu item not working, b=no-bug, c=common, folders
2025-12-28 17:58:18 +01:00

215 lines
6.6 KiB
C++

diff --git a/browser/components/tabbrowser/content/tabgroup.js b/browser/components/tabbrowser/content/tabgroup.js
index 394b2af2e187b82bb3e98ebcdc6e66b63036e20d..e92927612abf12631c384a8f54b6a607fb699424 100644
--- a/browser/components/tabbrowser/content/tabgroup.js
+++ b/browser/components/tabbrowser/content/tabgroup.js
@@ -14,11 +14,11 @@
class MozTabbrowserTabGroup extends MozXULElement {
static markup = `
<vbox class="tab-group-label-container" pack="center">
- <vbox class="tab-group-label-hover-highlight" pack="center">
<label class="tab-group-label" role="button" />
- </vbox>
</vbox>
- <html:slot/>
+ <html:div class="tab-group-container">
+ <html:div class="zen-tab-group-start"/>
+ </html:div>
<vbox class="tab-group-overflow-count-container" pack="center">
<label class="tab-group-overflow-count" role="button" />
</vbox>
@@ -69,20 +69,36 @@
}
connectedCallback() {
+ if (this._lastGroup && this._lastGroup !== this.group) {
+ this._lastGroup.dispatchEvent(
+ new CustomEvent("FolderUngrouped", {
+ bubbles: true,
+ detail: this,
+ })
+ );
+ }
+ if (this.group && this._lastGroup != this.group) {
+ this._lastGroup = this.group;
+ this.group.dispatchEvent(
+ new CustomEvent("FolderGrouped", {
+ bubbles: true,
+ detail: this,
+ })
+ );
+ } else if (!this.group) {
+ this._lastGroup = null;
+ }
// Always set the mutation observer to listen for tab change events, even
// if we are already initialized.
// This is needed to ensure events continue to fire even if the tab group is
// moved from the horizontal to vertical tab layout or vice-versa, which
// causes the component to be repositioned in the DOM.
- this.#observeTabChanges();
// Similar to above, always set up TabSelect listener, as this gets
// removed in disconnectedCallback
this.ownerGlobal.addEventListener("TabSelect", this);
- if (this._initialized) {
- return;
- }
+ if (!this._initialized) {
this._initialized = true;
this.saveOnWindowClose = true;
@@ -114,11 +130,14 @@
this.#labelContainerElement.addEventListener("mouseover", this);
this.#labelContainerElement.addEventListener("mouseout", this);
- this.#labelElement.addEventListener("contextmenu", e => {
- e.preventDefault();
- gBrowser.tabGroupMenu.openEditModal(this);
- return false;
- });
+ this.appendChild = function (child) {
+ this.groupContainer.appendChild(child);
+ for (let tab of this.tabs) {
+ if (tab.hasAttribute("zen-empty-tab") && tab.group === this) {
+ this.groupStartElement.after(tab);
+ }
+ }
+ };
this.#updateLabelAriaAttributes();
@@ -143,6 +162,8 @@
// mounts after getting created by `Tabbrowser.adoptTabGroup`.
this.#wasCreatedByAdoption = false;
}
+ this.#observeTabChanges();
+ }
resetDefaultGroupName = () => {
this.#defaultGroupName = "";
@@ -211,7 +232,10 @@
}
});
}
- this.#tabChangeObserver.observe(this, { childList: true });
+ const container = this.groupContainer;
+ if (container) {
+ this.#tabChangeObserver.observe(container, { childList: true });
+ }
}
get color() {
@@ -305,6 +329,9 @@
}
set collapsed(val) {
+ if (this.hasAttribute("split-view-group")) {
+ return;
+ }
if (!!val == this.collapsed) {
return;
}
@@ -391,7 +418,6 @@
tabGroupName,
})
.then(result => {
- this.dataset.tooltip = result;
});
}
@@ -466,13 +492,65 @@
* @returns {MozTabbrowserTab[]}
*/
get tabs() {
- let childrenArray = Array.from(this.children);
- for (let i = childrenArray.length - 1; i >= 0; i--) {
- if (childrenArray[i].tagName == "tab-split-view-wrapper") {
- childrenArray.splice(i, 1, ...childrenArray[i].tabs);
+ // add other group tabs if they are under this group
+ let childs = Array.from(this.groupContainer?.children ?? []);
+ const tabsCollect = [];
+ for (let item of childs) {
+ tabsCollect.push(item);
+ if (gBrowser.isTabGroup(item)) {
+ tabsCollect.push(...item.tabs);
}
}
- return childrenArray.filter(node => node.matches("tab"));
+ return tabsCollect.filter(node => node.matches("tab"));
+ }
+
+ get groupContainer() {
+ return this.querySelector(".tab-group-container");
+ }
+
+ get groupStartElement() {
+ return this.querySelector(".zen-tab-group-start");
+ }
+
+ get childGroupsAndTabs() {
+ const result = [];
+ const container = this.groupContainer;
+
+ for (const item of Array.from(container.children)) {
+ if (gBrowser.isTab(item)) {
+ result.push(item);
+ } else if (gBrowser.isTabGroup(item)) {
+ const labelContainer = item.labelElement;
+ labelContainer.visible = item.visible;
+ if (gBrowser.isTabGroupLabel(labelContainer)) {
+ result.push(labelContainer);
+ }
+ result.push(...item.childGroupsAndTabs);
+ }
+ }
+ return result;
+ }
+
+ get group() {
+ if (gBrowser.isTabGroup(this.parentElement?.parentElement)) {
+ return this.parentElement.parentElement;
+ }
+ return null;
+ }
+
+ get visible() {
+ let currentGroup = this;
+ while (currentGroup?.group) {
+ currentGroup = currentGroup?.group;
+ if (currentGroup.collapsed) {
+ return false;
+ }
+ }
+ return true;
+ }
+
+ get level() {
+ return this.group?.level + 1 || 0;
}
/**
@@ -553,7 +631,6 @@
addTabs(tabs, metricsContext) {
for (let tab of tabs) {
if (tab.pinned) {
- tab.ownerGlobal.gBrowser.unpinTab(tab);
}
let tabToMove =
this.ownerGlobal === tab.ownerGlobal
@@ -616,7 +693,7 @@
*/
on_click(event) {
let isToggleElement =
- event.target === this.#labelElement ||
+ this.labelElement.parentElement.contains(event.target) ||
event.target === this.#overflowCountLabel;
if (isToggleElement && event.button === 0) {
event.preventDefault();
@@ -687,5 +764,6 @@
}
}
+ window.MozTabbrowserTabGroup = MozTabbrowserTabGroup;
customElements.define("tab-group", MozTabbrowserTabGroup);
}