mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-10-11 12:26:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

macos: Sparkle notFound acknowledgement should only be called on dismiss (#9126)

Browse Source 
This was causing the "no update found" message to never really appear in
the real world.
This commit is contained in:
Mitchell Hashimoto
2025-10-10 09:30:12 -07:00
committed by GitHub
parent 2bf9c777d7
commit 207eccffda
5 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
macos/Sources/Features/Update/UpdatePopoverView.swift
View File

@@ -41,8 +41,8 @@ struct UpdatePopoverView: View {
case .installing:
InstallingView()
case .notFound:
NotFoundView(dismiss: dismiss)
case .notFound(let notFound):
NotFoundView(notFound: notFound, dismiss: dismiss)
case .error(let error):
UpdateErrorView(error: error, dismiss: dismiss)
@@ -331,6 +331,7 @@ fileprivate struct InstallingView: View {
}
fileprivate struct NotFoundView: View {
let notFound: UpdateState.NotFound
let dismiss: DismissAction
var body: some View {
@@ -348,6 +349,7 @@ fileprivate struct NotFoundView: View {
HStack {
Spacer()
Button("OK") {
notFound.acknowledgement()
dismiss()
}
.keyboardShortcut(.defaultAction)