mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-09-29 06:28:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use shallow search to improve performance

Browse Source
This commit is contained in:
Pete Schaffner
2024-02-07 21:39:36 +01:00
parent bc946109b7
commit 591c05641b
2 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
macos/Sources/Features/Terminal/TerminalWindow.swift
View File

@@ -37,9 +37,9 @@ class TerminalWindow: NSWindow {
override func updateConstraintsIfNeeded() { override func updateConstraintsIfNeeded() {
super.updateConstraintsIfNeeded() super.updateConstraintsIfNeeded()
guard let titlebarContainer = contentView?.superview?.firstSubview(withClassName: "NSTitlebarContainerView") else { guard let titlebarContainer = contentView?.superview?.subviews.first(where: {
return $0.className == "NSTitlebarContainerView"
} }) else { return }
for v in titlebarContainer.subviews(withClassName: "NSTitlebarSeparatorView") { for v in titlebarContainer.subviews(withClassName: "NSTitlebarSeparatorView") {
v.isHidden = true v.isHidden = true
@@ -82,9 +82,9 @@ class TerminalWindow: NSWindow {
func setTitlebarBackground(_ color: CGColor) { func setTitlebarBackground(_ color: CGColor) {
storedTitlebarBackgroundColor = color storedTitlebarBackgroundColor = color
guard let titlebarContainer = contentView?.superview?.firstSubview(withClassName: "NSTitlebarContainerView") else { guard let titlebarContainer = contentView?.superview?.subviews.first(where: {
return $0.className == "NSTitlebarContainerView"
} }) else { return }
titlebarContainer.wantsLayer = true titlebarContainer.wantsLayer = true
titlebarContainer.layer?.backgroundColor = color titlebarContainer.layer?.backgroundColor = color
@@ -146,10 +146,9 @@ class TerminalWindow: NSWindow {
guard let accessoryClipView = accessoryView.superview else { return } guard let accessoryClipView = accessoryView.superview else { return }
guard let titlebarView = accessoryClipView.superview else { return } guard let titlebarView = accessoryClipView.superview else { return }
guard titlebarView.className == "NSTitlebarView" else { return } guard titlebarView.className == "NSTitlebarView" else { return }
guard let toolbarView = titlebarView.subviews.first(where: {
guard let toolbarView = titlebarView.firstSubview(withClassName: "NSToolbarView") else { $0.className == "NSToolbarView"
return }) else { return }
}
addWindowButtonsBackdrop(titlebarView: titlebarView, toolbarView: toolbarView) addWindowButtonsBackdrop(titlebarView: titlebarView, toolbarView: toolbarView)
guard let windowButtonsBackdrop = windowButtonsBackdrop else { return } guard let windowButtonsBackdrop = windowButtonsBackdrop else { return }

11
macos/Sources/Helpers/NSView+Extension.swift
View File

@@ -1,17 +1,6 @@
import AppKit import AppKit
extension NSView { extension NSView {
func firstSubview(withClassName name: String) -> NSView? {
for subview in subviews {
if String(describing: type(of: subview)) == name {
return subview
} else if let found = subview.firstSubview(withClassName: name) {
return found
}
}
return nil
}
func subviews(withClassName name: String) -> [NSView] { func subviews(withClassName name: String) -> [NSView] {
var result = [NSView]() var result = [NSView]()