mirror of
https://github.com/ghostty-org/ghostty.git
synced 2026-01-02 03:22:37 +00:00
Rename goto_split top/bottom directions to up/down. (#3427)
Renames the top/bottom directions of `goto_split` to up/down. I have tested this on linux (nixos) but given that `goto_split` is broken on linux anyway (#2866) there's not a whole lot to test. I have no way to build on macOS so I can't verify that I've changed everything correctly for that. Closes #3237
This commit is contained in:
@@ -478,10 +478,42 @@ pub const Action = union(enum) {
|
||||
previous,
|
||||
next,
|
||||
|
||||
top,
|
||||
up,
|
||||
left,
|
||||
bottom,
|
||||
down,
|
||||
right,
|
||||
|
||||
pub fn parse(input: []const u8) !SplitFocusDirection {
|
||||
return std.meta.stringToEnum(SplitFocusDirection, input) orelse {
|
||||
// For backwards compatibility we map "top" and "bottom" onto the enum
|
||||
// values "up" and "down"
|
||||
if (std.mem.eql(u8, input, "top")) {
|
||||
return .up;
|
||||
} else if (std.mem.eql(u8, input, "bottom")) {
|
||||
return .down;
|
||||
} else {
|
||||
return Error.InvalidFormat;
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
test "parse" {
|
||||
const testing = std.testing;
|
||||
|
||||
try testing.expectEqual(.previous, try SplitFocusDirection.parse("previous"));
|
||||
try testing.expectEqual(.next, try SplitFocusDirection.parse("next"));
|
||||
|
||||
try testing.expectEqual(.up, try SplitFocusDirection.parse("up"));
|
||||
try testing.expectEqual(.left, try SplitFocusDirection.parse("left"));
|
||||
try testing.expectEqual(.down, try SplitFocusDirection.parse("down"));
|
||||
try testing.expectEqual(.right, try SplitFocusDirection.parse("right"));
|
||||
|
||||
try testing.expectEqual(.up, try SplitFocusDirection.parse("top"));
|
||||
try testing.expectEqual(.down, try SplitFocusDirection.parse("bottom"));
|
||||
|
||||
try testing.expectError(error.InvalidFormat, SplitFocusDirection.parse(""));
|
||||
try testing.expectError(error.InvalidFormat, SplitFocusDirection.parse("green"));
|
||||
}
|
||||
};
|
||||
|
||||
pub const SplitResizeDirection = enum {
|
||||
@@ -524,7 +556,16 @@ pub const Action = union(enum) {
|
||||
comptime field: std.builtin.Type.UnionField,
|
||||
param: []const u8,
|
||||
) !field.type {
|
||||
return switch (@typeInfo(field.type)) {
|
||||
const field_info = @typeInfo(field.type);
|
||||
|
||||
// Fields can provide a custom "parse" function
|
||||
if (field_info == .Struct or field_info == .Union or field_info == .Enum) {
|
||||
if (@hasDecl(field.type, "parse") and @typeInfo(@TypeOf(field.type.parse)) == .Fn) {
|
||||
return field.type.parse(param);
|
||||
}
|
||||
}
|
||||
|
||||
return switch (field_info) {
|
||||
.Enum => try parseEnum(field.type, param),
|
||||
.Int => try parseInt(field.type, param),
|
||||
.Float => try parseFloat(field.type, param),
|
||||
|
||||
Reference in New Issue
Block a user