From a7eaecf929b9a060962d3491d926f7d6b8fd0c63 Mon Sep 17 00:00:00 2001
From: Lukas <134181853+bo2themax@users.noreply.github.com>
Date: Sun, 26 Apr 2026 13:52:58 +0200
Subject: [PATCH] test: always use temporary config when running ui tests

---
 .../GhosttyCustomConfigCase.swift              | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/macos/GhosttyUITests/GhosttyCustomConfigCase.swift b/macos/GhosttyUITests/GhosttyCustomConfigCase.swift
index 645848095..5df4b432a 100644
--- a/macos/GhosttyUITests/GhosttyCustomConfigCase.swift
+++ b/macos/GhosttyUITests/GhosttyCustomConfigCase.swift
@@ -25,32 +25,24 @@ class GhosttyCustomConfigCase: XCTestCase {
 
     static let defaultsSuiteName: String = "GHOSTTY_UI_TESTS"
 
-    var configFile: URL?
+    private let configFile: URL = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
+        .appendingPathExtension("ghostty")
+
     override func setUpWithError() throws {
         continueAfterFailure = false
     }
 
     override func tearDown() async throws {
-        if let configFile {
-            try FileManager.default.removeItem(at: configFile)
-        }
+        try? FileManager.default.removeItem(at: configFile)
     }
 
     func updateConfig(_ newConfig: String) throws {
-        if configFile == nil {
-            let temporaryConfig = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
-                .appendingPathExtension("ghostty")
-            configFile = temporaryConfig
-        }
-        try newConfig.write(to: configFile!, atomically: true, encoding: .utf8)
+        try newConfig.write(to: configFile, atomically: true, encoding: .utf8)
     }
 
     func ghosttyApplication(defaultsSuite: String = GhosttyCustomConfigCase.defaultsSuiteName) throws -> XCUIApplication {
         let app = XCUIApplication()
         app.launchArguments.append(contentsOf: ["-ApplePersistenceIgnoreState", "YES"])
-        guard let configFile else {
-            return app
-        }
         app.launchEnvironment["GHOSTTY_CONFIG_PATH"] = configFile.path
         app.launchEnvironment["GHOSTTY_USER_DEFAULTS_SUITE"] = defaultsSuite
         return app