mirrors/ghostty
1
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-09-30 23:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

macos 26: fix visual glitches with moving tabs and titlebar tabs (#8594)

Browse Source 
This is a hacky fix to fix some visual glitches when titlebar tabs is on
and we're using the `move_tab` keybinding action (I test via the command
palette).

There is probably a more graceful way to fix this but this might be good
enough for a 1.2 to fix a very obviously nasty UI render.
This commit is contained in:
Mitchell Hashimoto
2025-09-11 14:57:07 -07:00
committed by GitHub
parent 7f3ee19225 09246780bb
commit a8c3186658
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
macos/Sources/Features/Terminal/TerminalController.swift
View File

@@ -1220,6 +1220,23 @@ class TerminalController: BaseTerminalController, TabGroupCloseCoordinator.Contr
// Get our target window // Get our target window
let targetWindow = tabbedWindows[finalIndex] let targetWindow = tabbedWindows[finalIndex]
// Moving tabs on macOS 26 RC causes very nasty visual glitches in the titlebar tabs.
// I believe this is due to messed up constraints for our hacky tab bar. I'd like to
// find a better workaround. For now, this improves things dramatically.
//
// Reproduction: titlebar tabs, create two tabs, "move tab left"
if #available(macOS 26, *) {
if window is TitlebarTabsTahoeTerminalWindow {
tabGroup.removeWindow(selectedWindow)
targetWindow.addTabbedWindow(selectedWindow, ordered: action.amount < 0 ? .below : .above)
DispatchQueue.main.async {
selectedWindow.makeKey()
}
return
}
}
// Begin a group of window operations to minimize visual updates // Begin a group of window operations to minimize visual updates
NSAnimationContext.beginGrouping() NSAnimationContext.beginGrouping()
NSAnimationContext.current.duration = 0 NSAnimationContext.current.duration = 0