From abd7d9202b977c62924769779a24c3bc6d8af964 Mon Sep 17 00:00:00 2001
From: Leah Amelia Chen <hi@pluie.me>
Date: Mon, 14 Apr 2025 21:43:02 +0800
Subject: [PATCH] gtk(bell): mark tab as needing attention on bell

---
 src/apprt/gtk/Surface.zig |  8 ++++++++
 src/apprt/gtk/TabView.zig | 22 ++++++++++++++--------
 2 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/src/apprt/gtk/Surface.zig b/src/apprt/gtk/Surface.zig
index 230c9a3c3..76de2a312 100644
--- a/src/apprt/gtk/Surface.zig
+++ b/src/apprt/gtk/Surface.zig
@@ -2450,4 +2450,12 @@ pub fn ringBell(self: *Surface) !void {
     if (window.window.as(gtk.Native).getSurface()) |surface| {
         surface.beep();
     }
+
+    // Mark tab as needing attention
+    if (self.container.tab()) |tab| tab: {
+        const page = window.notebook.getTabPage(tab) orelse break :tab;
+
+        // Need attention if we're not the currently selected tab
+        if (page.getSelected() == 0) page.setNeedsAttention(@intFromBool(true));
+    }
 }
diff --git a/src/apprt/gtk/TabView.zig b/src/apprt/gtk/TabView.zig
index 85a9bbcb2..ddd0951d2 100644
--- a/src/apprt/gtk/TabView.zig
+++ b/src/apprt/gtk/TabView.zig
@@ -114,9 +114,12 @@ pub fn gotoNthTab(self: *TabView, position: c_int) bool {
     return true;
 }
 
+pub fn getTabPage(self: *TabView, tab: *Tab) ?*adw.TabPage {
+    return self.tab_view.getPage(tab.box.as(gtk.Widget));
+}
+
 pub fn getTabPosition(self: *TabView, tab: *Tab) ?c_int {
-    const page = self.tab_view.getPage(tab.box.as(gtk.Widget));
-    return self.tab_view.getPagePosition(page);
+    return self.tab_view.getPagePosition(self.getTabPage(tab) orelse return null);
 }
 
 pub fn gotoPreviousTab(self: *TabView, tab: *Tab) bool {
@@ -161,17 +164,16 @@ pub fn moveTab(self: *TabView, tab: *Tab, position: c_int) void {
 }
 
 pub fn reorderPage(self: *TabView, tab: *Tab, position: c_int) void {
-    const page = self.tab_view.getPage(tab.box.as(gtk.Widget));
-    _ = self.tab_view.reorderPage(page, position);
+    _ = self.tab_view.reorderPage(self.getTabPage(tab) orelse return, position);
 }
 
 pub fn setTabTitle(self: *TabView, tab: *Tab, title: [:0]const u8) void {
-    const page = self.tab_view.getPage(tab.box.as(gtk.Widget));
+    const page = self.getTabPage(tab) orelse return;
     page.setTitle(title.ptr);
 }
 
 pub fn setTabTooltip(self: *TabView, tab: *Tab, tooltip: [:0]const u8) void {
-    const page = self.tab_view.getPage(tab.box.as(gtk.Widget));
+    const page = self.getTabPage(tab) orelse return;
     page.setTooltip(tooltip.ptr);
 }
 
@@ -203,8 +205,7 @@ pub fn closeTab(self: *TabView, tab: *Tab) void {
         if (n > 1) self.forcing_close = false;
     }
 
-    const page = self.tab_view.getPage(tab.box.as(gtk.Widget));
-    self.tab_view.closePage(page);
+    if (self.getTabPage(tab)) |page| self.tab_view.closePage(page);
 
     // If we have no more tabs we close the window
     if (self.nPages() == 0) {
@@ -260,6 +261,11 @@ fn adwTabViewCreateWindow(
 
 fn adwSelectPage(_: *adw.TabView, _: *gobject.ParamSpec, self: *TabView) callconv(.C) void {
     const page = self.tab_view.getSelectedPage() orelse return;
+
+    // If the tab was previously marked as needing attention
+    // (e.g. due to a bell character), we now unmark that
+    page.setNeedsAttention(@intFromBool(false));
+
     const title = page.getTitle();
     self.window.setTitle(std.mem.span(title));
 }