From fe725b5da19d5019f3b4d1338cfe342f63257e5f Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Fri, 24 Apr 2026 01:27:58 +0900 Subject: [PATCH] address review: update shaper test discover callsites CI on Windows (MSVC) surfaced three remaining callers of the old zero-arg `Discover.init()` in shaper test helpers that the earlier commit missed. Pass `lib` to match the new signature. Co-authored-by: Claude --- src/font/shaper/coretext.zig | 4 ++-- src/font/shaper/harfbuzz.zig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/font/shaper/coretext.zig b/src/font/shaper/coretext.zig index ff7c6d9d3..3f69af6d2 100644 --- a/src/font/shaper/coretext.zig +++ b/src/font/shaper/coretext.zig @@ -2585,7 +2585,7 @@ fn testShaperWithFont(alloc: Allocator, font_req: TestFont) !TestShaper { }); } else { // On CoreText we want to load Apple Emoji, we should have it. - var disco = font.Discover.init(); + var disco = font.Discover.init(lib); defer disco.deinit(); var disco_it = try disco.discover(alloc, .{ .family = "Apple Color Emoji", @@ -2640,7 +2640,7 @@ fn testShaperWithDiscoveredFont(alloc: Allocator, font_req: [:0]const u8) !TestS // Discover and add our font to the collection. { - var disco = font.Discover.init(); + var disco = font.Discover.init(lib); defer disco.deinit(); var disco_it = try disco.discover(alloc, .{ .family = font_req, diff --git a/src/font/shaper/harfbuzz.zig b/src/font/shaper/harfbuzz.zig index 9c78d9de3..a400ecaff 100644 --- a/src/font/shaper/harfbuzz.zig +++ b/src/font/shaper/harfbuzz.zig @@ -2071,7 +2071,7 @@ fn testShaperWithFont(alloc: Allocator, font_req: TestFont) !TestShaper { }); } else { // On CoreText we want to load Apple Emoji, we should have it. - var disco = font.Discover.init(); + var disco = font.Discover.init(lib); defer disco.deinit(); var disco_it = try disco.discover(alloc, .{ .family = "Apple Color Emoji", @@ -2126,7 +2126,7 @@ fn testShaperWithDiscoveredFont(alloc: Allocator, font_req: [:0]const u8) !TestS // Discover and add our font to the collection. { - var disco = font.Discover.init(); + var disco = font.Discover.init(lib); defer disco.deinit(); var disco_it = try disco.discover(alloc, .{ .family = font_req,