Xiangbao Meng
|
2bf9c777d7
|
Fix macos-titlebar-tabs related issues (#9090)
### This pr fixes multiple issues related to `macos-titlebar-tabs`
- [Window title clipping **on
Tahoe**](https://github.com/ghostty-org/ghostty/discussions/9027#discussion-8981483)
- Clipped tab bar **on Tahoe** when creating new ones in fullscreen
> Sequoia doesn't seem to have this issue (at least I didn't reproduce
myself)
- [Title missing **on Tahoe** after dragging a tab into a separate
window](https://github.com/ghostty-org/ghostty/discussions/9027#discussioncomment-14617088)
- [Clipped tab bar **on Tahoe** after dragging from one tab group to
another](https://github.com/ghostty-org/ghostty/discussions/9027#discussioncomment-14626078)
- [Stretched tab bar after switching system
appearance](https://github.com/ghostty-org/ghostty/discussions/9027#discussioncomment-14626918)
### Related issues
I checked all of the open sub-issues in #2349 , most of them should be
fixed in latest main branch (I didn't reproduce)
- [#1692](https://github.com/ghostty-org/ghostty/issues/1692)
@peteschaffner
- [#1945](https://github.com/ghostty-org/ghostty/issues/1945) this one I
reproduce only on Tahoe, and fixed in this pr, @injust
- [#1813](https://github.com/ghostty-org/ghostty/issues/1813) @jacakira
- [#1787](https://github.com/ghostty-org/ghostty/issues/1787)
@roguesherlock
- [#1691](https://github.com/ghostty-org/ghostty/issues/1691) ~**haven't
found a solution yet**(building zig on VM is a pain**)~
> Tried commenting out `isOpaque` check in
`TitlebarTabsVenturaTerminalWindow`, which would fix the issue, but I
see the note there about transparency issue.
>
> After commenting it out, it worked fine for me with blur and opacity
config, so **I might need some more background on this**. Didn't include
this change yet.
>
> [See screenshot
here](https://github.com/user-attachments/assets/eb17642d-b0de-46b2-b42a-19fb38a2c7f0)
### Minor improvements
- Match window title style with `window-title-font-family` and focus
state
<img width="843" height="198" alt="image"
src="https://github.com/user-attachments/assets/0138c4fa-1a4b-4bab-a415-b32695899ccf"
/>
---------
Co-authored-by: Mitchell Hashimoto <m@mitchellh.com>
|
2025-10-10 09:21:29 -07:00 |
|
Mitchell Hashimoto
|
f975ac8019
|
macOS: only show the update overlay if window doesn't support it
|
2025-10-08 15:39:56 -07:00 |
|
Mitchell Hashimoto
|
eaaf5aa8cf
|
macos: always reset titlebar tab constraints on frame change
Fixes #8595
Whenever the titlebar frame changes, we should set up our constraints
again to force it to re-render properly.
|
2025-09-12 20:14:31 -07:00 |
|
Mitchell Hashimoto
|
c4a978b07a
|
macos: set toolbar title isBordered to avoid glass view
This was recommended by the WWDC25 session on AppKit updates. My hack
was not the right approach.
|
2025-06-14 13:50:02 -07:00 |
|
Mitchell Hashimoto
|
b1b74d3421
|
comments
|
2025-06-13 12:25:21 -07:00 |
|
Mitchell Hashimoto
|
00d41239da
|
macOS: prep the tab bar when system appearance changes
|
2025-06-13 12:22:29 -07:00 |
|
Mitchell Hashimoto
|
9d9c451b0a
|
macos: titlebar tabs handle hidden traffic buttons
|
2025-06-12 20:03:21 -07:00 |
|
Mitchell Hashimoto
|
d84c30ce71
|
macos: titlebar tabs should be transparent
|
2025-06-12 18:10:37 -07:00 |
|
Mitchell Hashimoto
|
5f99670247
|
macos: tahoe titlebar tabs taking shape
|
2025-06-12 17:52:15 -07:00 |
|
Mitchell Hashimoto
|
70029bf82a
|
macos: tahoe terminal tabs shows title
|
2025-06-12 13:39:19 -07:00 |
|
Mitchell Hashimoto
|
5877913ab8
|
macoS: Split out terminal tabs for ventura vs tahoe
|
2025-06-12 12:06:30 -07:00 |
|