Mitchell Hashimoto
3e3705b932
macOS: fix surface focus/render state after dragging in to to another window/tab ( #12338 )
...
Fixes 2 bugs
1. After dragging a non-focused surface from window A to window B
**quickly without making B the key window**, the focused surface in
window A is not receiving `keyDown` events.
https://github.com/user-attachments/assets/a8861c0a-9300-470d-bf7e-0f32a9ab2cd1
2. #12343 After dragging a surface from tab A to tab B within the same
window, the dragged surface is not rendering input correctly.
> The reason the thread is stuck is because the surface's occlusion
state is set to invisible after target tab's activate while dragging,
since the dragged surface is still in previous tree before dropping, and
after dropping the occlusion state of this surface is not updated to
visible, which causing the surface is accepting input but not rendering.
https://github.com/user-attachments/assets/d67f5dba-8609-4f67-a956-921982faf796
2026-05-22 09:05:11 -07:00
Lukas
8f9b86afa8
macOS: add confirmCloseAsync to return the actual response
2026-05-19 20:00:10 +02:00
Lukas
7f5c233492
macOS: add windowCanBeClosedWithoutConfirmation without any side effects
2026-05-19 19:56:09 +02:00
Lukas
b6c6f7630a
macos: opacity-toggle setting persists between tabs in a window and to a newly created window ( #11583 )
2026-05-17 00:45:24 +02:00
Lukas
2c6dd59406
macOS: fix render_thread "stuck" after dragging surface to another tab within the same window
...
The reason the thread is stuck is because the surface's occlusion state is set to invisible after target tab's activate while dragging, since the dragged surface is still in previous tree before dropping, and after dropping the occlusion state of this surface is not updated to visible, which causing the surface is accepting input but not rendering.
2026-05-12 09:18:52 +02:00
Lukas
366c34831a
macOS: fix first responder after dragging a non-focused surface
...
This fixes a bug: after dragging a non-focused surface from window A to window B **quickly without making B the key window**, the focused surface in window A is not receiving `keyDown` events.
2026-05-12 09:18:51 +02:00
Lukas
61595b5ec9
macOS: fix focus state when toggling command palette from inline title editor
2026-04-29 22:41:18 +02:00
davidsanchez222
0e49204b95
refactor(macos): centralize background opacity toggling across controllers
2026-04-05 17:04:20 -04:00
davidsanchez222
e5c31e8b37
macos: opacity-toggle setting persists between tabs in a window and to a newly created window
2026-04-05 17:04:20 -04:00
Lukas
32920b6b2a
macOS: handle surface focus more gracefully
...
This will fix surface focus state is not consistent with first responder state when the search bar is open
2026-03-30 10:03:09 +02:00
Tim Culverhouse
d1468086ef
macos: defer key-window focus sync to reduce churn
...
Amp-Thread-ID: https://ampcode.com/threads/T-019cb9fe-b11b-753f-99e7-8ecc52b73ec4
Co-authored-by: Amp <amp@ampcode.com >
2026-03-04 12:43:51 -06:00
Mitchell Hashimoto
3aca722415
macos: further simplication of AppDelegate bell state
2026-02-26 09:52:26 -08:00
Mitchell Hashimoto
79ca4daea6
macos: try to clean up Appdelegate combine mess
2026-02-26 09:47:17 -08:00
Mitchell Hashimoto
ea8bf17df8
macos: use combine to coalesce bell values
2026-02-26 09:39:23 -08:00
MiUPa
feee4443da
macOS: add inline tab title editing
2026-02-23 08:38:09 -08:00
Jon Parise
629a656e53
macos: swiftlint 'vertical_whitespace' rule
2026-02-19 18:58:28 -05:00
Jon Parise
b532cd55d6
macos: swiftlint 'trailing_whitespace' rule
2026-02-19 18:56:43 -05:00
Jon Parise
33dce8511e
macos: swiftlint 'trailing_semicolon' rule
2026-02-19 18:56:25 -05:00
Jon Parise
6052f664cf
macos: swiftlint 'opening_brace' rule
2026-02-19 18:53:13 -05:00
Jon Parise
9287a61920
macos: swiftlint 'implicit_optional_initialization' rule
2026-02-19 18:36:38 -05:00
Jon Parise
56d67ce88f
macos: swiftlint 'control_statement' rule
2026-02-19 18:34:37 -05:00
Mitchell Hashimoto
5a7fdf735e
macos: custom tab title shows bell if active
...
Fixes #10210
2026-01-07 13:32:58 -08:00
Mitchell Hashimoto
323d362bc1
macos: dragging last window out of quick terminal works
2026-01-07 09:33:37 -08:00
Lukas
a265462aa6
macOS: moving a focused split to another tab should also update the previous tab
2026-01-07 09:18:41 -08:00
Lukas
02fc0f502f
macOS: rename function to avoid mutating misunderstanding
2026-01-07 09:18:17 -08:00
Mitchell Hashimoto
7d0157e69a
macOS: add Cmd+J "Jump to Selection" menu item and default binding
...
This matches other built-in macOS apps like Terminal, Notes, Safari. We
already had the binding, just needed to create the menu.
https://ampcode.com/threads/T-019b956a-f4e6-71b4-87fa-4162258d33ff
2026-01-06 14:30:11 -08:00
Aaron Ruan
9b6a3be993
macOS: Selection for Find feature
...
Adds the `selection_for_search` action, with Cmd+E keybind by default.
This action inputs the currently selected text into the search
field without changing focus, matching standard macOS behavior.
2026-01-06 22:21:55 +08:00
Mitchell Hashimoto
d4ba0fa27e
macos: last surface should close tab immediately not window
2025-12-30 15:07:28 -08:00
Mitchell Hashimoto
a826892ef7
macos: make undo/redo work for final split dragged out
...
Fixes #10093
2025-12-29 11:15:19 -08:00
Mitchell Hashimoto
7512f6158b
macos: fix bugs
2025-12-29 10:47:00 -08:00
Mitchell Hashimoto
19f7b57cd1
macos: fixup focus issues when closing the new window
2025-12-29 10:36:24 -08:00
Mitchell Hashimoto
29edbbbc86
macos: open dragged windows where they are dropped
2025-12-29 10:21:21 -08:00
Mitchell Hashimoto
5ecd26727e
macos: allow pulling split out into its own window
2025-12-29 10:11:59 -08:00
Mitchell Hashimoto
5245757875
macos: all sorts of cleanups
2025-12-29 06:55:01 -08:00
Mitchell Hashimoto
9724541a33
macos: unify split callbacks into a single tagged enum
2025-12-29 06:55:00 -08:00
Mitchell Hashimoto
5916755388
macos: drop splits across windows
2025-12-29 06:55:00 -08:00
Mitchell Hashimoto
8f8b5846c6
macos: hook up onDrop to move splits
2025-12-29 06:55:00 -08:00
Mitchell Hashimoto
2415116ad0
Revert "macOS: move NSGlassEffectView into TerminalViewContainer ( #10046 )"
...
This reverts commit b8490f40c5050278feae
2025-12-25 13:52:59 -08:00
Lukas
7ce88b6811
macOS: fix initial surface color scheme in quickTerminal
2025-12-24 21:46:42 +01:00
Mitchell Hashimoto
829dd1b9b2
macos: focus shenangians
2025-12-17 10:13:53 -08:00
Mitchell Hashimoto
e1356538ac
macos: show a highlight animation when a terminal is presented
2025-12-17 10:12:44 -08:00
Mitchell Hashimoto
835fe3dd0f
macos: add the active terminals to our command palette to jump
2025-12-17 09:30:39 -08:00
Mitchell Hashimoto
5d11bdddc3
macos: implement the present terminal action so we can use that
2025-12-17 09:04:51 -08:00
Mitchell Hashimoto
95f4093e96
macos: make syncAppearance a virtual method on BaseTerminalController
2025-12-16 12:59:56 -08:00
himura467
ded3dd4cbc
refactor(macos): do nothing if background-opacity >= 1
2025-12-16 11:32:10 -08:00
himura467
4c6d3f8ed2
macos: add toggle_background_opacity keybind action
2025-12-16 11:32:10 -08:00
lorenries
d364e421a8
introduce split-preserve-zoom config to maintain zoomed splits during navigation
2025-12-16 11:14:09 -08:00
Mitchell Hashimoto
50bbced0c9
macos: add title override to restorable state
2025-12-11 16:40:09 -08:00
Mitchell Hashimoto
7b48eb5c62
macos: add change tab title to menu
2025-12-11 16:16:12 -08:00
Mitchell Hashimoto
e93a4a911f
macos: implement prompt_tab_title
2025-12-11 16:03:30 -08:00
