Commit Graph

9637 Commits

Author SHA1 Message Date
Jeffrey C. Ollie
1cc5e7bec1 update zig-gobject to 0.3.2
Includes better ZIg 0.16 compat and updates for Gnome 50.
2026-07-28 15:52:01 -05:00
Mitchell Hashimoto
03eaa01d48 terminal: add visibility reports with GTK suspension tracking (#13494)
## Summary

Applications cannot reliably determine whether an unfocused terminal is
still
visible, so focus reports alone are insufficient for avoiding
unnecessary
rendering.

This adds terminal visibility reporting by:

- implementing private mode 2033
- supporting `CSI ? 998 n` visibility queries and `CSI ? 999 ; Ps n`
responses
- reporting effective visibility changes while mode 2033 is enabled
- preserving host-owned visibility state across terminal resets
- treating unknown visibility conservatively as potentially visible

On GTK 4.12 and newer, surface visibility now combines widget mapping
with the
toplevel `suspended` state. This allows Ghostty to recognize windows
hidden on
another workspace or otherwise known by the compositor to be
non-visible.
Older GTK versions retain the existing conservative behavior.

## Testing

Added coverage for:

- mode 2033 support and enable/disable behavior
- explicit visibility queries
- immediate reports when enabling the mode
- visible and non-visible responses
- visibility persistence across terminal resets
- suppression of visibility queries in read-only mode

## AI disclosure

Amp assisted with the implementation, tests, commit messages, and this
pull
request description. I reviewed the resulting changes and understand how
they
interact with the terminal, termio, surface, and GTK visibility paths.

Implements: #13451 
Reference: https://rockorager.dev/misc/visibility-reports/
2026-07-28 09:13:43 -07:00
Tim Culverhouse
6c8c07981d terminal: add visibility reports
Applications cannot infer whether an unfocused terminal remains visible, so
focus reports are insufficient for avoiding expensive rendering while a
view is hidden.

Implement private mode 2033 and the visibility query/report sequences.
Track conservative per-surface visibility, report every effective change
while enabled, and always answer explicit queries and mode enables. Keep
view visibility across terminal resets because it is owned by the host,
not terminal state.

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fa965-aa5f-7099-85b4-a9679d2c8bd3
2026-07-28 11:04:13 -05:00
Tim Culverhouse
2f3814ca5e gtk: honor suspended window state
GTK exposes the Wayland xdg_toplevel suspended state when the
compositor knows a window is not visible. Ghostty previously only used
widget map state, so it could continue rendering a mapped surface on an
inactive workspace or behind other windows.

Combine the mapped and suspended states for surface occlusion and update
all displayed surfaces whenever the toplevel suspension state changes.

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fa965-aa5f-7099-85b4-a9679d2c8bd3
2026-07-28 10:47:58 -05:00
Jeffrey C. Ollie
6e21f41c0c cli: fix list-themes preview lifecycle (#13466)
Start the vaxis event loop so the theme preview can receive terminal
input, and retain its environment map for as long as vaxis may access
it.
2026-07-28 09:21:34 -05:00
Mitchell Hashimoto
74f45b3219 config: update info about global keybinds on Linux (#13492) 2026-07-28 06:10:42 -07:00
Jon Parise
d320cd7df2 cli: fix list-themes preview lifecycle
Start the vaxis event loop so the theme preview can receive terminal
input, and retain its environment map for as long as vaxis may access
it.
2026-07-28 06:21:58 -04:00
Leah Amelia Chen
d71695550d config: update info about global keybinds on Linux 2026-07-28 13:26:08 +08:00
Uzair Aftab
4a22eed6d9 renderer/metal: fix 2x sizeof over-allocation in Buffer.sync
Buffer.sync and Buffer.syncFromArrayLists computed the new buffer size
in bytes (req_bytes * 2) and then multiplied by @sizeOf(T) again when
passing it to newBufferWithLength:, allocating data.len * sizeOf(T)^2 * 2
bytes. For the 32-byte CellText buffers this is a 64x over-allocation
and for the 4-byte CellBg buffers 8x, per swap-chain frame (e.g. ~9.4MB
instead of ~300KB per frame for a full 120x40 screen of text).

Match the OpenGL buffer implementation: track the new length in units
of T and multiply by @sizeOf(T) exactly once.
2026-07-27 23:42:06 +02:00
Mitchell Hashimoto
2dd79f3bc6 Expose additional events: desktop and progress (#13483)
This exposes libghostty-vt callbacks for additional terminal events.

* Desktop notifications from OSC 9/777
* Progress reports from OSC 9;4, including state and optional percentage
* Uses the `lib.Enum` progress state
* Exposes both through the existing terminal option/effect API

AI disclosure: Sol-5.6 was used extensively to write the code, I
reviewed it personally.
2026-07-27 13:22:01 -07:00
Mitchell Hashimoto
eb9faed28b font/sprite: update to z2d 0.12.1, use native path insetting (#13489)
This change updates z2d to 0.12.1 and changes the sprite font path
insetting functionality to use the new path offset abilities released in
the update.

In addition, there has been a slight change to the drawing of E0B5 and
its respective reflection; we now add a 1-pixel horizontal line segment
to each end to force them to be perpendicular. This is because
offsetting pre-expands the curves and ultimately causes the end segments
of the curve itself to have slight non-horizontal angles, which produce
small artifacts at the ends without the forced horizontal ends.
2026-07-27 13:20:50 -07:00
Chris Marchesi
d0e72a3ab6 font/sprite: update to z2d 0.12.1, use native path insetting
This change updates z2d to 0.12.1 and changes the sprite font path
insetting functionality to use the new path offset abilities released in
the update.

In addition, there has been a slight change to the drawing of E0B5 and
its respective reflection; we now add a 1-pixel horizontal line segment
to each end to force them to be perpendicular. This is because
offsetting pre-expands the curves and ultimately causes the end segments
of the curve itself to have slight non-horizontal angles, which produce
small artifacts at the ends without the forced horizontal ends.
2026-07-27 12:08:24 -07:00
Jack Pearkes
2729996eab terminal: update event tests for constructor API 2026-07-27 13:19:37 -04:00
Jack Pearkes
628adaf30f terminal: share progress state enum 2026-07-27 13:19:37 -04:00
Siva Mahadevan
10e6ace6b6 GhosttyI18n: fix build on freebsd with zig 0.16 2026-07-27 12:40:20 -04:00
Jack Pearkes
47d602c422 terminal: expose progress report effect 2026-07-27 12:16:28 -04:00
Jack Pearkes
c3655ba258 terminal: expose desktop notification effect 2026-07-27 12:16:09 -04:00
Mitchell Hashimoto
a27e04e8f9 lib-vt: readers for configured scrollback limits
C API callers could configure runtime scrollback limits but could not
read them back. Add terminal data keys for the primary screen byte and
line configurations.

Return GHOSTTY_NO_VALUE for unlimited limits and keep reads stable while
an alternate screen is active. Document the configured-value semantics
and add focused coverage for defaults, updates, and unlimited values.
2026-07-27 07:14:52 -07:00
Mitchell Hashimoto
03d5fa2689 lib-vt: move scrollback limits to terminal_set
Terminal construction previously accepted GhosttyTerminalOptions with
dimensions and one scrollback byte limit. Remove the options struct from
the ABI and make ghostty_terminal_new accept columns and rows directly.

Add byte and line limit options to ghostty_terminal_set and forward them
to the runtime Terminal setters. NULL removes a limit, while zero bytes
disables scrollback. Update type metadata, tests, and all API examples.
2026-07-27 07:14:40 -07:00
Mitchell Hashimoto
f4c68d65e5 terminal: support runtime scrollback limits
Scrollback limits were fixed when a terminal screen was initialized.
Move byte and line state and enforcement into a shared Limits type so
PageList can update both constraints after initialization and resize.

Add runtime setters to PageList and Terminal. Lowering a limit prunes
eligible history immediately, while zero bytes switches the primary
screen to no-scrollback behavior and clears retained history. Keep
alternate screens unchanged.
2026-07-27 07:02:39 -07:00
Mitchell Hashimoto
739603b8a2 Introduce scrollback-limit-lines to limit scrollback by lines instead of bytes (#13473)
This adds a new config `scrollback-limit-lines` to limit scrollback by
lines instead of bytes. This also renames `scrollback-limit` to
`scrollback-limit-bytes` to make it clear what it does but we have a
compatibility entry so old configurations will continue to work, so its
not breaking.

**This is NOT exclusive to `scrollback-limit-bytes`**. When both are
set, then the _first limit reached_ is used. Since lines is affected by
viewport size and bytes are affected by entries (more styles, more
graphemes, etc.), they serve somewhat different purposes and it might be
useful to set both.

The default remains 50MB of bytes, unlimited lines.

This is not exposed to libghostty yet. I have that coming as a follow up
change.
2026-07-27 05:57:27 -07:00
Mitchell Hashimoto
659a60ae53 terminal/search: fix tests 2026-07-26 20:28:58 -07:00
Mitchell Hashimoto
1092204df1 config: support unlimited scrollback limits 2026-07-26 20:13:45 -07:00
Mitchell Hashimoto
65c48213b6 config: expose scrollback line limit 2026-07-26 20:13:45 -07:00
Mitchell Hashimoto
10bc43420c terminal: make scrollback byte limit optional 2026-07-26 20:13:45 -07:00
Mitchell Hashimoto
86f81fb5b1 terminal: expose scrollback line limit 2026-07-26 20:13:45 -07:00
Mitchell Hashimoto
5b2d3b7df1 terminal: limit scrollback by physical lines 2026-07-26 20:13:45 -07:00
Mitchell Hashimoto
3b4600014c clarify comments 2026-07-26 15:38:19 -07:00
Riccardo Mazzarini
84254a9d8c build: avoid MSVC C++ runtime in no-libcxx builds
AI-assisted: Codex
2026-07-26 15:36:54 -07:00
Riccardo Mazzarini
1fe1b2d23c build: fix static libghostty-vt linking on Windows
This PR fixes static linking for libghostty-vt on Windows by propagating
a couple of missing dependencies (discovered while running Neovim's Zig
build, see
https://github.com/neovim/neovim/actions/runs/30130848061/job/89604799965?pr=39773).
2026-07-26 15:36:54 -07:00
Mitchell Hashimoto
40ab02e338 lib-vt: handle DECRQSS (#13471)
Move DECRQSS response encoding into the terminal DCS handler so both the
full termio path and libghostty-vt terminal stream emit the same
replies. The C API stream now maintains and releases DCS parser state
and forwards responses through write_pty.
2026-07-26 15:21:27 -07:00
Mitchell Hashimoto
39ae85f040 lib-vt: handle DECRQSS
Move DECRQSS response encoding into the terminal DCS handler so both
the full termio path and libghostty-vt terminal stream emit the same
replies. The C API stream now maintains and releases DCS parser state
and forwards responses through write_pty.
2026-07-26 15:04:16 -07:00
Mitchell Hashimoto
edcb6fb509 memset should match the C ABI (#13469)
The custom memset accepted its fill value as u8 even though C callers
pass int. Accept c_int and explicitly truncate it to the low byte, which
is what other implementations of this do.
2026-07-26 14:49:54 -07:00
Mitchell Hashimoto
6f10ddfe83 terminal: preserve underline style in DECRQSS (#13470)
DECRQSS previously serialized every active underline as SGR 4, which
caused double, curly, dotted, and dashed styles to round-trip as single
underlines.

Emit the 4:n form for extended underline styles while retaining the
legacy 4 form for single underlines, and cover every supported style.
2026-07-26 14:43:36 -07:00
Mitchell Hashimoto
be3d4a5335 terminal: avoid reallocating tabstop storage (#13465)
Avoid redundant tabstop allocation when the current buffer already
satisfies the requested size
2026-07-26 14:43:14 -07:00
Mitchell Hashimoto
cb2fef3902 terminal: preserve underline style in DECRQSS
DECRQSS previously serialized every active underline as SGR 4,
which caused double, curly, dotted, and dashed styles to round-trip
as single underlines.

Emit the 4:n form for extended underline styles while retaining the
legacy 4 form for single underlines, and cover every supported style.
2026-07-26 14:35:35 -07:00
Riccardo Mazzarini
20c3eae04d memset should match the C ABI
The custom memset accepted its fill value as u8 even though C callers
pass int. Accept c_int and explicitly truncate it to the low byte, which
is what other implementations of this do.
2026-07-26 14:33:34 -07:00
Aurelien Brabant
7ee3ac9ec8 refactor: use arena allocator 2026-07-26 17:50:33 +02:00
Aurelien Brabant
0075c75b61 refactor: remove unneeded appendAssumeCapacity 2026-07-26 17:09:52 +02:00
Aurelien Brabant
3024c5d19e refactor: address nits 2026-07-26 16:37:46 +02:00
Uzair Aftab
5caf20e3e5 terminal: avoid reallocating tabstop storage
Resizing tabstops to an already-supported width previously allocated and
copied an equally sized dynamic buffer because the capacity check
excluded equality. Treat an exactly sized buffer as sufficient, avoiding
the temporary allocation and copy.
Add a fixed-buffer regression test so an unnecessary second allocation
fails the test.
2026-07-26 14:15:17 +02:00
Aurelien Brabant
88bd4fdcea feat: implement vicinae-hotkey-v1 2026-07-26 05:47:40 +02:00
Jeffrey C. Ollie
f8e13f31e6 Fix desktop detection tests when running from Gnome
Environment variables from the "real" environment leaked into the test
after the Zig 0.16 update which would cause them to fail if you ran them
on a Gnome system.
2026-07-23 14:47:06 -05:00
Mitchell Hashimoto
d65cb5128a build: link libghostty-vt on Apple hosts with native linker
Replaces: https://github.com/ghostty-org/ghostty/pull/13427

Zig's Mach-O linker does not emit LC_ENCRYPTION_INFO_64 for physical
iOS dylibs. This allows libghostty-vt to build successfully but causes
frameworks containing it to fail App Store validation.

I think it'd be cleaner to always just build Apple targets on Apple hosts
with the native linker. We don't need to rely on Zig being correct and 
this helps ensure compatibility for details like this.
2026-07-23 06:41:30 -07:00
Mitchell Hashimoto
30de782e8e fix(terminal): fix kitty temp directory copy length mismatch (#13424)
EDIT:
[exposed](https://github.com/elias8/libghostty/actions/runs/29996356691/job/89171182671?pr=113#step:12:447)
while syncing libghostty dart bindings to latest main.
2026-07-23 06:02:00 -07:00
Jon Parise
e663d54051 os/hostname: switch to std.Io.net.HostName.validate
Zig 0.16's hostname validation routine is RFC 1123-compliant, so we can
use it directly rather than rolling our own.

Ref: efe649b13e
Ref: https://github.com/ziglang/zig/pull/25710
2026-07-23 08:15:06 -04:00
Elias Andualem
960c2cca5d fix: fix kitty temp directory copy length mismatch 2026-07-23 12:22:45 +03:00
Mitchell Hashimoto
b988efcfe5 fix some 0.16 translation regressions 2026-07-22 08:07:06 -07:00
Mitchell Hashimoto
a77c706a18 fix process and global error handling
Restore the error handling that the removed std.posix fork and waitpid
wrappers previously provided. Raw fork failures now propagate, waitpid
retries interruptions before reading status, and edit-config constructs the
sentinel-terminated argv required by execve.

Let global initialization own cleanup through its existing errdefer so
temporary paths are freed once. Report initialization failures with the
static synchronous I/O provider because global I/O has already been torn
down by that point.
2026-07-22 06:33:54 -07:00
Chris Marchesi
7121ab6c3f global: state should default to null 2026-07-21 23:14:34 -07:00