mirror of
https://github.com/ghostty-org/ghostty.git
synced 2026-05-20 12:01:34 +00:00
eda76e105f
PR #1168 introduced a loop to kill all children. The `waitpid` call is issued with the NOHANG flag, which means it returns immediately if no child has exited. This has the effect that we can repeatedly run through this loop making this syscall, flooding the system with calls and not getting timely responses. On my system, this caused Ghostty to take ~30 seconds to close. In my attempts to debug, I added logging to the loop which resolved the issue. To find out why, I added a loop counter and found the loop would run > 70 million cycles while trying to close. By adding logging, I introduced just enough delay in the loop cycle to prevent whatever flooding of syscalls was happening. This reduced the loop counter to ~2 cycles before closing. Add a small delay to prevent syscall flooding.