mirror of
https://github.com/ghostty-org/ghostty.git
synced 2026-04-06 07:38:21 +00:00
3d581eb92e
When compiling C++ files, Zig unconditionally passes -nostdinc++ and, if link_libcpp is set, adds its bundled libc++/libc++abi include paths as replacements (see Compilation.zig). On MSVC targets this conflicts with the MSVC C++ runtime headers (vcruntime_typeinfo.h, vcruntime_exception.h, etc.), causing compilation failures in SIMD C++ code. The fix is to use linkLibC instead of linkLibCpp on MSVC. Zig always passes -nostdinc to strip default search paths, but LibCDirs.detect re-adds the MSVC SDK include directories, which contain both C and C++ standard library headers. This gives us proper access to MSVC's own <optional>, <iterator>, <cstddef>, etc. without the libc++ conflicts. For the package builds (highway, simdutf, utfcpp) this means switching from linkLibCpp to linkLibC on MSVC. For SharedDeps and GhosttyZig, linkLibC is already called separately, so we just skip linkLibCpp.
82 lines
2.5 KiB
Zig
82 lines
2.5 KiB
Zig
const std = @import("std");
|
|
|
|
pub fn build(b: *std.Build) !void {
|
|
const optimize = b.standardOptimizeOption(.{});
|
|
const target = b.standardTargetOptions(.{});
|
|
|
|
const lib = b.addLibrary(.{
|
|
.name = "simdutf",
|
|
.root_module = b.createModule(.{
|
|
.target = target,
|
|
.optimize = optimize,
|
|
}),
|
|
.linkage = .static,
|
|
});
|
|
lib.linkLibC();
|
|
// On MSVC, we must not use linkLibCpp because Zig unconditionally
|
|
// passes -nostdinc++ and then adds its bundled libc++/libc++abi
|
|
// include paths, which conflict with MSVC's own C++ runtime headers.
|
|
// The MSVC SDK include directories (added via linkLibC) contain
|
|
// both C and C++ headers, so linkLibCpp is not needed.
|
|
if (target.result.abi != .msvc) {
|
|
lib.linkLibCpp();
|
|
}
|
|
lib.addIncludePath(b.path("vendor"));
|
|
|
|
if (target.result.os.tag.isDarwin()) {
|
|
const apple_sdk = @import("apple_sdk");
|
|
try apple_sdk.addPaths(b, lib);
|
|
}
|
|
|
|
if (target.result.abi.isAndroid()) {
|
|
const android_ndk = @import("android_ndk");
|
|
try android_ndk.addPaths(b, lib);
|
|
}
|
|
|
|
var flags: std.ArrayList([]const u8) = .empty;
|
|
defer flags.deinit(b.allocator);
|
|
// Zig 0.13 bug: https://github.com/ziglang/zig/issues/20414
|
|
// (See root Ghostty build.zig on why we do this)
|
|
try flags.appendSlice(b.allocator, &.{
|
|
"-DSIMDUTF_IMPLEMENTATION_ICELAKE=0",
|
|
|
|
// Fixes linker issues for release builds missing ubsanitizer symbols
|
|
"-fno-sanitize=undefined",
|
|
"-fno-sanitize-trap=undefined",
|
|
});
|
|
|
|
if (target.result.os.tag == .freebsd or target.result.abi == .musl) {
|
|
try flags.append(b.allocator, "-fPIC");
|
|
}
|
|
|
|
lib.addCSourceFiles(.{
|
|
.flags = flags.items,
|
|
.files = &.{
|
|
"vendor/simdutf.cpp",
|
|
},
|
|
});
|
|
lib.installHeadersDirectory(
|
|
b.path("vendor"),
|
|
"",
|
|
.{ .include_extensions = &.{".h"} },
|
|
);
|
|
|
|
b.installArtifact(lib);
|
|
|
|
// {
|
|
// const test_exe = b.addTest(.{
|
|
// .name = "test",
|
|
// .root_source_file = .{ .path = "main.zig" },
|
|
// .target = target,
|
|
// .optimize = optimize,
|
|
// });
|
|
// test_exe.linkLibrary(lib);
|
|
//
|
|
// var it = module.import_table.iterator();
|
|
// while (it.next()) |entry| test_exe.root_module.addImport(entry.key_ptr.*, entry.value_ptr.*);
|
|
// const tests_run = b.addRunArtifact(test_exe);
|
|
// const test_step = b.step("test", "Run tests");
|
|
// test_step.dependOn(&tests_run.step);
|
|
// }
|
|
}
|