mirror of
https://github.com/ghostty-org/ghostty.git
synced 2026-04-06 07:38:21 +00:00
292bf13d06
- Fixes: https://github.com/ghostty-org/ghostty/issues/11964 Made a private enum type `VersionConfig` to reference whether the release is a semver or tip, makes it easier for later in the view to `switch` between cases. I do think there could be a better place for this enum or we can get rid of it, open to opinions. Right now version parsing is kind of duplicated between `AboutView` and `UpdateModalView` so we can also extract to a common helper if wanted. Tested by manually setting `Marketing Version` in build settings to `1.3.1` <img width="412" height="532" alt="Screenshot 2026-03-30 at 18 31 15" src="https://github.com/user-attachments/assets/285bb94d-138b-4169-bb66-684eb04b6ca3" /> `332b2aefc` <img width="412" height="532" alt="Screenshot 2026-03-30 at 18 32 48" src="https://github.com/user-attachments/assets/fea30d39-bea7-4885-8221-1696e148f45e" /> ### AI Disclosure I used Sonnet 4.6 to understand where the version strings came from and in what format, it read release yml files to see what's going on. Then it proposed really bad code so I manually went in and cleaned up the view.