mirror of
https://github.com/ghostty-org/ghostty.git
synced 2026-06-02 18:08:11 +00:00
2c62d182ce
Fixes #12783 where opening the context menu (with right click) inside the quick-terminal will hide the quick-terminal if autohide is enabled. The cause of this issue is the quick-terminal window becoming inactive and immediately active again when you open the context-menu. When the window becomes inactive, the autohide feature hides the quick-terminal. The temporary focus loss in GTK is triggered by GDK focus change events, which probably originate from the windowing backend treating the context menu as its own window. Whereas in GTK the context menu is not a separate window but instead part of the widget tree of the window it was opened from, so even when the context menu has focus that window is still the active one in GTK. As a fix `Window.propIsActive`, which implements the autohide logic, will now do its work from a timeout callback, since there is probably no reliable way to distinguish a temporary focus loss from a real one from inside GTK and I'm not sure we can make any assumptions about the timing of things happening in the windowing backend. A 100ms delay should be long enough for the focus state to settle while still hiding the quick-terminal quickly. I reproduced the bug and verified the fix on Wayland with both Hyprland and KDE. Temporary focus loss happens on X11+KDE as well, although it doesn't matter there because there is no quick-terminal. ### AI Disclosure No AI was used, code and comments were written by myself.