mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-26 12:27:06 +00:00 
			
		
		
		
	Remove jQuery .attr from the project page (#30004)
				
					
				
			- Switched from jQuery `.attr` to plain javascript `.getAttribute` - Tested the issue movement between columns, column background color setting, and column deletion. It all works as before --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		| @@ -33,7 +33,7 @@ async function moveIssue({item, from, to, oldIndex}) { | ||||
|  | ||||
|   const columnSorting = { | ||||
|     issues: Array.from(columnCards, (card, i) => ({ | ||||
|       issueID: parseInt($(card).attr('data-issue')), | ||||
|       issueID: parseInt(card.getAttribute('data-issue')), | ||||
|       sorting: i, | ||||
|     })), | ||||
|   }; | ||||
| @@ -134,7 +134,7 @@ export function initRepoProject() { | ||||
|         if ($projectColorInput.val()) { | ||||
|           setLabelColor($projectHeader, $projectColorInput.val()); | ||||
|         } | ||||
|         $boardColumn.attr('style', `background: ${$projectColorInput.val()}!important`); | ||||
|         $boardColumn[0].style = `background: ${$projectColorInput.val()} !important`; | ||||
|         $('.ui.modal').modal('hide'); | ||||
|       } | ||||
|     }); | ||||
| @@ -159,9 +159,9 @@ export function initRepoProject() { | ||||
|   }); | ||||
|  | ||||
|   $('.show-delete-project-column-modal').each(function () { | ||||
|     const $deleteColumnModal = $(`${$(this).attr('data-modal')}`); | ||||
|     const $deleteColumnModal = $(`${this.getAttribute('data-modal')}`); | ||||
|     const $deleteColumnButton = $deleteColumnModal.find('.actions > .ok.button'); | ||||
|     const deleteUrl = $(this).attr('data-url'); | ||||
|     const deleteUrl = this.getAttribute('data-url'); | ||||
|  | ||||
|     $deleteColumnButton.on('click', async (e) => { | ||||
|       e.preventDefault(); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Yarden Shoham
					Yarden Shoham