mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-26 12:27:06 +00:00 
			
		
		
		
	Fine tune markdown editor toolbar (#24046)
1. Remove unnecessary `btn-link` `muted` classes
* Link is link, button is button, I can't see a real requirement to make
a button like a link.
* If anyone insists, please help to show me real example from modern
frameworks / websites, how and why they do so.
    * No need to duplicate a lot of class names on similar elements
* Declare styles clearly, for example, `markdown-toolbar` itself should
have `display: flex`, but not use `gt-df` to overwrite the `display:
block`.
2. Remove unnecessary `role` attribute
    * https://github.com/github/markdown-toolbar-element/issues/70
* The `markdown-toolbar-element` does want to add `role=button`, but
there is a bug.
* So we do the similar thing as upstream does (add the role by JS),
until they fix their bugs.
3. Indent `markdown-switch-easymde` (before it doesn't have a proper
indent)
Screenshot:

			
			
This commit is contained in:
		| @@ -70,7 +70,10 @@ class ComboMarkdownEditor { | ||||
|  | ||||
|     this.textareaMarkdownToolbar = this.container.querySelector('markdown-toolbar'); | ||||
|     this.textareaMarkdownToolbar.setAttribute('for', this.textarea.id); | ||||
|  | ||||
|     for (const el of this.textareaMarkdownToolbar.querySelectorAll('.markdown-toolbar-button')) { | ||||
|       // upstream bug: The role code is never executed in base MarkdownButtonElement https://github.com/github/markdown-toolbar-element/issues/70 | ||||
|       el.setAttribute('role', 'button'); | ||||
|     } | ||||
|     this.switchToEasyMDEButton = this.container.querySelector('.markdown-switch-easymde'); | ||||
|     this.switchToEasyMDEButton?.addEventListener('click', async (e) => { | ||||
|       e.preventDefault(); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 wxiaoguang
					wxiaoguang