From 83151e98ccc3676aa514ac7aae9c55666f83cee6 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Mon, 18 May 2026 07:38:40 +0200
Subject: [PATCH] ci: narrow files-changed frontend filter (#37749)

Drop the broad `tools/*.{js,ts}` globs from the `frontend` filter so
edits to CI-only or backend helper scripts in `tools/` stop triggering
frontend and e2e jobs. Only `tools/generate-svg.ts` is kept.

Also renames `tools/lint-pr-title.js` to `.ts` for consistency, drops
the empty root `*.js` glob, fixes stray indentation in the `dockerfile`
filter and adds missing `setup-node`.

---
This PR was written with the help of Claude Opus 4.7

---------

Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
---
 .github/workflows/files-changed.yml          | 8 +++-----
 .github/workflows/pull-pr-title.yml          | 3 +++
 Makefile                                     | 2 +-
 tools/{lint-pr-title.js => lint-pr-title.ts} | 0
 4 files changed, 7 insertions(+), 6 deletions(-)
 rename tools/{lint-pr-title.js => lint-pr-title.ts} (100%)

diff --git a/.github/workflows/files-changed.yml b/.github/workflows/files-changed.yml
index 7b68a393d0..ac2bd1a5ba 100644
--- a/.github/workflows/files-changed.yml
+++ b/.github/workflows/files-changed.yml
@@ -63,11 +63,9 @@ jobs:
               - "options/locale/locale_en-US.json"
 
             frontend:
-              - "*.js"
               - "*.ts"
               - "web_src/**"
-              - "tools/*.js"
-              - "tools/*.ts"
+              - "tools/generate-svg.ts"
               - "assets/emoji.json"
               - "package.json"
               - "pnpm-lock.yaml"
@@ -99,8 +97,8 @@ jobs:
               - "Makefile"
 
             dockerfile:
-                - "Dockerfile"
-                - "Dockerfile.rootless"
+              - "Dockerfile"
+              - "Dockerfile.rootless"
 
             swagger:
               - "templates/swagger/v1_json.tmpl"
diff --git a/.github/workflows/pull-pr-title.yml b/.github/workflows/pull-pr-title.yml
index 59b0e78c40..6dadcb7058 100644
--- a/.github/workflows/pull-pr-title.yml
+++ b/.github/workflows/pull-pr-title.yml
@@ -23,6 +23,9 @@ jobs:
     timeout-minutes: 5
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
+        with:
+          node-version: 24
       - run: make lint-pr-title
         env:
           PR_TITLE: ${{ github.event.pull_request.title }}
diff --git a/Makefile b/Makefile
index 809300d880..782e31ccfd 100644
--- a/Makefile
+++ b/Makefile
@@ -320,7 +320,7 @@ lint-md-fix: node_modules ## lint markdown files and fix issues
 
 .PHONY: lint-pr-title
 lint-pr-title: ## lint PR title against Conventional Commits (set PR_TITLE=...)
-	@node ./tools/lint-pr-title.js
+	@node ./tools/lint-pr-title.ts
 
 .PHONY: lint-spell
 lint-spell: ## lint spelling
diff --git a/tools/lint-pr-title.js b/tools/lint-pr-title.ts
similarity index 100%
rename from tools/lint-pr-title.js
rename to tools/lint-pr-title.ts