From b28c4f2b08e980cc1ec0b2d3ffe8fb588a5ac313 Mon Sep 17 00:00:00 2001 From: Giteabot Date: Fri, 8 May 2026 10:30:33 -0700 Subject: [PATCH] fix(actions): fix blank lines after `::endgroup::` (#37597) (#37612) Backport #37597 by @silverwind `endLogGroup` was incorrectly appending empty `
`s, producing a useless blank line after every group. Before and after: Screenshot 2026-05-07 at 22 40 40 Screenshot 2026-05-07 at 22 37 12 Signed-off-by: silverwind Co-authored-by: silverwind Co-authored-by: Claude (Opus 4.7) --- web_src/js/components/ActionRunJobView.vue | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/web_src/js/components/ActionRunJobView.vue b/web_src/js/components/ActionRunJobView.vue index 934ad9d706..d40c535870 100644 --- a/web_src/js/components/ActionRunJobView.vue +++ b/web_src/js/components/ActionRunJobView.vue @@ -197,10 +197,9 @@ function beginLogGroup(stepIndex: number, startTime: number, line: LogLine, cmd: } // end a log group -function endLogGroup(stepIndex: number, startTime: number, line: LogLine, cmd: LogLineCommand) { +function endLogGroup(stepIndex: number) { const el = getJobStepLogsContainer(stepIndex); el._stepLogsActiveContainer = undefined; - el.append(createLogLine(stepIndex, startTime, line, cmd)); } // show/hide the step logs for a step @@ -254,7 +253,7 @@ function appendLogs(stepIndex: number, startTime: number, logLines: LogLine[]) { beginLogGroup(stepIndex, startTime, line, cmd); continue; case 'endgroup': - endLogGroup(stepIndex, startTime, line, cmd); + endLogGroup(stepIndex); continue; } // the active logs container may change during the loop, for example: entering and leaving a group