mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-26 12:27:06 +00:00 
			
		
		
		
	Prevent creating empty sessions (#6677)
* Prevent creating empty sessions Signed-off-by: Andrew Thornton <art27@cantab.net> * Update modules/setting/session.go * Remove unnecessary option Signed-off-by: Andrew Thornton <art27@cantab.net> * Add destory to list of ignored misspellings * rename cookie.go -> virtual.go * Delete old file * Add test to ensure that sessions are not created without being logged in Signed-off-by: Andrew Thornton <art27@cantab.net> * fix tests Signed-off-by: Andrew Thornton <art27@cantab.net> * Update integrations/create_no_session_test.go
This commit is contained in:
		@@ -5,11 +5,15 @@
 | 
			
		||||
package setting
 | 
			
		||||
 | 
			
		||||
import (
 | 
			
		||||
	"encoding/json"
 | 
			
		||||
	"path"
 | 
			
		||||
	"path/filepath"
 | 
			
		||||
	"strings"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/modules/log"
 | 
			
		||||
	// This ensures that VirtualSessionProvider is available
 | 
			
		||||
	_ "code.gitea.io/gitea/modules/session"
 | 
			
		||||
 | 
			
		||||
	"github.com/go-macaron/session"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
@@ -31,5 +35,12 @@ func newSessionService() {
 | 
			
		||||
	SessionConfig.Gclifetime = Cfg.Section("session").Key("GC_INTERVAL_TIME").MustInt64(86400)
 | 
			
		||||
	SessionConfig.Maxlifetime = Cfg.Section("session").Key("SESSION_LIFE_TIME").MustInt64(86400)
 | 
			
		||||
 | 
			
		||||
	shadowConfig, err := json.Marshal(SessionConfig)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		log.Fatal("Can't shadow session config: %v", err)
 | 
			
		||||
	}
 | 
			
		||||
	SessionConfig.ProviderConfig = string(shadowConfig)
 | 
			
		||||
	SessionConfig.Provider = "VirtualSession"
 | 
			
		||||
 | 
			
		||||
	log.Info("Session Service Enabled")
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user