mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-26 12:27:06 +00:00 
			
		
		
		
	Multiple Queue improvements: LevelDB Wait on empty, shutdown empty shadow level queue, reduce goroutines etc (#15693)
* move shutdownfns, terminatefns and hammerfns out of separate goroutines Coalesce the shutdownfns etc into a list of functions that get run at shutdown rather then have them run at goroutines blocked on selects. This may help reduce the background select/poll load in certain configurations. * The LevelDB queues can actually wait on empty instead of polling Slight refactor to cause leveldb queues to wait on empty instead of polling. * Shutdown the shadow level queue once it is empty * Remove bytefifo additional goroutine for readToChan as it can just be run in run * Remove additional removeWorkers goroutine for workers * Simplify the AtShutdown and AtTerminate functions and add Channel Flusher * Add shutdown flusher to CUQ * move persistable channel shutdown stuff to Shutdown Fn * Ensure that UPCQ has the correct config * handle shutdown during the flushing * reduce risk of race between zeroBoost and addWorkers * prevent double shutdown Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
		| @@ -5,6 +5,8 @@ | ||||
| package queue | ||||
|  | ||||
| import ( | ||||
| 	"context" | ||||
|  | ||||
| 	"code.gitea.io/gitea/modules/nosql" | ||||
|  | ||||
| 	"gitea.com/lunny/levelqueue" | ||||
| @@ -41,6 +43,7 @@ func NewLevelUniqueQueue(handle HandlerFunc, cfg, exemplar interface{}) (Queue, | ||||
| 	if len(config.ConnectionString) == 0 { | ||||
| 		config.ConnectionString = config.DataDir | ||||
| 	} | ||||
| 	config.WaitOnEmpty = true | ||||
|  | ||||
| 	byteFIFO, err := NewLevelUniqueQueueByteFIFO(config.ConnectionString, config.QueueName) | ||||
| 	if err != nil { | ||||
| @@ -86,12 +89,12 @@ func NewLevelUniqueQueueByteFIFO(connection, prefix string) (*LevelUniqueQueueBy | ||||
| } | ||||
|  | ||||
| // PushFunc pushes data to the end of the fifo and calls the callback if it is added | ||||
| func (fifo *LevelUniqueQueueByteFIFO) PushFunc(data []byte, fn func() error) error { | ||||
| func (fifo *LevelUniqueQueueByteFIFO) PushFunc(ctx context.Context, data []byte, fn func() error) error { | ||||
| 	return fifo.internal.LPushFunc(data, fn) | ||||
| } | ||||
|  | ||||
| // Pop pops data from the start of the fifo | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Pop() ([]byte, error) { | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Pop(ctx context.Context) ([]byte, error) { | ||||
| 	data, err := fifo.internal.RPop() | ||||
| 	if err != nil && err != levelqueue.ErrNotFound { | ||||
| 		return nil, err | ||||
| @@ -100,12 +103,12 @@ func (fifo *LevelUniqueQueueByteFIFO) Pop() ([]byte, error) { | ||||
| } | ||||
|  | ||||
| // Len returns the length of the fifo | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Len() int64 { | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Len(ctx context.Context) int64 { | ||||
| 	return fifo.internal.Len() | ||||
| } | ||||
|  | ||||
| // Has returns whether the fifo contains this data | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Has(data []byte) (bool, error) { | ||||
| func (fifo *LevelUniqueQueueByteFIFO) Has(ctx context.Context, data []byte) (bool, error) { | ||||
| 	return fifo.internal.Has(data) | ||||
| } | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 zeripath
					zeripath