diff --git a/services/mailer/mail_issue_common.go b/services/mailer/mail_issue_common.go index 816fb864d60..11979691761 100644 --- a/services/mailer/mail_issue_common.go +++ b/services/mailer/mail_issue_common.go @@ -99,7 +99,9 @@ func composeIssueCommentMessages(ctx context.Context, comment *mailComment, lang } } locale := translation.NewLocale(lang) - + if lang == "mock" { + locale = &translation.MockLocale{} + } mailMeta := map[string]any{ "locale": locale, "FallbackSubject": fallback, diff --git a/services/mailer/mail_test.go b/services/mailer/mail_test.go index cbe3bb08bbe..2925328307e 100644 --- a/services/mailer/mail_test.go +++ b/services/mailer/mail_test.go @@ -18,10 +18,14 @@ import ( actions_model "gitea.dev/models/actions" activities_model "gitea.dev/models/activities" + "gitea.dev/models/asymkey" + git_model "gitea.dev/models/git" + "gitea.dev/models/gituser" issues_model "gitea.dev/models/issues" repo_model "gitea.dev/models/repo" "gitea.dev/models/unittest" user_model "gitea.dev/models/user" + "gitea.dev/modules/git" "gitea.dev/modules/markup" "gitea.dev/modules/setting" "gitea.dev/modules/storage" @@ -556,3 +560,32 @@ func TestEmbedBase64Images(t *testing.T) { assert.Equal(t, expected, string(resultMailBody)) }) } + +func TestMailPullRequestPush(t *testing.T) { + doer, _, issue, comment := prepareMailerTest(t) + mc := &mailComment{ + Issue: issue, + Comment: comment, + Doer: doer, + } + issue.IsPull = true + issue.PullRequest = &issues_model.PullRequest{BaseRepo: mc.Issue.Repo} + mc.Comment.Type = issues_model.CommentTypePullRequestPush + mc.Comment.Commits = []*git_model.SignCommitWithStatuses{ + { + SignCommit: &asymkey.SignCommit{ + UserCommit: &gituser.UserCommit{ + GitCommit: &git.Commit{ + CommitMessage: git.CommitMessage{MessageRaw: "test commit msg"}, + ID: git.Sha1ObjectFormat.EmptyObjectID(), + }, + }, + }, + }, + } + + msgs, err := composeIssueCommentMessages(t.Context(), mc, "mock", []*user_model.User{{Name: "Test", Email: "test@gitea.com"}}, false, "pull request push") + require.NoError(t, err) + assert.Contains(t, msgs[0].Body, `0000000000 - test commit msg`) + assert.Contains(t, msgs[0].Body, ``) +} diff --git a/templates/mail/repo/issue/default.tmpl b/templates/mail/repo/issue/default.tmpl index 2d217a87f1d..74b407a7792 100644 --- a/templates/mail/repo/issue/default.tmpl +++ b/templates/mail/repo/issue/default.tmpl @@ -68,10 +68,9 @@