From d3341cfb078c8be2f85b370499baeaf9c2896961 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 25 Apr 2026 04:40:21 +0000 Subject: [PATCH] models/webhook: address review feedback - add RepoID to hookOwner3, use HookRepo1Inactive in delete test Agent-Logs-Url: https://github.com/go-gitea/gitea/sessions/d187e3a5-2c68-4115-a4d1-d2bda8f54004 Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com> --- models/webhook/webhook_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/models/webhook/webhook_test.go b/models/webhook/webhook_test.go index 732e164e9a3..a5c6c87b3f0 100644 --- a/models/webhook/webhook_test.go +++ b/models/webhook/webhook_test.go @@ -57,6 +57,7 @@ func prepareWebhookTestData(t *testing.T) *webhookTestFixtures { hookOwner3 := &Webhook{ OwnerID: 3, + RepoID: 3, URL: "https://www.example.com/url3", ContentType: ContentTypeJSON, Events: `{"push_only":false,"choose_events":false,"events":{"create":false,"push":true,"pull_request":true}}`, @@ -272,9 +273,9 @@ func TestUpdateWebhook(t *testing.T) { func TestDeleteWebhookByRepoID(t *testing.T) { fixture := prepareWebhookTestData(t) - unittest.AssertExistsAndLoadBean(t, &Webhook{ID: fixture.HookRepo1.ID, RepoID: 1}) - assert.NoError(t, DeleteWebhookByRepoID(t.Context(), 1, fixture.HookRepo1.ID)) - unittest.AssertNotExistsBean(t, &Webhook{ID: fixture.HookRepo1.ID, RepoID: 1}) + unittest.AssertExistsAndLoadBean(t, &Webhook{ID: fixture.HookRepo1Inactive.ID, RepoID: 1}) + assert.NoError(t, DeleteWebhookByRepoID(t.Context(), 1, fixture.HookRepo1Inactive.ID)) + unittest.AssertNotExistsBean(t, &Webhook{ID: fixture.HookRepo1Inactive.ID, RepoID: 1}) err := DeleteWebhookByRepoID(t.Context(), unittest.NonexistentID, unittest.NonexistentID) assert.Error(t, err)