mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 09:44:21 +00:00 
			
		
		
		
	Forbid HTML injection using jQuery (#29843)
See https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/no-append-html.md Tested the following components and they work as before: - notification table - issue author dropdown - comment edit box attachments div Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		@@ -125,7 +125,9 @@ function initRepoIssueListAuthorDropdown() {
 | 
			
		||||
    if (newMenuHtml) {
 | 
			
		||||
      const $newMenuItems = $(newMenuHtml);
 | 
			
		||||
      $newMenuItems.addClass('dynamic-item');
 | 
			
		||||
      $menu.append('<div class="divider dynamic-item"></div>', ...$newMenuItems);
 | 
			
		||||
      const div = document.createElement('div');
 | 
			
		||||
      div.classList.add('divider', 'dynamic-item');
 | 
			
		||||
      $menu[0].append(div, ...$newMenuItems);
 | 
			
		||||
    }
 | 
			
		||||
    $searchDropdown.dropdown('refresh');
 | 
			
		||||
    // defer our selection to the next tick, because dropdown will set the selection item after this `menu` function
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user