John Olheiser
e9061a537c
Fix admin notices ( #10480 ) ( #10483 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-26 11:14:37 -06:00
John Olheiser
ed664a9e1d
Change admin dashboard to POST ( #10465 ) ( #10466 )
...
* Change admin dashboard to POST (#10465 )
* Add form and convert to POST
* Redirect for flash
* Convert octicons back to fa for 1.11
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-25 17:42:43 -06:00
John Olheiser
4cb18601ff
Change action GETs to POST ( #10462 ) ( #10464 )
...
* Change action GETs to POST
* submite = submit + smite
* No more # href
* Fix test
* Match other tests
* Explicit csrf
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-25 15:08:21 -06:00
zeripath
4f64688902
Truncate long commit message header ( #10301 ) ( #10319 )
...
* Truncate long commit message header
* Fix overflow in view commit table
* Use @media less
* Further improvements
* Fix the commit message on small screens
* adjust width of minimal table
2020-02-18 08:51:39 +01:00
Lunny Xiao
987cd277f6
Fix reply on code review ( #10227 ) ( #10257 )
...
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2020-02-13 11:32:30 +02:00
Lauris BH
80eb50655a
Fix followers and following tabs in profile ( #10202 ) ( #10203 )
2020-02-09 21:00:24 +00:00
guillep2k
b5b44364e3
Allow emoji on review head comments ( #10159 ) ( #10174 )
...
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-02-07 21:39:24 +01:00
guillep2k
e48b460a0a
Fix issue/pull link ( #10158 ) ( #10173 )
2020-02-07 11:51:23 +08:00
Lunny Xiao
049af0d3d0
Fix branch page pull request title and link error ( #10092 ) ( #10097 )
...
* Fix branch page pull request title and link error (#10092 )
2020-02-01 15:14:56 +00:00
6543
b3549bb5ec
[UI] Show pull icon on pull ( #10061 ) ( #10062 )
2020-01-29 20:40:43 +00:00
Lunny Xiao
16dfd9ffbe
Sanitize credentials in mirror form ( #9975 ) ( #9991 )
2020-01-26 08:16:53 +00:00
6543
128cc34344
Fixed repo link in generated comment for cross repository dependency ( #9863 ) ( #9935 )
...
* fixed link to issue in issue comments after adding/removing a dependency, before links assumed the issue was in the same repository. also changed the format of the displayed issue since the issue will not necessarily be in the same repo
* based on pr comments, changed to use HTMLURL instead of piecing together the issue url, and added an if statement around the issue link display as a nil protection
* only showing repo name in dependency comment if the issue is from another repo
Co-authored-by: Brad Albright <32200834+bhalbright@users.noreply.github.com >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-01-22 12:54:40 +02:00
Lunny Xiao
0dced15c1a
Fix wrong hint when status checking is running on pull request view ( #9886 ) ( #9928 )
...
* Fix wrong hint when status checking is running on pull request view
* fix lint
* fix test
* fix test
* fix wrong tmpl
* fix import
* rename function name
2020-01-22 08:06:11 +02:00
zeripath
ff508c9c9b
Add option to prevent LDAP from deactivating everything on empty search ( #9879 ) ( #9896 )
...
* Add option to prevent LDAP from deactivating everything on empty search
* Update options/locale/locale_en-US.ini
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2020-01-20 21:18:23 +02:00
Lunny Xiao
f96c1a2c79
Fix wrong permissions check when issues/prs shared operations ( #9885 ) ( #9889 )
...
* Fix wrong permissions check when issues/prs shared operations
* move redirect to the last of the function
* fix swagger
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-20 17:59:33 +02:00
zeripath
e878d743f4
Ensure that 2fa is checked on reset-password ( #9857 ) ( #9876 )
...
* Ensure that 2fa is checked on reset-password
* Apply suggestions from code review
Co-Authored-By: Lauris BH <lauris@nix.lv >
* Properly manage scratch_code regeneration
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-19 23:21:21 +00:00
Lunny Xiao
8add1dfacc
Fix issues/pulls dependencies problems ( #9842 ) ( #9864 )
...
* Fix issues/pulls dependencies problems
* fix swagger and api param name
* fix js
2020-01-19 12:56:57 -05:00
6543
1980e59ac2
Fix milestones page ( #9771 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com >
2020-01-14 23:33:12 +01:00
John Olheiser
04a77b1f42
Add HTML URL to API Issues ( #9654 ) ( #9661 )
...
* Add HTML URL to API Issues
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Swagger
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-09 08:07:21 +02:00
David Svantesson
c181070f9e
Repository teams - disable remove button when have access to all ( #9640 )
...
Co-authored-by: zeripath <art27@cantab.net >
2020-01-08 08:36:39 +08:00
zeripath
e5d8e2d10c
Branches not at ref commit ID should not be listed as Merged ( #9614 )
...
Once a branch has been merged if the commit ID no longer equals that of
the pulls ref commit id don't offer to delete the branch on the pull screen
and don't list it as merged on branches.
Fix #9201
When looking at the pull page we should also get the commits from the refs/pulls/x/head
Fix #9158
2020-01-07 17:06:14 +00:00
zeripath
62eb1b0f25
Graceful Queues: Issue Indexing and Tasks ( #9363 )
...
* Queue: Add generic graceful queues with settings
* Queue & Setting: Add worker pool implementation
* Queue: Add worker settings
* Queue: Make resizing worker pools
* Queue: Add name variable to queues
* Queue: Add monitoring
* Queue: Improve logging
* Issues: Gracefulise the issues indexer
Remove the old now unused specific queues
* Task: Move to generic queue and gracefulise
* Issues: Standardise the issues indexer queue settings
* Fix test
* Queue: Allow Redis to connect to unix
* Prevent deadlock during early shutdown of issue indexer
* Add MaxWorker settings to queues
* Merge branch 'master' into graceful-queues
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/queue/queue_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/queue/queue_disk.go
* Update modules/queue/queue_disk_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Rename queue.Description to queue.ManagedQueue as per @guillep2k
* Cancel pool workers when removed
* Remove dependency on queue from setting
* Update modules/queue/queue_redis.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* As per @guillep2k add mutex locks on shutdown/terminate
* move unlocking out of setInternal
* Add warning if number of workers < 0
* Small changes as per @guillep2k
* No redis host specified not found
* Clean up documentation for queues
* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
* Update modules/indexer/issues/indexer_test.go
* Ensure that persistable channel queue is added to manager
* Rename QUEUE_NAME REDIS_QUEUE_NAME
* Revert "Rename QUEUE_NAME REDIS_QUEUE_NAME"
This reverts commit 1f83b4fc9b
.
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2020-01-07 12:23:09 +01:00
6543
bcac7cb934
fix swagger description of reaction API ( #9617 )
2020-01-06 06:58:13 +02:00
zeripath
2a1cf5bae9
Add some padding to the shadowed comment box ( #9612 )
...
* Add some padding to the shadowed comment box
* prevent the padding affecting the other comments
2020-01-05 19:25:27 +00:00
Lauris BH
2b8b0f66ed
Add translatable Powered by Gitea text in footer ( #9600 )
2020-01-04 20:27:19 +00:00
Bagas Sanjaya
34c5eee703
Add footer extra links template ( #9576 )
...
* Add footer extra links template
* [Docs] Update to mention extra links footer template
* Commit suggestion from @davidsvantesson
Co-Authored-By: David Svantesson <davidsvantesson@gmail.com >
* Move template placement to right side of footer
Co-authored-by: David Svantesson <davidsvantesson@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-03 20:41:56 +02:00
David Svantesson
ea707f5a77
Add branch protection option to block merge on requested changes. ( #9592 )
...
* Add branch protection option to block merge on requested changes.
* Add migration step
* Fix check to correct negation
* Apply suggestions from code review
Language improvement.
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com >
* Copyright year.
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-03 19:47:09 +02:00
mrsdizzie
b39fab41c8
Some more e-mail notification fixes ( #9596 )
...
* Some more e-mail notification fixes
A few more small e-mail notification fixes/changes
* Style footer of notification email to be smaller
* Include text for when pull request is merged
* Don't include original body of issue or PR when merging/closing by
setting issue.Content to "" in these cases
* Set Re: prefix and meessage-ID headers based on actName instead of checking for a
comment. This fixes a bug where certain actions that didn't have a
comment were setting Message-ID instead of In-Reply-To which caused some
mail programs not to show those messages as they would have had the same
Message-ID as a previous message. Also fixes the case where a final
comment and closing message would have been displayed out of order if
you didn't have a copy of the original issue/pr cretion message.
* Update other template footers for consistency
2020-01-03 19:13:22 +02:00
John Olheiser
b2b10858c6
Don't auto-init SimpleMDE for review textarea ( #9574 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-02 04:02:11 +01:00
6543
d1798f77f6
swagger UI: hide iretating search field ( #9554 )
2020-01-01 18:08:13 +02:00
Flutterlice
8941f7fc01
Fix for a wrong URL in activity page of repository. (Using config url instead of an actual one) ( #9571 )
2020-01-01 08:54:21 +08:00
mrsdizzie
0989404d2f
Update default issue template ( #9568 )
...
Some small changes:
* Include text if approve/comment/request changes on PR
* List filename for review comments
* Bold username when mentioned
This will stop empty body messages when approving PR on gitea.com
2019-12-31 21:30:46 +02:00
6543
9600c27085
[API] Fix 9544 | return 200 when reaction already exist ( #9550 )
...
* add ErrReactionAlreadyExist
* extend CreateReaction
* reaction already exist = 200
* extend FindReactionsOptions
* refactor swagger options/definitions
* fix swagger-validate
* Update models/error.go
Co-Authored-By: zeripath <art27@cantab.net >
* fix test PART1
* extend FindReactionsOptions with UserID option
* catch error on test
* fix test PART2
* format ...
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: techknowlogick <matti@mdranta.net >
2019-12-31 03:21:21 -05:00
6543
655aea13a5
update swagger info ( #9558 )
2019-12-31 12:11:15 +08:00
zeripath
0c07f1de5b
Provide Default messages for merges ( #9393 )
...
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
2019-12-30 18:34:11 -05:00
6543
261c3a56a2
[Fix] Release attachment should use DownloadURL() not Name ( #9529 )
...
* Handle if two or more attachments have the same name
* previously only the first could be downloaded - now each is downloadable
* dos also take care of #6506 (fix was: #6512 )
* use func DownloadURL() at issue attatchments too
2019-12-28 23:33:13 +00:00
Lunny Xiao
ed67bbe444
Fix repository issues pagination bug when there are more than one label filter ( #9512 )
2019-12-28 14:43:46 +00:00
6543
4ee97465e9
[Fix] AllowedReaction code ( #9518 )
...
* optimize
* CI.restart()
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: zeripath <art27@cantab.net >
2019-12-27 18:43:56 -05:00
6543
f2d03cda96
[API] Extend times API ( #9200 )
...
Extensively extend the times API.
close #8833 ; close #8513 ; close #8559
2019-12-27 20:30:58 +00:00
Lunny Xiao
c0f8795462
Upgrade lato fonts to v16. ( #9498 )
...
* Upgrade lato fonts to v16
* Upgrade lato fonts to v16
* fix bug
2019-12-25 23:11:39 -05:00
6543
40e99ea010
[API] Extend contents with dates ( #9464 )
...
* extend CommitTree func
* make sure Date NOT nil
* spell corection
Co-Authored-By: zeripath <art27@cantab.net >
* add TEST
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2019-12-24 10:33:52 +08:00
mrsdizzie
1df701fd1a
Add ActionCommentPull action ( #9456 )
...
* Add ActionCommentPull action
Adds ActionCommentPull action to distinguish between a comment on an
issue and on a pull request
* Update modules/notification/action/action.go
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2019-12-22 08:29:26 +00:00
6543
2848c5eb8f
Swagger info corrections ( #9441 )
...
* use numbers and not http.Status___ enum
* fix test
* add many missing swagger responses
* code format
* Deletion Sould return 204 ...
* error handling improvements
* if special error type ... then add it to swagger too
* one smal nit
* invalidTopicsError is []string
* valid swagger specification 2.0
- if you add responses swagger can tell you if you do it right 👍
* use ctx.InternalServerError
* Revert "use numbers and not http.Status___ enum"
This reverts commit b1ff386e24
.
* use http.Status* enum everywhere
2019-12-20 19:07:12 +02:00
John Olheiser
f5a25d5349
Fix NewCommitStatus ( #9434 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-19 21:46:53 +00:00
Alexey 〒erentyev
4147cc91ed
Fix background reactions in the arc-green theme ( #9421 )
...
* Fixed arc-green theme reactions background
Signed-off-by: Alexey Terentyev <axifnx@gmail.com >
* Added MD5 AppVer
Signed-off-by: Alexey Terentyev <axifnx@gmail.com >
2019-12-18 22:35:03 -05:00
techknowlogick
590d56dbb3
switch to fomantic-ui ( #9374 )
2019-12-17 16:34:11 -05:00
zeripath
601b0cf4c1
Add description to labels on create issue ( #9392 )
2019-12-17 15:02:17 -05:00
Mario Lubenka
61db834904
Change target branch for pull request ( #6488 )
...
* Adds functionality to change target branch of created pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use const instead of var in JavaScript additions
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Check if branches are equal and if PR already exists before changing target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Make sure to check all commits
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Print error messages for user as error flash message
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Disallow changing target branch of closed or merged pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Resolve conflicts after merge of upstream/master
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Change order of branch select fields
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes duplicate check
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use ctx.Tr for translations
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Recompile JS
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use correct translation namespace
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove redundant if condition
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves most change branch logic into pull service
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Completes comment
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Add Ref to ChangesPayload for logging changed target branches
instead of creating a new struct
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Revert changes to go.mod
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Directly use createComment method
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return 404 if pull request is not found. Move written check up
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove variable declaration
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return client errors on change pull request target errors
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return error in commit.HasPreviousCommit
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds blank line
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Test patch before persisting new target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update patch before testing (not working)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes patch calls when changeing pull request target
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes unneeded check for base name
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves ChangeTargetBranch completely to pull service. Update patch status.
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Set webhook mode after errors were validated
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update PR in one transaction
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Move logic for check if head is equal with branch to pull model
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds missing comment and simplify return
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adjust CreateComment method call
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
2019-12-16 14:20:25 +08:00
Brad Albright
f6b29012e0
Add /milestones endpoint ( #8733 )
...
Create a /milestones endpoint which basically serves as a dashboard view for milestones, very similar to the /issues or /pulls page.
Closes #8232
2019-12-15 14:20:08 +00:00
zeripath
dc2fe9801f
Make repository management section handle lfs locks ( #8726 )
...
* Make repository maangement section handle lfs locks
* Add check attribute handling and handle locking paths better
* More cleanly check-attributes
* handle error
* Check if file exists in default branch before linking to it.
* fixup
* Properly cleanPath
* Use cleanPath
* Sigh
2019-12-12 21:18:07 +08:00