mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-14 19:46:28 +00:00
4bece1feb4
Replace the three caller-provided buffer parameters (modeBuf, fnameBuf, shaBuf)
with internal allocation. Use rd.ReadBytes('\x00') to read mode+fname in one
call and slice the result directly. Allocate sha internally. Update both callers
(catBatchParseTreeEntries and lfs_nogogit.go) to drop the buffer setup.
Co-Authored-By: GitHub Copilot <copilot@github.com>
Agent-Logs-Url: https://github.com/go-gitea/gitea/sessions/43dab9a5-8c12-41c7-8da6-77c268a65ada
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
81 lines
1.9 KiB
Go
81 lines
1.9 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
|
|
"code.gitea.io/gitea/modules/log"
|
|
)
|
|
|
|
// ParseTreeEntries parses the output of a `git ls-tree -l` command.
|
|
func ParseTreeEntries(data []byte) ([]*TreeEntry, error) {
|
|
return parseTreeEntries(data, nil)
|
|
}
|
|
|
|
// parseTreeEntries FIXME this function's design is not right, it should not make the caller read all data into memory
|
|
func parseTreeEntries(data []byte, ptree *Tree) ([]*TreeEntry, error) {
|
|
entries := make([]*TreeEntry, 0, bytes.Count(data, []byte{'\n'})+1)
|
|
for pos := 0; pos < len(data); {
|
|
posEnd := bytes.IndexByte(data[pos:], '\n')
|
|
if posEnd == -1 {
|
|
posEnd = len(data)
|
|
} else {
|
|
posEnd += pos
|
|
}
|
|
|
|
line := data[pos:posEnd]
|
|
lsTreeLine, err := parseLsTreeLine(line)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
entry := &TreeEntry{
|
|
ptree: ptree,
|
|
ID: lsTreeLine.ID,
|
|
entryMode: lsTreeLine.EntryMode,
|
|
name: lsTreeLine.Name,
|
|
size: lsTreeLine.Size.Value(),
|
|
sized: lsTreeLine.Size.Has(),
|
|
}
|
|
pos = posEnd + 1
|
|
entries = append(entries, entry)
|
|
}
|
|
return entries, nil
|
|
}
|
|
|
|
func catBatchParseTreeEntries(objectFormat ObjectFormat, ptree *Tree, rd BufferedReader, sz int64) ([]*TreeEntry, error) {
|
|
entries := make([]*TreeEntry, 0, 10)
|
|
|
|
loop:
|
|
for sz > 0 {
|
|
mode, fname, sha, count, err := ParseCatFileTreeLine(objectFormat, rd)
|
|
if err != nil {
|
|
if err == io.EOF {
|
|
break loop
|
|
}
|
|
return nil, err
|
|
}
|
|
sz -= int64(count)
|
|
entry := new(TreeEntry)
|
|
entry.ptree = ptree
|
|
|
|
entry.entryMode = ParseEntryMode(string(mode))
|
|
if entry.entryMode == EntryModeNoEntry {
|
|
log.Debug("Unknown mode: %v", string(mode))
|
|
return nil, fmt.Errorf("unknown mode: %v", string(mode))
|
|
}
|
|
|
|
entry.ID = objectFormat.MustID(sha)
|
|
entry.name = string(fname)
|
|
entries = append(entries, entry)
|
|
}
|
|
if _, err := rd.Discard(1); err != nil {
|
|
return entries, err
|
|
}
|
|
|
|
return entries, nil
|
|
}
|