silverwind 74f0c84fa4 Enable more revive linter rules (#30608) ...

Noteable additions:

- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches

Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.

2024-04-22 11:48:42 +00:00

..

actions.go

Return responseText instead of string in some functions (#28836)

2024-01-19 10:45:23 +08:00

admin_auth_ldap_test.go

Penultimate round of db.DefaultContext refactor (#27414)

2023-10-11 04:24:07 +00:00

admin_auth_ldap.go

Penultimate round of db.DefaultContext refactor (#27414)

2023-10-11 04:24:07 +00:00

admin_auth_oauth.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

admin_auth_stmp.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

admin_auth.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

admin_regenerate.go

Move some asymkey functions to service layer (#28894)

2024-03-04 08:57:39 +00:00

admin_user_change_password.go

Improve "must-change-password" logic and document (#30472)

2024-04-14 17:22:14 +00:00

admin_user_create.go

Improve "must-change-password" logic and document (#30472)

2024-04-14 17:22:14 +00:00

admin_user_delete.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

admin_user_generate_access_token.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

admin_user_list.go

Reduce usage of db.DefaultContext (#27073)

2023-09-14 17:09:32 +00:00

admin_user_must_change_password.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

admin_user.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

admin.go

Simplify how git repositories are opened (#28937)

2024-01-27 21:09:51 +01:00

cert.go

Expanded minimum RSA Keylength to 3072 (#26604)

2023-08-28 00:53:16 +00:00

cmd.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

docs.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

doctor_convert.go

Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662)

2024-01-10 11:03:23 +00:00

doctor_test.go

Move doctor package from modules to services (#28856)

2024-01-20 10:07:31 +08:00

doctor.go

Move doctor package from modules to services (#28856)

2024-01-20 10:07:31 +08:00

dump_repo.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

dump.go

Add --skip-db option to dump command (#30613)

2024-04-21 23:32:12 +02:00

embedded.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

generate.go

Refactor JWT secret generating & decoding code (#29172)

2024-02-16 15:18:30 +00:00

hook_test.go

Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687)

2023-03-29 14:32:26 +08:00

hook.go

Enable more revive linter rules (#30608)

2024-04-22 11:48:42 +00:00

keys.go

Refactor cmd setup and remove deadcode (#29313)

2024-02-22 07:04:30 +00:00

mailer.go

Return responseText instead of string in some functions (#28836)

2024-01-19 10:45:23 +08:00

main_test.go

make writing main test easier (#27270)

2023-09-28 01:38:53 +00:00

main.go

Improve CLI code and descriptions (#28482)

2023-12-15 15:49:01 +00:00

manager_logging.go

chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621)

2024-04-21 19:44:03 +00:00

manager.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

migrate_storage_test.go

Another round of db.DefaultContext refactor (#27103)

2023-09-25 13:17:37 +00:00

migrate_storage.go

Fix migrate storage bug (#28830)

2024-01-20 23:27:31 +08:00

migrate.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

restore_repo.go

Refactor to use urfave/cli/v2 (#25959)

2023-07-21 17:28:19 +08:00

serv.go

Refactor cmd setup and remove deadcode (#29313)

2024-02-22 07:04:30 +00:00

web_acme.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

web_graceful.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

web_https.go

Implement FSFE REUSE for golang files (#21840)

2022-11-27 18:20:29 +00:00

web.go

Clean up log messages (#30313)

2024-04-07 19:17:06 +08:00