mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-01 05:12:13 +00:00
a3cc34472b
Pass `ServeHeaderOptions` by value instead of pointer across all call
sites — no nil-check semantics are needed and the struct is small enough
that copying is fine.
## Changes
- **`services/context/base.go`**: `SetServeHeaders` and `ServeContent`
accept `ServeHeaderOptions` (value, not pointer); internal unsafe
pointer cast replaced with a clean type conversion
- **`routers/api/packages/helper/helper.go`**: `ServePackageFile`
variadic changed from `...*context.ServeHeaderOptions` to
`...context.ServeHeaderOptions`; internal variable is now a value type
- **All call sites** (13 files): `&context.ServeHeaderOptions{...}` →
`context.ServeHeaderOptions{...}`
Before/after at the definition level:
```go
// Before
func (b *Base) SetServeHeaders(opt *ServeHeaderOptions) { ... }
func (b *Base) ServeContent(r io.ReadSeeker, opts *ServeHeaderOptions) { ... }
func ServePackageFile(..., forceOpts ...*context.ServeHeaderOptions) { ... }
// After
func (b *Base) SetServeHeaders(opts ServeHeaderOptions) { ... }
func (b *Base) ServeContent(r io.ReadSeeker, opts ServeHeaderOptions) { ... }
func ServePackageFile(..., forceOpts ...context.ServeHeaderOptions) { ... }
```
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
120 lines
3.1 KiB
Go
120 lines
3.1 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
chef_module "code.gitea.io/gitea/modules/packages/chef"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/templates"
|
|
"code.gitea.io/gitea/modules/util"
|
|
shared "code.gitea.io/gitea/routers/web/shared/packages"
|
|
"code.gitea.io/gitea/services/context"
|
|
)
|
|
|
|
const (
|
|
tplSettingsPackages templates.TplName = "user/settings/packages"
|
|
tplSettingsPackagesRuleEdit templates.TplName = "user/settings/packages_cleanup_rules_edit"
|
|
tplSettingsPackagesRulePreview templates.TplName = "user/settings/packages_cleanup_rules_preview"
|
|
)
|
|
|
|
func Packages(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.SetPackagesContext(ctx, ctx.Doer)
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsPackages)
|
|
}
|
|
|
|
func PackagesRuleAdd(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.SetRuleAddContext(ctx)
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsPackagesRuleEdit)
|
|
}
|
|
|
|
func PackagesRuleEdit(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.SetRuleEditContext(ctx, ctx.Doer)
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsPackagesRuleEdit)
|
|
}
|
|
|
|
func PackagesRuleAddPost(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings_title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.PerformRuleAddPost(
|
|
ctx,
|
|
ctx.Doer,
|
|
setting.AppSubURL+"/user/settings/packages",
|
|
tplSettingsPackagesRuleEdit,
|
|
)
|
|
}
|
|
|
|
func PackagesRuleEditPost(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.PerformRuleEditPost(
|
|
ctx,
|
|
ctx.Doer,
|
|
setting.AppSubURL+"/user/settings/packages",
|
|
tplSettingsPackagesRuleEdit,
|
|
)
|
|
}
|
|
|
|
func PackagesRulePreview(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.SetRulePreviewContext(ctx, ctx.Doer)
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsPackagesRulePreview)
|
|
}
|
|
|
|
func InitializeCargoIndex(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.InitializeCargoIndex(ctx, ctx.Doer)
|
|
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/packages")
|
|
}
|
|
|
|
func RebuildCargoIndex(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("packages.title")
|
|
ctx.Data["PageIsSettingsPackages"] = true
|
|
|
|
shared.RebuildCargoIndex(ctx, ctx.Doer)
|
|
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/packages")
|
|
}
|
|
|
|
func RegenerateChefKeyPair(ctx *context.Context) {
|
|
priv, pub, err := util.GenerateKeyPair(chef_module.KeyBits)
|
|
if err != nil {
|
|
ctx.ServerError("GenerateKeyPair", err)
|
|
return
|
|
}
|
|
|
|
if err := user_model.SetUserSetting(ctx, ctx.Doer.ID, chef_module.SettingPublicPem, pub); err != nil {
|
|
ctx.ServerError("SetUserSetting", err)
|
|
return
|
|
}
|
|
|
|
ctx.ServeContent(strings.NewReader(priv), context.ServeHeaderOptions{
|
|
ContentType: "application/x-pem-file",
|
|
Filename: ctx.Doer.Name + ".priv",
|
|
})
|
|
}
|