mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-01 05:12:13 +00:00
db7eb4d51b
Use shared repo permission resolution for Actions task users in issue label remove and clear paths, and add a regression test for deleting issue labels with a Gitea Actions token. This fixes issue label deletion when the request is authenticated with a Gitea Actions token. Fixes #37011 The bug was that the delete path re-resolved repository permissions using the normal user permission helper, which does not handle Actions task users. As a result, `DELETE /api/v1/repos/{owner}/{repo}/issues/{index}/labels/{id}` could return `500` for Actions tokens even though label listing and label addition worked. --------- Co-authored-by: Codex <codex@openai.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
80 lines
2.4 KiB
Go
80 lines
2.4 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package packages
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
org_model "code.gitea.io/gitea/models/organization"
|
|
packages_model "code.gitea.io/gitea/models/packages"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unit"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
func LinkToRepository(ctx context.Context, pkg *packages_model.Package, repo *repo_model.Repository, doer *user_model.User) error {
|
|
if pkg.OwnerID != repo.OwnerID {
|
|
return util.ErrPermissionDenied
|
|
}
|
|
if pkg.RepoID > 0 {
|
|
return util.ErrInvalidArgument
|
|
}
|
|
|
|
perms, err := access_model.GetDoerRepoPermission(ctx, repo, doer)
|
|
if err != nil {
|
|
return fmt.Errorf("error getting permissions for user %d on repository %d: %w", doer.ID, repo.ID, err)
|
|
}
|
|
if !perms.CanWrite(unit.TypePackages) {
|
|
return util.ErrPermissionDenied
|
|
}
|
|
|
|
if err := packages_model.SetRepositoryLink(ctx, pkg.ID, repo.ID); err != nil {
|
|
return fmt.Errorf("error while linking package '%v' to repo '%v' : %w", pkg.Name, repo.FullName(), err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func UnlinkFromRepository(ctx context.Context, pkg *packages_model.Package, doer *user_model.User) error {
|
|
if pkg.RepoID == 0 {
|
|
return util.ErrInvalidArgument
|
|
}
|
|
|
|
repo, err := repo_model.GetRepositoryByID(ctx, pkg.RepoID)
|
|
if err != nil && !repo_model.IsErrRepoNotExist(err) {
|
|
return fmt.Errorf("error getting repository %d: %w", pkg.RepoID, err)
|
|
}
|
|
if err == nil {
|
|
perms, err := access_model.GetDoerRepoPermission(ctx, repo, doer)
|
|
if err != nil {
|
|
return fmt.Errorf("error getting permissions for user %d on repository %d: %w", doer.ID, repo.ID, err)
|
|
}
|
|
if !perms.CanWrite(unit.TypePackages) {
|
|
return util.ErrPermissionDenied
|
|
}
|
|
}
|
|
|
|
user, err := user_model.GetUserByID(ctx, pkg.OwnerID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !doer.IsAdmin {
|
|
if !user.IsOrganization() {
|
|
if doer.ID != pkg.OwnerID {
|
|
return fmt.Errorf("no permission to unlink package '%v' from its repository, or packages are disabled", pkg.Name)
|
|
}
|
|
} else {
|
|
isOrgAdmin, err := org_model.OrgFromUser(user).IsOrgAdmin(ctx, doer.ID)
|
|
if err != nil {
|
|
return err
|
|
} else if !isOrgAdmin {
|
|
return fmt.Errorf("no permission to unlink package '%v' from its repository, or packages are disabled", pkg.Name)
|
|
}
|
|
}
|
|
}
|
|
return packages_model.UnlinkRepository(ctx, pkg.ID)
|
|
}
|