zeripath e8574f2f7d Nicely handle missing user in collaborations (#17049) ...

* Nicely handle missing user in collaborations

It is possible to have a collaboration in a repository which refers to a no-longer
existing user. This causes the repository transfer to fail with an unusual error.

This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting
the collaboration but also adds consistency check. It also adds an
Access consistency check.

Fix #17044

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

2021-09-27 19:07:19 +01:00

..

db

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

fixtures

Fix commit status index problem (#17061)

2021-09-23 18:50:06 +08:00

login

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

migrations

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

access_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

access.go

Nicely handle missing user in collaborations (#17049)

2021-09-27 19:07:19 +01:00

action_list.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

action_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

action.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

admin_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

admin.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

attachment_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

attachment.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

avatar_test.go

Fix individual tests (addition to #15802) (#15818)

2021-05-12 00:13:42 -04:00

avatar.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

branches_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

branches.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

commit_status_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

commit_status.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

commit.go

Replace list.List with slices (#16311)

2021-08-09 14:08:51 -04:00

consistency_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

consistency.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

engine_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

error_oauth2.go

gofmt (#1662)

2017-05-04 13:54:56 +08:00

error.go

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

external_login_user.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

fixture_generation.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

fixture_test.go

refactor: move from io/ioutil to io and os package (#17109)

2021-09-22 13:38:34 +08:00

gpg_key_add.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

gpg_key_commit_verification.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

gpg_key_common.go

Add option to provide signature for a token to verify key ownership (#14054)

2021-07-13 15:28:07 +02:00

gpg_key_import.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

gpg_key_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

gpg_key_verify.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

gpg_key.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

helper_directory.go

refactor: move from io/ioutil to io and os package (#17109)

2021-09-22 13:38:34 +08:00

helper_environment.go

chore(models): rewrite code format. (#14754)

2021-03-14 19:52:12 +01:00

helper.go

Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136)

2021-09-27 16:55:12 +01:00

issue_assignees_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_assignees.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_comment_list.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_comment_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_comment.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_dependency_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_dependency.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_label_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_label.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_list_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_list.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_lock.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_milestone_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_milestone.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_reaction_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_reaction.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_stopwatch_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_stopwatch.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_tracked_time_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

issue_tracked_time.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_user_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_user.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_watch_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_watch.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

issue_xref_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue_xref.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

issue.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

lfs_lock.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

lfs.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

main_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

migrate.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

notification_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

notification.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

org_team_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

org_team.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

org_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

org.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

project_board.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

project_issue.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

project_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

project.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

protected_tag_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

protected_tag.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

pull_list.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

pull_sign.go

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

pull_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

pull.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

release.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_activity.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_archiver.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_avatar.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_branch.go

Move newbranch to standalone package (#9627)

2020-01-14 11:38:04 +08:00

repo_collaboration_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_collaboration.go

Nicely handle missing user in collaborations (#17049)

2021-09-27 19:07:19 +01:00

repo_generate_test.go

Fixed assert statements. (#16089)

2021-06-07 07:27:09 +02:00

repo_generate.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_indexer.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_issue.go

Add EnableTimetracking option to app settings (#3719)

2018-04-09 23:15:32 +08:00

repo_language_stats.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_list_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_list.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_mirror.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_permission_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_permission.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_pushmirror_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

repo_pushmirror.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_redirect_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_redirect.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_sign.go

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

repo_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

repo_transfer_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

repo_transfer.go

Nicely handle missing user in collaborations (#17049)

2021-09-27 19:07:19 +01:00

repo_unit.go

Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136)

2021-09-27 16:55:12 +01:00

repo_watch_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo_watch.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

repo.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

review_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

review.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

session.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

ssh_key_authorized_keys.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

ssh_key_authorized_principals.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

ssh_key_deploy.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

ssh_key_fingerprint.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

ssh_key_parse.go

refactor: move from io/ioutil to io and os package (#17109)

2021-09-22 13:38:34 +08:00

ssh_key_principals.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

ssh_key_test.go

Add support for ed25519_sk and ecdsa_sk SSH keys (#13462)

2021-01-20 20:36:55 +00:00

ssh_key.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

star_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

star.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

statistic.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

task.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

token_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

token.go

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

topic_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

topic.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

unit.go

Kanban board (#8346)

2020-08-16 23:07:38 -04:00

update.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

upload.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_avatar.go

Allow LDAP Sources to provide Avatars (#16851)

2021-09-26 22:39:36 -04:00

user_follow_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

user_follow.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_heatmap_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

user_heatmap.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_mail_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

user_mail.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

user_openid_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

user_openid.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_redirect_test.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_redirect.go

DBContext is just a Context (#17100)

2021-09-23 23:45:36 +08:00

user_test.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

user.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

userlist_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

userlist.go

Move twofactor to models/login (#17143)

2021-09-25 15:00:12 +02:00

webhook_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

webhook.go

Move login related structs and functions to models/login (#17093)

2021-09-24 19:32:56 +08:00

wiki_test.go

Move db related basic functions to models/db (#17075)

2021-09-19 19:49:59 +08:00

wiki.go

Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186)

2020-11-27 21:42:08 -05:00