From 033302d97d48645c5083d2900a84099aa2943c20 Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Mon, 5 Jan 2026 08:20:24 +0800 Subject: [PATCH] refactor(terminal): remove unnecessary buf_valid() (#37224) In close_buffer(), free_buffer() is called to remove the buffer from buffer_handles immediately after removing it from the buffer list, so as long as a buffer is in buffer_handles it is always valid. --- src/nvim/terminal.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/nvim/terminal.c b/src/nvim/terminal.c index ade9b46aaa..f5818f9219 100644 --- a/src/nvim/terminal.c +++ b/src/nvim/terminal.c @@ -2117,12 +2117,8 @@ static void invalidate_terminal(Terminal *term, int start_row, int end_row) static void refresh_terminal(Terminal *term) { buf_T *buf = handle_get_buffer(term->buf_handle); - bool valid = true; - if (!buf || !(valid = buf_valid(buf))) { + if (!buf) { // Destroyed by `close_buffer`. Do not do anything else. - if (!valid) { - term->buf_handle = 0; - } return; } linenr_T ml_before = buf->b_ml.ml_line_count;