From 056fdd97d6337faa5f6ad5fa16786a6e5bfb33c7 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Sun, 14 Jun 2026 17:10:49 -0400 Subject: [PATCH] vim-patch:9.0.2123: Problem with initializing the length of range() lists Problem: Problem with initializing the length of range() lists Solution: Set length explicitly when it shouldn't contain any items range() may cause a wrong calculation of list length, which may later then cause a segfault in list_find(). This is usually not a problem, because range_list_materialize() calculates the length, when it materializes the list. In addition, in list_find() when the length of the range was wrongly initialized, it may seem to be valid, so the check for list index out-of-bounds will not be true, because it is called before the list is actually materialized. And so we may eventually try to access a null pointer, causing a segfault. So this patch does 3 things: - In f_range(), when we know that the list should be empty, explicitly set the list->lv_len value to zero. This should happen, when start is larger than end (in case the stride is positive) or end is larger than start when the stride is negative. This should fix the underlying issue properly. However, - as a safety measure, let's check that the requested index is not out of range one more time, after the list has been materialized and return NULL in case it suddenly is. - add a few more tests to verify the behaviour. fixes: vim/vim#13557 closes: vim/vim#13563 -------- Vim9 (non) materialize list is N/A. Port only tests. https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8 Co-authored-by: Christian Brabandt Co-authored-by: Tim Pope --- test/old/testdir/test_functions.vim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/old/testdir/test_functions.vim b/test/old/testdir/test_functions.vim index 6622e8e46a..b94648a07e 100644 --- a/test/old/testdir/test_functions.vim +++ b/test/old/testdir/test_functions.vim @@ -3145,6 +3145,9 @@ func Test_range() " get() call assert_equal(4, get(range(1, 10), 3)) call assert_equal(-1, get(range(1, 10), 42, -1)) + call assert_equal(0, get(range(1, 0, 2), 0)) + call assert_equal(0, get(range(0, -1, 2), 0)) + call assert_equal(0, get(range(-2, -1, -2), 0)) " index() call assert_equal(1, index(range(1, 5), 2))