refactor(tests): all screen tests should use highlights

This is the first installment of a multi-PR series significantly
refactoring how highlights are being specified.

The end goal is to have a base set of 20 ish most common highlights,
and then specific files only need to add more groups to that as needed.

As a complicating factor, we also want to migrate to the new default
color scheme eventually. But by sharing a base set, that future PR
will hopefully be a lot smaller since a lot of tests will be migrated
just simply by updating the base set in place.

As a first step, fix the anti-pattern than Screen defaults to ignoring
highlights. Highlights are integral part of the screen state, not
something "extra" which we only test "sometimes". For now, we still
allow opt-out via the intentionally ugly

  screen._default_attr_ids = nil

The end goal is to get rid of all of these eventually (which will be
easier as part of the color scheme migration)
This commit is contained in:
bfredl
2024-03-22 11:02:52 +01:00
parent dc110cba3c
commit 0c59771e31
40 changed files with 793 additions and 711 deletions

View File

@@ -214,7 +214,7 @@ describe('system()', function()
feed(':call system("echo")<cr>')
screen:expect([[
^ |
~ |*12
{1:~ }|*12
:call system("echo") |
]])
end)
@@ -262,14 +262,14 @@ describe('system()', function()
)
screen:expect([[
|
~ |*12
{1:~ }|*12
]] .. (is_os('win') and [[
:call system("for /L %I in (1,0,2) do @echo y") |]] or [[
:call system("yes") |]]))
feed('foo<c-c>')
screen:expect([[
^ |
~ |*12
{1:~ }|*12
Type :qa and press <Enter> to exit Nvim |
]])
end)
@@ -283,15 +283,15 @@ describe('system()', function()
)
screen:expect([[
|
~ |*12
{1:~ }|*12
]] .. (is_os('win') and [[
:call system("for /L %I in (1,0,2) do @echo y") |]] or [[
:call system("yes") |]]))
feed('foo<c-c>')
screen:expect([[
^ |
~ |*12
-- INSERT -- |
{1:~ }|*12
{5:-- INSERT --} |
]])
end)
end)
@@ -447,7 +447,7 @@ describe('systemlist()', function()
feed(':call systemlist("echo")<cr>')
screen:expect([[
^ |
~ |*12
{1:~ }|*12
:call systemlist("echo") |
]])
end)
@@ -456,13 +456,13 @@ describe('systemlist()', function()
feed(':call systemlist("yes | xargs")<cr>')
screen:expect([[
|
~ |*12
{1:~ }|*12
:call systemlist("yes | xargs") |
]])
feed('<c-c>')
screen:expect([[
^ |
~ |*12
{1:~ }|*12
Type :qa and press <Enter> to exit Nvim |
]])
end)