fix: pvs warnings (#21145)

* fix(PVS/V009): start file with special comment

* fix(PVS/V501): identical sub-expressions for comparison

* fix(PVS/V560): part of conditional expression is always true/false

* fix(PVS/V593): review expression of type A = B < C

* fix(PVS/V614): potentially uninitialized variable used
This commit is contained in:
dundargoc
2022-11-22 01:07:45 +01:00
committed by GitHub
parent edd0de9821
commit 0cbc23d3cc
6 changed files with 8 additions and 5 deletions

View File

@@ -382,7 +382,7 @@ static void parse_border_title(Object title, Object title_pos, FloatConfig *fcon
return;
}
if (title.type == kObjectTypeArray && title.data.array.size == 0) {
if (title.data.array.size == 0) {
api_set_error(err, kErrorTypeValidation, "title cannot be an empty array");
return;
}
@@ -391,7 +391,6 @@ static void parse_border_title(Object title, Object title_pos, FloatConfig *fcon
fconfig->title_chunks = parse_virt_text(title.data.array, err, &fconfig->title_width);
fconfig->title = true;
return;
}
static bool parse_title_pos(Object title_pos, FloatConfig *fconfig, Error *err)