mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 03:18:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: pvs warnings (#21145)

Browse Source 
* fix(PVS/V009): start file with special comment

* fix(PVS/V501): identical sub-expressions for comparison

* fix(PVS/V560): part of conditional expression is always true/false

* fix(PVS/V593): review expression of type A = B < C

* fix(PVS/V614): potentially uninitialized variable used
This commit is contained in:
dundargoc
2022-11-22 01:07:45 +01:00
committed by GitHub
parent edd0de9821
commit 0cbc23d3cc
6 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/api/win_config.c
View File

@@ -382,7 +382,7 @@ static void parse_border_title(Object title, Object title_pos, FloatConfig *fcon
return; return;
} }
if (title.type == kObjectTypeArray && title.data.array.size == 0) { if (title.data.array.size == 0) {
api_set_error(err, kErrorTypeValidation, "title cannot be an empty array"); api_set_error(err, kErrorTypeValidation, "title cannot be an empty array");
return; return;
} }
@@ -391,7 +391,6 @@ static void parse_border_title(Object title, Object title_pos, FloatConfig *fcon
fconfig->title_chunks = parse_virt_text(title.data.array, err, &fconfig->title_width); fconfig->title_chunks = parse_virt_text(title.data.array, err, &fconfig->title_width);
fconfig->title = true; fconfig->title = true;
return;
} }
static bool parse_title_pos(Object title_pos, FloatConfig *fconfig, Error *err) static bool parse_title_pos(Object title_pos, FloatConfig *fconfig, Error *err)

2
src/nvim/ex_eval.c
View File

@@ -862,7 +862,7 @@ void ex_endif(exarg_T *eap)
/// Handle ":else" and ":elseif". /// Handle ":else" and ":elseif".
void ex_else(exarg_T *eap) void ex_else(exarg_T *eap)
{ {
int result; bool result = false;
cstack_T *const cstack = eap->cstack; cstack_T *const cstack = eap->cstack;
bool skip = CHECK_SKIP; bool skip = CHECK_SKIP;

3
src/nvim/linematch.c
View File

@@ -1,3 +1,6 @@
// This is an open source non-commercial project. Dear PVS-Studio, please check
// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
#include <assert.h> #include <assert.h>
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h> #include <stddef.h>

1
src/nvim/msgpack_rpc/unpacker.c
View File

@@ -380,6 +380,7 @@ bool unpacker_parse_redraw(Unpacker *p)
size_t size = p->read_size; size_t size = p->read_size;
GridLineEvent *g = p->grid_line_event; GridLineEvent *g = p->grid_line_event;
// -V:NEXT_TYPE:501
#define NEXT_TYPE(tok, typ) \ #define NEXT_TYPE(tok, typ) \
result = mpack_rtoken(&data, &size, &tok); \ result = mpack_rtoken(&data, &size, &tok); \
if (result == MPACK_EOF) { \ if (result == MPACK_EOF) { \

2
src/nvim/os/fs.c
View File

@@ -974,7 +974,7 @@ int os_file_mkdir(char *fname, int32_t mode)
*tail = NUL; *tail = NUL;
int r; int r;
char *failed_dir; char *failed_dir;
if ((r = os_mkdir_recurse(fname, mode, &failed_dir) < 0)) { if (((r = os_mkdir_recurse(fname, mode, &failed_dir)) < 0)) {
semsg(_(e_mkdir), failed_dir, os_strerror(r)); semsg(_(e_mkdir), failed_dir, os_strerror(r));
xfree(failed_dir); xfree(failed_dir);
} }

2
src/nvim/quickfix.c
View File

@@ -6711,7 +6711,7 @@ static bool mark_quickfix_ctx(qf_info_T *qi, int copyID)
typval_T *ctx = qi->qf_lists[i].qf_ctx; typval_T *ctx = qi->qf_lists[i].qf_ctx;
if (ctx != NULL && ctx->v_type != VAR_NUMBER if (ctx != NULL && ctx->v_type != VAR_NUMBER
&& ctx->v_type != VAR_STRING && ctx->v_type != VAR_FLOAT) { && ctx->v_type != VAR_STRING && ctx->v_type != VAR_FLOAT) {
abort = abort || set_ref_in_item(ctx, copyID, NULL, NULL); abort = set_ref_in_item(ctx, copyID, NULL, NULL);
} }
Callback *cb = &qi->qf_lists[i].qf_qftf_cb; Callback *cb = &qi->qf_lists[i].qf_qftf_cb;