mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-29 14:38:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.1864: still crash with bt_quickfix1_poc

Browse Source 
Problem:  crash with bt_quickfix1_poc when cleaning up
          and EXITFREE is defined
Solution: Test if buffer is valid in a window, else close
          window directly, don't try to access buffer properties

While at it, increase the crash timeout slightly, so that CI has a
chance to finish processing the test_crash() test.

623ba31821

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq
2023-11-17 09:19:01 +08:00
parent 2371b9303d
commit 1274380029
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nvim/window.c
View File

@@ -3776,6 +3776,12 @@ void close_others(int message, int forceit)
continue;
}
// autoccommands messed this one up
if (!buf_valid(wp->w_buffer) && win_valid(wp)) {
wp->w_buffer = NULL;
win_close(wp, false, false);
continue;
}
// Check if it's allowed to abandon this window
int r = can_abandon(wp->w_buffer, forceit);
if (!win_valid(wp)) { // autocommands messed wp up

4
test/old/testdir/test_crash.vim
View File

@@ -40,7 +40,7 @@ func Test_crash1()
" clean up
call delete('Xerr')
" This test takes a bit longer
call TermWait(buf, 500)
call TermWait(buf, 1000)
let file = 'crash/poc_tagfunc.vim'
let args = printf(cmn_args, vim, file)
@@ -55,7 +55,7 @@ func Test_crash1()
\ ' && echo "crash 6: [OK]" >> X_crash1_result.txt' .. "\<cr>")
" clean up
call delete('X')
call TermWait(buf, 200)
call TermWait(buf, 1000)
" clean up
exe buf .. "bw!"